mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-07-03 04:25:48 +00:00
a63135363b
Because of the check `if step.Stopped == 0` without the check there are edgecases where could be the case a stoped steped can be markt as running again, witch is wrong. I do remember we have "running" steps indefinetly in cancled pipelines. This could be the fix, i just did not test that specific. Anyway the func hat a good testcoverage ... so just look at the tests _Source: https://github.com/woodpecker-ci/woodpecker/pull/3143#discussion_r1446138088_
83 lines
2.5 KiB
Go
83 lines
2.5 KiB
Go
// Copyright 2022 Woodpecker Authors
|
|
// Copyright 2019 mhmxs
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pipeline
|
|
|
|
import (
|
|
"time"
|
|
|
|
"go.woodpecker-ci.org/woodpecker/v2/pipeline/rpc"
|
|
"go.woodpecker-ci.org/woodpecker/v2/server/model"
|
|
)
|
|
|
|
func UpdateStepStatus(store model.UpdateStepStore, step *model.Step, state rpc.State) error {
|
|
if state.Exited {
|
|
step.Stopped = state.Finished
|
|
step.ExitCode = state.ExitCode
|
|
step.Error = state.Error
|
|
step.State = model.StatusSuccess
|
|
if state.ExitCode != 0 || state.Error != "" {
|
|
step.State = model.StatusFailure
|
|
}
|
|
if state.ExitCode == 137 {
|
|
step.State = model.StatusKilled
|
|
}
|
|
} else if step.Stopped == 0 {
|
|
step.Started = state.Started
|
|
step.State = model.StatusRunning
|
|
}
|
|
return store.StepUpdate(step)
|
|
}
|
|
|
|
func UpdateStepToStatusStarted(store model.UpdateStepStore, step model.Step, state rpc.State) (*model.Step, error) {
|
|
step.Started = state.Started
|
|
step.State = model.StatusRunning
|
|
return &step, store.StepUpdate(&step)
|
|
}
|
|
|
|
func UpdateStepToStatusSkipped(store model.UpdateStepStore, step model.Step, stopped int64) (*model.Step, error) {
|
|
step.State = model.StatusSkipped
|
|
if step.Started != 0 {
|
|
step.State = model.StatusSuccess // for daemons that are killed
|
|
step.Stopped = stopped
|
|
}
|
|
return &step, store.StepUpdate(&step)
|
|
}
|
|
|
|
func UpdateStepStatusToDone(store model.UpdateStepStore, step model.Step, state rpc.State) (*model.Step, error) {
|
|
step.Stopped = state.Finished
|
|
step.Error = state.Error
|
|
step.ExitCode = state.ExitCode
|
|
if state.Started == 0 {
|
|
step.State = model.StatusSkipped
|
|
} else {
|
|
step.State = model.StatusSuccess
|
|
}
|
|
if step.ExitCode != 0 || step.Error != "" {
|
|
step.State = model.StatusFailure
|
|
}
|
|
return &step, store.StepUpdate(&step)
|
|
}
|
|
|
|
func UpdateStepToStatusKilled(store model.UpdateStepStore, step model.Step) (*model.Step, error) {
|
|
step.State = model.StatusKilled
|
|
step.Stopped = time.Now().Unix()
|
|
if step.Started == 0 {
|
|
step.Started = step.Stopped
|
|
}
|
|
step.ExitCode = 137
|
|
return &step, store.StepUpdate(&step)
|
|
}
|