mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2024-07-01 03:30:49 +00:00
Code Issues Projects Releases Wiki Activity
5415 commits 15 branches 69 tags 160 MiB
Commit graph

302 commits

Author SHA1 Message Date
Fernando Barbosa c7467b9828
fix: agent panic when node is terminated during step execution (#3331) 
Fixes https://github.com/woodpecker-ci/woodpecker/issues/3330

This adds error handling on the agent's WaitStep function, on two
sections where it could encounter a `panic: runtime error: invalid
memory address or nil pointer dereference` in case it could no longer
access complete information about a specific pod.

This error was found to happen if the node in which the pod was running
was terminated during the step's execution.
spite active pipelines being executed on the node.

Now instead of a panic on the agent's logs and undefined behavior on the
UI it will display a more helpful error message on the UI.

### Additional context

We observed the bug first on v2.1.1, but tested the fix internally on
top of 2.3.0.


![image](https://github.com/woodpecker-ci/woodpecker/assets/7269710/dfbcf089-85f7-4b5d-8102-f21af95c5cda)
 2024-02-05 22:46:14 +01:00
qwerty287 9df572ef31
Add release event trigger (#3226) 
Supersedes #764 

Bitbucket does not support release webhooks.

---------

Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
 2024-01-30 17:39:00 +01:00
Lukas 94b882fb95
Add spellcheck config (#3018) 
Part of #738 

```
pnpx cspell lint --gitignore '{**,.*}/{*,.*}'
```

---------

Co-authored-by: Anbraten <anton@ju60.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
 2024-01-27 21:15:10 +01:00
Anbraten 0b5eef7d1e
Improve secret availability checks (#3271) 2024-01-27 20:59:44 +01:00
Thomas Anderson e5c83190c7
Sanitize pod's step label (#3275) 
Closes #3272
 2024-01-26 13:42:21 +01:00
Elias 1c3159ebb7
fix: bug pod service without label service (#3256) 2024-01-23 07:42:47 +01:00
qwerty287 6925afd83b
Pin prettier version (#3260) 2024-01-22 21:38:47 +02:00
Elias 32a1199519
fix: bug annotations (#3255) 
Fix Issue: https://github.com/woodpecker-ci/woodpecker/issues/3254

Co-authored-by: elias.souza <elias.souza@quintoandar.com.br>
 2024-01-22 13:39:49 +01:00
qwerty287 5e2f7d81b3
Clean up models (#3228) 2024-01-22 07:56:18 +01:00
Thomas Anderson 072fa29f4a
Fixed Pods creation of WP services (#3236) 
Closes #3178
 2024-01-21 03:56:37 +01:00
qwerty287 d1d2e9723d
Support custom steps entrypoint (#2985) 
Closes https://github.com/woodpecker-ci/woodpecker/issues/278

---------

Co-authored-by: Anbraten <anton@ju60.de>
Co-authored-by: 6543 <6543@obermui.de>
 2024-01-19 05:34:02 +01:00
6543 6a6cb094fb
Add schema test for depends_on (#3205) 2024-01-15 08:54:27 +01:00
Thomas Anderson 10f2e209d6
Secured kubernetes backend configuration (#3204) 
Follow up of #3165
 2024-01-15 03:59:08 +01:00
qwerty287 001b5639a6
Use assert for test (#3201) 
instead of `if`s
 2024-01-14 19:33:58 +01:00
qwerty287 b9f6f3f9fb
Replace goimports with gci (#3202) 
`gci` seems to be much more strict.
 2024-01-14 18:22:06 +01:00
qwerty287 45bf8600ef
Remove multipart logger (#3200) 2024-01-14 10:54:02 +01:00
Robert Kaussow 685907ddf6
Fix spelling in test description (#3198) 2024-01-13 15:24:13 +01:00
Thomas Anderson 0611fa9b32
Added protocol in port configuration (#2993) 
Closes  #2727
 2024-01-12 23:57:24 +01:00
Thomas Anderson 9bbc446009
Kubernetes AppArmor and seccomp (#3123) 
Closes #2545

seccomp
https://kubernetes.io/docs/tutorials/security/seccomp/

https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/135-seccomp/README.md

AppArmor
https://kubernetes.io/docs/tutorials/security/apparmor/

fddcbb9cbf/keps/sig-node/24-apparmor/README.md
Went ahead and implemented API from KEP-24 above.
 2024-01-12 23:32:24 +01:00
Robert Kaussow 9bbba4441d
Enable golangci linter forcetypeassert (#3168) 
Split out from https://github.com/woodpecker-ci/woodpecker/pull/2960
 2024-01-12 02:01:02 +01:00
Robert Kaussow f813badcf9
Enable golangci linter contextcheck (#3170) 
Split out from https://github.com/woodpecker-ci/woodpecker/pull/2960
 2024-01-11 22:15:15 +01:00
6543 f8fb28e651
More docker backend test remove more undocumented (#3156) 
remove Sysctls and IpcMode
 2024-01-11 19:30:13 +01:00
qwerty287 b0a2b1cf2d
Lowercase all log strings (#3173) 
from #3161

---------

Co-authored-by: 6543 <6543@obermui.de>
 2024-01-11 19:17:07 +01:00
qwerty287 f56f9cb1c0
Cleanups + prefer .yaml (#3069) 
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
 2024-01-11 18:43:54 +01:00
6543 d1fe86b7be
Use UUID as podName and cleanup arguments for Kubernetes backend (#3135) 
to much args are just horrible to maintain. And we already have it nice
structured stored as step.
 2024-01-11 16:32:37 +01:00
Robert Kaussow 7756c60a33
Enable golangci linter stylecheck (#3167) 
This PR only fixes error string formatting, log message strings are
still mixed upper/lowercase (see
https://github.com/woodpecker-ci/woodpecker/pull/3161#issuecomment-1885140649)
and I'm not aware of a linter to enforce it.
 2024-01-10 22:56:42 +01:00
qwerty287 00df53e941
Clean up logging (#3161) 
- use `Err` method instead of format strings
- use `Msg` if no format string is used
 2024-01-10 20:57:12 +01:00
qwerty287 12c40eb957
Enable gocritic and don't ignore globally (#3159) 
Use `nolint` directives instead.

From #2960
 2024-01-10 15:34:44 +01:00
qwerty287 1b380ff4b4
Enable nolintlint (#3158) 2024-01-10 12:11:18 +01:00
qwerty287 768fd71841
Enable some linters (#3129) 
Mostly those that did not require much work.

From #2960

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2024-01-09 21:35:37 +01:00
6543 c91c6fbe9e
TestToConfigSmall ignore sort order of env vars (#3154) 
so this https://ci.woodpecker-ci.org/repos/3780/pipeline/11803/30 can
not randomly happen
 2024-01-09 18:34:11 +01:00
6543 e3cf7b212c
fix also test of #3137 2024-01-09 16:36:17 +01:00
6543 06538504f8
fix regression: save env into configEnv 
introduced by #3137
 2024-01-09 16:28:10 +01:00
6543 aab2f0e675
Use step uuid instead of name in GRPC status calls (#3143) 
close #3109

~~also fix start time of steps to be set correctly~~ edgecase do not hit
anymore as we have a clear sepperation between workflows and steps now
:)

---------

Co-authored-by: Anbraten <anton@ju60.de>
 2024-01-09 15:39:09 +01:00
6543 cd59a85230
Use name in backend types instead of alias (#3142) 2024-01-09 15:22:59 +01:00
6543 1eacf74376
Remove duplicate assignment of CI_STEP_NAME (#3139) 
Co-authored-by: Anbraten <anton@ju60.de>
 2024-01-09 08:56:28 +01:00
6543 12df59d0ec
Add step name as label to docker containers (#3137) 
and add a test
 2024-01-09 06:01:34 +01:00
6543 c64340cf8f
Use UUID instead of step name where possible (#3136) 
things I found while looking at  #3109
 2024-01-09 05:43:03 +01:00
6543 31614d0e38
Use step type to detect services in Kubernetes backend (#3141) 
and use the correct name for tail log

---------

Co-authored-by: Anbraten <anton@ju60.de>
 2024-01-09 05:42:36 +01:00
Thomas Anderson c0fc4828ff
Flexible image pull secret reference (#3016) 
Co-authored-by: pat-s <patrick.schratz@gmail.com>
 2024-01-05 08:33:56 +01:00
qwerty287 5517d87dd6
Fix step depends_on as string in schema (#3099) 2024-01-01 12:16:36 +01:00
Anbraten 6fbf98f1b9
Fix slice unmarshaling (#3097) 
closes #3055
 2024-01-01 11:03:31 +01:00
6543 8b47b3a978
make event in pipeline schema also a constraint_list (#3082) 2023-12-31 08:49:46 +01:00
6543 2cb7669413
add just more dag tests (#3083) 2023-12-30 16:45:11 +01:00
qwerty287 c74dc9ce92
Remove old files (#3077) 
from https://github.com/woodpecker-ci/woodpecker/pull/3069

- `.changelog.yml`: no longer used
- `pipeline/samples`
 2023-12-30 15:10:31 +01:00
qwerty287 a37af3eeac
Add imports checks to linter (#3056) 
supersedes https://github.com/woodpecker-ci/woodpecker/pull/874

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2023-12-29 21:19:42 +01:00
qwerty287 7e2ea306c4
Remove workflow version again (#3052) 2023-12-28 14:34:13 +01:00
Kamila Borowska 4bc2fed550
Fix DAG cycle detection (#3049) 
Previously a graph like this.

    a <- b
    ^    ^
    |    |
    c <- d

Was incorrectly recognized as having a cycle.

Fixes #3048.
 2023-12-28 00:14:28 +01:00
6543 840fca198e
make backend step dag generation deterministic (#3037) 
the the generation for backend steps if a dag is used deterministic.

this also fix where the test randomly fail like in:
- https://ci.woodpecker-ci.org/repos/3780/pipeline/11057/30
- https://ci.woodpecker-ci.org/repos/3780/pipeline/11076/25
 2023-12-27 12:38:33 +02:00
qwerty287 e575ffe72d
Add some tests (#3030) 2023-12-27 10:36:49 +01:00