Add linter staticcheck (#535)

* Add linter staticcheck

Co-authored-by: 6543 <6543@obermui.de>

.golangci.yml

@@ -17,6 +17,7 @@ linters:
     - bidichk
     - misspell
     - whitespace
+    - staticcheck
 
 run:
   timeout: 5m

cli/loglevel/loglevel.go

@@ -35,11 +35,14 @@ func logLevel(c *cli.Context) error {
 		ll, err = client.SetLogLevel(&woodpecker.LogLevel{
 			Level: lvl.String(),
 		})
+		if err != nil {
+			return err
+		}
 	} else {
 		ll, err = client.LogLevel()
-	}
+		if err != nil {
-	if err != nil {
+			return err
-		return err
+		}
 	}
 
 	log.Info().Msgf("Logging level: %s", ll.Level)

cmd/server/setup.go

@@ -15,6 +15,7 @@
 package main
 
 import (
+	"context"
 	"fmt"
 	"os"
 	"time"
@@ -352,7 +353,7 @@ func setupMetrics(g *errgroup.Group, store_ store.Store) {
 
 	g.Go(func() error {
 		for {
-			stats := server.Config.Services.Queue.Info(nil)
+			stats := server.Config.Services.Queue.Info(context.TODO())
 			pendingJobs.Set(float64(stats.Stats.Pending))
 			waitingJobs.Set(float64(stats.Stats.WaitingOnDeps))
 			runningJobs.Set(float64(stats.Stats.Running))

pipeline/backend/docker/docker.go

@@ -149,9 +149,9 @@ func (e *engine) Wait(ctx context.Context, proc *backend.Step) (*backend.State,
 	if err != nil {
 		return nil, err
 	}
-	if info.State.Running {
+	// if info.State.Running {
-		// todo
+	// TODO
-	}
+	// }
 
 	return &backend.State{
 		Exited:    true,

server/grpc/rpc.go

@@ -137,7 +137,7 @@ func (s *RPC) Update(c context.Context, id string, state rpc.State) error {
 		return err
 	}
 
-	if proc, err = shared.UpdateProcStatus(s.store, *proc, state, build.Started); err != nil {
+	if _, err = shared.UpdateProcStatus(s.store, *proc, state, build.Started); err != nil {
 		log.Error().Msgf("error: rpc.update: cannot update proc: %s", err)
 	}
 

server/pubsub/pub.go

@@ -24,9 +24,9 @@ func New() Publisher {
 
 func (p *publisher) Create(c context.Context, dest string) error {
 	p.Lock()
-	t, ok := p.topics[dest]
+	_, ok := p.topics[dest]
 	if !ok {
-		t = newTopic(dest)
+		t := newTopic(dest)
 		p.topics[dest] = t
 	}
 	p.Unlock()

server/queue/fifo_test.go

@@ -496,7 +496,9 @@ func TestWaitingVsPending(t *testing.T) {
 	}
 
 	assert.NoError(t, q.Error(noContext, got.ID, fmt.Errorf("exitcode 1, there was an error")))
-	got, _ = q.Poll(noContext, func(*Task) bool { return true })
+	got, err := q.Poll(noContext, func(*Task) bool { return true })
+	assert.NoError(t, err)
+	assert.EqualValues(t, task2, got)
 
 	info = q.Info(noContext)
 	if info.Stats.WaitingOnDeps != 0 {

server/remote/bitbucketserver/internal/client.go

@@ -115,6 +115,9 @@ func (c *Client) FindRepo(owner string, name string) (*Repo, error) {
 		log.Err(err).Msg("")
 	}
 	contents, err := ioutil.ReadAll(response.Body)
+	if err != nil {
+		return nil, err
+	}
 	repo := Repo{}
 	err = json.Unmarshal(contents, &repo)
 	if err != nil {
@@ -184,6 +187,9 @@ func (c *Client) CreateHook(owner string, name string, callBackLink string) erro
 
 	putHookSettings := arrayToHookSettings(hooks)
 	hookBytes, err := json.Marshal(putHookSettings)
+	if err != nil {
+		return err
+	}
 	return c.doPut(fmt.Sprintf(pathHookEnabled, c.base, owner, name, hookName), hookBytes)
 }
 
@@ -202,6 +208,9 @@ func (c *Client) DeleteHook(owner string, name string, link string) error {
 	})
 	putHookSettings := arrayToHookSettings(putHooks)
 	hookBytes, err := json.Marshal(putHookSettings)
+	if err != nil {
+		return err
+	}
 	return c.doPut(fmt.Sprintf(pathHookEnabled, c.base, owner, name, hookName), hookBytes)
 }
 

server/remote/gitea/gitea.go

@@ -118,7 +118,7 @@ func (c *Gitea) Login(ctx context.Context, w http.ResponseWriter, req *http.Requ
 		return nil, nil
 	}
 
-	token, err := config.Exchange(oauth2.NoContext, code)
+	token, err := config.Exchange(ctx, code)
 	if err != nil {
 		return nil, err
 	}

server/remote/github/convert.go

@@ -190,9 +190,9 @@ func convertPushHook(from *webhook) *model.Build {
 	if len(build.Author) == 0 {
 		build.Author = from.Head.Author.Username
 	}
-	if len(build.Email) == 0 {
+	// if len(build.Email) == 0 {
-		// default to gravatar?
+	// TODO: default to gravatar?
-	}
+	// }
 	if strings.HasPrefix(build.Ref, "refs/tags/") {
 		// just kidding, this is actually a tag event. Why did this come as a push
 		// event we'll never know!

server/remote/github/github.go

@@ -266,12 +266,11 @@ func (c *client) Dir(ctx context.Context, u *model.User, r *model.Repo, b *model
 	}
 
 	var files []*remote.FileMeta
-	var errors []error
 
 	for i := 0; i < len(data); i++ {
 		select {
 		case err := <-errc:
-			errors = append(errors, err)
+			return nil, err
 		case fileMeta := <-fc:
 			files = append(files, fileMeta)
 		}