Add "path" support to gitea on push hooks (#235)

This commit is contained in:
6543 2021-07-04 20:38:59 +02:00 committed by GitHub
parent 70958acc44
commit ee3e4bb189
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 78 additions and 17 deletions

View file

@ -386,7 +386,7 @@ when:
Execute a step only on commit with certain files added/removed/modified:
**NOTE: Feature is only available for Github repositories.**
**NOTE: Feature is only available for Github and Gitea repositories.**
```diff
when:
@ -396,7 +396,7 @@ when:
Execute a step only on commit excluding certain files added/removed/modified:
**NOTE: Feature is only available for Github repositories.**
**NOTE: Feature is only available for Github and Gitea repositories.**
```diff
when:

View file

@ -30,7 +30,10 @@ const HookPush = `
"name": "Gordon the Gopher",
"email": "gordon@golang.org",
"username": "gordon"
}
},
"added": ["CHANGELOG.md"],
"removed": [],
"modified": ["app/controller/application.rb"]
}
],
"repository": {

View file

@ -88,20 +88,35 @@ func buildFromPush(hook *pushHook) *model.Build {
}
return &model.Build{
Event: model.EventPush,
Commit: hook.After,
Ref: hook.Ref,
Link: hook.Compare,
Branch: strings.TrimPrefix(hook.Ref, "refs/heads/"),
Message: message,
Avatar: avatar,
Author: author,
Email: hook.Sender.Email,
Timestamp: time.Now().UTC().Unix(),
Sender: sender,
Event: model.EventPush,
Commit: hook.After,
Ref: hook.Ref,
Link: hook.Compare,
Branch: strings.TrimPrefix(hook.Ref, "refs/heads/"),
Message: message,
Avatar: avatar,
Author: author,
Email: hook.Sender.Email,
Timestamp: time.Now().UTC().Unix(),
Sender: sender,
ChangedFiles: getChangedFilesFromPushHook(hook),
}
}
func getChangedFilesFromPushHook(hook *pushHook) []string {
files := make([]string, 0)
if len(hook.Commits) == 0 {
return files
}
files = append(files, hook.Commits[0].Added...)
files = append(files, hook.Commits[0].Removed...)
files = append(files, hook.Commits[0].Modified...)
return files
}
// helper function that extracts the Build data from a Gitea tag hook
func buildFromTag(hook *pushHook) *model.Build {
avatar := expandAvatar(

View file

@ -13,3 +13,43 @@
// limitations under the License.
package gitea
import (
"bytes"
"net/http"
"testing"
"github.com/franela/goblin"
"github.com/woodpecker-ci/woodpecker/model"
"github.com/woodpecker-ci/woodpecker/remote/gitea/fixtures"
)
func Test_parser(t *testing.T) {
g := goblin.Goblin(t)
g.Describe("Gitea parser", func() {
g.It("should ignore unsupported hook events", func() {
buf := bytes.NewBufferString(fixtures.HookPullRequest)
req, _ := http.NewRequest("POST", "/hook", buf)
req.Header = http.Header{}
req.Header.Set(hookEvent, "issues")
r, b, err := parseHook(req)
g.Assert(r == nil).IsTrue()
g.Assert(b == nil).IsTrue()
g.Assert(err == nil).IsTrue()
})
g.Describe("given a push hook", func() {
g.It("should extract repository and build details", func() {
buf := bytes.NewBufferString(fixtures.HookPush)
req, _ := http.NewRequest("POST", "/hook", buf)
req.Header = http.Header{}
req.Header.Set(hookEvent, hookPush)
r, b, err := parseHook(req)
g.Assert(err == nil).IsTrue()
g.Assert(r != nil).IsTrue()
g.Assert(b != nil).IsTrue()
g.Assert(b.Event).Equal(model.EventPush)
g.Assert(b.ChangedFiles).Equal([]string{"CHANGELOG.md", "app/controller/application.rb"})
})
})
})
}

View file

@ -43,9 +43,12 @@ type pushHook struct {
} `json:"repository"`
Commits []struct {
ID string `json:"id"`
Message string `json:"message"`
URL string `json:"url"`
ID string `json:"id"`
Message string `json:"message"`
URL string `json:"url"`
Added []string `json:"added"`
Removed []string `json:"removed"`
Modified []string `json:"modified"`
} `json:"commits"`
Sender struct {