mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2024-11-22 09:51:01 +00:00
Code Issues Projects Releases Wiki Activity

Pass settings to services (#4338)

Browse source
This commit is contained in:
qwerty287 2024-11-09 22:04:27 +02:00 committed by GitHub
parent 5139401b53
commit e13085b69f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pipeline/frontend/yaml/compiler/convert.go
View file

@ -114,12 +114,9 @@ func (c *Compiler) createProcess(container *yaml_types.Container, stepType backe
return secret.Value, nil return secret.Value, nil
} }
// TODO: why don't we pass secrets to detached steps?
if !detached {
if err := settings.ParamsToEnv(container.Settings, environment, "PLUGIN_", true, getSecretValue); err != nil { if err := settings.ParamsToEnv(container.Settings, environment, "PLUGIN_", true, getSecretValue); err != nil {
return nil, err return nil, err
} }
}
if err := settings.ParamsToEnv(container.Environment, environment, "", false, getSecretValue); err != nil { if err := settings.ParamsToEnv(container.Environment, environment, "", false, getSecretValue); err != nil {
return nil, err return nil, err