mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2024-07-02 12:05:56 +00:00
Code Issues Projects Releases Wiki Activity

Make sure step passed into go routine exist and does not change (#1903)

Browse source 
just a tiny code improvement
This commit is contained in:
6543 2023-07-06 20:19:10 +02:00 committed by GitHub
parent 5d72060bbd
commit 94f2331a4c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
server/pipeline/start.go
View file

@ -48,15 +48,16 @@ func start(ctx context.Context, store store.Store, activePipeline *model.Pipelin
} }
// open logs streamer for each step // open logs streamer for each step
go func() { for _, wf := range activePipeline.Workflows {
for _, wf := range activePipeline.Workflows { for _, step := range wf.Children {
for _, step := range wf.Children { stepID := step.ID
if err := server.Config.Services.Logs.Open(context.Background(), step.ID); err != nil { go func() {
log.Error().Err(err).Msgf("could not open log stream for step %d", step.ID) if err := server.Config.Services.Logs.Open(context.Background(), stepID); err != nil {
log.Error().Err(err).Msgf("could not open log stream for step %d", stepID)
} }
} }()
} }
}() }
updatePipelineStatus(ctx, activePipeline, repo, user) updatePipelineStatus(ctx, activePipeline, repo, user)