fixes #914

model/build.go

@@ -32,11 +32,16 @@ type Build struct {
 	Verified  bool    `json:"verified"      meddler:"build_verified"` // deprecate
 	Reviewer  string  `json:"reviewed_by"   meddler:"build_reviewer"`
 	Reviewed  int64   `json:"reviewed_at"   meddler:"build_reviewed"`
-	// Jobs      []*Job  `json:"jobs,omitempty"  meddler:"-"`
 	Procs     []*Proc `json:"procs,omitempty" meddler:"-"`
 }
 
-type BuildGroup struct {
-	Date   string
-	Builds []*Build
+// Trim trims string values that would otherwise exceed
+// the database column sizes and fail to insert.
+func (b *Build) Trim() {
+	if len(b.Title) > 500 {
+		b.Title = b.Title[:500]
+	}
+	if len(b.Message) > 500 {
+		b.Message = b.Message[:500]
+	}
 }

model/build_test.go

@@ -0,0 +1,23 @@
+package model
+
+import (
+	"crypto/rand"
+	"fmt"
+	"testing"
+)
+
+func TestBuildTrim(t *testing.T) {
+	d := make([]byte, 1000)
+	rand.Read(d)
+
+	b := Build{}
+	b.Message = fmt.Sprintf("%X", d)
+
+	if len(b.Message) != 2000 {
+		t.Errorf("Failed to generate 2000 byte test string")
+	}
+	b.Trim()
+	if len(b.Message) != 500 {
+		t.Errorf("Failed to trim text string to 500 bytes")
+	}
+}

server/hook.go

@@ -197,6 +197,7 @@ func PostHook(c *gin.Context) {
 		}
 	}
 
+	build.Trim()
 	err = store.CreateBuild(c, build, build.Procs...)
 	if err != nil {
 		logrus.Errorf("failure to save commit for %s. %s", repo.FullName, err)