Handling channel close

remote/github/github.go

@@ -261,10 +261,11 @@ func (c *client) Dir(u *model.User, r *model.Repo, b *model.Build, f string) ([]
 			content, err := c.File(u, r, b, path)
 			if err != nil {
 				errc <- err
-			}
+			} else {
-			fc <- &remote.FileMeta{
+				fc <- &remote.FileMeta{
-				Name: path,
+					Name: path,
-				Data: content,
+					Data: content,
+				}
 			}
 		}(f + "/" + *file.Name)
 	}
@@ -275,12 +276,16 @@ func (c *client) Dir(u *model.User, r *model.Repo, b *model.Build, f string) ([]
 	go func() {
 		for {
 			select {
-			case err := <-errc:
+			case err, open := <-errc:
-				errors = append(errors, err)
+				if open {
-				wg.Done()
+					errors = append(errors, err)
-			case fileMeta := <-fc:
+					wg.Done()
-				files = append(files, fileMeta)
+				}
-				wg.Done()
+			case fileMeta, open := <-fc:
+				if open {
+					files = append(files, fileMeta)
+					wg.Done()
+				}
 			}
 		}
 	}()

server/configFetcher.go

@@ -18,17 +18,17 @@ func (cf *configFetcher) Fetch() ([]*remote.FileMeta, error) {
 	for i := 0; i < 5; i++ {
 		select {
 		case <-time.After(time.Second * time.Duration(i)):
-			file, err := cf.remote_.File(cf.user, cf.repo, cf.build, cf.repo.Config) // either a file
+			file, fileerr := cf.remote_.File(cf.user, cf.repo, cf.build, cf.repo.Config) // either a file
-			if err == nil {
+			if fileerr == nil {
 				return []*remote.FileMeta{&remote.FileMeta{
 					Name: cf.repo.Config,
 					Data: file,
 				}}, nil
 			}
 
-			dir, err := cf.remote_.Dir(cf.user, cf.repo, cf.build, cf.repo.Config) // or a folder
+			dir, direrr := cf.remote_.Dir(cf.user, cf.repo, cf.build, ".drone") // or a folder
-			if err != nil {
+			if direrr != nil {
-				return nil, err
+				return nil, direrr
 			}
 			return dir, nil
 		}