mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2024-11-22 09:51:01 +00:00
Code Issues Projects Releases Wiki Activity

Remove review button from approval view (#3617)

Browse source 
Not required anymore after
https://github.com/woodpecker-ci/woodpecker/pull/2757 was merged.
This commit is contained in:
Robert Kaussow 2024-04-15 16:42:19 +02:00 committed by GitHub
parent 00f0fcd416
commit 21f87b4b1d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web/src/assets/locales/en.json
View file

@ -260,7 +260,6 @@
"log_auto_scroll_off": "Turn off automatic scrolling" "log_auto_scroll_off": "Turn off automatic scrolling"
}, },
"protected": { "protected": {
"review": "Review changes",
"awaits": "This pipeline is awaiting approval by a maintainer!", "awaits": "This pipeline is awaiting approval by a maintainer!",
"approve": "Approve", "approve": "Approve",
"decline": "Decline", "decline": "Decline",

12
web/src/views/repo/pipeline/Pipeline.vue
View file

@ -34,13 +34,6 @@
<Icon name="status-blocked" class="w-16 h-16" /> <Icon name="status-blocked" class="w-16 h-16" />
<span class="text-xl">{{ $t('repo.pipeline.protected.awaits') }}</span> <span class="text-xl">{{ $t('repo.pipeline.protected.awaits') }}</span>
<div v-if="repoPermissions.push" class="flex gap-2 flex-wrap items-center justify-center"> <div v-if="repoPermissions.push" class="flex gap-2 flex-wrap items-center justify-center">
<Button
color="blue"
:start-icon="forge ?? 'repo'"
:text="$t('repo.pipeline.protected.review')"
:to="pipeline.forge_url"
:title="message"
/>
<Button <Button
color="green" color="green"
:text="$t('repo.pipeline.protected.approve')" :text="$t('repo.pipeline.protected.approve')"
@ -90,9 +83,7 @@ import PipelineLog from '~/components/repo/pipeline/PipelineLog.vue';
import PipelineStepList from '~/components/repo/pipeline/PipelineStepList.vue'; import PipelineStepList from '~/components/repo/pipeline/PipelineStepList.vue';
import useApiClient from '~/compositions/useApiClient'; import useApiClient from '~/compositions/useApiClient';
import { useAsyncAction } from '~/compositions/useAsyncAction'; import { useAsyncAction } from '~/compositions/useAsyncAction';
import useConfig from '~/compositions/useConfig';
import useNotifications from '~/compositions/useNotifications'; import useNotifications from '~/compositions/useNotifications';
import usePipeline from '~/compositions/usePipeline';
import { Pipeline, PipelineStep, Repo, RepoPermissions } from '~/lib/api/types'; import { Pipeline, PipelineStep, Repo, RepoPermissions } from '~/lib/api/types';
import { findStep } from '~/utils/helpers'; import { findStep } from '~/utils/helpers';
@ -156,9 +147,6 @@ const selectedStepId = computed({
}, },
}); });
const { forge } = useConfig();
const { message } = usePipeline(pipeline);
const selectedStep = computed(() => findStep(pipeline.value.workflows || [], selectedStepId.value || -1)); const selectedStep = computed(() => findStep(pipeline.value.workflows || [], selectedStepId.value || -1));
const { doSubmit: approvePipeline, isLoading: isApprovingPipeline } = useAsyncAction(async () => { const { doSubmit: approvePipeline, isLoading: isApprovingPipeline } = useAsyncAction(async () => {