Fix linter (#3354)

pipeline/backend/kubernetes/kubernetes.go

@@ -230,7 +230,7 @@ func (e *kube) WaitStep(ctx context.Context, step *types.Step, taskUUID string)
 
 	finished := make(chan bool)
 
-	podUpdated := func(old, new any) {
+	podUpdated := func(_, new any) {
 		pod, ok := new.(*v1.Pod)
 		if !ok {
 			log.Error().Msgf("could not parse pod: %v", new)
@@ -307,7 +307,7 @@ func (e *kube) TailStep(ctx context.Context, step *types.Step, taskUUID string)
 
 	up := make(chan bool)
 
-	podUpdated := func(old, new any) {
+	podUpdated := func(_, new any) {
 		pod, ok := new.(*v1.Pod)
 		if !ok {
 			log.Error().Msgf("could not parse pod: %v", new)

pipeline/frontend/yaml/compiler/option.go

@@ -36,7 +36,7 @@ func WithOption(option Option, b bool) Option {
 	case b:
 		return option
 	default:
-		return func(compiler *Compiler) {}
+		return func(_ *Compiler) {}
 	}
 }
 

server/logging/log_test.go

@@ -42,10 +42,10 @@ func TestLogging(t *testing.T) {
 	logger := New()
 	assert.NoError(t, logger.Open(ctx, testStepID))
 	go func() {
-		assert.NoError(t, logger.Tail(ctx, testStepID, func(entry ...*model.LogEntry) { wg.Done() }))
+		assert.NoError(t, logger.Tail(ctx, testStepID, func(_ ...*model.LogEntry) { wg.Done() }))
 	}()
 	go func() {
-		assert.NoError(t, logger.Tail(ctx, testStepID, func(entry ...*model.LogEntry) { wg.Done() }))
+		assert.NoError(t, logger.Tail(ctx, testStepID, func(_ ...*model.LogEntry) { wg.Done() }))
 	}()
 
 	<-time.After(500 * time.Millisecond)
@@ -60,7 +60,7 @@ func TestLogging(t *testing.T) {
 
 	wg.Add(1)
 	go func() {
-		assert.NoError(t, logger.Tail(ctx, testStepID, func(entry ...*model.LogEntry) { wg.Done() }))
+		assert.NoError(t, logger.Tail(ctx, testStepID, func(_ ...*model.LogEntry) { wg.Done() }))
 	}()
 
 	<-time.After(500 * time.Millisecond)

server/pipeline/queue.go

@@ -38,7 +38,7 @@ func queuePipeline(ctx context.Context, repo *model.Repo, pipelineItems []*stepb
 			task.Labels[k] = v
 		}
 		task.Labels["repo"] = repo.FullName
-		task.Dependencies = taskIds(item.DependsOn, pipelineItems)
+		task.Dependencies = taskIDs(item.DependsOn, pipelineItems)
 		task.RunOn = item.RunsOn
 		task.DepStatus = make(map[string]model.StatusValue)
 
@@ -57,11 +57,11 @@ func queuePipeline(ctx context.Context, repo *model.Repo, pipelineItems []*stepb
 	return server.Config.Services.Queue.PushAtOnce(ctx, tasks)
 }
 
-func taskIds(dependsOn []string, pipelineItems []*stepbuilder.Item) (taskIds []string) {
+func taskIDs(dependsOn []string, pipelineItems []*stepbuilder.Item) (taskIDs []string) {
 	for _, dep := range dependsOn {
 		for _, pipelineItem := range pipelineItems {
 			if pipelineItem.Workflow.Name == dep {
-				taskIds = append(taskIds, fmt.Sprint(pipelineItem.Workflow.ID))
+				taskIDs = append(taskIDs, fmt.Sprint(pipelineItem.Workflow.ID))
 			}
 		}
 	}

server/pubsub/pub_test.go

@@ -41,7 +41,7 @@ func TestPubsub(t *testing.T) {
 		broker.Subscribe(ctx, func(message Message) { assert.Equal(t, testMessage, message); wg.Done() })
 	}()
 	go func() {
-		broker.Subscribe(ctx, func(message Message) { wg.Done() })
+		broker.Subscribe(ctx, func(_ Message) { wg.Done() })
 	}()
 
 	<-time.After(500 * time.Millisecond)

server/router/middleware/session/agent.go

@@ -29,7 +29,7 @@ func AuthorizeAgent(c *gin.Context) {
 		return
 	}
 
-	parsed, err := token.ParseRequest(c.Request, func(t *token.Token) (string, error) {
+	parsed, err := token.ParseRequest(c.Request, func(_ *token.Token) (string, error) {
 		return secret, nil
 	})
 	switch {

server/router/middleware/session/user.go

@@ -55,7 +55,7 @@ func SetUser() gin.HandlerFunc {
 			// this means the user is accessing with a web browser,
 			// so we should implement CSRF protection measures.
 			if t.Kind == token.SessToken {
-				err = token.CheckCsrf(c.Request, func(t *token.Token) (string, error) {
+				err = token.CheckCsrf(c.Request, func(_ *token.Token) (string, error) {
 					return user.Hash, nil
 				})
 				// if csrf token validation fails, exit immediately

server/store/datastore/migration/migration.go

@@ -90,7 +90,7 @@ func Migrate(e *xorm.Engine, allowLong bool) error {
 	if oldCount < 1 || err != nil {
 		// allow new schema initialization if old migrations table is empty or it does not exist (err != nil)
 		// schema initialization will always run if we call `InitSchema`
-		m.InitSchema(func(engine *xorm.Engine) error {
+		m.InitSchema(func(_ *xorm.Engine) error {
 			// do nothing on schema init, models are synced in any case below
 			return nil
 		})

woodpecker-go/woodpecker/client_test.go

@@ -26,7 +26,7 @@ import (
 )
 
 func Test_QueueInfo(t *testing.T) {
-	fixtureHandler := func(w http.ResponseWriter, r *http.Request) {
+	fixtureHandler := func(w http.ResponseWriter, _ *http.Request) {
 		fmt.Fprint(w, `{
 			"pending": null,
 			"running": [