mirror of
https://github.com/wallabag/wallabag.git
synced 2024-12-29 19:10:29 +00:00
d0ec2ddd23
Which wasn't covered by a test!
553 lines
21 KiB
PHP
553 lines
21 KiB
PHP
<?php
|
|
|
|
namespace Tests\Wallabag\CoreBundle\Helper;
|
|
|
|
use Graby\Graby;
|
|
use Monolog\Handler\TestHandler;
|
|
use Monolog\Logger;
|
|
use Psr\Log\NullLogger;
|
|
use Symfony\Component\Validator\ConstraintViolation;
|
|
use Symfony\Component\Validator\ConstraintViolationList;
|
|
use Symfony\Component\Validator\Validator\RecursiveValidator;
|
|
use Wallabag\CoreBundle\Entity\Entry;
|
|
use Wallabag\CoreBundle\Entity\Tag;
|
|
use Wallabag\CoreBundle\Helper\ContentProxy;
|
|
use Wallabag\CoreBundle\Helper\RuleBasedTagger;
|
|
use Wallabag\UserBundle\Entity\User;
|
|
|
|
class ContentProxyTest extends \PHPUnit_Framework_TestCase
|
|
{
|
|
private $fetchingErrorMessage = 'wallabag can\'t retrieve contents for this article. Please <a href="http://doc.wallabag.org/en/user/errors_during_fetching.html#how-can-i-help-to-fix-that">troubleshoot this issue</a>.';
|
|
|
|
public function testWithBadUrl()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => false,
|
|
'title' => '',
|
|
'url' => '',
|
|
'content_type' => '',
|
|
'language' => '',
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://user@:80');
|
|
|
|
$this->assertSame('http://user@:80', $entry->getUrl());
|
|
$this->assertEmpty($entry->getTitle());
|
|
$this->assertSame($this->fetchingErrorMessage, $entry->getContent());
|
|
$this->assertEmpty($entry->getPreviewPicture());
|
|
$this->assertEmpty($entry->getMimetype());
|
|
$this->assertEmpty($entry->getLanguage());
|
|
$this->assertSame(0.0, $entry->getReadingTime());
|
|
$this->assertSame(null, $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithEmptyContent()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => false,
|
|
'title' => '',
|
|
'url' => '',
|
|
'content_type' => '',
|
|
'language' => '',
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertSame('http://0.0.0.0', $entry->getUrl());
|
|
$this->assertEmpty($entry->getTitle());
|
|
$this->assertSame($this->fetchingErrorMessage, $entry->getContent());
|
|
$this->assertEmpty($entry->getPreviewPicture());
|
|
$this->assertEmpty($entry->getMimetype());
|
|
$this->assertEmpty($entry->getLanguage());
|
|
$this->assertSame(0.0, $entry->getReadingTime());
|
|
$this->assertSame('0.0.0.0', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithEmptyContentButOG()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => false,
|
|
'title' => '',
|
|
'url' => '',
|
|
'content_type' => '',
|
|
'language' => '',
|
|
'status' => '',
|
|
'open_graph' => [
|
|
'og_title' => 'my title',
|
|
'og_description' => 'desc',
|
|
],
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://domain.io');
|
|
|
|
$this->assertSame('http://domain.io', $entry->getUrl());
|
|
$this->assertSame('my title', $entry->getTitle());
|
|
$this->assertSame($this->fetchingErrorMessage . '<p><i>But we found a short description: </i></p>desc', $entry->getContent());
|
|
$this->assertEmpty($entry->getPreviewPicture());
|
|
$this->assertEmpty($entry->getLanguage());
|
|
$this->assertEmpty($entry->getHttpStatus());
|
|
$this->assertEmpty($entry->getMimetype());
|
|
$this->assertSame(0.0, $entry->getReadingTime());
|
|
$this->assertSame('domain.io', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithContent()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'status' => '200',
|
|
'open_graph' => [
|
|
'og_title' => 'my OG title',
|
|
'og_description' => 'OG desc',
|
|
'og_image' => 'http://3.3.3.3/cover.jpg',
|
|
],
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertSame('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame('200', $entry->getHttpStatus());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithContentAndNoOgImage()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'status' => '200',
|
|
'open_graph' => [
|
|
'og_title' => 'my OG title',
|
|
'og_description' => 'OG desc',
|
|
'og_image' => null,
|
|
],
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertNull($entry->getPreviewPicture());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame('200', $entry->getHttpStatus());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithContentAndBadLanguage()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$validator = $this->getValidator();
|
|
$validator->expects($this->once())
|
|
->method('validate')
|
|
->willReturn(new ConstraintViolationList([new ConstraintViolation('oops', 'oops', [], 'oops', 'language', 'dontexist')]));
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'dontexist',
|
|
'status' => '200',
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $validator, $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertNull($entry->getLanguage());
|
|
$this->assertSame('200', $entry->getHttpStatus());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithContentAndBadOgImage()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$validator = $this->getValidator();
|
|
$validator->expects($this->exactly(2))
|
|
->method('validate')
|
|
->will($this->onConsecutiveCalls(
|
|
new ConstraintViolationList(),
|
|
new ConstraintViolationList([new ConstraintViolation('oops', 'oops', [], 'oops', 'url', 'https://')])
|
|
));
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'status' => '200',
|
|
'open_graph' => [
|
|
'og_title' => 'my OG title',
|
|
'og_description' => 'OG desc',
|
|
'og_image' => 'https://',
|
|
],
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $validator, $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertNull($entry->getPreviewPicture());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame('200', $entry->getHttpStatus());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithForcedContent()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry(
|
|
$entry,
|
|
'http://0.0.0.0',
|
|
[
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'date' => '1395635872',
|
|
'authors' => ['Jeremy', 'Nico', 'Thomas'],
|
|
'all_headers' => [
|
|
'Cache-Control' => 'no-cache',
|
|
],
|
|
]
|
|
);
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
$this->assertSame('24/03/2014', $entry->getPublishedAt()->format('d/m/Y'));
|
|
$this->assertContains('Jeremy', $entry->getPublishedBy());
|
|
$this->assertContains('Nico', $entry->getPublishedBy());
|
|
$this->assertContains('Thomas', $entry->getPublishedBy());
|
|
$this->assertContains('no-cache', $entry->getHeaders());
|
|
}
|
|
|
|
public function testWithForcedContentAndDatetime()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$logHandler = new TestHandler();
|
|
$logger = new Logger('test', [$logHandler]);
|
|
|
|
$proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $logger, $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry(
|
|
$entry,
|
|
'http://1.1.1.1',
|
|
[
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'date' => '2016-09-08T11:55:58+0200',
|
|
]
|
|
);
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
$this->assertSame('08/09/2016', $entry->getPublishedAt()->format('d/m/Y'));
|
|
}
|
|
|
|
public function testWithForcedContentAndBadDate()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$logger = new Logger('foo');
|
|
$handler = new TestHandler();
|
|
$logger->pushHandler($handler);
|
|
|
|
$proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $logger, $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry(
|
|
$entry,
|
|
'http://1.1.1.1',
|
|
[
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'date' => '01 02 2012',
|
|
]
|
|
);
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertContains('this is my content', $entry->getContent());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame(4.0, $entry->getReadingTime());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
$this->assertNull($entry->getPublishedAt());
|
|
|
|
$records = $handler->getRecords();
|
|
|
|
$this->assertCount(1, $records);
|
|
$this->assertContains('Error while defining date', $records[0]['message']);
|
|
}
|
|
|
|
public function testTaggerThrowException()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag')
|
|
->will($this->throwException(new \Exception()));
|
|
|
|
$proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry(
|
|
$entry,
|
|
'http://1.1.1.1',
|
|
[
|
|
'html' => str_repeat('this is my content', 325),
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
]
|
|
);
|
|
|
|
$this->assertCount(0, $entry->getTags());
|
|
}
|
|
|
|
public function dataForCrazyHtml()
|
|
{
|
|
return [
|
|
'script and comment' => [
|
|
'<strong>Script inside:</strong> <!--[if gte IE 4]><script>alert(\'lol\');</script><![endif]--><br />',
|
|
'lol',
|
|
],
|
|
'script' => [
|
|
'<strong>Script inside:</strong><script>alert(\'lol\');</script>',
|
|
'script',
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataForCrazyHtml
|
|
*/
|
|
public function testWithCrazyHtmlContent($html, $escapedString)
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry(
|
|
$entry,
|
|
'http://1.1.1.1',
|
|
[
|
|
'html' => $html,
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1',
|
|
'content_type' => 'text/html',
|
|
'language' => 'fr',
|
|
'status' => '200',
|
|
'open_graph' => [
|
|
'og_title' => 'my OG title',
|
|
'og_description' => 'OG desc',
|
|
'og_image' => 'http://3.3.3.3/cover.jpg',
|
|
],
|
|
]
|
|
);
|
|
|
|
$this->assertSame('http://1.1.1.1', $entry->getUrl());
|
|
$this->assertSame('this is my title', $entry->getTitle());
|
|
$this->assertNotContains($escapedString, $entry->getContent());
|
|
$this->assertSame('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture());
|
|
$this->assertSame('text/html', $entry->getMimetype());
|
|
$this->assertSame('fr', $entry->getLanguage());
|
|
$this->assertSame('200', $entry->getHttpStatus());
|
|
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
public function testWithImageAsContent()
|
|
{
|
|
$tagger = $this->getTaggerMock();
|
|
$tagger->expects($this->once())
|
|
->method('tag');
|
|
|
|
$graby = $this->getMockBuilder('Graby\Graby')
|
|
->setMethods(['fetchContent'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$graby->expects($this->any())
|
|
->method('fetchContent')
|
|
->willReturn([
|
|
'html' => '<p><img src="http://1.1.1.1/image.jpg" /></p>',
|
|
'title' => 'this is my title',
|
|
'url' => 'http://1.1.1.1/image.jpg',
|
|
'content_type' => 'image/jpeg',
|
|
'status' => '200',
|
|
'open_graph' => [],
|
|
]);
|
|
|
|
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
|
$entry = new Entry(new User());
|
|
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
|
|
|
$this->assertEquals('http://1.1.1.1/image.jpg', $entry->getUrl());
|
|
$this->assertEquals('this is my title', $entry->getTitle());
|
|
$this->assertContains('http://1.1.1.1/image.jpg', $entry->getContent());
|
|
$this->assertSame('http://1.1.1.1/image.jpg', $entry->getPreviewPicture());
|
|
$this->assertEquals('image/jpeg', $entry->getMimetype());
|
|
$this->assertEquals('200', $entry->getHttpStatus());
|
|
$this->assertEquals('1.1.1.1', $entry->getDomainName());
|
|
}
|
|
|
|
private function getTaggerMock()
|
|
{
|
|
return $this->getMockBuilder(RuleBasedTagger::class)
|
|
->setMethods(['tag'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
}
|
|
|
|
private function getLogger()
|
|
{
|
|
return new NullLogger();
|
|
}
|
|
|
|
private function getValidator()
|
|
{
|
|
return $this->getMockBuilder(RecursiveValidator::class)
|
|
->setMethods(['validate'])
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
}
|
|
}
|