mirror of
https://github.com/wallabag/wallabag.git
synced 2024-11-29 12:31:02 +00:00
59b97fae99
Instead of just say “Failed to save entry” we’ll save the entry at all cost and try to fetch content. If fetching content failed, the entry will still be saved at least, but without content.
610 lines
22 KiB
PHP
610 lines
22 KiB
PHP
<?php
|
|
|
|
namespace Tests\Wallabag\ImportBundle\Import;
|
|
|
|
use Wallabag\UserBundle\Entity\User;
|
|
use Wallabag\CoreBundle\Entity\Entry;
|
|
use Wallabag\CoreBundle\Entity\Config;
|
|
use Wallabag\ImportBundle\Import\PocketImport;
|
|
use GuzzleHttp\Client;
|
|
use GuzzleHttp\Subscriber\Mock;
|
|
use GuzzleHttp\Message\Response;
|
|
use GuzzleHttp\Stream\Stream;
|
|
use Wallabag\ImportBundle\Redis\Producer;
|
|
use Monolog\Logger;
|
|
use Monolog\Handler\TestHandler;
|
|
use Simpleue\Queue\RedisQueue;
|
|
use M6Web\Component\RedisMock\RedisMockFactory;
|
|
|
|
class PocketImportTest extends \PHPUnit_Framework_TestCase
|
|
{
|
|
protected $token;
|
|
protected $user;
|
|
protected $em;
|
|
protected $contentProxy;
|
|
protected $logHandler;
|
|
|
|
private function getPocketImport($consumerKey = 'ConsumerKey')
|
|
{
|
|
$this->user = new User();
|
|
|
|
$config = new Config($this->user);
|
|
$config->setPocketConsumerKey('xxx');
|
|
|
|
$this->user->setConfig($config);
|
|
|
|
$this->contentProxy = $this->getMockBuilder('Wallabag\CoreBundle\Helper\ContentProxy')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$pocket = new PocketImport(
|
|
$this->em,
|
|
$this->contentProxy
|
|
);
|
|
$pocket->setUser($this->user);
|
|
|
|
$this->logHandler = new TestHandler();
|
|
$logger = new Logger('test', [$this->logHandler]);
|
|
$pocket->setLogger($logger);
|
|
|
|
return $pocket;
|
|
}
|
|
|
|
public function testInit()
|
|
{
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$this->assertEquals('Pocket', $pocketImport->getName());
|
|
$this->assertNotEmpty($pocketImport->getUrl());
|
|
$this->assertEquals('import.pocket.description', $pocketImport->getDescription());
|
|
}
|
|
|
|
public function testOAuthRequest()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['code' => 'wunderbar_code']))),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
$pocketImport->setClient($client);
|
|
|
|
$code = $pocketImport->getRequestToken('http://0.0.0.0/redirect');
|
|
|
|
$this->assertEquals('wunderbar_code', $code);
|
|
}
|
|
|
|
public function testOAuthRequestBadResponse()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(403),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
$pocketImport->setClient($client);
|
|
|
|
$code = $pocketImport->getRequestToken('http://0.0.0.0/redirect');
|
|
|
|
$this->assertFalse($code);
|
|
|
|
$records = $this->logHandler->getRecords();
|
|
$this->assertContains('PocketImport: Failed to request token', $records[0]['message']);
|
|
$this->assertEquals('ERROR', $records[0]['level_name']);
|
|
}
|
|
|
|
public function testOAuthAuthorize()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
$pocketImport->setClient($client);
|
|
|
|
$res = $pocketImport->authorize('wunderbar_code');
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals('wunderbar_token', $pocketImport->getAccessToken());
|
|
}
|
|
|
|
public function testOAuthAuthorizeBadResponse()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(403),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
$pocketImport->setClient($client);
|
|
|
|
$res = $pocketImport->authorize('wunderbar_code');
|
|
|
|
$this->assertFalse($res);
|
|
|
|
$records = $this->logHandler->getRecords();
|
|
$this->assertContains('PocketImport: Failed to authorize client', $records[0]['message']);
|
|
$this->assertEquals('ERROR', $records[0]['level_name']);
|
|
}
|
|
|
|
/**
|
|
* Will sample results from https://getpocket.com/developer/docs/v3/retrieve.
|
|
*/
|
|
public function testImport()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory('
|
|
{
|
|
"status": 1,
|
|
"list": {
|
|
"229279689": {
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "1",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 0,
|
|
"resolved_title": "The Massive Ryder Cup Preview",
|
|
"resolved_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"is_index": "0",
|
|
"has_video": "1",
|
|
"has_image": "1",
|
|
"word_count": "3197",
|
|
"images": {
|
|
"1": {
|
|
"item_id": "229279689",
|
|
"image_id": "1",
|
|
"src": "http://a.espncdn.com/combiner/i?img=/photo/2012/0927/grant_g_ryder_cr_640.jpg&w=640&h=360",
|
|
"width": "0",
|
|
"height": "0",
|
|
"credit": "Jamie Squire/Getty Images",
|
|
"caption": ""
|
|
}
|
|
},
|
|
"videos": {
|
|
"1": {
|
|
"item_id": "229279689",
|
|
"video_id": "1",
|
|
"src": "http://www.youtube.com/v/Er34PbFkVGk?version=3&hl=en_US&rel=0",
|
|
"width": "420",
|
|
"height": "315",
|
|
"type": "1",
|
|
"vid": "Er34PbFkVGk"
|
|
}
|
|
},
|
|
"tags": {
|
|
"grantland": {
|
|
"item_id": "1147652870",
|
|
"tag": "grantland"
|
|
},
|
|
"Ryder Cup": {
|
|
"item_id": "1147652870",
|
|
"tag": "Ryder Cup"
|
|
}
|
|
}
|
|
},
|
|
"229279690": {
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "1",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 1,
|
|
"resolved_title": "The Massive Ryder Cup Preview",
|
|
"resolved_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"is_index": "0",
|
|
"has_video": "0",
|
|
"has_image": "0",
|
|
"word_count": "3197"
|
|
}
|
|
}
|
|
}
|
|
')),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->exactly(2))
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, true));
|
|
|
|
$this->em
|
|
->expects($this->exactly(2))
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
$entry = new Entry($this->user);
|
|
|
|
$this->contentProxy
|
|
->expects($this->once())
|
|
->method('updateEntry')
|
|
->willReturn($entry);
|
|
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 1, 'imported' => 1, 'queued' => 0], $pocketImport->getSummary());
|
|
}
|
|
|
|
/**
|
|
* Will sample results from https://getpocket.com/developer/docs/v3/retrieve.
|
|
*/
|
|
public function testImportAndMarkAllAsRead()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory('
|
|
{
|
|
"status": 1,
|
|
"list": {
|
|
"229279689": {
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "1",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 0,
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"has_video": "1",
|
|
"has_image": "1",
|
|
"word_count": "3197"
|
|
},
|
|
"229279690": {
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview/2",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "0",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 1,
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"has_video": "0",
|
|
"has_image": "0",
|
|
"word_count": "3197"
|
|
}
|
|
}
|
|
}
|
|
')),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->exactly(2))
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, false));
|
|
|
|
$this->em
|
|
->expects($this->exactly(2))
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
// check that every entry persisted are archived
|
|
$this->em
|
|
->expects($this->any())
|
|
->method('persist')
|
|
->with($this->callback(function ($persistedEntry) {
|
|
return $persistedEntry->isArchived();
|
|
}));
|
|
|
|
$entry = new Entry($this->user);
|
|
|
|
$this->contentProxy
|
|
->expects($this->exactly(2))
|
|
->method('updateEntry')
|
|
->willReturn($entry);
|
|
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->setMarkAsRead(true)->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 2, 'queued' => 0], $pocketImport->getSummary());
|
|
}
|
|
|
|
/**
|
|
* Will sample results from https://getpocket.com/developer/docs/v3/retrieve.
|
|
*/
|
|
public function testImportWithRabbit()
|
|
{
|
|
$client = new Client();
|
|
|
|
$body = <<<'JSON'
|
|
{
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "1",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 0,
|
|
"resolved_title": "The Massive Ryder Cup Preview",
|
|
"resolved_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"has_video": "0",
|
|
"has_image": "0",
|
|
"word_count": "3197"
|
|
}
|
|
JSON;
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory('
|
|
{
|
|
"status": 1,
|
|
"list": {
|
|
"229279690": '.$body.'
|
|
}
|
|
}
|
|
')),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->never())
|
|
->method('findByUrlAndUserId');
|
|
|
|
$this->em
|
|
->expects($this->never())
|
|
->method('getRepository');
|
|
|
|
$entry = new Entry($this->user);
|
|
|
|
$this->contentProxy
|
|
->expects($this->never())
|
|
->method('updateEntry');
|
|
|
|
$producer = $this->getMockBuilder('OldSound\RabbitMqBundle\RabbitMq\Producer')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$bodyAsArray = json_decode($body, true);
|
|
// because with just use `new User()` so it doesn't have an id
|
|
$bodyAsArray['userId'] = null;
|
|
|
|
$producer
|
|
->expects($this->once())
|
|
->method('publish')
|
|
->with(json_encode($bodyAsArray));
|
|
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->setProducer($producer);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->setMarkAsRead(true)->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 1], $pocketImport->getSummary());
|
|
}
|
|
|
|
/**
|
|
* Will sample results from https://getpocket.com/developer/docs/v3/retrieve.
|
|
*/
|
|
public function testImportWithRedis()
|
|
{
|
|
$client = new Client();
|
|
|
|
$body = <<<'JSON'
|
|
{
|
|
"item_id": "229279689",
|
|
"resolved_id": "229279689",
|
|
"given_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"given_title": "The Massive Ryder Cup Preview - The Triangle Blog - Grantland",
|
|
"favorite": "1",
|
|
"status": "1",
|
|
"time_added": "1473020899",
|
|
"time_updated": "1473020899",
|
|
"time_read": "0",
|
|
"time_favorited": "0",
|
|
"sort_id": 0,
|
|
"resolved_title": "The Massive Ryder Cup Preview",
|
|
"resolved_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview",
|
|
"excerpt": "The list of things I love about the Ryder Cup is so long that it could fill a (tedious) novel, and golf fans can probably guess most of them.",
|
|
"is_article": "1",
|
|
"has_video": "0",
|
|
"has_image": "0",
|
|
"word_count": "3197"
|
|
}
|
|
JSON;
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory('
|
|
{
|
|
"status": 1,
|
|
"list": {
|
|
"229279690": '.$body.'
|
|
}
|
|
}
|
|
')),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->never())
|
|
->method('findByUrlAndUserId');
|
|
|
|
$this->em
|
|
->expects($this->never())
|
|
->method('getRepository');
|
|
|
|
$entry = new Entry($this->user);
|
|
|
|
$this->contentProxy
|
|
->expects($this->never())
|
|
->method('updateEntry');
|
|
|
|
$factory = new RedisMockFactory();
|
|
$redisMock = $factory->getAdapter('Predis\Client', true);
|
|
|
|
$queue = new RedisQueue($redisMock, 'pocket');
|
|
$producer = new Producer($queue);
|
|
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->setProducer($producer);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->setMarkAsRead(true)->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 1], $pocketImport->getSummary());
|
|
|
|
$this->assertNotEmpty($redisMock->lpop('pocket'));
|
|
}
|
|
|
|
public function testImportBadResponse()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(403),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->import();
|
|
|
|
$this->assertFalse($res);
|
|
|
|
$records = $this->logHandler->getRecords();
|
|
$this->assertContains('PocketImport: Failed to import', $records[0]['message']);
|
|
$this->assertEquals('ERROR', $records[0]['level_name']);
|
|
}
|
|
|
|
public function testImportWithExceptionFromGraby()
|
|
{
|
|
$client = new Client();
|
|
|
|
$mock = new Mock([
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory(json_encode(['access_token' => 'wunderbar_token']))),
|
|
new Response(200, ['Content-Type' => 'application/json'], Stream::factory('
|
|
{
|
|
"status": 1,
|
|
"list": {
|
|
"229279689": {
|
|
"status": "1",
|
|
"favorite": "1",
|
|
"resolved_url": "http://www.grantland.com/blog/the-triangle/post/_/id/38347/ryder-cup-preview"
|
|
}
|
|
}
|
|
}
|
|
')),
|
|
]);
|
|
|
|
$client->getEmitter()->attach($mock);
|
|
|
|
$pocketImport = $this->getPocketImport();
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->once())
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, true));
|
|
|
|
$this->em
|
|
->expects($this->once())
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
$entry = new Entry($this->user);
|
|
|
|
$this->contentProxy
|
|
->expects($this->once())
|
|
->method('updateEntry')
|
|
->will($this->throwException(new \Exception()));
|
|
|
|
$pocketImport->setClient($client);
|
|
$pocketImport->authorize('wunderbar_code');
|
|
|
|
$res = $pocketImport->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 1, 'queued' => 0], $pocketImport->getSummary());
|
|
}
|
|
}
|