Commit graph

12 commits

Author SHA1 Message Date
Yassine Guedidi
97ed7788b4
Merge pull request #6823 from yguedidi/use-webpack-encore
Use Webpack Encore
2025-02-07 20:51:41 +01:00
Jérémy Benoist
c774398d85
Merge pull request #7849 from anarcat/rss-alternate
restore pre-Atom behavior of linking directly to the article
2025-02-07 20:08:54 +01:00
Yassine Guedidi
f261247766 Use Webpack Encore 2025-02-02 15:31:01 +01:00
Yassine Guedidi
c89878d88e Rename wallassets to build 2025-01-20 12:36:10 +01:00
Antoine Beaupré
6f53da0fc9
restore pre-Atom behavior of linking directly to the article
RFC4287 section 4.2.7.2 specifies that "rel=alternate" is effectively
the default for the link element:

   If the "rel" attribute is not present, the link
   element MUST be interpreted as if the link relation type is
   "alternate".

So having a plain `<link>` and a `<link rel="alternate">` is kind of
weird, *especially* if they point to different resources. So we just
remove the plain entry and *replace* it with the rel=alternate, which
is really the default here.

The sample Atom feeds in RFC4287 (section 1.1) do give an
example *only* with `rel="alternate"`:

     <entry>
       <title>Atom draft-07 snapshot</title>
       <link rel="alternate" type="text/html"
        href="http://example.org/2005/04/02/atom"/>
       <link rel="enclosure" type="audio/mpeg" length="1337"
        href="http://example.org/audio/ph34r_my_podcast.mp3"/>

To refer to the actual Wallabag URL, we use the "via", which is
defined in the RFC as:

   5.  The value "via" signifies that the IRI in the value of the href
       attribute identifies a resource that is the source of the
       information provided in the containing element.

I'm not sure how widely used that tag is, but I feel that the
distinction between `rel="alternate"` is weird at best, and buggy (and
certainly introducing unpleasantness in my usage) at worse.

Before:

        <link href="{{ entry.url }}"/>
        <link rel="alternate" type="text/html"
              href="{{ url('view', {'id': entry.id}) }}"/>
        <link rel="via"
              href="{{ entry.url }}"/>

That is:

        <link href="http://example.com/"/>
        <link rel="alternate" type="text/html"
              href="http://wallabag.example.com/view/1"/>
        <link rel="via"
              href="http://example.com/"/>

After:

        <link rel="alternate" href="{{ entry.url }}"/>
        <link rel="via" type="text/html"
              href="{{ url('view', {'id': entry.id}) }}"/>

That is:

        <link rel="alternate" href="http://example.com"/>
        <link rel="via" type="text/html"
              href="http://wallabag.example.com/view/1"/>

Closes: #7848
2024-11-22 12:02:05 -05:00
Nicolas Lœuillet
2a382b15c1 Add Markdown export 2024-11-13 17:39:29 +01:00
Alexander Sulfrian
2c8702954d Add sharing to linkding 2024-05-21 20:57:20 +02:00
Yassine Guedidi
e66ea216ce Fix CSS class name 2024-04-04 10:25:08 +02:00
Yassine Guedidi
b8819cc3d7 Use IsGranted in EntryController 2024-04-04 10:25:08 +02:00
Yassine Guedidi
71e7c16dfe Fix logo path in entries.xml.twig 2024-02-25 00:28:03 +01:00
Yassine Guedidi
0b44170e83 Remove the CoreBundle namespace 2024-02-23 07:42:48 +01:00
Yassine Guedidi
664b4baa3e Move templates 2024-02-19 10:32:55 +01:00