Added test for deduplication

This commit is contained in:
Nicolas Lœuillet 2017-05-05 14:33:36 +02:00
parent c613df0e25
commit d09fe4d233
No known key found for this signature in database
GPG key ID: BDC1EFB5CA0145F2
4 changed files with 67 additions and 3 deletions

View file

@ -392,4 +392,23 @@ class EntryRepository extends EntityRepository
return $qb->getQuery()->getArrayResult();
}
/**
* Find all entries by url and owner.
*
* @param $url
* @param $userId
*
* @return array
*/
public function findAllByUrlAndUserId($url, $userId)
{
$res = $this->createQueryBuilder('e')
->where('e.url = :url')->setParameter('url', urldecode($url))
->andWhere('e.user = :user_id')->setParameter('user_id', $userId)
->getQuery()
->getResult();
return $res;
}
}

View file

@ -6,10 +6,11 @@ use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Tester\CommandTester;
use Wallabag\CoreBundle\Command\CleanDuplicatesCommand;
use Tests\Wallabag\CoreBundle\WallabagCoreTestCase;
use Wallabag\CoreBundle\Entity\Entry;
class CleanDuplicatesCommandTest extends WallabagCoreTestCase
{
public function testRunTagAllCommandForAll()
public function testTagAll()
{
$application = new Application($this->getClient()->getKernel());
$application->add(new CleanDuplicatesCommand());
@ -56,4 +57,48 @@ class CleanDuplicatesCommandTest extends WallabagCoreTestCase
$this->assertContains('Cleaned 0 duplicates for user admin', $tester->getDisplay());
}
public function testDuplicate()
{
$url = 'http://www.lemonde.fr/sport/visuel/2017/05/05/rondelle-prison-blanchissage-comprendre-le-hockey-sur-glace_5122587_3242.html';
$client = $this->getClient();
$em = $client->getContainer()->get('doctrine.orm.entity_manager');
$this->logInAs('admin');
$nbEntries = $em->getRepository('WallabagCoreBundle:Entry')->findAllByUrlAndUserId($url, $this->getLoggedInUserId());
$this->assertCount(0, $nbEntries);
$user = $em->getRepository('WallabagUserBundle:User')->findOneById($this->getLoggedInUserId());
$entry1 = new Entry($user);
$entry1->setUrl($url);
$entry2 = new Entry($user);
$entry2->setUrl($url);
$em->persist($entry1);
$em->persist($entry2);
$em->flush();
$nbEntries = $em->getRepository('WallabagCoreBundle:Entry')->findAllByUrlAndUserId($url, $this->getLoggedInUserId());
$this->assertCount(2, $nbEntries);
$application = new Application($this->getClient()->getKernel());
$application->add(new CleanDuplicatesCommand());
$command = $application->find('wallabag:clean-duplicates');
$tester = new CommandTester($command);
$tester->execute([
'command' => $command->getName(),
'username' => 'admin',
]);
$this->assertContains('Cleaned 1 duplicates for user admin', $tester->getDisplay());
$nbEntries = $em->getRepository('WallabagCoreBundle:Entry')->findAllByUrlAndUserId($url, $this->getLoggedInUserId());
$this->assertCount(1, $nbEntries);
}
}

View file

@ -70,7 +70,7 @@ class ExportCommandTest extends WallabagCoreTestCase
$tester->execute([
'command' => $command->getName(),
'username' => 'admin',
'filepath' => 'specialexport.json'
'filepath' => 'specialexport.json',
]);
$this->assertFileExists('specialexport.json');

View file

@ -111,7 +111,7 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
$this->assertEquals('http://domain.io', $entry->getUrl());
$this->assertEquals('my title', $entry->getTitle());
$this->assertEquals($this->fetchingErrorMessage . '<p><i>But we found a short description: </i></p>desc', $entry->getContent());
$this->assertEquals($this->fetchingErrorMessage.'<p><i>But we found a short description: </i></p>desc', $entry->getContent());
$this->assertEmpty($entry->getPreviewPicture());
$this->assertEmpty($entry->getLanguage());
$this->assertEmpty($entry->getHttpStatus());