mirrors/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-01-24 07:38:11 +00:00
Code Issues Projects Releases Wiki Activity

Improve checks & add tests

Browse source
This commit is contained in:
Jeremy Benoist 2019-01-28 06:03:16 +01:00
parent a2e60dd393
commit 8d082488e9
No known key found for this signature in database
GPG key ID: BCA73962457ACC3C
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Wallabag/ImportBundle/Import/PocketImport.php
View file

@ -206,10 +206,10 @@ class PocketImport extends AbstractImport
$this->fetchContent($entry, $url); $this->fetchContent($entry, $url);
// 0, 1, 2 - 1 if the item is archived - 2 if the item should be deleted // 0, 1, 2 - 1 if the item is archived - 2 if the item should be deleted
$entry->setArchived(1 == $importedEntry['status'] || $this->markAsRead); $entry->setArchived(1 === (int) $importedEntry['status'] || $this->markAsRead);
// 0 or 1 - 1 If the item is starred // 0 or 1 - 1 if the item is starred
$entry->setStarred(1 == $importedEntry['favorite']); $entry->setStarred(1 === (int) $importedEntry['favorite']);
$title = 'Untitled'; $title = 'Untitled';
if (isset($importedEntry['resolved_title']) && '' !== $importedEntry['resolved_title']) { if (isset($importedEntry['resolved_title']) && '' !== $importedEntry['resolved_title']) {

7
tests/Wallabag/ImportBundle/Import/PocketImportTest.php
View file

@ -226,6 +226,13 @@ class PocketImportTest extends TestCase
->method('getRepository') ->method('getRepository')
->willReturn($entryRepo); ->willReturn($entryRepo);
$this->em
->expects($this->any())
->method('persist')
->with($this->callback(function ($persistedEntry) {
return $persistedEntry->isArchived() && $persistedEntry->isStarred();
}));
$entry = new Entry($this->user); $entry = new Entry($this->user);
$this->contentProxy $this->contentProxy