mirrors/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2025-06-07 16:08:48 +00:00
Code Issues Projects Releases Wiki Activity

updateOriginUrl: remove 'query string' case from ignore list

Browse source 
Two urls with a different query string may refer to two different pages
so keep them both.

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
This commit is contained in:
Kevin Decherf 2018-10-24 22:27:27 +02:00
parent 44e63667d9
commit 6059967951
2 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Wallabag/CoreBundle/Helper/ContentProxy.php
View file

@ -374,8 +374,6 @@ class ContentProxy
$entry->setUrl($url); $entry->setUrl($url);
break; break;
case ['fragment']: case ['fragment']:
case ['query']:
case ['fragment', 'query']:
// noop // noop
break; break;
default: default:

12
tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
View file

@ -777,20 +777,12 @@ class ContentProxyTest extends TestCase
null, null,
'example.com', 'example.com',
], ],
'no query string in fetched content' => [
'https://example.org/hello?world=1',
null,
'https://example.org/hello',
'https://example.org/hello?world=1',
null,
'example.org',
],
'query string in fetched content' => [ 'query string in fetched content' => [
'https://example.org/hello', 'https://example.org/hello',
null, null,
'https://example.org/hello?world=1', 'https://example.org/hello?world=1',
'https://example.org/hello?world=1',
'https://example.org/hello', 'https://example.org/hello',
null,
'example.org', 'example.org',
], ],
'fragment in fetched content' => [ 'fragment in fetched content' => [
@ -805,8 +797,8 @@ class ContentProxyTest extends TestCase
'https://example.org/hello', 'https://example.org/hello',
null, null,
'https://example.org/hello?foo#world', 'https://example.org/hello?foo#world',
'https://example.org/hello?foo#world',
'https://example.org/hello', 'https://example.org/hello',
null,
'example.org', 'example.org',
], ],
'different path and query string in fetch content' => [ 'different path and query string in fetch content' => [