mirrors/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2024-11-26 19:11:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2680 from wallabag/taggingrule-255

Browse source 
Limit rule to 255
This commit is contained in:
Nicolas Lœuillet 2016-12-06 21:00:24 +01:00 committed by GitHub
commit 558d5199b9
2 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/Wallabag/CoreBundle/Entity/TaggingRule.php
View file

@ -28,6 +28,7 @@ class TaggingRule
* @var string
*
* @Assert\NotBlank()
* @Assert\Length(max=255)
* @RulerZAssert\ValidRule(
* allowed_variables={"title", "url", "isArchived", "isStared", "content", "language", "mimetype", "readingTime", "domainName"},
* allowed_operators={">", "<", ">=", "<=", "=", "is", "!=", "and", "not", "or", "matches"}

23
tests/Wallabag/CoreBundle/Controller/ConfigControllerTest.php
View file

@ -515,6 +515,29 @@ class ConfigControllerTest extends WallabagCoreTestCase
}
}
public function testTaggingRuleTooLong()
{
$this->logInAs('admin');
$client = $this->getClient();
$crawler = $client->request('GET', '/config');
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('button[id=tagging_rule_save]')->form();
$crawler = $client->submit($form, [
'tagging_rule[rule]' => str_repeat('title', 60),
'tagging_rule[tags]' => 'cool tag',
]);
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(['_text']));
$this->assertContains('255 characters', $body[0]);
}
public function testDeletingTaggingRuleFromAnOtherUser()
{
$this->logInAs('bob');