mirrors/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2024-11-29 20:41:03 +00:00
Code Issues Projects Releases Wiki Activity

Add prefix for tag slugs

Browse source 
This should be considered as a temporary fix, we may deprecate tag
slugs in the future.

Fixes #6048

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
This commit is contained in:
Kevin Decherf 2023-01-09 22:18:23 +01:00
parent 126b32131f
commit 2f2cfa2c2a
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Wallabag/CoreBundle/Entity/Tag.php
View file

@ -45,7 +45,7 @@ class Tag
/**
* @Expose
* @Gedmo\Slug(fields={"label"})
* @Gedmo\Slug(fields={"label"}, prefix="t:")
* @ORM\Column(length=128, unique=true)
*/
private $slug;

2
tests/Wallabag/CoreBundle/Controller/ExportControllerTest.php
View file

@ -124,7 +124,7 @@ class ExportControllerTest extends WallabagCoreTestCase
$this->assertSame('binary', $headers->get('content-transfer-encoding'));
ob_start();
$crawler = $client->request('GET', '/export/tag_entries.pdf?tag=foo-bar');
$crawler = $client->request('GET', '/export/tag_entries.pdf?tag=t:foo-bar');
ob_end_clean();
$this->assertSame(200, $client->getResponse()->getStatusCode());

10
tests/Wallabag/CoreBundle/Controller/FeedControllerTest.php
View file

@ -250,29 +250,29 @@ class FeedControllerTest extends WallabagCoreTestCase
$client = $this->getTestClient();
// tag foo - without sort
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/foo');
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/t:foo');
$this->assertSame(200, $client->getResponse()->getStatusCode());
$this->assertSame('test title entry4', $crawler->filterXPath('//feed/entry[1]/title')->text());
$this->assertSame('test title entry1', $crawler->filterXPath('//feed/entry[2]/title')->text());
// tag foo - with sort created
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/foo?sort=created');
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/t:foo?sort=created');
$this->assertSame(200, $client->getResponse()->getStatusCode());
$this->assertSame('test title entry4', $crawler->filterXPath('//feed/entry[1]/title')->text());
$this->assertSame('test title entry1', $crawler->filterXPath('//feed/entry[2]/title')->text());
// tag foo - with sort updated
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/foo?sort=updated');
$crawler = $client->request('GET', '/feed/admin/SUPERTOKEN/tags/t:foo?sort=updated');
$this->assertSame(200, $client->getResponse()->getStatusCode());
$this->assertSame('test title entry1', $crawler->filterXPath('//feed/entry[1]/title')->text());
$this->assertSame('test title entry4', $crawler->filterXPath('//feed/entry[2]/title')->text());
// tag foo - with invalid sort
$client->request('GET', '/feed/admin/SUPERTOKEN/tags/foo?sort=invalid');
$client->request('GET', '/feed/admin/SUPERTOKEN/tags/t:foo?sort=invalid');
$this->assertSame(400, $client->getResponse()->getStatusCode());
// tag foo/3000
$client->request('GET', '/feed/admin/SUPERTOKEN/tags/foo/3000');
$client->request('GET', '/feed/admin/SUPERTOKEN/tags/t:foo/3000');
$this->assertSame(302, $client->getResponse()->getStatusCode());
}