mirrors/wallabag
1
0
Fork 0
mirror of https://github.com/wallabag/wallabag.git synced 2024-06-13 18:59:27 +00:00
Code Issues Projects Releases Wiki Activity

EntryRepository: refactor getBuilderForUntaggedByUser

Browse source 
Improve SQL performance by replacing size(e.tags) with a left join and a
null condition

Move the QueryBuilder logic into getRawBuilderForUntaggedByUser

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
This commit is contained in:
Kevin Decherf 2018-09-02 17:44:19 +02:00
parent b7c5fda512
commit 0636697289
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/Wallabag/CoreBundle/Repository/EntryRepository.php
View file

@ -102,7 +102,7 @@ class EntryRepository extends EntityRepository
}
/**
* Retrieves untagged entries for a user.
* Retrieve a sorted list of untagged entries for a user.
*
* @param int $userId
*
@ -111,8 +111,21 @@ class EntryRepository extends EntityRepository
public function getBuilderForUntaggedByUser($userId)
{
return $this
->getSortedQueryBuilderByUser($userId)
->andWhere('size(e.tags) = 0');
->sortQueryBuilder($this->getRawBuilderForUntaggedByUser($userId));
}
/**
* Retrieve untagged entries for a user.
*
* @param int $userId
*
* @return QueryBuilder
*/
public function getRawBuilderForUntaggedByUser($userId)
{
return $this->getQueryBuilderByUser($userId)
->leftJoin('e.tags', 't')
->andWhere('t.id is null');
}
/**