mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-11-18 07:27:56 +00:00
8067244765
Dont swallow API errors (fixes #1834)
214 lines
6.5 KiB
Rust
214 lines
6.5 KiB
Rust
use crate::PerformCrud;
|
|
use actix_web::web::Data;
|
|
use lemmy_api_common::{
|
|
blocking,
|
|
check_community_ban,
|
|
check_person_block,
|
|
comment::*,
|
|
get_local_user_view_from_jwt,
|
|
get_post,
|
|
send_local_notifs,
|
|
};
|
|
use lemmy_apub::{
|
|
activities::{
|
|
comment::create_or_update::CreateOrUpdateComment,
|
|
voting::vote::{Vote, VoteType},
|
|
CreateOrUpdateType,
|
|
},
|
|
fetcher::post_or_comment::PostOrComment,
|
|
generate_apub_endpoint,
|
|
EndpointType,
|
|
};
|
|
use lemmy_db_queries::{
|
|
source::{comment::Comment_, person_mention::PersonMention_},
|
|
Crud,
|
|
Likeable,
|
|
};
|
|
use lemmy_db_schema::source::{comment::*, person_mention::PersonMention};
|
|
use lemmy_db_views::comment_view::CommentView;
|
|
use lemmy_utils::{
|
|
utils::{remove_slurs, scrape_text_for_mentions},
|
|
ApiError,
|
|
ConnectionId,
|
|
LemmyError,
|
|
};
|
|
use lemmy_websocket::{send::send_comment_ws_message, LemmyContext, UserOperationCrud};
|
|
|
|
#[async_trait::async_trait(?Send)]
|
|
impl PerformCrud for CreateComment {
|
|
type Response = CommentResponse;
|
|
|
|
async fn perform(
|
|
&self,
|
|
context: &Data<LemmyContext>,
|
|
websocket_id: Option<ConnectionId>,
|
|
) -> Result<CommentResponse, LemmyError> {
|
|
let data: &CreateComment = self;
|
|
let local_user_view =
|
|
get_local_user_view_from_jwt(&data.auth, context.pool(), context.secret()).await?;
|
|
|
|
let content_slurs_removed =
|
|
remove_slurs(&data.content.to_owned(), &context.settings().slur_regex());
|
|
|
|
// Check for a community ban
|
|
let post_id = data.post_id;
|
|
let post = get_post(post_id, context.pool()).await?;
|
|
let community_id = post.community_id;
|
|
|
|
check_community_ban(local_user_view.person.id, community_id, context.pool()).await?;
|
|
|
|
check_person_block(local_user_view.person.id, post.creator_id, context.pool()).await?;
|
|
|
|
// Check if post is locked, no new comments
|
|
if post.locked {
|
|
return Err(ApiError::err_plain("locked").into());
|
|
}
|
|
|
|
// If there's a parent_id, check to make sure that comment is in that post
|
|
if let Some(parent_id) = data.parent_id {
|
|
// Make sure the parent comment exists
|
|
let parent = blocking(context.pool(), move |conn| Comment::read(conn, parent_id))
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_create_comment", e))?;
|
|
|
|
check_person_block(local_user_view.person.id, parent.creator_id, context.pool()).await?;
|
|
|
|
// Strange issue where sometimes the post ID is incorrect
|
|
if parent.post_id != post_id {
|
|
return Err(ApiError::err_plain("couldnt_create_comment").into());
|
|
}
|
|
}
|
|
|
|
let comment_form = CommentForm {
|
|
content: content_slurs_removed,
|
|
parent_id: data.parent_id.to_owned(),
|
|
post_id: data.post_id,
|
|
creator_id: local_user_view.person.id,
|
|
..CommentForm::default()
|
|
};
|
|
|
|
// Create the comment
|
|
let comment_form2 = comment_form.clone();
|
|
let inserted_comment = blocking(context.pool(), move |conn| {
|
|
Comment::create(conn, &comment_form2)
|
|
})
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_create_comment", e))?;
|
|
|
|
// Necessary to update the ap_id
|
|
let inserted_comment_id = inserted_comment.id;
|
|
let protocol_and_hostname = context.settings().get_protocol_and_hostname();
|
|
|
|
let updated_comment: Comment =
|
|
blocking(context.pool(), move |conn| -> Result<Comment, LemmyError> {
|
|
let apub_id = generate_apub_endpoint(
|
|
EndpointType::Comment,
|
|
&inserted_comment_id.to_string(),
|
|
&protocol_and_hostname,
|
|
)?;
|
|
Ok(Comment::update_ap_id(conn, inserted_comment_id, apub_id)?)
|
|
})
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_create_comment", e))?;
|
|
|
|
CreateOrUpdateComment::send(
|
|
&updated_comment,
|
|
&local_user_view.person,
|
|
CreateOrUpdateType::Create,
|
|
context,
|
|
)
|
|
.await?;
|
|
|
|
// Scan the comment for user mentions, add those rows
|
|
let post_id = post.id;
|
|
let mentions = scrape_text_for_mentions(&comment_form.content);
|
|
let recipient_ids = send_local_notifs(
|
|
mentions,
|
|
updated_comment.clone(),
|
|
local_user_view.person.clone(),
|
|
post,
|
|
context.pool(),
|
|
true,
|
|
&context.settings(),
|
|
)
|
|
.await?;
|
|
|
|
// You like your own comment by default
|
|
let like_form = CommentLikeForm {
|
|
comment_id: inserted_comment.id,
|
|
post_id,
|
|
person_id: local_user_view.person.id,
|
|
score: 1,
|
|
};
|
|
|
|
let like = move |conn: &'_ _| CommentLike::like(conn, &like_form);
|
|
blocking(context.pool(), like)
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_like_comment", e))?;
|
|
|
|
let object = PostOrComment::Comment(updated_comment);
|
|
Vote::send(
|
|
&object,
|
|
&local_user_view.person,
|
|
community_id,
|
|
VoteType::Like,
|
|
context,
|
|
)
|
|
.await?;
|
|
|
|
let person_id = local_user_view.person.id;
|
|
let comment_id = inserted_comment.id;
|
|
let comment_view = blocking(context.pool(), move |conn| {
|
|
CommentView::read(conn, comment_id, Some(person_id))
|
|
})
|
|
.await??;
|
|
|
|
// If its a comment to yourself, mark it as read
|
|
if local_user_view.person.id == comment_view.get_recipient_id() {
|
|
let comment_id = inserted_comment.id;
|
|
blocking(context.pool(), move |conn| {
|
|
Comment::update_read(conn, comment_id, true)
|
|
})
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_update_comment", e))?;
|
|
}
|
|
// If its a reply, mark the parent as read
|
|
if let Some(parent_id) = data.parent_id {
|
|
let parent_comment = blocking(context.pool(), move |conn| {
|
|
CommentView::read(conn, parent_id, Some(person_id))
|
|
})
|
|
.await??;
|
|
if local_user_view.person.id == parent_comment.get_recipient_id() {
|
|
blocking(context.pool(), move |conn| {
|
|
Comment::update_read(conn, parent_id, true)
|
|
})
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_update_parent_comment", e))?;
|
|
}
|
|
// If the parent has PersonMentions mark them as read too
|
|
let person_id = local_user_view.person.id;
|
|
let person_mention = blocking(context.pool(), move |conn| {
|
|
PersonMention::read_by_comment_and_person(conn, parent_id, person_id)
|
|
})
|
|
.await?;
|
|
if let Ok(mention) = person_mention {
|
|
blocking(context.pool(), move |conn| {
|
|
PersonMention::update_read(conn, mention.id, true)
|
|
})
|
|
.await?
|
|
.map_err(|e| ApiError::err("couldnt_update_person_mentions", e))?;
|
|
}
|
|
}
|
|
|
|
send_comment_ws_message(
|
|
inserted_comment.id,
|
|
UserOperationCrud::CreateComment,
|
|
websocket_id,
|
|
data.form_id.to_owned(),
|
|
Some(local_user_view.person.id),
|
|
recipient_ids,
|
|
context,
|
|
)
|
|
.await
|
|
}
|
|
}
|