mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-10-03 09:12:19 +00:00
b6584defd0
The following problem could happen: * Thread 1 : urisourcebin gets activated from READY->PAUSED * Thread 2 : some element causes a pad to be added to urisourcebin , which gets linked downstream, which decides to activate upstream to pull-based. * That requires "activating" the pads from PUSH to NONE, and then from NONE to PULL * Thread 1 : the base class state change handlers checks if all pads are activated The issue is that since going form PUSH to PULL requires going through NONE, there is a window during which: * Thread 1 : The pad was set to NONE (before being set to PULL) * Thread 2 : The base class activates that pad (to PUSH) * Thread 1 : The attempt to "activate" to PULL fails (silently or not) This is very racy, so in order to avoid that, we make sure that we only add pads once the transition from READY->PAUSED in the parent classes is done. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2784> |
||
|---|---|---|
| .. | ||
| gstdecodebin2.c | ||
| gstdecodebin3-parse.c | ||
| gstdecodebin3.c | ||
| gstparsebin.c | ||
| gstplay-enum.c | ||
| gstplay-enum.h | ||
| gstplaybackelement.c | ||
| gstplaybackelements.h | ||
| gstplaybackplugin.c | ||
| gstplaybackutils.c | ||
| gstplaybackutils.h | ||
| gstplaybin2.c | ||
| gstplaybin3.c | ||
| gstplaysink.c | ||
| gstplaysink.h | ||
| gstplaysinkaudioconvert.c | ||
| gstplaysinkaudioconvert.h | ||
| gstplaysinkconvertbin.c | ||
| gstplaysinkconvertbin.h | ||
| gstplaysinkvideoconvert.c | ||
| gstplaysinkvideoconvert.h | ||
| gstrawcaps.h | ||
| gststreamsynchronizer.c | ||
| gststreamsynchronizer.h | ||
| gstsubtitleoverlay.c | ||
| gstsubtitleoverlay.h | ||
| gsturidecodebin.c | ||
| gsturidecodebin3.c | ||
| gsturisourcebin.c | ||
| meson.build | ||