Rob Agar
f48c8f4d17
missing transceiver unref in WebRTC renegotiation example
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1160 >
2021-10-15 10:03:46 +01:00
He Junyan
18f97d703d
Docs: Fix a typo for Intel's vaapi driver name.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1151 >
2021-10-15 07:57:37 +00:00
Thibault Saunier
a1dc45b654
wraps:ffmpeg: Move to 4.4
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1156 >
2021-10-15 02:32:40 +00:00
Mengkejiergeli Ba
b57df4cfd1
tests:va: Fix null ptr dereference in multi-vpp
...
Dereference the pointer err before null check, which raised a null
pointer dereference issue by Coverity. Modify it to do the null check
of err first, then dereference it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143 >
2021-10-15 00:45:45 +00:00
Mengkejiergeli Ba
4a6cc431d2
va: Fix null ptr dereference for vadeocder
...
Making a null check in gst_va_decode_picture_free () indicates pic->buffers or pic->slices
can be null, then in _destroy_buffers () the pointers are dereferenced, which is detected
as dereference after null check by Coverity. Thus, modify the code to do null check in
_detroy_buffers ().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143 >
2021-10-15 00:45:44 +00:00
Xavier Claessens
d477c9e903
Pin all wrap files to closest tag or commit sha1
...
Tracking branches, especially master, can cause regressions at any time.
We should try to use as much stable release tags as possible in the
future.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1152 >
2021-10-14 22:34:49 +00:00
Vivia Nikolaidou
23bf9f75b6
tsdemux: Handle delayed seek events
...
Store the event in case it cannot be processed immediately and process
it after the first segment has been produced.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980 >
2021-10-14 21:45:00 +00:00
Vivia Nikolaidou
5800ffea0f
tsdemux: Protect demux->segment_event with a mutex
...
Would otherwise cause weird issues when processing a delayed seek event
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980 >
2021-10-14 21:45:00 +00:00
Piotrek Brzeziński
a102444c90
video-converter: Fix v210->I420 last line conversion
...
Last line would not be converted correctly if height was an odd number.
Fixed by accounting for data type (8bit vs. 16bit) differences between
respective packing and unpacking functions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973 >
2021-10-14 21:03:58 +00:00
Piotrek Brzeziński
33ccabd206
video-format: Clean up v210 packing code
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973 >
2021-10-14 21:03:58 +00:00
Piotrek Brzeziński
35a7b19381
video-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973 >
2021-10-14 21:03:58 +00:00
Nicolas Dufresne
da464bde5f
codecs: h264: Fix wrong type of ret variable
...
This ret is not a GstFlowReturn. This broke v4l2 decoder which does not
implement new_picture() virtual function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1154 >
2021-10-14 20:12:03 +00:00
Seungha Yang
b3710aa68d
d3d11: Rename screen capture element
...
Old name "desktopdup" may confuse users. Now it's renamed to
"screencapture"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1136 >
2021-10-14 15:15:56 +00:00
Thibault Saunier
9a183e45d4
validate:launcher: Reindent utils.py
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121 >
2021-10-14 12:59:29 +00:00
Thibault Saunier
004a83f82a
validate:launcher: Check if the running MR will close a referenced issue
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121 >
2021-10-14 12:59:29 +00:00
Thibault Saunier
42501adc4c
ci: Check for closed bugs for unit tests too
...
And add FIXMEs for test that should have been reenabled but haven't,
we will reenable them when CI is stable enough!
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121 >
2021-10-14 12:59:29 +00:00
Thibault Saunier
968ecbba54
tests: Move all unit tests issues to the GStreamer monorepo
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121 >
2021-10-14 12:59:29 +00:00
Thibault Saunier
2dacd33e9e
transcoder: Set state back to NULL after run() finishes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063 >
2021-10-14 12:04:45 +00:00
Thibault Saunier
07908ccead
transcoder: Use full path for includes in 'gsttranscoder.h'
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063 >
2021-10-14 12:04:45 +00:00
Mengkejiergeli Ba
8f678c95d6
va:display: Don't close an fd with negative value
...
Cannot pass negative parameter to close() and thus no need to apply
close() when fd < 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131 >
2021-10-14 11:12:41 +00:00
Mengkejiergeli Ba
5e7aa06257
va: Fix error handling for decoder
...
Need to check if va decoder is closed successfully.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131 >
2021-10-14 11:12:41 +00:00
Mengkejiergeli Ba
2eaba0cefa
va: Fix error handling for base transform
...
Need to check the returned value of gst_buffer_pool_set_active() when
setting the active status of buffer pool.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131 >
2021-10-14 11:12:41 +00:00
Matthew Waters
ee1255079b
gl/dmabuf: add some debug logging about why things may fail to be uploaded
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1145 >
2021-10-14 07:41:44 +00:00
Matthew Waters
42597181e2
playbin2/3: autoplug/caps: don't expand caps to ANY
...
Retrieving the pad template caps from a ghost pad returns ANY which when
merged with any other caps will return ANY. ANY is not very specific
and may cause suboptimal code paths in e.g. decoders that assume the
lowest common denominator when presented with ANY caps.
Fixes negotiating dma-buf with vaapidecodebin between glupload in the
video sink element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1144 >
2021-10-14 17:04:26 +11:00
Thibault Saunier
0a781424e6
meson:avtp: Error out if sock_txtime is not present and avtp is enabled
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1142 >
2021-10-14 01:01:54 +00:00
Thibault Saunier
287814a83d
Revert "tests: Blacklist some tests that recently failed"
...
This reverts commit 9f13ee5b0e
as
it was merge as part of the bigger CI gardening MR
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1139 >
2021-10-13 20:34:42 +00:00
Philippe Normand
8b553d5b32
soup-stub: Gate G_URI_FLAGS_SCHEME_NORMALIZE behind glib version check
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1138 >
2021-10-13 19:24:02 +00:00
Thibault Saunier
7a25a4ce02
ges:test: Document some GES failures
...
Namely races in:
* check.gst-editing-services.edit_while_seeked_with_stop_it
* check.gst-editing-services.check_layer_activness_gaps_it
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/803
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/804
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130 >
2021-10-13 18:01:38 +00:00
Thibault Saunier
19c0921179
ges:tests: Create shorter assets to avoid timeouts
...
And use a simple GStreamer pipeline as testsrcbin with GstTranscoder
doesn't let us easily set the framerate of the source and we end up
having videorate dropping frames leading to the rendered file having
an unprecise duration.
This should fix races with `check.gst-editing-services.pythontests.pyunittest.python.test_assets.TestTimeline.test_reload_asset`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130 >
2021-10-13 18:01:38 +00:00
Thibault Saunier
fbee6c8b23
validate:launcher: Avoid spamming terminal when inspecting unit tests
...
And redirect GStreamer logs when necessary
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130 >
2021-10-13 18:01:38 +00:00
Thibault Saunier
34d05cd876
validate:launcher: Run validate unit tests as GstValidate tests
...
So we have all the features and we can properly document known issue
for them
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130 >
2021-10-13 18:01:38 +00:00
Seungha Yang
4dd0c6ce44
codecparsers: {h264,h265}parser: Fix typo around SEI nalu generator
...
Fix to create correct SEI nalu when the size of payloadType and/or
payloadType is larger than 255 (0xff)
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1601
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1106 >
2021-10-13 17:21:52 +00:00
Stéphane Cerveau
7256ddb74a
rebase-branch-from-old: few improvments
...
- Enhance the documentation
- Allow to revert cherry-pick
- coding style
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1094 >
2021-10-13 17:03:09 +00:00
Seungha Yang
551239c618
validate: flow: Fix for line-ending mismatch issue on Windows
...
Unlike POSIX system, Windows distinguishes "w" and "wb" and when
a file is opened with text mode, OS will translate \n into \r\n.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1092 >
2021-10-13 16:21:52 +00:00
Víctor Manuel Jáquez Leal
a2aa2cda42
vapostproc: Negotiate interlaced.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109 >
2021-10-13 14:59:09 +00:00
Víctor Manuel Jáquez Leal
60be3dbd2a
vapostproc: Copy missing fields at fixate.
...
When caps negotiation implies a caps feature change, some fields might
get lost. This patch brings them back from input caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109 >
2021-10-13 14:59:09 +00:00
Víctor Manuel Jáquez Leal
5ae1072c2f
vapostproc: Simplify size fixate.
...
gst_va_vpp_fixate_size() returned the fixated caps, but that is not
needed since `othercaps` are modified inline.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109 >
2021-10-13 14:59:09 +00:00
Víctor Manuel Jáquez Leal
b53446ddc9
vapostproc: Simplify fixate.
...
The first approach to fixate was simply a copy&paste of both
videoconvert and videoscale, trying to keep their logic as isolated
as possible. But that brought duplicated and sparse logic.
This patch merge both approaches simplifying the fixate operation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109 >
2021-10-13 14:59:09 +00:00
Víctor Manuel Jáquez Leal
1642c3fc96
va: filter, deinterlace, vpp: Add gst_va_buffer_get_surface_flags().
...
Add a helper function to get, from GstVideoInfo and GstBuffers flags,
the VA interlace surface flags. This is used currently by vainterlace
element, but it will be used in vapostproc too if it can process
interlaced frames.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109 >
2021-10-13 14:59:09 +00:00
Thibault Saunier
9f13ee5b0e
tests: Blacklist some tests that recently failed
...
See:
- https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/739
- https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/740
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/927 >
2021-10-13 12:37:08 +00:00
Bastien Nocera
e1271c0d9c
gtkglsink: Avoid assertion when applying "auto" rotation method
...
Guard against the orientation not coming from an inexistant tag, nor
from the application (rotation set to "auto") which caused an assertion.
When the application requests the auto rotation method, make sure it is
resolved to a rotation that's applicable.
ERROR:gstreamer/subprojects/gst-plugins-good/ext/gtk/gtkgstglwidget.c:745:gtk_gst_gl_widget_set_rotate_method: code should not be reached
Fixes: 103ceb853a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1134 >
2021-10-13 09:16:32 +00:00
Philippe Normand
c3455def2e
soup: Runtime compatibility support for libsoup2 and libsoup3
...
The src and sink elements no longer link against libsoup. It is now loaded at
runtime. If any version is resident already, it is used. Otherwise we first try
to load libsoup3 and if it's not found we fallback to libsoup2.
For the unit-tests, we now build one version of the test unit file per libsoup
version found. So if both libsoup2 and libsoup3 are available on the host, the
CI will cover them both.
Based on initial patch by Daniel Kolesa <dkolesa@igalia.com> and
Patrick Griffis <pgriffis@igalia.com>.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1044 >
2021-10-13 08:32:25 +00:00
Seungha Yang
0a94da9611
examples: playback-test: Fix for UI resize scenario on Windows
...
Application needs to notify videosink element of video widget resize
via gst_video_overlay_set_render_rectangle() since WM_SIZE event
wouldn't be notified.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1115 >
2021-10-13 07:04:08 +00:00
Olivier Crête
4d3a200358
audio: Merge simd libs into the main one
...
Actually extract the .o objects from the convience libraries and put
them into the main one. Without this, they will just be referenced by
the .pc file, but it will be unusable because they are not installed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1122 >
2021-10-13 01:28:16 +00:00
Nirbheek Chauhan
d9449b1d81
meson: Remove duplicate definition of 'examples' option
...
This is a hard error starting with Meson 0.60.0rc1, due to
https://github.com/mesonbuild/meson/pull/9184#issuecomment-941603358
The upstream change might get reverted before release, but we should
of course fix this regardless.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1127 >
2021-10-12 22:54:56 +00:00
Olivier Crête
c272d0bfcd
rtopuspay: Set marker bit inside RTP packet too
...
At the end of a talk spurt, not only set the marker flag on the
GstBuffer, but also set the bit inside the RTP header as recommended
by the RFC.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1124 >
2021-10-12 17:18:19 -04:00
Bastien Nocera
9e5b6830cd
gtksink: Fetch the default "widget" value in the docs
...
There's really no interesting "widget" value that could be shown in the
docs, so use the GST_PARAM_DOC_SHOW_DEFAULT flag to avoid showing
another value.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088 >
2021-10-12 20:27:34 +00:00
Bastien Nocera
b0d4996380
gtksink: Avoid errors fetching widget property
...
Avoid errors when fetching the "widget" property and GTK initialisation
fails, such as when running in a non-graphical environment.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088 >
2021-10-12 20:27:34 +00:00
Olivier Crête
941c0e81dd
gtksink: Return reference to GtkWidget in the acquire function
...
This should ensure thread safety.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088 >
2021-10-12 20:27:34 +00:00
Olivier Crête
103ceb853a
gtkglsink: Add rotate-method property
...
This mostly just takes code out of glimagesink and applies it here.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088 >
2021-10-12 20:27:34 +00:00