Thibault Saunier
2be3c04b9b
validate:scenario: Force clock sink for scenarios with a pause action
2014-11-19 17:59:26 +01:00
Thibault Saunier
a15b2544ce
validate: Handle wrong paths when listing avalaible apps
...
User can make mistake or we can have an empty path.
2014-11-19 17:59:26 +01:00
Thibault Saunier
7f8c0c2751
validate: Do not check if first buffer running time is 0
...
It can perfectly not be 0, so it makes no sense to check that.
https://bugzilla.gnome.org/show_bug.cgi?id=739965
2014-11-19 17:59:26 +01:00
Thibault Saunier
5d8f6083b4
validate: Add audiomixer test to the default testsuite
2014-11-16 18:27:32 +01:00
Thibault Saunier
9255a8f876
pad-monitor: Give better details about segment mismatch issues
2014-11-16 18:27:32 +01:00
Thibault Saunier
4a2b9d6431
validate: Be more precise in issue type for wrong seqnum
...
Depending on the type of event where the bug occurs,
it is not the same issue type. That allows us to have
much precise reports, and better explain the user
where the issue stands.
2014-11-16 18:27:32 +01:00
Thibault Saunier
c77089cc62
validate: Fix a few annotation issues
2014-11-16 18:27:32 +01:00
Thibault Saunier
8c6803c467
validate: Add the notion of WAIT_MULTIPLIER for the wait action
...
Allowing the user to decide to wait more, or less, or even not wait
for the wait action to execute when running scenarios.
2014-11-16 18:27:32 +01:00
Thibault Saunier
1c2c0e63c2
validate:scenario: Report an EXECUTION_ERROR on action execution failure
...
If the action type handles a better error report type, it should just
return TRUE, and report its issue itself.
2014-11-04 17:33:09 +01:00
Thibault Saunier
e2d8096cb7
validate: Do not exit when we can not discover a result file
...
Loggable.error actually exit the process, it is not what we want!
+ Avoid a backtrace
2014-11-04 17:33:08 +01:00
Edward Hervey
4814110a86
scenario: Allow set-property action to work much earlier
...
By default an action has no playback-time, this makes it actionable
immediatly.
When no playback-time is set on a set-property action, it will
be activated the moment the element is added in the pipeline.
2014-11-04 17:12:00 +01:00
Edward Hervey
6a86f7c1c9
validate-bin-monitor: Initialize local variable
...
Avoids segfaults when freeing them if they didn't get filled in
2014-10-31 16:01:52 +01:00
Mathieu Duponchelle
85587a9aa5
validate: update pre-commit hook.
...
+ Allows to run multiple pre-commit hooks.
+ Always relink the hooks on autogen.
+ Run pep8 on commited python files.
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
7bbd3ed288
apps: gstvalidate.py: fix various pyflakes / uncaught pep8 issues.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
9bdc6e9b6d
validate-launcher: utils: fix various pyflakes / uncaught pep8 issues.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
b30d27e35e
validate-launcher: main: fix various pyflakes / uncaught pep8 issues.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
95065edebd
validate-launcher: loggable: fix various pyflakes / uncaught pep8 issues.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
a0a88e1708
validate-launcher: baseclasses: fix various pyflakes / uncaught pep8 issues.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
8c1e84b5f4
validate-launcher: pep8ify sources.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739208
2014-10-30 15:40:17 +01:00
Mathieu Duponchelle
fa39e0358a
validate-utils: downgrade ERROR to DEBUG.
...
This function is called in places where it is legit for it
to return NULL.
2014-10-30 15:39:01 +01:00
Mathieu Duponchelle
4d569b51ed
launcher: add a way to specify an application directory.
...
https://bugzilla.gnome.org/show_bug.cgi?id=739091
2014-10-30 15:31:29 +01:00
Mathieu Duponchelle
74ed40c904
launcher: Don't implement product-specific TestManagers.
...
This manager will be moved in GES.
https://bugzilla.gnome.org/show_bug.cgi?id=739091
2014-10-30 15:31:29 +01:00
Mathieu Duponchelle
b0beefacfa
validate-launcher: restructure filesystem
...
https://bugzilla.gnome.org/show_bug.cgi?id=739091
2014-10-30 15:31:29 +01:00
Ramprakash Jelari
eb47b1021f
validate: Fix compiler warning about implicit enum type conversion
...
gst-validate-reporter.c:119:39: error: implicit conversion from enumeration type
'GstValidateReportingDetails' to different enumeration type
'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
GstValidateInterceptionReturn ret = GST_VALIDATE_SHOW_UNKNOWN;
~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:124:11: error: implicit conversion from enumeration type
'GstValidateReportingDetails' to different enumeration type
'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
ret = iface->get_reporting_level (reporter);
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:127:10: error: implicit conversion from enumeration type
'GstValidateInterceptionReturn' to different enumeration type
'GstValidateReportingDetails' [-Werror,-Wenum-conversion]
return ret;
~~~~~~ ^~~
2014-10-24 15:19:19 +02:00
Mathieu Duponchelle
6cf2d92b0f
build: We install all headers system wide for now.
...
Will be fixed when the API is deemed stable enough
2014-10-22 14:16:45 +02:00
Mathieu Duponchelle
30aef5ba84
validate: rename GstValidateReportingLevel.
...
Removes the confusion with GstValidateReportLevel.
Modeled on GstDebugGraphDetails.
2014-10-21 23:41:04 +02:00
Thibault Saunier
6d0930bb36
validate: Verify that elements always send a segment before pushing EOS
...
EOS is some kind of data flow and thus a segment event should always be
pushed before the EOS is sent
2014-10-21 20:40:27 +02:00
Thibault Saunier
23d7df3788
validate: Properly check that the seqnum of the EOS is always properly set
...
In the pipeline, an EOS should always have the same seqnum of the
previous SEGMENT event that was received. If the segment is the result
of a seek, it should always be the same as the seek seqnum too.
+ (Mathieu Duponchelle): fix reporting and concatenation tests.
2014-10-21 20:37:23 +02:00
Thibault Saunier
34a9c36edc
validate: Add support for text based override files
...
Allowing user to easily determine the severity of issue
types in a config file
https://bugzilla.gnome.org/show_bug.cgi?id=737852
2014-10-21 20:23:32 +02:00
Thibault Saunier
b0d39c1c45
validate: Remove unused method
...
gst_media_descriptor_add_frame is not used anywhere
https://bugzilla.gnome.org/show_bug.cgi?id=737852
2014-10-21 20:21:58 +02:00
Thibault Saunier
a3513fc952
validate: Move GstStructure file parsing into utils
...
So it can be reused, at least in GstValidate.
2014-10-21 20:21:52 +02:00
Thibault Saunier
8ec61ddac2
validate: report: Simplify the issue ID registering using GQuarks
...
+ Remove unused issue types
https://bugzilla.gnome.org/show_bug.cgi?id=737790
2014-10-21 20:21:42 +02:00
Thibault Saunier
bb93dbb9fb
validate: Check all buffers when we have the info from MediaDescriptor
...
We now check that each buffer is the expected one for each buffer that
come into the decoder.
+ Fix some minor leaks in test-utils
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:21:36 +02:00
Thibault Saunier
cd9a3640b2
validate:media-descriptor-parser: Add a way to create from a string
...
So it is simple to make use of it from the testsuite
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
f793d06783
report: g_critical are CRITICAL issues!
...
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
94efe0df85
validate: launcher: Fix printing of errors in final report
...
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
20633cec19
validate: Add the possibility to generate media infos with frame descs
...
+ Fix a little issue when the generation fails.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
b3fa06c3c1
validate: MediaDescriptors: Add md5sum to buffer informations
...
In the media descriptor files, we now have the md5sum of the actual
content of encoded buffers so that we can check that the buffer content is
perfectly what is was supposed to be.
+ Fix the check of whether a frame is a keyframe in the string
comparison (g_ascii_strcasecmp return 0 if string matches)
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
50273c42a9
validate: Move some method between GstMediaDescriptorParser and GstMediaDescriptor
...
So that method land where they actually belong.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
c5dfd9c8c8
validate: Add a way to pass a MediaDescriptor around monitors
...
And add an option in gst-validate so that the user can define what
media descriptor file to use.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
c8a99218de
validate:media-descriptor: Handle stream with no tags
...
It was segfaulting before.
2014-10-21 20:14:05 +02:00
Thibault Saunier
8fb3e6112c
validate: Add more files to gitignore
2014-10-21 20:14:05 +02:00
Thibault Saunier
8f5347c465
validate: Move some method between GstMediaDescriptorParser and GstMediaDescriptor
...
So that method land where they actually belong.
2014-10-21 20:14:05 +02:00
Mathieu Duponchelle
c542d9c6bc
validate-report / reporter: rework the way we repeat issues.
...
+ runner: update reports count algorithm.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
5690a02e0a
pad-monitor: mark the peer pad as EOS too.
...
When a sink pad gets EOS, its src pad monitor should also
be marked as EOS (helpful with issue concatenation).
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0b1d00df25
validate-pad-monitor / runner: Check per-object reporting levels.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
167c29125d
validate-report: Set conditions in which a report can't be master.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
582cebeae6
validate-report: Add a reporting level field and setter.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
030e7e8ba8
validate-runner: implement synthetic report.
...
+ Fix criticals logic in validate_runner_printf
+ Update padmonitor tests
+ Split validate_report_printf function.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1993229993
validate-runner: Implement REPORT_NONE for global reporting.
...
Yeah that was tough. Helpful already though, for example:
GST_VALIDATE_REPORT_LEVEL=none,x:all gst-validate src name=x ! sink
will only report issues reported by the source.
+ Add test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0a1cdb2164
tests: Check monitors correctly determine their reporting level.
...
+ [API] gst_validate_reporter_get_reporting_level
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
5cb60060dc
validate-runner / monitor: Let the user single out pads.
...
That's some pretty specific code but it should be helpful.
The following syntax can be used : element-name::pad-name.
+ Free return of gst_object_get_name.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
b21bb1ff34
validate-runner / reporter: Sanitize reports refcounting.
...
The previous code worked but was confusing, the runner didn't actually
take the ref it was releasing later.
+ Fix indentation.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
de554ba417
tests: Test reports refcounts.
...
+ Set the element monitor on the element as qdata.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
c943a75766
validate-monitor: Determine the reporting level at setup.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1d7f15598f
validate-runner: Add code to parse GST_VALIDATE_REPORT_LEVEL.
...
+ Extend the tests.
+ [API] gst_validate_runner_get_default_reporting_level
+ [API] gst_validate_runner_get_reporting_level_for_name
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6ed125bfb1
validate-runner: report-level initial work.
...
+ Defines reporting levels and document them.
+ Add API to get the default level.
+ fix indentation.
+ fix some typos.
+ Add the beginning of a reporting test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6e08079f8b
validate-pad-monitor: concatenate issues.
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=735665
The process is to check for a similar report in intercept_report on
the pads of the upstream element, set that report as the master report
of the intercepted report, and return REPORTER_KEEP instead
of REPORTER_REPORT.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
d747e1cd05
test-utils: add a create_and_monitor element function.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
f001777cc6
validate-reporter: Add some methods
...
+ gst_validate_reporter_get_reports
+ gst_validate_reporter_get_reports_count
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
222a517384
validate-report: Add the notion of master / shadow reports.
...
A master report is a report that has been detected by a monitor
to stem from the same issue. It thus contains a list of
"shadow reports" which it will browse when printing itself.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
b8ac717297
validate-report: Make the ref / unref functions safer.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1fcaf8918f
tests/padmonitor: Correcly strdup the result of get_metadata.
...
The const pointer was becoming invalid after the first call to add_metadata,
and we ended up setting corrupted data on the second call.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
3e557ca92b
validate-reporter: Add return value to intercept_report.
...
It will allow to drop, keep or report reports.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6104701268
validate-pad-monitor: Reimplement reporter interface.
...
+ Do nothing there for now, except chain up.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
fb90aa2ead
validate-reporter: add gst_validate_reporter_get_report.
...
+ Add locking.
2014-10-21 20:13:51 +02:00
Thibault Saunier
1cc89414f1
Back to development
2014-10-20 13:38:20 +02:00
Thibault Saunier
ad415424a1
Release 1.4.0
2014-10-20 13:24:29 +02:00
Thibault Saunier
26ef55d622
validate: Print position if it could properly be queried
...
Otherwize we will print meaningless garbage.
2014-10-13 16:30:05 +02:00
Thibault Saunier
4823d998fc
validate:launcher: Minor enhancement in the documentation
2014-10-13 10:32:07 +02:00
Thibault Saunier
99045f7dbb
validate: Rename action type playback_time to playback-time
...
Keeping backward compatiblity with the old naming
2014-10-12 20:19:42 +02:00
Thibault Saunier
02ab99fcbb
validate: Rename gst_validate_add_action_type to gst_validate_register_action_type
...
The _register naming corresponds much better to what the method does
and makes it more similar to how we refer to this kind of action in
GStreamer.
It is a last minute API change, but that API should not change anymore
after 1.4 is released.
2014-10-12 20:10:19 +02:00
Thibault Saunier
9158bb36e3
validate: Fix the addition of playback_time in the parameter types
2014-10-12 20:00:03 +02:00
Thibault Saunier
8289f64904
validate: Rename --list-action-types to --inspect-action-type
...
Making clearer the meaning of the parameter and closer to the
usual naming in the GStreamer land.
2014-10-12 19:46:39 +02:00
Thibault Saunier
ce87de95ea
validate: Add the 'flags' for the seek action type
...
This was always a mandatory field but was not documented
2014-10-12 19:16:08 +02:00
Anuj Jaiswal
83c0453d81
validate: mishandled pointer criticals
...
Free glist of criticals
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736313
2014-10-09 20:38:12 -03:00
Thibault Saunier
17bf802515
validate:docs: Add documentation about the default testsuite
2014-10-01 11:02:17 +02:00
Mathieu Duponchelle
8cfffb4a3a
validate-runner: switch to using a GList for the reports.
...
+ Return a copy of that list in get_reports.
+ update tests.
2014-09-30 11:42:42 +02:00
Mathieu Duponchelle
1f1cf83af8
validate-runner: Hide implementation.
2014-09-30 11:42:42 +02:00
Mathieu Duponchelle
855f141453
gst-validate-runner: Add locking for the reports list.
2014-09-30 11:42:42 +02:00
Thibault Saunier
e7315aa78e
Release 1.3.90
2014-09-29 15:37:40 +02:00
Thibault Saunier
b856d5985c
validate:launcher: Factorize code to get a MediaDescriptor name for classname
...
Instead of copy/pasting that code badly
2014-09-12 11:26:48 +02:00
Edward Hervey
490a8f1ed9
validate/docs: Add location of Scenario/Action defines
2014-09-12 10:22:15 +02:00
Anuj Jaiswal
c98f7e7b38
validate: (performance issue)refactor to remove duplicate assignment
...
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736412
2014-09-12 09:57:05 +02:00
Thibault Saunier
1649b49f1c
validate: docs: Always dist the launcher directoty
...
Fixing make distcheck
2014-09-12 09:57:05 +02:00
Thibault Saunier
332a51d1f0
validate: Get the Runner reports in order of arrival
...
Making sure they are printed in the right order
2014-09-12 09:57:05 +02:00
Thibault Saunier
7e85c9b0b5
validate: Start a testsuite
...
Currently implemented tests are:
* Settup and cleanup on monitor is done properly
* Some tests in the PadMonitor are done properly, namely:
- Buffer before segment
- Buffer outside segment
- First buffer running time is always 0
- The Demuxer flow aggregation is properly checked
https://bugzilla.gnome.org/show_bug.cgi?id=736379
2014-09-12 09:57:05 +02:00
Edward Hervey
80de4392ce
validate/private: Avoid double typdef
...
Instead just include required (public and local) header
gst-validate-scenario.h:43:44: error: redefinition of typedef 'GstValidateActionParameter' is a C11 feature [-Werror,-Wtypedef-redefinition]
2014-09-12 09:49:35 +02:00
Thibault Saunier
07391578c9
validate: Make sphinx documentation generation optionnal
2014-09-06 12:37:30 +02:00
Thibault Saunier
3ff59368f0
validate:launcher: Add needed files to build documentation with sphinx
2014-09-06 12:22:48 +02:00
Thibault Saunier
b843ead1f8
validate: launcher: Cleanup and rename apps to avoid '-' in their name
2014-09-06 11:38:38 +02:00
Thibault Saunier
7838f3ebae
validate:launcher: Avoid '.' before media file extension in test classnames
2014-09-06 10:02:13 +02:00
Felix Schwarz
1a8b460d23
validate:docs: fix spelling mistakes
...
https://bugzilla.gnome.org/show_bug.cgi?id=736160
2014-09-05 23:21:21 +02:00
Thibault Saunier
3755581fd3
validate: Take a const gchar ** in gst_validate_print_action_types
...
This is what we actually need and thus is cleaner.
2014-09-05 23:15:29 +02:00
Thibault Saunier
69165a9f04
validate: Implement the notion of implementer namespace to the action types
...
This allows users to know who implements an action type.
+ Enhance the printing of all action making it readable.
2014-09-05 23:03:58 +02:00
Thibault Saunier
15f52d4fa3
validate: Add informations on the switch-track action overrided for playbin
2014-09-05 19:30:52 +02:00
Thibault Saunier
34fd5af840
validate: docs: Add some GstValidate usage documentation
...
+ Fix minor issues in the gst-validate and gst-validate-transcoding
tools documentation
2014-09-05 19:00:23 +02:00
Guillaume Desmottes
f7955f5249
validate: remove redundant pre-condition in monitor_factory_create
...
The same check is already done at the head of the function.
https://bugzilla.gnome.org/show_bug.cgi?id=736019
2014-09-05 19:00:23 +02:00
Guillaume Desmottes
f900f53e95
validate: fix a couple of typos in comments
...
https://bugzilla.gnome.org/show_bug.cgi?id=736019
2014-09-05 19:00:23 +02:00
Thibault Saunier
ef64eb0d0e
validate:docs: Sensibly update the usage file
2014-09-05 19:00:23 +02:00