mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-19 00:01:23 +00:00
scenario: Allow set-property action to work much earlier
By default an action has no playback-time, this makes it actionable immediatly. When no playback-time is set on a set-property action, it will be activated the moment the element is added in the pipeline.
This commit is contained in:
parent
6a86f7c1c9
commit
4814110a86
1 changed files with 49 additions and 1 deletions
|
@ -186,6 +186,7 @@ gst_validate_action_new (void)
|
|||
GstValidateAction *action = g_slice_new0 (GstValidateAction);
|
||||
|
||||
gst_validate_action_init (action);
|
||||
action->playback_time = GST_CLOCK_TIME_NONE;
|
||||
|
||||
return action;
|
||||
}
|
||||
|
@ -872,7 +873,8 @@ get_position (GstValidateScenario * scenario)
|
|||
_check_position (scenario, rate, position);
|
||||
|
||||
if (act && (((rate > 0 && (GstClockTime) position >= act->playback_time) ||
|
||||
(rate < 0 && (GstClockTime) position <= act->playback_time)) ||
|
||||
(rate < 0 && (GstClockTime) position <= act->playback_time) ||
|
||||
(act->playback_time == GST_CLOCK_TIME_NONE)) ||
|
||||
(GST_STATE (pipeline) < GST_STATE_PAUSED))) {
|
||||
GstValidateActionType *type;
|
||||
|
||||
|
@ -1567,6 +1569,49 @@ gst_validate_scenario_finalize (GObject * object)
|
|||
G_OBJECT_CLASS (gst_validate_scenario_parent_class)->finalize (object);
|
||||
}
|
||||
|
||||
static void
|
||||
_element_added_cb (GstBin * bin, GstElement * element,
|
||||
GstValidateScenario * scenario)
|
||||
{
|
||||
GstValidateScenarioPrivate *priv = scenario->priv;
|
||||
GList *tmp;
|
||||
|
||||
/* Check if it's an element we track for a set-property action */
|
||||
tmp = priv->actions;
|
||||
while (tmp) {
|
||||
GstValidateAction *action = (GstValidateAction *) tmp->data;
|
||||
const gchar *name;
|
||||
|
||||
if (action->playback_time != GST_CLOCK_TIME_NONE)
|
||||
break;
|
||||
if (g_strcmp0 (action->type, "set-property"))
|
||||
break;
|
||||
|
||||
GST_DEBUG_OBJECT (bin, "Checking action #%d %p (%s)", action->action_number,
|
||||
action, action->type);
|
||||
name = gst_structure_get_string (action->structure, "target-element-name");
|
||||
if (!strcmp (name, GST_ELEMENT_NAME (element))) {
|
||||
GstValidateActionType *action_type;
|
||||
action_type = _find_action_type (action->type);
|
||||
GST_DEBUG_OBJECT (element, "Executing set-property action");
|
||||
if (action_type->execute (scenario, action)) {
|
||||
priv->actions = g_list_remove_link (priv->actions, tmp);
|
||||
gst_mini_object_unref (GST_MINI_OBJECT (action));
|
||||
g_list_free (tmp);
|
||||
tmp = priv->actions;
|
||||
} else
|
||||
tmp = tmp->next;
|
||||
} else
|
||||
tmp = tmp->next;
|
||||
}
|
||||
|
||||
/* If it's a bin, listen to the child */
|
||||
if (GST_IS_BIN (element)) {
|
||||
g_signal_connect (element, "element-added", (GCallback) _element_added_cb,
|
||||
scenario);
|
||||
}
|
||||
}
|
||||
|
||||
GstValidateScenario *
|
||||
gst_validate_scenario_factory_create (GstValidateRunner *
|
||||
runner, GstElement * pipeline, const gchar * scenario_name)
|
||||
|
@ -1589,6 +1634,9 @@ gst_validate_scenario_factory_create (GstValidateRunner *
|
|||
gst_validate_reporter_set_name (GST_VALIDATE_REPORTER (scenario),
|
||||
g_strdup (scenario_name));
|
||||
|
||||
g_signal_connect (pipeline, "element-added", (GCallback) _element_added_cb,
|
||||
scenario);
|
||||
|
||||
bus = gst_element_get_bus (pipeline);
|
||||
gst_bus_add_signal_watch (bus);
|
||||
g_signal_connect (bus, "message", (GCallback) message_cb, scenario);
|
||||
|
|
Loading…
Reference in a new issue