Nicolas Dufresne
23e273acb2
v4l2transform: Ensure output pool is configured
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
026f79b5bd
v4l2transform: Check if caps have changes before asserting
...
In set_caps, now checks if caps actually changed and succeed if they didn't
change.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
a89986ebd5
v4l2videodec: Ensure pool is configured
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
83f053e980
v4l2object: Always set a size when deciding allocation
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
acebdd86da
v4l2object: Improved decide allocation
...
Improve decide allocation so it properly configure both local and downstream
buffer pools. Also read back the pool config if it was changed to to driver
limitations.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
cf6c7e9846
v4l2bufferpool: Do not pre-configure the pool
...
Pre-configuring the pool is error prone, since it may hide a configuration failure and
endup with a pool that is not configured the way it should (e.g. no video meta, wrong
queue size, etc.)
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
fa6cd1d25a
v4l2bufferpool: Preserve downstream minimum even in RW
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
7b8bb7188b
v4l2bufferpool: Turn cropmeta into a custom option
...
Turn crop meta into a custom option and make sure it's there is needed.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
db3d2f35f0
v4l2bufferpool: Early catch short allocation
...
Catch short allocation after saving the format. This is not a catch all, but should catch
most of the miss-behaving drivers when doing S_FMT/G_FMT and avoid potential crash.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
2b0ac06ade
v4l2bufferpool: Port to use GstV4l2Allocator
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
fd13e9e96d
Implement V4l2 Allocator
...
This goal of this allocator is mainly to allow tracking the memory.
Currently, when a buffer memory has been modified, the buffer and it's
memory is disposed and lost until the stream is restarted.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
1b4561cf35
v4l2object: Don't advertise crop meta
...
Currently we advertise crop meta, but not element handle support this meta.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
a721e54922
v4l2object: Setup pool already send element error
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
409cccb477
v4l2object: Workaround decoder that set num_planes to 0 in the format
...
Some well known decoder wrongly set num_planes to 0 in their format instead of
one. In this case we would endup with no size when deciding buffer allocation.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
46ffef798c
v4l2object: Ensure size before configuring the pool
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
5a61fb7f25
v4l2object: Set minimum buffers to 2
...
All the element requires at least two buffers. This is not used for RW mode.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
3393083497
v4l2object: Remove unused MAX_BUFFERS define
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
8f6bd0dbc0
v4l2object: Don't hardcode min/max use default instead
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
f6d425bf0f
v4l2transform: Install PROP_CAPTURE_IO_MODE with right ID
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
1635697f7e
v4l2transform: decide_allocation returns a boolean
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
cf788c9ec7
v4l2videodec: Install PROP_CAPTURE_IO_MODE with right ID
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
527df8b888
v4l2transform: Add propose_allocation
...
This should remove 1 copy between the decoder and the transform.
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
0488984f82
v4l2: Move propose allocation to v4l2object
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
f810196b3e
v4l2transform: Fixup caps query
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
d4c24cc52f
v4l2transform: Setup cropping if needed
2014-05-08 15:56:36 -04:00
Nicolas Dufresne
2676ac9075
v4l2transform: Expose BGRA and ARGB formats
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
10b67e9913
v4l2transform: Ensure output pool is activated
...
That pool may be different then the internal pool.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
91efa79ed9
v4l2transform: Ensure internal buffer pools actication
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
7a4b076099
v4l2transform: Move subinstance subclass init near other init
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
6d5ffe8da2
v4l2transform: Stop stream before closing the devices.
2014-05-08 15:56:35 -04:00
Víctor Manuel Jáquez Leal
4f7ee5c130
v4l2transform: copy metdata
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
b781156625
Implement GstV4l2Transform
...
Implement a v4l2 element that wraps HW video converters.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
0028de808b
v4l2: Probe for CREATE_BUFS in order to correctly set pool min/max
...
In order to correctly set the pool min/max, we need to probe for CREATE_BUFS
ioctl. This can be done as soon as the format has been negotiated using a
count of 0.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
8d6e72a299
v4l2: Move capture eos handling in _process()
...
Now that we might be copying out buffer (e.g. downstream don't support video
meta bug we need it) we need to move the EOS handling inside the process
method.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
49065b1693
v4l2object: Fix support for planar format in 1 v4l2 mplane
...
So far we where only setting saving the first plane stride in the meta. This was
leading to wrong values in GstVideoMeta.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
a6a8c2b5eb
v4l2videodec: Cleanly fail if set_format is never called
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
a8e81bd81e
v4l2: Expose RGB32 formats with and without alpha
...
As soon a the alpha component can be set, we can expose the RGB32 and BGR32
format as ARGB and BGRA as long we can deterministically set the alpha padding
value.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
403909d873
v4l2: Correctly check if video meta is needed
...
Correctly check if video meta is needed. In buffer pool, trust need_video_meta
flag in order to decide if configuration should succeed.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
f70bb08411
v4l2object: Fix tiled stride request
...
Fix stride request for tiled format and improve logging.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
36dfdff84c
v4l2object: Ensure video and crop meta are enabled if needed
...
In certain cases we cannot live without video meta and/or crop meta
being enabled in our internal buffer pool. Ensure this is always the case,
regardless of having support for allocation query.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
e9eba56cd3
v4l2videodec: Ensure internal pool are activated
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
a8024fef04
v4l2videodec: Check that pool where allocated before flushing them
...
Upon error, the pools might not have been allocated yet, hence we should not
try and flush them (even though we still want to make sure the processing thread
is fully stopped).
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
6196026c76
v4l2bufferpool: Enforce activation outside of process
...
Enforce pool being activate from before calling pool process. This should
help catching basic errors in the usage of buffer pool.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
efe68f086f
v4l2object: don't use own pool if downstream don't support video meta
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
2f00119e3b
v4l2bufferpool: Use obj->n_v4l2_planes for correct number of planes
...
Buffer pool was guessing wrongly the number of planes rather
then reading the value from obj->n_v4l2_planes. This was causing
format YU12 (I420) to fail upon check.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
f3ce6fd25b
v4l2object: Fix handling of contiuous vs non-contiguous support
...
The complex mechanic to try and choose the right thing did not work. Instead,
simply probe the non-contiguous format first and then the contiguous one.
This is in fact very low overhead, as there is a relatively small number of
pixel format supported by each devices.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
a7286563ee
v4l2: Add initial support for alignment and cropping
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
70e7868f18
v4l2object: Rename setup_format() method into acquire_format()
...
The setup_format() was confusing since it does not set anything, in fact
it reads the setup from the driver and save it.
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
8cf1c330d5
v4l2object: Move type declaration to the top
2014-05-08 15:56:35 -04:00
Nicolas Dufresne
b4d89b9809
v4l2videodec: Protect NULL pool while going to READY
...
When the pipeline fails early, the pool might be unset before the processing
thread has run once. Add protection against that.
2014-05-08 15:56:35 -04:00