Dave Piché
574cbbf0b5
webrtc: fix log error message in function gst_webrtc_bin_set_local_description
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1511 >
2022-01-13 15:11:35 +00:00
Tim-Philipp Müller
cab0eaed1c
mxfdemux: don't error out if VANC track only contains packets we don't handle
...
If the VANC track does contain packets, but we skip over all packets, just
treat it the same as if there hadn't been any packets at all and send a
GAP event instead of erroring out with "Failed to handle essence element".
We would error out because when we reach the end of the loop without having
found a closed caption packet the flow return variable is still FLOW_ERROR
which is what it has been initialised to.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1518 >
2022-01-13 11:34:37 +00:00
He Junyan
05ee44b62b
codecparsers: h265parser: return invalid profile if len is 0.
...
Though the profiles[0] is inited as GST_H265_PROFILE_INVALID in the
gst_h265_profile_tier_level_get_profile(), the profile detecting may
change its content later. So the return of profiles[0] may not be an
invalid profile even the len is 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1517 >
2022-01-13 05:28:17 +00:00
He Junyan
9eb0f8501f
codecparsers: h265parser: Fix the index incrementation error in append_profile().
...
The current "*idx++" operation just refers the pointer and increment the pointer
itself, not the content of the pointer. This causes that the count of the profiles
is always 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1517 >
2022-01-13 05:28:17 +00:00
Dmitry Osipenko
644969e0ba
kmssink: Support auto-detection of NVIDIA Tegra driver
...
NVIDIA Tegra SoCs have a separate (from GPU) display controller. It's
the primary display device on all Tegra SoCs. Add Tegra to the list
of primary DRM drivers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1514 >
2022-01-13 04:50:55 +00:00
Mark Nauwelaerts
4dece4701d
gst-env: extend PATH to include plugin scanner and generator
2022-01-12 21:27:30 +00:00
Mathieu Duponchelle
d8c8737e71
cccombiner: fix s334-1a scheduling
...
The previous code was mistakenly trying to compute a cc_type out
of the first byte in the byte triplet, whereas it is to be interpreted
as:
> Bit b7 of the LINE value is the field number (0 for field 2; 1 for field 1).
> Bits b6 and b5 are 0. Bits b4-b0 form a 5-bit unsigned integer which
> represents the offset
The same mistake was made when creating padding packets.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1496 >
2022-01-12 14:34:22 +00:00
Mathieu Duponchelle
6861ea8fe1
cccombiner: merge buffers for both fields with caption type s334-1a
...
Other elements such as line21encoder expect both fields to be present
in the same meta, not one meta per field.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1496 >
2022-01-12 14:34:22 +00:00
Bastien Nocera
c63365c80f
gtk: Add "video-aspect-ratio-override" property
...
Allow front-ends to override the pixel aspect ratio found inside the
video file itself, or most likely, missing from the video file.
This is a long-standing feature of totem.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Bastien Nocera
522be6cf7c
gtk: Remove _update_par() forward declaration
...
No functional changes.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137/diffs#note_1102782
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Bastien Nocera
6f677a8993
gtk: Mark properties as changeable in the PLAYING state
...
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137#note_1102789
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Bastien Nocera
5dfe92a579
gtk: Fix "pixel-aspect-ratio" property range
...
Fix the arguments passed to gst_param_spec_fraction in the incorrect
order.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Bastien Nocera
488d29eb41
gtk: Rename display pixel aspect ratio related constants
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Bastien Nocera
17130de754
gtk: Make "pixel-aspect-ratio" changes immediate
...
Schedule a resize when the display's pixel aspect ratio has changed, if
one isn't already scheduled.
Closes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/883
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1137 >
2022-01-12 13:27:31 +00:00
Jordan Petridis
86a62d94ed
gstglutils: introspection annotations fixups
...
* gst_gl_ensure_element_data: specify the type for the element arg
* gst_gl_handle_set_context: correctly annotate the display and
gl_ctx as just (out) instead of (inout)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1501 >
2022-01-12 12:11:47 +00:00
Mengkejiergeli Ba
5905955cc3
av1parser: Fix data type of film grain param
...
Fix cb_offset and cr_offset data type from guint8 to guint16. According
to spec, cb_offset and cr_offset are 9 bit long, while guint8 can cause
interger overflow, and thus change to guint16.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1508 >
2022-01-12 11:03:17 +00:00
Sebastian Dröge
79ce12416f
codec-utils: Use nullable annotation instead of allow-none for various Opus functions
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Sebastian Dröge
e667c95674
codec-utils: Annotate out parameters for Opus functions as (optional)
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Sebastian Dröge
6de587593a
codec-utils: Add missing annotations to gst_codec_utils_h264_get_profile_flags_level()
...
And fix some minor typos.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Mathieu Duponchelle
61eeb866b0
validate: loggable: fix Callable import
...
Since 3.3 importing Callable from collections is deprecated,
it should be imported from collections.abc .
Since 3.10 the alias has been removed altogether.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1504 >
2022-01-11 16:39:56 +00:00
Nirbheek Chauhan
1be6d6ccf5
meson: Add explicit check: kwarg to all run_command() calls
...
This is required since Meson 0.61.0, and causes a warning to be
emitted otherwise:
2c079d855e
https://github.com/mesonbuild/meson/issues/9300
This exposed a bunch of places where we had broken run_command()
calls, unnecessary run_command() calls, and places where check: true
should be used.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1507 >
2022-01-09 18:12:47 +05:30
Nirbheek Chauhan
945fd11907
audio: Add logging that was useful in figuring out the last commit
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1461 >
2022-01-08 05:15:30 +00:00
Nirbheek Chauhan
554a2a5145
audio-converter: Fix resampling when there's nothing to output
...
Sometimes we can't output anything because we don't have enough
incoming frames. In that case, the resampler was trying to call
do_quantize() and do_resample() in a loop forever because there would
never be samples to output (so chain->samples would always be NULL).
Fix this by not calling chain->make_func() in a loop -- seems
completely unnecessary since calling it over and over won't change
anything if the make_func() can't output samples.
Also add some checks for the input and / or output being NULL when
doing conversion or quantization. This will happen when we have
nothing to output.
We can't bail early, because we need resampler->samples_avail to be
updated in gst_audio_resampler_resample(), so we must call that and
no-op everything along the way.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1461 >
2022-01-08 05:15:30 +00:00
Stéphane Cerveau
51e93408a9
alphacombine: update example launch line
...
Fix typos and missing videoconvert element to demonstrate
the alphacombine element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1494 >
2022-01-06 14:59:02 +00:00
He Junyan
428a9a6c01
vaapi: av1dec: Use named profiles to replace the numeric ones.
...
Use named AV1 profiles (i.e., main, high) to replace the old "0"
and "1" profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1491 >
2022-01-05 09:20:02 +00:00
He Junyan
d334c08b55
av1parse: Set the "tu" as the default alignment.
...
The tu(temporal unit) is more widely used than the current alignment.
We now change the default alignment to tu.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468 >
2022-01-05 08:47:06 +00:00
He Junyan
cfd69b0467
av1parse: Fix the wrong DELTA_UNIT flag setting for key frames.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468 >
2022-01-05 08:47:06 +00:00
He Junyan
2266f70d79
av1parse: Copy the PTS and DURATION when we create data.
...
We need to create header buffers for annex b format. This kind of
buffers should inherit the PTS and DURATION from the original buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1468 >
2022-01-05 08:47:06 +00:00
Nirbheek Chauhan
6b7d819c25
vtenc: Signal ignored alpha component with ProRes
...
When the image is opaque but the output ProRes format has an alpha
component (4 component, 32 bits per pixel), Apple requires that we
signal that it should be ignored by setting the depth to 24 bits per
pixel. Not doing so causes the encoded files to fail validation.
So we set that in the caps and qtmux sets the depth value in the
container, which will be read by demuxers so that decoders can skip
those bytes entirely. qtdemux does this, but vtdec does not use this
information at present.
The sister change was made in qtmux and qtdemux in:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1061
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1489 >
2022-01-04 18:01:54 +00:00
He Junyan
e1f9c6d559
codecparsers: h265parser: Correct the read of slice_sao_chroma_flag.
...
According to the SPEC, for parsing the slice header, we should read the
slice_sao_chroma_flag only when ChromaArrayType is not equal to 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1488 >
2022-01-04 09:53:25 +08:00
Thibault Saunier
ccf64e369e
meson: Allow using GStreamer plugins from custom_subprojects
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1490 >
2022-01-03 16:27:04 -03:00
Jordan Petridis
b0370cdf00
ci: replace license notice
...
This file was copied from microsoft documentation [1]
and its header was refering to the license on that repo.
This change was lost during gstreamer/gstreamer!1000
[1] 9ec230dfd4/LICENSE-CODE
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1487 >
2022-01-03 12:43:15 +02:00
Rafał Dzięgiel
8889b6351d
assrender: Support RFC8081 mime types
...
Old "application/*" are now as per RFC8081 deprecated in favor of
new "font/*" mime types. Some new encoders are already using the
updated mime types. We need to also add them to the support list
in order for assrender to correctly identify them as fonts.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1481 >
2022-01-03 06:42:23 +00:00
Rafał Dzięgiel
a2719d79ff
assrender: Handle ".ttc" attachment extension
...
TTC stands for "TrueType Collection" file. We can pass it
into libass as any other attachment. Add it to the supported
extensions list, so the fonts it contains will be used.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1481 >
2022-01-03 06:42:23 +00:00
Philippe Normand
f0e6959bba
webrtcdatachannel: Notify buffered-amount property updates
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1484 >
2022-01-02 10:18:35 +00:00
Heinrich Kruger
6dd15acf2d
rtp-hdrext-colorspace: Fix color range encoding
...
The color space RTP header extension encodes color range as specified in
https://www.webmproject.org/docs/container/#Range . In other words:
0: Unspecified,
1: Broadcast Range,
2: Full range,
3: Defined by matrix coefficients and transfer characteristic.
This does not match the values of GstVideoColorRange, so it is not
correct to just write the colorimetry.range value to the header
extension.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1482 >
2021-12-30 16:31:33 +00:00
Seungha Yang
5fefc689a0
d3d11decoder: Negotiate again on the first output buffer
...
... unconditionally. There may be updated field in sinkpad caps
after the new_sequence() call (HDR related ones for example),
then we should signal the information to downstream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1474 >
2021-12-30 11:09:45 +00:00
Philippe Normand
43856a0735
webrtcstats: Fix null pointer dereference
...
If there is no jitterbuffer stats we should not attempt to store them in the
global stats structure.
Also add a g_return_if_fail in _gst_structure_take_structure() about this
because it is a programmer error to pass an invalid pointer address there.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1479 >
2021-12-29 15:55:57 +00:00
He Junyan
13f0128f7e
codecparsers: av1parse: Add the DECODE_ONLY flag to output buffer.
...
When the alignment is ALIGN_FRAME and the output buf contains a frame
which is not to be shown, the GST_BUFFER_FLAG_DECODE_ONLY flag should
be set.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1050 >
2021-12-25 12:18:24 +00:00
Jeongki Kim
04f6fbc237
rtpg726depay: fix endian conversion
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1469 >
2021-12-24 14:52:38 +09:00
Olivier Crête
818a185b5d
webrtcstats: Fall back to last packet ssrc if caps dont provide it
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
4e32d6bf3e
webrtcstats: Use our own caps instead of the sticky event
...
The sticky event seems to get cleared sometimes.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
29befed685
webrtcbin: Store the ssrc of the last received packet
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
fc7e7f5ccc
webrtc stats: Remove duplicate structure get
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
f35435f1f7
webrtc stats: Add more details about codecs into the stats
...
This makes the output a little closer to what the upstream stats are.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Corentin Damman
31f4444724
rtpjitterbuffer: fix typo in tests
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1466 >
2021-12-23 14:31:27 +00:00
Brad Hards
d4379c8df7
doc: typo fix for streaming
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1463 >
2021-12-23 07:50:22 +00:00
Tim-Philipp Müller
2452f0bbcf
docs: interlaced video: small additions for alternate interlacing
...
Clarify that width/height in caps is still the frame height/width,
not field height width, just like framerate is frame rate not
field rate.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1465 >
2021-12-23 01:52:04 +00:00
He Junyan
85d2118a53
va: av1dec: Use named profiles to replace the numeric ones.
...
Use named AV1 profiles (i.e., main, high, and professional) to replace
the old 0, 1, 2 profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:34 +09:00
Seungha Yang
796007f75d
av1enc: Update for newly designed AV1 profile signalling
...
Accept named AV1 profiles (i.e., main, high, and professional)
as well
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:34 +09:00