Stéphane Cerveau
152b878a8b
gst-examples: add -xobjective-c for darwin
...
To avoid error when including #include <AppKit/AppKit.h>
the build should include the c args xobjective-c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2116 >
2022-04-05 11:40:01 +01:00
Stéphane Cerveau
39b6e6816b
bad: examples: fix unused res warning
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2116 >
2022-04-05 11:39:02 +01:00
Zhao Zhili
28091342da
examples: fix build on macOS with gtk+-quartz-3.0
...
gdk_quartz_window_get_nsview is not declared in the header file now:
error: implicit declaration of function 'gdk_quartz_window_get_nsview'
is invalid in C99 [-Werror,-Wimplicit-function-declaration]
fixes #979
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2116 >
2022-04-05 11:38:53 +01:00
Tong Wu
05ee80f104
msdk: use mfxU32 instead of uint32_t
...
Msdk should use mfx variables defined in mfxdefs.h. Replace uint32_t
with mfxU32.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2113 >
2022-04-04 22:57:04 +01:00
Tim-Philipp Müller
fa74785d27
ci: Don't check indentation on post merge pipelines
...
We're probably safe to assume that it hasn't changed
since the MR pipeline last checked it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2106 >
2022-04-02 00:47:22 +00:00
Tim-Philipp Müller
54fb9ee553
ci: stop automatically running tests post-merge
...
We did that in order to find flaky tests so we could add
them to our ignore lists, but that's all done now and I
doubt anyone still looks at the results, so this is just
wasting runner cycles at this point.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2106 >
2022-04-02 00:47:22 +00:00
Sebastian Dröge
b2fe6ac3e8
playbin/playbin3: Allow setting a NULL URI
...
The URI is already initialized to NULL at the beginning and GstPlayer
was assuming that it is possible to set to NULL at a later time too.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1124
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2105 >
2022-04-02 01:12:55 +01:00
Chun-wei Fan
ffea6475d4
openexr: Specify modules when finding OpenEXR.
...
Specify modules to look for OpenEXR when CMake is used, as we may have
CMake config files instead of pkg-config files that result from building
OpenEXR, which may be built with CMake which is typically the case on Visual
Studio builds.
In this case, Meson does seem to find the 'OpenEXR' package with CMake
after trying pkg-config, but does not consider it enough without the
'modules:' argument.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2035 >
2022-03-31 16:04:27 +00:00
Daniel Stone
71f524be33
ci: Don't tie up a full job slot for cerbero trigger
...
We don't have a huge amount of capacity on shared runners, so better if
we don't use that limited capacity on a job which sits there doing
~nothing.
There is a new runner class called 'placeholder-job' which accepts a
huge number of parallel jobs, separately to normal jobs, on the
assumption that they will consume ~no resources; start using that.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2083 >
2022-03-31 16:13:48 +01:00
Nirbheek Chauhan
69936ad852
meson: Add some messages when selecting libsoup
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2082 >
2022-03-31 15:32:17 +01:00
Nirbheek Chauhan
45ce19dd2d
soup: Fix usage of symbols / defines that are gone in libsoup3
...
I am not sure about the SOUP_MESSAGE_OVERWRITE_CHUNKS change, but it
was definitely already broken when using libsoup-3.0 in a shared
build. souphttpsrc probably needs to be ported from SoupMessage to
SoupServerMessage when using libsoup-3.0.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2082 >
2022-03-31 15:32:17 +01:00
Nirbheek Chauhan
2813e30392
soup: Fix pre-processor macros in souploader for libsoup-3.0
...
Some of the preprocessor conditionals in the loader were very broken
with libsoup-3.0 + --default-library=static
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1111
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2082 >
2022-03-31 15:32:17 +01:00
Edward Hervey
0425d60190
pbutils: Fix wmv screen detection
...
strncmp vs !strncmp :)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2076 >
2022-03-30 23:24:55 +01:00
Edward Hervey
530272850d
avviddec: Remove vc1/wmv3 override
...
FFMPEG 5+ doesn't allow overriding the codec anymore (causes a segfault if you
attempt to do that). But the best part is ... that with the current caps
implementation in pad template and gst_ffmpeg_caps_to_codecid() we would never
replace it by anything different than the existing codec id.
Fixes #1054
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2074 >
2022-03-30 17:36:06 +01:00
Matthew Waters
c7351622ee
validate/media-info: silence unsed variable warning
...
Fixes:
../validate/gst/validate/gst-validate-media-info.c:714:28: error: variable 'total_sink_count' set but not used [-Werror,-Wunused-but-set-variable]
guint id, ncounters = 0, total_sink_count = 0;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
6a4089795d
rtsp-stream: remove unused variable:
...
Fixes:
../gst/rtsp-server/rtsp-stream.c:2670:9: error: variable 'n_messages' set but not used [-Werror,-Wunused-but-set-variable]
guint n_messages = 0;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
9f1becb19f
applemeida/texturecache: remove unused variable
...
Fixes:
../sys/applemedia/videotexturecache.m:71:20: error: variable 'features' set but not used [-Werror,-Wunused-but-set-variable]
GstCapsFeatures *features;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
91eb442389
applemedia/corevideobuffer: remove unused variable
...
Fixes:
../sys/applemedia/corevideobuffer.c:209:19: error: variable 'video_meta' set but not used [-Werror,-Wunused-but-set-variable]
GstVideoMeta *video_meta;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
ba8c6baae4
applemedia/iosgl: remove unused variable
...
Fixes:
../sys/applemedia/iosurfaceglmemory.c:219:41: error: variable 'texfmt' set but not used [-Werror,-Wunused-but-set-variable]
GLuint tex_id, tex_target, texifmt, texfmt;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
c546392caf
vtdec: remove unused variable
...
Fixes:
../sys/applemedia/vtdec.c:611:35: error: variable 'output_flags' set but not used [-Werror,-Wunused-but-set-variable]
VTDecodeFrameFlags input_flags, output_flags;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
293a41ea76
avsamplevideosink: remove unused variable
...
Fixes
../sys/applemedia/avsamplevideosink.m:80:20: error: variable 'gstelement_class' set but not used [-Werror,-Wunused-but-set-variable]
GstElementClass *gstelement_class;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
214a912232
avfassetsrc: fix unused-but-set warning
...
../sys/applemedia/avfassetsrc.m:1014:12: error: variable 'caps' set but not used [-Werror,-Wunused-but-set-variable]
GstCaps *caps;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
c7cea7651d
speed: fix unused-but-set warning
...
../gst/speed/gstspeed.c:523:39: error: variable 'base' set but not used [-Werror,-Wunused-but-set-variable]
gint64 start_value, stop_value, base;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
7d015ea03c
resindvd: silence unused-but-set warning
...
../ext/resindvd/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
guint16 STD_buffer_size_bound;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
85077bcfa7
mpegts: don't shadow res variable
...
Fixes unused-but-set warning:
../gst/mpegtsmux/gstbasetsmux.c:2115:43: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
gboolean all_headers, done = FALSE, res = FALSE;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
7eecee4aba
mpeg: fix unused-but-set warning
...
../gst-libs/gst/mpegts/gst-dvb-section.c:206:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
guint i = 0, allocated_events = 12;
^
../gst-libs/gst/mpegts/gst-dvb-section.c:365:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
guint i = 0, allocated_streams = 12;
^
../gst-libs/gst/mpegts/gst-dvb-section.c:543:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
guint i = 0, allocated_streams = 12;
^
../gst-libs/gst/mpegts/gst-dvb-section.c:885:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
guint i = 0, allocated_services = 8;
^
../gst-libs/gst/mpegts/gst-dvb-section.c:1316:9: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
guint i = 0, allocated_services = 8;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
1b1158feb2
osxcoreaudio: fix unused-but-set warning
...
../sys/osxaudio/gstosxcoreaudio.c:480:18: error: variable 'interleaved' set but not used [-Werror,-Wunused-but-set-variable]
gboolean sign, interleaved;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2068 >
2022-03-30 00:52:53 +01:00
Matthew Waters
8f78986e87
mpegdemux: silence unused-but-set werror
...
../gst/mpegdemux/gstpesfilter.c:117:11: error: variable 'STD_buffer_size_bound' set but not used [-Werror,-Wunused-but-set-variable]
guint16 STD_buffer_size_bound;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2067 >
2022-03-30 00:05:22 +01:00
Matthew Waters
ec666df016
examples/player/android: add missing dummy.cpp
...
allows libc++_shared.so to be placed in the application
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2065 >
2022-03-29 19:35:29 +01:00
Matthew Waters
b0628713de
deinterlace: silence unused-but-set werror from imported code
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2062 >
2022-03-29 18:31:57 +01:00
Matthew Waters
641897ea70
examples/player/android: update for android changes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2059 >
2022-03-29 15:19:18 +01:00
Matthew Waters
a9284b4351
osxvideosink: fix unused-but-set-variable warning
...
../sys/osxvideo/osxvideosink.m:859:11: error: variable 'data' set but not used [-Werror,-Wunused-but-set-variable]
guint8 *data, *readp, *writep;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2055 >
2022-03-29 13:27:51 +01:00
Corentin Damman
4630096440
rawvideoparse: set format from caps in gst_raw_video_parse_set_config_from_caps
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2054 >
2022-03-29 11:25:07 +01:00
Matthew Waters
24c456fbe2
glmixerbin: slightly better pad/element creation
...
Use the return value from gst_element_link_pads() and gst_bin_add()
Fixes:
../ext/gl/gstglmixerbin.c:305:12: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
gboolean res = TRUE;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2053 >
2022-03-29 10:31:45 +01:00
Sangchul Lee
1ba785b070
webrtcbin: Update documentation of 'get-stats' action signal
...
Some stats fields are updated according to the current implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2034 >
2022-03-26 02:13:08 +00:00
Matthew Waters
c41d29c902
rtpptdemux: fix leak of caps when ignoring a pt
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2033 >
2022-03-26 01:18:03 +00:00
Thibault Saunier
31248b1cb8
Fix license as GES is released under the LGPL2+ license
...
This was a mistake that some of the licensing notice in a few files was
referring to GPL3+ and it needs fixing
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2015 >
2022-03-24 10:37:52 +01:00
Nirbheek Chauhan
4163c1bd0b
webrtc_sendrecv.py: Link pads instead of elements
...
This was not a problem here because even if we end up accidentally
linking to the wrong pad, things will work out eventually as long as
one pad-added is emitted for each pad that is added.
But it will be a huge problem if someone copies this code and changes
something that requires different handling for different sorts of
pads. The resultant code will be racy. Let's not do this, it's a bad
example.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2013 >
2022-03-24 00:46:42 +01:00
Stéphane Cerveau
5e89be5c84
wavparse: handle query in any parse state
...
In order to create the stream_id, we need to
pass the query to the default query handler.
If the parse state is different from GST_WAVPARSE_DATA
the query should be passed to the default query
handler.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2011 >
2022-03-23 15:00:13 +01:00
Benjamin Gaignard
3583a69a04
v4l2codecs: Fix memory leak
...
Free pending_requests array when releasing decoder to avoid memory leak
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2002 >
2022-03-21 22:07:03 +01:00
Nirbheek Chauhan
3f1f1700bc
webrtcbin: Warn when offer didn't intersect with transceiver caps
...
We were silently falling back to creating a recvonly offer if the caps
didn't intersect.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:15 +00:00
Nirbheek Chauhan
3bc84aa7d5
webrtc-sendrecv: Fix create-answer caps negotiation
...
We need to parse the payload type map provided by the offer SDP and
set those values on the payloader, otherwise webrtcbin will create
a recvonly answer SDP and we won't send anything to the browser.
Fixed it for both C and Python sendrecv examples.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:15 +00:00
Nirbheek Chauhan
c786551322
webrtc_sendrecv.py: Add picture-id-mode to rtpvp8pay
...
This doesn't just make TWCC stats perform better, it also fixes
stuttery video playback in Chrome.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:15 +00:00
Nirbheek Chauhan
1fce36d033
webrtc_sendrecv.py: Print an error on unknown JSON message
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Nirbheek Chauhan
ad0484245d
webrtc_sendrecv.py: Add missing copyright headers
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Nirbheek Chauhan
c814409ac1
webrtc_sendrecv.py: Implement all negotiation modes
...
Earlier, the example only supported one negotiation mode:
* Browser client is running, gstreamer starts a call and sends offer
Now these three modes are also supported:
* Browser client is running, gstreamer starts a call and sends an
offer request
* gstreamer connects and waits for browser client to start a call and
send an offer
* gstreamer connects and waits for browser client to start a call and
send an offer request
The following features are still missing:
* Data channel support
* TWCC support + stats logging
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Nirbheek Chauhan
646a570dcb
webrtc_sendrecv.py: Make it executable
...
Why wasn't it already. Tired of typing 'python webrtc_sendrecv.py'.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Nirbheek Chauhan
368d52dfbd
webrtc_sendrecv.py: Fix event loop usage for messages
...
Instead of creating a new loop, we should just be fetching the running
loop, then doing a blocking network call inside the callback, schedule
it on the event loop. This is what the C example does too.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Nirbheek Chauhan
b999257f67
webrtc_sendrecv.py: Use default arg for server URL
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995 >
2022-03-20 22:38:14 +00:00
Matthew Waters
e987b6e82a
discoverer: chain up to parent finalize methods in all our types
...
Fixes a memory leak:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x5ac5cd in malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3
#1 0x1007007 in g_malloc /work/glib-2.72.0/_builddir/../glib/gmem.c:125:13
#2 0xf82e82 in g_data_set_internal /work/glib-2.72.0/_builddir/../glib/gdataset.c:464:8
#3 0xf833f7 in g_datalist_id_set_data_full /work/glib-2.72.0/_builddir/../glib/gdataset.c:670:3
#4 0xef81be in g_object_notify_queue_freeze /work/glib-2.72.0/_builddir/../gobject/gobject.c:295:7
#5 0xef79c6 in g_object_unref /work/glib-2.72.0/_builddir/../gobject/gobject.c:3632:16
#6 0x5e58bf in LLVMFuzzerTestOneInput /src/gstreamer/ci/fuzzing/gst-discoverer.c:132:5
#7 0x4dd1a2 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
#8 0x4dc98a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:514:3
#9 0x4de6c4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:809:5
#10 0x4dea29 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3
#11 0x4ce4a0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
#12 0x4f6f52 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#13 0x7f1c709980b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1996 >
2022-03-19 11:52:53 +00:00