webrtcbin: Warn when offer didn't intersect with transceiver caps

We were silently falling back to creating a recvonly offer if the caps
didn't intersect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1995>
This commit is contained in:
Nirbheek Chauhan 2022-03-15 17:01:59 +05:30 committed by GStreamer Marge Bot
parent 3bc84aa7d5
commit 3f1f1700bc

View file

@ -4025,7 +4025,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options,
goto rejected;
}
GST_TRACE_OBJECT (webrtc, "trying to compare %" GST_PTR_FORMAT
GST_LOG_OBJECT (webrtc, "trying to compare %" GST_PTR_FORMAT
" and %" GST_PTR_FORMAT, offer_caps, trans_caps);
/* FIXME: technically this is a little overreaching as some fields we
@ -4056,6 +4056,8 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options,
/* if no transceiver, then we only receive that stream and respond with
* the intersection with the transceivers codec preferences caps */
answer_dir = GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_RECVONLY;
GST_WARNING_OBJECT (webrtc, "did not find compatible transceiver for "
"offer caps %" GST_PTR_FORMAT ", will only receive", offer_caps);
}
if (!rtp_trans) {