Commit graph

66 commits

Author SHA1 Message Date
Luis de Bethencourt
c884a3b3a5 equalizer: fix dynamic changes on bands
When we are in passthrough, the transform function doesn't run and if the
passthrough check is in this function it will never be deactivated. Fix this by
checking directly whenever a gain is changed.

Also set the passthrough to TRUE at init because the gains default to 0, so we
can passthrough until any gain property is changed.

https://bugzilla.gnome.org/show_bug.cgi?id=748068
2015-04-22 10:38:39 +01:00
David Sansome
8154c90c9b equalizer: Don't call iirequalizer's transform_ip in passthrough mode
It tries to map the read-only buffer with GST_MAP_READWRITE and crashes.

https://bugzilla.gnome.org/show_bug.cgi?id=737886
2014-10-13 08:30:03 +02:00
Tim-Philipp Müller
230cf41cc9 Fix FSF address
https://bugzilla.gnome.org/show_bug.cgi?id=687520
2012-11-04 00:07:18 +00:00
Stefan Sauer
1f255a585b equalizer: enable presets for the n-band equalizer
Add a test for saving and restoring the preset.
2012-08-17 15:01:40 +02:00
Stefan Sauer
ea17c457f9 childproxy: update api use 2012-06-11 18:24:20 +02:00
Sebastian Dröge
aa2cd462da gst: Update for GST_PLUGIN_DEFINE() API changes 2012-04-05 17:36:38 +02:00
Wim Taymans
068ee88862 update for child proxy api change 2012-03-31 15:43:49 +02:00
Wim Taymans
82a43ad1ab Merge branch 'master' into 0.11
Conflicts:
	gst/equalizer/gstiirequalizer.c
2012-02-17 23:49:21 +01:00
Tim-Philipp Müller
f76f7374ea equalizer: fix switching from passthrough to non-passthrough when parameters change
commit b5bf0294 moved the if(need_new_coefficients) set_passthrough(equ)
after the if(is_passthrough) return FLOW_OK shortcut, so the passthrough
mode would never get updated even if the coefficients change.

Fixes equalizer-test doing .. nothing.
2012-02-17 18:35:54 +00:00
Wim Taymans
dd26b14930 iirequalizer: fix equalizer and unit test 2012-02-06 15:20:55 +01:00
Wim Taymans
583d39dd8d update for new memory API 2012-01-25 12:30:28 +01:00
Wim Taymans
1584806634 port to new gthread API 2012-01-19 11:33:53 +01:00
Sebastian Dröge
93e3ed5a86 Merge branch 'master' into 0.11
Conflicts:
	ext/cairo/gsttextoverlay.c
	ext/pulse/pulseaudiosink.c
	gst/audioparsers/gstaacparse.c
	gst/avi/gstavimux.c
	gst/flv/gstflvmux.c
	gst/interleave/interleave.c
	gst/isomp4/gstqtmux.c
	gst/matroska/matroska-demux.c
	gst/matroska/matroska-mux.c
	gst/matroska/matroska-mux.h
	gst/matroska/matroska-read-common.c
	gst/multifile/gstmultifilesink.c
	gst/multipart/multipartmux.c
	gst/shapewipe/gstshapewipe.c
	gst/smpte/gstsmpte.c
	gst/udp/gstmultiudpsink.c
	gst/videobox/gstvideobox.c
	gst/videocrop/gstaspectratiocrop.c
	gst/videomixer/videomixer.c
	gst/videomixer/videomixer2.c
	gst/wavparse/gstwavparse.c
	po/ja.po
	po/lv.po
	po/sr.po
	tests/check/Makefile.am
	tests/check/elements/qtmux.c
	tests/check/elements/rgvolume.c
2012-01-10 14:32:32 +01:00
Sebastian Dröge
80dcefc702 equalizer: Update for the new raw audio layout field 2012-01-05 10:30:32 +01:00
Tim-Philipp Müller
66f6e12888 Work around deprecated thread API in glib master
Add private replacements for deprecated functions such as
g_mutex_new(), g_mutex_free(), g_cond_new() etc., mostly
to avoid the deprecation warnings. We'll change these
over to the new API once we depend on glib >= 2.32.
2011-12-12 09:46:27 +00:00
Tim-Philipp Müller
dc540c23da Merge remote-tracking branch 'origin/master' into 0.11
Conflicts:
	gst/equalizer/gstiirequalizer.c
2011-11-27 23:31:43 +00:00
Stefan Sauer
b5bf029401 equalizer: also sync the parameters for the filter bands 2011-11-26 21:40:22 +01:00
Stefan Sauer
9ce6c731c3 various: add missing includes 2011-11-10 23:09:23 +02:00
Stefan Sauer
fb162c8eb4 controller: port to new controller location and api 2011-11-04 20:15:48 +01:00
Wim Taymans
4b6a226263 Merge branch 'master' into 0.11
Conflicts:
	ext/pulse/pulseaudiosink.c
	ext/pulse/pulsesink.c
2011-10-27 16:08:22 +02:00
René Stadler
6082f27d48 equalizer: remove avoidable call to gst_object_set_name 2011-10-21 22:33:34 +02:00
Wim Taymans
445bf71bd1 port to more audio api changes 2011-08-19 16:09:48 +02:00
Wim Taymans
77ad0a1363 port more elements to new audio caps and API 2011-08-19 14:01:45 +02:00
Mark Nauwelaerts
d9ba4b7616 equalizer: port to 0.11 2011-06-30 10:30:16 +02:00
David Schleef
7b8981766b Change M_PI to G_PI 2010-12-30 14:20:52 -08:00
Benjamin Otte
1055aaa9cb Add -Wredundant-decls warning flag
Also fix compile issues
2010-03-17 19:35:10 +01:00
Tim-Philipp Müller
4b1566d7f3 equalizer: printf format fix 2009-11-05 23:40:15 +00:00
Sebastian Dröge
fb682d0444 equalizer: Notify about band property changes caused by changing number of bands 2009-11-05 10:54:12 +01:00
Sebastian Dröge
64e00f172c equalizer: Make changes to band properties and the number of bands threadsafe 2009-11-05 10:45:59 +01:00
Sebastian Dröge
025e26f73a equalizer: Fix stupid off by two bug 2009-11-05 10:30:46 +01:00
Sebastian Dröge
9405a328b1 equalizer: Add band property to select the band filter type
This allows per band configuration of a peak, low shelf or
high shelf filter, which can be very useful if the band frequencies
and widths are manually configured.
2009-11-05 08:21:33 +01:00
Sebastian Dröge
0525abd4af equalizer: Fix code style 2009-11-05 08:21:33 +01:00
Sebastian Dröge
e1acc8f4da equalizer: Some cleanup 2009-11-05 08:21:33 +01:00
Stefan Kost
27ea0b076a equalizer: use shelfing filters for first and last band
Refactor the filter setup. Add two new filters with shelf characteristics for
first and last band. Change gain calculation as recommended in the quoted
document (no qrt needed). Rename variables to match the formulas in the
document.
2009-10-07 00:35:27 +03:00
Stefan Kost
7b6e594b69 equalizer: fix filter history usage. Fixes #597397
The process functions where overwriting the history for each channel. Also pull
some static things out of the inner loop.
2009-10-05 23:04:39 +03:00
Ghislain 'Aus' Lacroix
9507cdc84c equalizer: Use floating point arithmetic internally for the int16 mode
By using int32 arithmetic we will introduce distortions as the
IIR filter is very sensitive to rounding errors. Fixes bug #580214.
2009-05-28 12:39:46 +02:00
Stefan Kost
7de49319d7 equalizer: Don't reset frequency bands from user settings. Fixes #570343.
Move reallocating the history buffer out of _compute_frequencies() and call the
right function as needed. Add some logging and tweak the formatting of existing
logging. Simplify setting need_new_coefficients when changing properties.
2009-02-03 14:16:40 +02:00
Sebastian Dröge
3ca3d1de2b gst/equalizer/gstiirequalizer.c: Don't calculate the filter coefficients for every single buffer but only when it's n...
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c: (update_coefficients):
Don't calculate the filter coefficients for every single buffer
but only when it's needed. Fixes bug #557260.
2008-10-27 08:30:51 +00:00
Sebastian Dröge
f6ef43bbd7 gst/equalizer/gstiirequalizer.c: Don't clip float/double samples, correctly unset passthrough mode and use better rou...
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_transform_ip):
Don't clip float/double samples, correctly unset passthrough mode
and use better rounding for integer samples.
2008-05-31 08:37:00 +00:00
Sebastian Dröge
c17d49ee20 gst/equalizer/gstiirequalizer.*: Update the filter coefficients only when needed in the transform_ip function and cor...
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_set_property), (gst_iir_equalizer_init),
(setup_filter), (set_passthrough), (update_coefficients),
(gst_iir_equalizer_compute_frequencies),
(gst_iir_equalizer_transform_ip):
* gst/equalizer/gstiirequalizer.h:
Update the filter coefficients only when needed in the transform_ip
function and correctly set the element into passthrough mode if the
gain of all bands is 0.
2008-05-30 11:03:57 +00:00
Sebastian Dröge
3d3f7cd6da gst/equalizer/gstiirequalizer.c: Use a bigger type in integer mode for the intermediate results to prevent overflows....
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
Use a bigger type in integer mode for the intermediate results to
prevent overflows. This fixes the crippled sound when using the
equalizer in integer mode. Fixes bug #510865.
2008-05-20 10:47:10 +00:00
Sebastian Dröge
6fcf22d5a3 gst/equalizer/gstiirequalizer.c: Unparent all bands from the equalizer when finalizing to stop leaking them.
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c: (gst_iir_equalizer_finalize):
Unparent all bands from the equalizer when finalizing to stop
leaking	them.
2008-01-18 07:03:23 +00:00
Sebastian Dröge
ee1f115ef9 gst/equalizer/gstiirequalizer.c: Fix compilation.
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_transform_ip):
Fix compilation.
2007-12-06 12:45:50 +00:00
Sebastian Dröge
e59f930d9a gst/equalizer/gstiirequalizer.c: Don't process buffers in passthrough mode.
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_transform_ip):
Don't process buffers in passthrough mode.
2007-12-06 12:42:11 +00:00
Sebastian Dröge
6edf8c4326 gst/equalizer/: Allow setting 0 as bandwidth and handle this correctly.
Original commit message from CVS:
* gst/equalizer/demo.c: (main):
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_class_init), (setup_filter):
Allow setting 0 as bandwidth and handle this correctly.
Also handle a bandwidth of rate/2 properly.
* gst/equalizer/gstiirequalizernbands.c:
(gst_iir_equalizer_nbands_class_init):
Make it possible to generate a N-band equalizer with 1 bands. The
previous limit of 2 was caused by a nowadays replaced calculation
doing a division by zero if number of bands was 1.
2007-11-03 19:50:11 +00:00
Sebastian Dröge
ceb068d0e9 gst/equalizer/: Add small demo application based on the spectrum demo applications that gets white noise as input, pu...
Original commit message from CVS:
* gst/equalizer/Makefile.am:
* gst/equalizer/demo.c: (on_window_destroy), (on_configure_event),
(on_gain_changed), (on_bandwidth_changed), (on_freq_changed),
(draw_spectrum), (message_handler), (main):
Add small demo application based on the spectrum demo applications
that gets white noise as input, pushes it through an equalizer and
paints the spectrum. For every equalizer band it's possible to set
gain, bandwidth and frequency.
* gst/equalizer/gstiirequalizer.c: (setup_filter):
Add some guarding against too large or too small frequencies and
bandwidths. Also improve debugging a bit.
2007-10-30 21:37:49 +00:00
Sebastian Dröge
7c8653f596 gst/equalizer/gstiirequalizer.c: Replace filters with a bit better filters for which we can actually find documentati...
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_set_property),
(gst_iir_equalizer_band_get_property),
(gst_iir_equalizer_band_class_init), (arg_to_scale),
(setup_filter), (gst_iir_equalizer_compute_frequencies):
Replace filters with a bit better filters for which we can actually
find documentation, which don't change anything on zero gain, etc.
Make the frequency property of the bands writable, rename the
band-width property to bandwidth and change the	meaning to the
frequency difference between bandedges, change the meaning of the
gain property to dB instead of a weird scale between -1	and 1 that
has no real meaning.
2007-10-30 21:18:45 +00:00
Sebastian Dröge
5001ce6baa gst/equalizer/gstiirequalizer.c: Add a missing break.
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_set_property):
Add a missing break.
2007-10-18 06:20:21 +00:00
Sebastian Dröge
2204bb6549 gst/equalizer/gstiirequalizer.*: Move bandwidth property to the separate bands and add float64 support.
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_set_property),
(gst_iir_equalizer_band_get_property),
(gst_iir_equalizer_band_class_init), (gst_iir_equalizer_band_init),
(gst_iir_equalizer_band_get_type), (gst_iir_equalizer_class_init),
(setup_filter), (gst_iir_equalizer_setup):
* gst/equalizer/gstiirequalizer.h:
Move bandwidth property to the separate bands and add float64 support.
2007-10-18 06:14:42 +00:00
Stefan Kost
08821314b4 gst/equalizer/: Better algorith for the center frequencies. Subtract band filters from input for negative gains. Rewo...
Original commit message from CVS:
* gst/equalizer/gstiirequalizer.c:
(gst_iir_equalizer_band_set_property),
(gst_iir_equalizer_child_proxy_get_child_by_index),
(gst_iir_equalizer_child_proxy_get_children_count),
(gst_iir_equalizer_child_proxy_interface_init),
(gst_iir_equalizer_class_init), (arg_to_scale), (setup_filter),
(gst_iir_equalizer_compute_frequencies):
* gst/equalizer/gstiirequalizer10bands.c:
(gst_iir_equalizer_10bands_class_init):
* gst/equalizer/gstiirequalizer3bands.c:
(gst_iir_equalizer_3bands_class_init):
* gst/equalizer/gstiirequalizernbands.c:
Better algorith for the center frequencies. Subtract band filters from
input for negative gains. Rework the gain mapping.
2007-07-20 11:37:37 +00:00