Commit graph

190 commits

Author SHA1 Message Date
Sebastian Dröge
ae6616ad0d omxvideoenc: Minor code refactoring 2011-11-08 08:31:43 +01:00
Sebastian Dröge
d4eb77fa2b omxvideodec: Make sure to always release buffers back to OMX 2011-11-08 08:31:32 +01:00
Sebastian Dröge
1d071c05dc omx: Also properly release buffers when in error state 2011-11-08 08:24:49 +01:00
Jonas Larsson
0682012181 omx: Properly release buffers during flushing
We can't pass them back to OMX_FillThisBuffer() or OMX_EmptyThisBuffer()
but instead of doing nothing we have to put them back into our queue.
Otherwise the buffer is leaked and we will have too few buffers in
the future.
2011-11-08 08:24:49 +01:00
Sebastian Dröge
9151617d39 omxvideodec: Free pending frames after draining component 2011-11-07 14:00:47 +01:00
Sebastian Dröge
0b301021de omxvideoenc: Free pending frames after draining the component 2011-11-07 14:00:35 +01:00
Sebastian Dröge
636cdd31bf omxvideoenc: Make handling and usage of the base video codec frames threadsafe 2011-11-07 11:07:01 +01:00
Sebastian Dröge
9a6cea5af3 omxvideoenc: Fix deadlock between srcpad stream lock and ::reset() 2011-11-07 11:05:29 +01:00
Sebastian Dröge
95b06504f9 omxvideoenc: Make handling and usage of the base video codec frames threadsafe 2011-11-07 11:04:27 +01:00
Sebastian Dröge
a80ca97ec3 omxvideoenc: Free all pending frames after draining the component 2011-11-07 10:58:44 +01:00
Sebastian Dröge
be1f75d2f4 omxvideodec: Always free all pending frames when caps changes require reconfiguration 2011-11-07 10:58:24 +01:00
Sebastian Dröge
0c0aa78373 omxaudioenc: Only drain the component a single time and only after processing started 2011-11-04 09:44:04 +01:00
Sebastian Dröge
d5371b9208 omxvideodec: Only drain the component a single time and only after processing started 2011-11-04 09:44:04 +01:00
Sebastian Dröge
3a17d11109 omxvideoenc: Only drain the component a single time and only after processing started 2011-11-04 09:44:04 +01:00
Sebastian Dröge
fa6881c1cc omx: Reset buffer flags to 0 after it was consumed by the component or the element
Some implementations don't reset the flags and the standard is not
really clear on the expected behaviour. Let's just always reset the
flags as they're not valid at this point anymore.
2011-11-04 09:04:16 +01:00
Sebastian Dröge
ef67a43702 omxvideoenc: Better handling of encoder parameters
Only set them if necessary and allow to use the component
defaults.
2011-11-02 13:50:14 +01:00
Sebastian Dröge
08fabd6a07 omxvideoenc: Make unsupported bitrate/quantizer settings less fatal 2011-11-02 13:22:50 +01:00
Sebastian Dröge
ec9dde48e5 omxvideodec: If no stride was set for the OMX output port assume GStreamer stride
This is not really correct but there's nothing else we could do.
2011-11-02 10:39:50 +01:00
Sebastian Dröge
7ebef2941b omxvideoenc: If no stride was set for the OMX input port assume GStreamer stride
This is not really correct but there's nothing else we could do.
2011-11-02 10:39:10 +01:00
Sebastian Dröge
1ef38751c7 omxaudioenc: Implement draining of the component and use it
This makes sure that all buffers are encoded and pushed downstream
before flushing the ports and losing some buffers.
2011-11-01 16:46:09 +01:00
Sebastian Dröge
8eaf25c10e omxvideoenc: Implement draining of the component and use it
This makes sure that all buffers are encoded and pushed downstream
before flushing the ports and losing some buffers.
2011-11-01 16:41:46 +01:00
Sebastian Dröge
e4b7ffcc1b omxvideodec: Implement draining of the component and use it
This makes sure that all buffers are decoded and pushed downstream
before flushing the ports and losing some buffers.
2011-11-01 16:23:22 +01:00
Sebastian Dröge
2f2c17a1b5 omxvideodec: Fix deadlock if ::reset is called before finding the corresponding frame of a decoded buffer 2011-11-01 16:23:22 +01:00
Sebastian Dröge
f93a45fb66 omxaudioenc: Forward downstream flow returns to upstream 2011-11-01 15:10:12 +01:00
Sebastian Dröge
21faf556ff omxvideoenc: Forward downstream flow returns to upstream 2011-11-01 15:10:01 +01:00
Sebastian Dröge
3b4260e54f omxvideodec: Forward downstream flow returns to upstream 2011-11-01 13:58:38 +01:00
Sebastian Dröge
f631097284 omx: Add minimal README file 2011-10-25 14:24:59 +02:00
Sebastian Dröge
10a5680692 omxvideodec: Fix deadlock caused by calling reset while the loop function does something with the base video codec stream lock 2011-10-20 15:21:07 +02:00
Sebastian Dröge
6689faa661 omxvideoenc: Fix deadlock caused by calling reset while the loop function does something with the base video codec stream lock 2011-10-20 15:20:47 +02:00
Sebastian Dröge
cf6f14d03c omxvideodec: Move locking at the correct place 2011-10-20 14:30:38 +02:00
Sebastian Dröge
72fa93956b omx: Remove QCOM hack to reset nOffset in EmptyBufferDone
This is now done in a generic way that does not require any
hacks because it will work without any side effects on any
OMX implementation.
2011-10-14 10:27:47 +02:00
Sebastian Dröge
2750a8869b omx: Reset nOffset to 0 in EmptyBufferDone if nFilledLen is 0
Some OMX implementations don't reset nOffset when the complete
buffer is emptied but instead only reset nFilledLen. We reset
nOffset to 0 if nFilledLen == 0, which is safe to do because
the offset *must* be 0 if the buffer is not filled at all.

Seen in QCOM's OMX implementation.
2011-10-14 10:26:21 +02:00
Sebastian Dröge
ac8085dce9 omxvideoenc: If one parameter/configuration is not supported don't skip the next 2011-10-10 10:38:29 +02:00
Sebastian Dröge
37967b4316 omxh264dec: Require stream-format=byte-stream
Other stream-formats are unlikely to be supported by OMX components.
2011-10-03 09:13:29 +02:00
Sebastian Dröge
bb1dd8aaba omxvideodec: Add API for subclasses to prepare/convert frames 2011-09-29 10:44:20 +02:00
Sebastian Dröge
febb83ec54 omxaudioenc: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
2011-09-28 10:35:38 +02:00
Sebastian Dröge
e364088596 omxvideoenc: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
2011-09-28 10:35:37 +02:00
Sebastian Dröge
ab9ce7db7d omxvideodec: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
2011-09-28 10:35:37 +02:00
Sebastian Dröge
792cdb7d1f omxvideodec: New hack for QCOM to recreate the component instead of reconfiguring it on caps changes 2011-09-28 10:35:31 +02:00
Sebastian Dröge
a7f77e22a4 omx: Change a g_assert() into a GST_WARNING_OBJECT() 2011-09-27 12:28:22 +02:00
Sebastian Dröge
837fc4ca66 omx: Add hack for Qualcomm's OMX implementation to manually reset nOffset in EmptyBufferDone 2011-09-26 13:05:23 +02:00
Sebastian Dröge
7dbf68a232 omxaudioenc: Add a check to prevent a zero-sized OMX buffer 2011-09-23 17:04:15 +02:00
Sebastian Dröge
d5452a53b0 omxvideoenc: Add some more checks for correct OMX buffer sizes 2011-09-23 17:04:14 +02:00
Sebastian Dröge
5659bd3b4f omxvideodec: Add some more checks for OMX buffer sizes 2011-09-23 16:40:30 +02:00
Sebastian Dröge
f0fe1148b7 omx: Wait until the Executing state is reached before calling OMX_FillThisBuffer()
This correctly works around the QCOM race condition that happens when calling
FTB after setting the new state and before reaching it.
2011-09-14 10:16:41 +02:00
Sebastian Dröge
3ba45aa0af omxvideodec: Negotiate video format with downstream and what the component claims to support 2011-09-02 14:43:43 +02:00
Vincent Penquerc'h
fa2dff1ad6 basevideoencoder: fix element leak
and this concludes an hour of yelling at the bloody test failing,
only to track down the problem not being in the test.

https://bugzilla.gnome.org/show_bug.cgi?id=657368
2011-08-26 10:27:16 +02:00
Sebastian Dröge
9eb39ceef2 omxvideoenc: Release basevideocodec stream lock while waiting for a buffer
This prevents deadlocks if no empty input buffers are available and
releasing input buffers requires the loop function to handle some
output buffers first.
2011-08-19 09:23:58 +02:00
Sebastian Dröge
e583c48222 omxvideodec: Release basevideocodec stream lock while waiting for a buffer
This prevents deadlocks if no empty input buffers are available and
releasing input buffers requires the loop function to handle some
output buffers first.
2011-08-19 09:23:54 +02:00
Sebastian Dröge
e494792ca4 basevideodecoder: Fix deadlock 2011-08-18 10:24:40 +02:00