Benjamin Gaignard
4ff27314f6
codecs: h265decoder: Fix return value if klass->new_picture isn't set
...
If klass->new_picture isn't set we need to initialize
ret with GST_FLOW_OK to avoid unwanted error case
Fixes: 5b405d1585
("codecs: h265decoder: Use GstFlowReturn everywhere")
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1426 >
2021-12-08 11:02:32 +01:00
Danny Smith
779e715b6c
gstnetclockclient: signal lost sync if remote time resets
...
When detecting the remote time has been reset which may occur if remote
device providing the clock server has been power reset, then clock is
no longer synced. Setting clock state will trigger a signal to client
informing on sync lost making it possibility to take appropriate action.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/975 >
2021-12-07 13:45:30 +00:00
Philippe Normand
86719e25a4
wpevideosrc: Use basesrc event vfunc
...
Allows for basic default handling from the base class.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1422 >
2021-12-07 11:43:26 +00:00
Tim-Philipp Müller
8557f10acf
ci: run fedora amd64 docker jobs on packet runners
...
Which have much better network connectivity to fdo gitlab.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1420 >
2021-12-06 17:36:26 +00:00
Guillaume Desmottes
2aa2477208
jpegdec: only allow conversions from RGB
...
libjpeg-turbo only supports converting from RGB to other RGB formats.
Fix runtime error when trying to convert from a YUV format for example.
Fix #916
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1421 >
2021-12-06 16:52:38 +00:00
Tim-Philipp Müller
26169cee0e
teletextdec: fix minor string leak
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1416 >
2021-12-06 13:07:37 +00:00
Nicolas Dufresne
06f1dfc724
ci: fedora-docker: Cache media files
...
As of now all integration tests endup fetching 600MB of media every run. This
will increase the docker side, but this is to the traceof that the docker
image will quickly be cached on all runners.
Fixes #841
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1413 >
2021-12-06 12:18:25 +00:00
Marc Leeman
49736fb3fd
ristsink: set properties on children early
...
The properties on the udpsink/udpsrc elements need to be set before
there is any state change. If not, in a network without default gateway,
udpsink tries to bind an a NULL interface and fails.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1411 >
2021-12-03 23:46:08 +00:00
Nicolas Dufresne
7e875ddb2c
v4l2codecs: mpeg2: Fix selected sizeimage
...
Due to a copy paste bug, the bitdepth was never set and that was leading
to requesting sizeimage of 0. Previously that worked since the driver
would in that case pick a size for us. But now the we bumped the minimum
to 4KB, the driver happily allocate 4KB of bitstream which lead to
decoding error.
As MPEG2 have a fixed bitdeph of 8, use a define instead of the run-time
variable.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1415 >
2021-12-03 07:55:30 -05:00
Nicolas Dufresne
05458f05e0
v4l2codecs: vp9: Drop frames on non-keyframe format change
...
V4L2 does not yet support this feature, this will skip over the
transition portion up to the next keyframe.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1404 >
2021-12-02 15:52:03 -05:00
Nicolas Dufresne
a6eb1e7782
v4l2codecs: Fix renegotiation
...
If we hold the last reference to the allocator, leaving the device
streaming will cause an EBUSY error when trying to free the allocate
buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1404 >
2021-12-02 15:45:26 -05:00
Seungha Yang
e87791592e
d3d11vp9dec: Drop frames on non-keyframe format change
...
... in case of NVIDIA GPU
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Seungha Yang
2c834b5fc7
nvvp9sldec: Drop frames on non-keyframe format change
...
NVDEC doesn't seem to be able to handle the case
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Seungha Yang
e2e45e51b0
codecs: vp9: Drop frames on non-keyframe format change
...
... if subclass does not support the case
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Nicolas Dufresne
43759ffeaa
codecs: vp9: Also consider render_width/height
...
Also emits new_sequence if on keyframe and the render_width/height have
change. The subclass can always optimize this if the frame resolution
didn't change, the output caps needs to reflect this though.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Marc Leeman
f699c08af9
rtpsink: set properties on children early
...
The properties on the udpsink/udpsrc elements need to be set before
there is any state change. If not, in a network without default gateway,
udpsink tries to bind an a NULL interface and fails.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1398 >
2021-12-02 14:23:05 +01:00
Víctor Manuel Jáquez Leal
d10ad61891
vaapidecodebin: Misc enhancements.
...
- Use GST_WARNING rather than g_critical
- Replace gst_ghost_pad_new_from_template() with
gst_ghost_pad_new() to avoid using the template.
- Declare extern variable
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1405 >
2021-12-02 08:37:19 +00:00
Víctor Manuel Jáquez Leal
90df5b5ab8
vaapidecode: Autogenerate caps template.
...
vaapidecode is used in vaapidecodebin and it exposes all the
theoretically supported caps, but that slows down autoplug. With this
autplug is negotiated faster, giving more option to decodebin to select
other decoder.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1405 >
2021-12-02 08:37:19 +00:00
Nicolas Dufresne
d04fba93f8
v4l2codecs: vp9: Remove uneeded picture data
...
The GstV4l2Request now holds a reference on the picture buffer and is
recounted already. This effectively removes usage of GRefCount which is only
available in GLib 2.58, while we support 2.56.
Fixes #910
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:59 -05:00
Nicolas Dufresne
19d99dbcae
v4l2codecs: decoder: Add method to get the pic_buf
...
This helper will be needed for VP9 frame duplication.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:59 -05:00
Nicolas Dufresne
8a1440b3f1
v4l2codecs: vp9: Add missing error checks in decide_allocation
...
This could otherwise lead to crash.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:56 -05:00
Jordan Petridis
eb33309050
ci: Avoid fetching tags for build jobs
...
Avoid fetching tags since we don't need them for builds.
Only caveat might be what happens when a pipeline from
a tag is triggered
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1400 >
2021-11-30 17:01:52 +02:00
Jordan Petridis
1ffa79d1aa
ci: Looks like we where not triggering pipelines for tags
...
Oops.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1400 >
2021-11-30 17:01:52 +02:00
Jordan Petridis
98cd5f9b8b
ci: Set GIT_DEPTH variable
...
This switches gitlab-runner to using shallow clones
related #841
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1400 >
2021-11-30 17:01:52 +02:00
Corentin Noël
a445ff1607
basesink: Add missing annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1392 >
2021-11-30 02:28:15 +00:00
Corentin Noël
7b1958c8de
pushsrc: Add missing annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1392 >
2021-11-30 02:28:15 +00:00
Corentin Noël
4e2e8492c9
bitwriter: Add missing annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1392 >
2021-11-30 02:28:15 +00:00
Corentin Noël
6da9285158
baseparse: Add missing annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1392 >
2021-11-30 02:28:15 +00:00
Nicolas Dufresne
4ca7f1e014
v4l2codecs: h264: Fix typo in comment
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1387 >
2021-11-30 00:28:34 +00:00
Nicolas Dufresne
83933b7772
v4l2codecs: h264: Properly set pic_num/frame_num
...
The V4L2 uAPI uses pic_num for both PicNum and ShortTermPicNum. It also
doe the same for both FrameNum and LongTermFrameIdx. This change does
not change the fluster score, but fixed a visual corruption noticed
with some third party streams.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1387 >
2021-11-30 00:28:34 +00:00
He Junyan
b5c07e11ca
va: Use a lock to protect the surface copy by using vpp.
...
If we use vpp to do the surface copy, its operation is not atomic.
We need to maintain the filter's context unchanged during the whole
copy progress.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00
He Junyan
954f7cf88c
va: Use the GstVaSurfaceCopy of the allocator atomically.
...
The mem_copy() of the allocator can be called simultaneously from
different threads. We should use atomic pointer operations to create
and use the GstVaSurfaceCopy of the allocator.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00
He Junyan
7f31dcf084
va: DMA allocator: Set the copied memory properly when popped from pool.
...
The current code does not set the copied memory correctly when it is popped
from the surface cache pool.
1. We forget to ref the allocator, which causes the allocator to be freed
unexpected, and we get a crash later because of the memory violation.
2. We forget to add ref_mems_count, which causes the surface leak because
the surface can not be pushed back to the cache pool again.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00
Daniel Almeida
285695ee52
v4l2codecs: gstv4l2decoder: set minimum sizeimage
...
Set minimum sizeimage such that there is enough space for any overhead
introduced by the codec.
Notably fix a vp9 issue in which a small image would not have a
bitstream buffer large enough to accomodate it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Daniel Almeida
120b96a974
v4l2codecs: gstv4l2codecsvp9dec: implement a render delay
...
The v4l2 backend support delayed output for performance reasons.
It is then possible to use render delays to queue multiple requests
simultaneously, thus increasing performance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Daniel Almeida
ccab90773f
v4l2codecs: vp9dec: Implement VP9 v4l2 decoder
...
Implement a v4l2 based vp9 decoder element based on the preexisting vp8
v4l2 decoder.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Daniel Almeida
c51d74ae3a
v4l2codecs: update to the new uAPI
...
The new VP9 stateless API is in its way to be destaged. Update our
headers to match.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Daniel Almeida
a2b0837bc5
codecs: gstvp9decoder: copy frame->system_frame_number into picture
...
A comment in gstvp9picture.h states that picture->system_frame_number
should get its value from frame->system_frame_number, but in fact
it was never copied at all.
Fix it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Daniel Almeida
98dc7a64a0
codecs: gstvp9{decoder|statefulparser}: optionally parse compressed headers
...
Rework gstvp9{decoder|statefulparser} to optionally parse compressed headers.
The information in these headers might be needed for accelerators
downstream, so optionally parse them if downstream requests it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1012 >
2021-11-29 17:41:19 +00:00
Wim Taymans
9aaef931bf
v4l2: handle 0x0 sizes gracefully
...
Also ignore 0x0 sizes in the fallback case and assume the size can be
anything between 1x1 and MAXxMAX.
This fixes the case where a width=0, height=0 caps are created. Whith
this patch the caps will contain width=[1,MAX], height=[1,MAX].
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1396 >
2021-11-29 15:35:36 +01:00
Mathieu Duponchelle
e90859f4d8
webrtcbin: deduplicate extmaps
...
When an extmap is defined twice for the same ID, firefox complains and
errors out (chrome is smart enough to accept strict duplicates).
To work around this, we deduplicate extmap attributes, and also error
out when a different extmap is defined for the same ID.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1383 >
2021-11-25 18:38:22 +00:00
He Junyan
d867180b4e
codecs: mpeg2decoder: drain() only when significant sequence changes.
...
There are a lot of info in the mpeg2's sequence(also including ext
display_ext and scalable_ext). We need to notify the subclass about
its change, but not all the changes should trigger a drain(), which
may change the output picture order. For example, the matrix changes
in sequence header does not change the decoder context and so no need
to trigger a drain().
Fixes : #899
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1375 >
2021-11-24 14:42:57 +00:00
Seungha Yang
2a17618dcc
openjpegenc: Fix build warning
...
Compiling C object subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpeg.dll.p/gstopenjpegenc.c.obj
../subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpegenc.c(416):
warning C4133: '=': incompatible types - from 'GstFlowReturn (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)' to
'gboolean (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)'
../subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpegenc.c(418):
warning C4133: '=': incompatible types - from 'GstFlowReturn (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)' to
'gboolean (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)'
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1378 >
2021-11-24 13:11:23 +00:00
Mathieu Duponchelle
4412198c05
rtpfunnel: fix extmap handling on accept-caps
...
Follow-up on 97d83056b3
, only check
for intersection with the current srccaps when checking if a sinkpad
can accept caps.
I must have been lucky in my firefox testing then, and always entered
the code path with audio getting negotiated first, thus not failing
the is_subset check when srccaps had been negotiated as
application/x-rtp, and an accept-caps query was made for the video
caps with a defined extmap.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1384 >
2021-11-23 20:26:30 +00:00
Krystian Wojtas
423acef4d9
tutorials: Fix typos
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1382 >
2021-11-23 19:56:27 +01:00
Guillaume Desmottes
d67a63a298
gssink: add metadata property
...
This property can be used to set metadata on the storage object.
Similar API has been added to the S3 sink already, see
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/613
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1377 >
2021-11-23 16:00:53 +01:00
Corentin Noël
578fddbf58
basesrc: Add annotation to virtual methods with (out) parameters
...
This allows to actually use these virtual methods from the GObject introspection.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1376 >
2021-11-23 08:54:01 +00:00
Seungha Yang
ffa8aff6b1
d3d11: Update comments
...
Remove copy & paste mistake (this is not GstGL) and add more
description.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1374 >
2021-11-23 07:23:12 +00:00
Víctor Manuel Jáquez Leal
5e3bf0fff7
vapostproc, vadeinterlace: don't transform caps if no intersection.
...
If caps to transform don't intersect with those supported by the VA
filter (VAEntrypointVideoProc) then return them as is, because only
pass-through mode is the only possibility.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
Víctor Manuel Jáquez Leal
68379649db
vapostproc: Append featured caps rather than merge.
...
So it would be possible to honor upstream preference.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00