mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 11:32:38 +00:00
Code Issues 1 Projects Releases Wiki Activity
121391 commits 44 branches 1513 tags 344 MiB
Commit graph

121391 commits

This branch
This branch
All branches
Author SHA1 Message Date
Edward Hervey
9b5ea24e2b h265parser: Fix unsigned value reading 
Unsigned values are always above 0, use MAX variant for reading

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
7f697a7065 examples/ipcpipeline: Fix ESC handler 
Same as for gst-play

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
55319cbf32 tests/play: Fix debug statement 
The interval is in milliseconds, convert to nanoseconds for debugging statement

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
fc5b616fca tests/webrtcbin: Remove useless checks with unsigned values 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
1221a09a5d closedcaption: Use proper type for storing result 
drop_ccp_from_cc_data() will return a negative value if there was an
error. Storing that in an unsigned value will cause the checks for errors to
never happen.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
524bea241d cea708decoder: Remove useless checks 
No need to check for the type limits

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
3e83d7d0bc isacdec: Remove impossible check 
WebRtcIsac_DecodePlc() never returns a negative value (confirmed by
documentation and current/historical code)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
d6eebeafbf sctpdec: Remove useless check 
A uint16 will always be below ... the maximum value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
8d0cd490f0 mpeg2decoder: Remove useless check 
The enum is unsigned

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
9b8ecba9a1 vkinstance: Remove useless check 
priv->requested_api_major is unsigned

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
7a2aef9fa2 basetsmux: Add explicit macro for GstClockTimeDiff handling 
The checks in the other macro were useless for unsigned values

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
67c4c35fb7 mxfdemux: Remove useless check 
values will always be positive

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
5bc4ebfe61 speed: Refactor event handler 
To avoid fallthrough issues which were tricky to fix

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
21d81d25ec bad: Clearly specify fallthrough in switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
a9984a0003 vorbisdec: Fix check for "-1" bitrate values 
The check is exactly the same, but more explicit.

Original commit that introduced the check is
20fb58be19:
---
vorbisdec: don't put invalid bitrate values into the taglist

Bitrates are stored as 32-bit signed integers in the vorbis
identification headers, but seem to be read incorrectly,
namely as unsigned 32-bit integers, into the vorbis structure
members which are of type long, which makes our check for
values <= 0 fail with files that put -1 in there for unset
values.
---

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
8b9ac40710 good: Enable extra warning flags 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
47b723c6e1 splitmuxsink: Fix GST_(S)TIME_{ARGS|FORMAT} usage 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
8bc17b58a2 good: Clearly specify fallthrough in switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
2a6c1bbb01 matroska: Reorder switch/case for parsing 
Just makes it clearer

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
5d69f2bc36 qtmux: Fix GST_STIME_ARGS usage 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
b0f527a79e adaptivedemux2: Fix CLAMP usage 
It's a positive value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
02df2a5e9a adaptivedemux2: Remove useless ABS 
Just compare the difference (in the right order)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
9f4f500543 filesrc: Properly handle lseek return value 
On windows we use _lseeki64 which returns a guint64.

The only error code lseek and _lseeki64 return is a casted -1, therefore just do
that to handle all platforms

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
77ad891e68 test: Remove always-true assertion 
The offset is not deterministic

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
72df7ab3bd test: Avoid type-limit issue 
```
../subprojects/gstreamer/tests/check/elements/filesink.c: In function ‘test_seeking’:
../subprojects/gstreamer/tests/check/elements/filesink.c:92:23: warning: comparison of unsigned expression in ‘< 0’ is
  always false [-Wtype-limits]

   92 |         for (i = 0; i < num_bytes; ++i)                                 \
      |                       ^
../subprojects/gstreamer/tests/check/elements/filesink.c:266:3: note: in expansion of macro ‘PUSH_BYTES’
  266 |   PUSH_BYTES (0);
      |   ^~~~~~~~~~
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
a81371bf8b base: Enable more warning flags 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
568ae91a2a compositor: Don't use CLAMP for unsigned values 
Just use MIN, we already know it's above 0

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
c0d35e14a5 gst-play: Move esc-handling to the right place 
It's meant to fall through to the default handler of the switch (for
debugging). Some intermediary commits broke that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
989539830d libvisual: Fix for libvisual headers 
They use old style definition

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
9e58164cfb base: Do not use old-style definition 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
319ff17300 base: Fix fallthrough declarations 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
0e8f8dfe15 gstreamer: Add more warning flags 
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4123

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
316722d7c9 gstptpclock: Fix GST_STIME_ARGS usage 
It requires a signed value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
39a1b61469 gstreamer: Make switch passthrough as such 
vasnprintf requires special handling since the following 'case' is #ifdef'ed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Carlos Bentzen
b83b73841d webrtc: fix duplicate payload types with RTX and multiple video codecs 
Before this patch, there could be duplicate payload types in offers that
have, within a media section, multiple codecs and RTX enabled:

```
m=video 9 UDP/TLS/RTP/SAVPF 96 97 97 <-- HAS DUPLICATES
a=sendrecv
a=rtpmap:96 VP8/90000
a=rtcp-fb:96 nack
a=rtcp-fb:96 nack pli
a=rtcp-fb:96 ccm fir
a=rtcp-fb:96 transport-cc
a=rtpmap:97 H264/90000
a=rtcp-fb:97 nack
a=rtcp-fb:97 nack pli
a=rtcp-fb:97 ccm fir
a=rtcp-fb:97 transport-cc
a=rtpmap:97 rtx/90000  <--------- PT IS DUPLICATE
a=fmtp:97 apt=96
```

Fix this by populating the media_mapping array with all media formats
rather than only the first one. The added test case reproduces the issue,
which fails without this patch.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8259>
 2025-01-13 10:11:59 +00:00
Edward Hervey
0891a0e5eb wasapi: Use signed value for can_frames 
The can retrieval function can return negative values (which will be properly handled)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
aedb587616 amfcodec: Add missing break statement 
Setting frame-sad would also set ltr

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
8b62792e5c d3d12: Add missing breaks to switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
916774b4f0 h265bitwriter: Don't use type too small 
The computed `coef_val` could exceed the maximum range of a gint8. Use a bigger
one, the checks after will ensure it's properly cropped/padded

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
5bb22c24dc mpegts: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
b78c119a42 msemediabuffer: Fix ASCII character detection 
Use glib function. The previous check was checking whether a signed int was
lower than its limit (which ... is always TRUE).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
efbe1e96ca msesourcebuffer: Fix unsigned value handling 
Use the explicit valid clocktime handler instead

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
2f1f44cdc7 ristsink: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
a0f50df7a0 splitmuxsink: Fix wrong usage of GstClockTime vs GstClockTimeDiff 
This could potentially have caused issues (because of the rest of the code using
checks for signed invalid values on a unsigned value)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
2e6b98ad89 splitmuxsrc: Add missing break 
This would cause the reconfigure path to be called

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
0ee882cfb9 adaptivedemux2: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
32ebee5594 adaptivedemux2: Fix usage of GstClockTime vs GstClockTimeDiff 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
65b4d26db6 audiorate: Fix unsigned integer comparision 
next_offset uses a magic "-1" value for unset values. Use that value and not
checking whether it's positive (it always is, it's unsigned)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
344ef36b5a videorate: Avoid overflow in calculations 
base_ts and next_end_ts are both guint64. Use explicit check to avoid "negative"
timestamps (which would overflow, not be negative).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
84f995dd90 test: Fix unsigned integer usage 
num_queued is unsigned, it'll never be below 0.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00