Mathieu Duponchelle
e90859f4d8
webrtcbin: deduplicate extmaps
...
When an extmap is defined twice for the same ID, firefox complains and
errors out (chrome is smart enough to accept strict duplicates).
To work around this, we deduplicate extmap attributes, and also error
out when a different extmap is defined for the same ID.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1383 >
2021-11-25 18:38:22 +00:00
He Junyan
d867180b4e
codecs: mpeg2decoder: drain() only when significant sequence changes.
...
There are a lot of info in the mpeg2's sequence(also including ext
display_ext and scalable_ext). We need to notify the subclass about
its change, but not all the changes should trigger a drain(), which
may change the output picture order. For example, the matrix changes
in sequence header does not change the decoder context and so no need
to trigger a drain().
Fixes : #899
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1375 >
2021-11-24 14:42:57 +00:00
Seungha Yang
2a17618dcc
openjpegenc: Fix build warning
...
Compiling C object subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpeg.dll.p/gstopenjpegenc.c.obj
../subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpegenc.c(416):
warning C4133: '=': incompatible types - from 'GstFlowReturn (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)' to
'gboolean (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)'
../subprojects/gst-plugins-bad/ext/openjpeg/gstopenjpegenc.c(418):
warning C4133: '=': incompatible types - from 'GstFlowReturn (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)' to
'gboolean (__cdecl *)(GstVideoEncoder *,GstVideoCodecFrame *)'
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1378 >
2021-11-24 13:11:23 +00:00
Guillaume Desmottes
d67a63a298
gssink: add metadata property
...
This property can be used to set metadata on the storage object.
Similar API has been added to the S3 sink already, see
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/613
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1377 >
2021-11-23 16:00:53 +01:00
Seungha Yang
ffa8aff6b1
d3d11: Update comments
...
Remove copy & paste mistake (this is not GstGL) and add more
description.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1374 >
2021-11-23 07:23:12 +00:00
Víctor Manuel Jáquez Leal
5e3bf0fff7
vapostproc, vadeinterlace: don't transform caps if no intersection.
...
If caps to transform don't intersect with those supported by the VA
filter (VAEntrypointVideoProc) then return them as is, because only
pass-through mode is the only possibility.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
Víctor Manuel Jáquez Leal
68379649db
vapostproc: Append featured caps rather than merge.
...
So it would be possible to honor upstream preference.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
Víctor Manuel Jáquez Leal
718e83ed4c
vapostproc: Remove dead code.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
Víctor Manuel Jáquez Leal
26040bd932
va: filter: Validate input parameter in internal function.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
Víctor Manuel Jáquez Leal
8377463128
va: allocator: log drm modifier
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1369 >
2021-11-22 15:27:10 +00:00
He Junyan
a14f0da324
va: vpp: Fix the memory leak in fixate_caps().
...
For the BaseTransform class, the function of fixate_caps(), takes
the ownership of "othercaps". So we should clear it in our subclass.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1372 >
2021-11-22 10:54:23 +00:00
Philippe Normand
ee7fe545b2
player: Ensure the GstPlay is created before the wrapped renderer
...
The GstPlayerWrappedVideoRenderer implicitely depends on GstPlay.
Fixes #878
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1345 >
2021-11-20 10:15:49 +00:00
Philippe Normand
12a5bf64f8
play: Allow runtime configuration of video-renderer
...
This is a requirement for GstPlayer when using the default overlay interface
provided by the pipeline. The GstPlayerWrappedVideoRenderer requires a valid
pipeline, but that's available only after the GstPlay thread has successfully
started.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1345 >
2021-11-20 10:15:49 +00:00
He Junyan
c2bffe22f3
va: decoder: Also ref the display when duplicating pictures.
...
The _destroy_buffers() will check the display handle using the
g_return_val_if_fail. we should not generate the invalid pointer
warning.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1368 >
2021-11-19 14:40:18 +00:00
Seungha Yang
53391d2b8d
docs: Update doc cache for Windows specific plugins
...
Updating doc cache for d3d11, mediafoundation and wasapi2 plugins
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1360 >
2021-11-19 13:38:19 +00:00
Seungha Yang
7f796b10b2
wasapi2: Fix typo in doc
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1360 >
2021-11-19 13:38:19 +00:00
Seungha Yang
6acf89b3d3
mediafoundation: Skip doc for non-default encoder elements
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1360 >
2021-11-19 13:38:19 +00:00
Seungha Yang
7fe08d8bed
d3d11: Stop doc for non-default decoder and deinterlacer elements
...
Just skip doc for non-default decoder/deinterlacer elements
since there are multiple element in case that system has
multiple GPUs.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1360 >
2021-11-19 13:38:19 +00:00
Wonchul Lee
ae7a365274
d3d11: Fix deadlock while doing unprepare
...
ShowWindow() could be blocked while doing gst_d3d11_window_win32_unprepare
when external window handle provided to d3d11videosink in multi-threaded
environment.
The condition that issue happened is, UI thread is waiting for a
background thread that changes d3d11videosink state to NULL, and the
background thread would try to send a window message to the queue.
The queue is already occupied by the UI thread, so the background
thread will be blocked.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1366 >
2021-11-19 13:42:53 +09:00
Philippe Normand
a6fd767025
wpevideosrc: Fix frame stuttering in GL rendering path
...
Make sure the EGLImage we're rendering to the GL memory stays alive long enough,
until the the GL memory has been destroyed.
This change fixes tearing and black flashes artefacts that were happening
because the EGLImage was sometimes destroyed before the sink actually rendered
the associated texture.
Fixes #889
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1354 >
2021-11-16 21:55:41 +00:00
Philippe Normand
053dd564a1
wpevideosrc: Run through gst-indent
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1354 >
2021-11-16 21:55:41 +00:00
Tim-Philipp Müller
972615cf22
docs: fix unnecessary ampersand, < and > escaping in code blocks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1340 >
2021-11-12 11:39:19 +00:00
Timo Wischer
8e7ce64a6e
avtp: crf: Process also local CRF streams
...
Without this patch locally generated CRF streams will be ignored.
Therefore the same network interface could not be CRF talker and
CRF listener.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1074 >
2021-11-10 16:53:04 +00:00
Jean Felder
bd91286a3b
id3tag: Map GST_TAG_MUSICBRAINZ_RELEASETRACKID
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1331 >
2021-11-10 01:33:33 +00:00
Jean Felder
aaf72b9ff4
id3tag: Map GST_TAG_MUSICBRAINZ_RELEASEGROUPID
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1331 >
2021-11-10 01:33:33 +00:00
Jean Felder
b1c74609e8
id3tag: Remove trailing whitespace
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1331 >
2021-11-10 01:33:33 +00:00
Timo Wischer
36006c61e9
avtpsrc: Use correct size for provided buffers
...
Without this patch the following pipeline would send packets containing
garbage in the data section.
$ gst-launch-1.0 avtpsrc ! avtpsink
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1077 >
2021-11-09 16:59:10 +00:00
Timo Wischer
de95d3a1c4
avtp: crfsync: Warn when CRF package not yet received
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1075 >
2021-11-09 15:36:25 +01:00
Timo Wischer
214691b972
test: avtp: crf: Check for rounding errors
...
on average period calculation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1073 >
2021-11-09 10:59:00 +00:00
Timo Wischer
5a25eb61b7
avtp: crf: Use double for average period calculation
...
to also support CRF intervals like every 1,333,333ns 64 events
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1073 >
2021-11-09 10:59:00 +00:00
Timo Wischer
6a576938ac
tests: avtp: crf: Test for timestamp_interval > 1
...
in case of CRF AVTPDUs with single CRF timestamp.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1076 >
2021-11-09 09:07:01 +01:00
Timo Wischer
5a9e9895ab
avtp: crf: Properly handling one timestamp per PDU
...
The average_period should always represent the time between two
events. The specification defines the event time as the time
between audio samples, video frame sync, video line sync, etc.
In case of one timestamp per PDU the timestamp_interval identifies
the amount of events between the timestamp of one PDU and the
timestamp of the next PDU.
As described in IEEE 1722-2016 chapter
"10.4.12 timestamp_interval field" timestamp_interval shall be
nonzero.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1076 >
2021-11-09 09:07:01 +01:00
Thomas Klausner
49449dfa41
shm: NetBSD build fix
...
shm_unlink() and friends live in librt on NetBSD. Adapt build system.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1323 >
2021-11-08 21:14:42 +00:00
Martin Reboredo
2546cef4be
aom: Set fixed_qp_offsets to a deactivated value
...
aom only uses fixed_qp_offsets with the
Constant Quality (Q) Rate Control mode,
previously this was locking any usage
with another Rate Control mode.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1198 >
2021-11-08 16:42:17 +00:00
Antonio Ospite
7deee582d2
magicleap: update lumin_rt libraries names to the latest official version
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1314 >
2021-11-05 16:21:34 +00:00
He Junyan
0345188aaa
codecs: h264dec: Calculate the latency by its bump mode.
...
The current latency calculation just uses the num_reorder_frames,
which is not very precise. We should consider the bump mode of the
DPB, the faster it bumps, the lower latency we will have.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1046 >
2021-11-05 14:40:42 +00:00
Thibault Saunier
d0c5778669
doc: Update nvdec documentation
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/870
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1309 >
2021-11-05 13:26:33 +00:00
Seungha Yang
21d7bd09ce
h264parse: Don't insert extra AUD if exists in bitstream already
...
AUD nalu in packetized format is completely valid and therefore we should not
assume that we should insert AUD for packetized -> bytestream
conversion.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/862
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296 >
2021-11-04 16:32:55 +00:00
Seungha Yang
aa1d97b0fb
tests: h264parse: Add test for AUD insertion
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296 >
2021-11-04 16:32:54 +00:00
Seungha Yang
8eee442715
wasapi2ringbuffer: Fix client object leak
...
Check whether ringbuffer is holding client object already since
open_device() may be called multiple times
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1307 >
2021-11-04 12:41:32 +00:00
Sebastian Dröge
f9a97efbe1
webrtcbin: Clear errors from finding codec preferences before the next iteration
...
The media is just skipped and the error is not propagated to the caller,
so keeping it around here would cause assertions a bit later when trying
to set a new error over the old one.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Sebastian Dröge
30153f1591
webrtcbin: Move addition of attributes to the caps after making sure they're not empty or any
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Sebastian Dröge
d628ccf0e5
webrtcbin: Don't require fixed caps when querying caps for a transceiver pad to match it with a media
...
Upstream caps might for example be
application/x-rtp,media=audio,encoding-name={OPUS, X-GST-OPUS-DRAFT-SPITTKA-00, multiopus}
and while that is not fixed caps it is enough to match it with a media.
Only caps structures that have the correct structure name and that have
the media and encoding-name field are preserved, but if both are present
then these caps are used as "codec preferences".
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Tim-Philipp Müller
a7b376011b
Back to development
2021-11-03 19:31:23 +00:00
Tim-Philipp Müller
f513c289b0
Release 1.19.3
2021-11-03 15:43:43 +00:00
Tim-Philipp Müller
d51b091cd9
Update ChangeLogs for 1.19.3
2021-11-03 15:43:32 +00:00
Nicolas Dufresne
aedd5f0dd1
codecs: mpeg2: Drain before a new_sequence get signalled
...
The decoder may need to re-allocate the output buffer, it is easier if all
pictured have been outputed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
f9958eda8e
v4l2codecs: gstv4l2codecsmpeg2dec: implement a render delay
...
The v4l2 backend support delayed output for performance reasons.
It is then possible to use render delays to queue multiple requests
simultaneously, thus increasing performance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
a8decde6d3
codecs: gstmpeg2decoder: add support for render delay
...
Some decoding APIs support delayed output for performance reasons.
One example would be to request decoding for multiple frames and
then query for the oldest frame in the output queue.
This also increases throughput for transcoding and improves seek
performance when supported by the underlying backend.
Introduce support in the mpeg2 base class, so that backends that
support render delays can actually implement it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
477b824f8e
v4l2codecs: Implement a MPEG2 V4L2 decoder element
...
Implement a MPEG2 V4L2 decoder element based on the previous h264
implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00