Philipp Zabel
7ae6c203cb
v4l2: bufferpool: Drop writable check on output pool process
...
Output buffers don't have to be writable. Accepting read-only buffers
from the V4L2 buffer pool allows upstream elements to write directly
into the V4L2 buffers without triggering a CPU copy into a new buffer
from the same V4L2 buffer pool every time.
Tested with the vivid output device:
GST_DEBUG=GST_PERFORMANCE:7 gst-launch-1.0 videotestsrc ! v4l2sink device=/dev/video5
With this change, gst_v4l2_buffer_pool_dqbuf() must be allowed to not
resize read-only memories of output buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6648 >
2024-04-16 08:15:16 +00:00
Seungha Yang
ebd27cb2d2
mediafoundation: Fix device enumeration
...
Do not stop device enumerate even if a device could not be opened.
Otherwise the other devices listed after the failed device will not be
reported by device provider
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3460
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6647 >
2024-04-16 06:57:06 +00:00
Seungha Yang
4313083584
d3d12encoder: Fix buffer pool leak
...
Add missing buffer pool release
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6637 >
2024-04-16 03:41:28 +00:00
Philippe Normand
e87ecf448b
vpxdec: Include vpx error details in errors and warnings
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6636 >
2024-04-16 02:44:01 +00:00
Philippe Normand
ce16646190
vp9enc: Include vpx error details in errors and warnings
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6636 >
2024-04-16 02:44:01 +00:00
Philippe Normand
45fdf4b69b
vpxenc: Rename GST_VPX_WARN to GST_VPX_ENC_WARN
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6636 >
2024-04-16 02:44:01 +00:00
Seungha Yang
6ddadcb830
d3d11videosink: Fix rendering on keyed mutex enabled handle
...
As of the commit 69b2e1565c
,
keyed mutex will be handled by the memory object.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3468
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6635 >
2024-04-16 02:07:06 +00:00
Qian Hu (胡骞)
01b00643af
qtdemux: fix wrong full_range offset when parsing colr box
...
use colr_data[18] >> 7 to get full range information, instead
of colr_data[17] >> 7
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6634 >
2024-04-16 01:22:56 +00:00
William Wedler
9fe8fd41ba
fix: qml6glsink: Notify that the returned QSGNode node has changes
...
Sets the QSGNode::DirtyMaterial bit when a new buffer is used for the material's texture
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3469
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6633 >
2024-04-16 00:09:19 +00:00
U. Artie Eoff
f137e41a09
libav: guard dropped AV_OPT_TYPE_CHANNEL_LAYOUT
...
The FF_API_OLD_CHANNEL_LAYOUT api was dropped in upstream:
https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/65ddc7498824
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6632 >
2024-04-15 23:22:40 +00:00
U. Artie Eoff
383723e095
libav: guard dropped AV_CODEC_ID_AYUV api
...
The FF_API_AYUV_CODECID api was dropped in upstream:
https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/9ee59b63f5ea
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6632 >
2024-04-15 23:22:40 +00:00
Tim-Philipp Müller
738a7c3e2b
tests: fix possible libscpp build failure in gst-plugins-bad
...
../subprojects/gst-plugins-bad/tests/check/libs/gstlibscpp.cc:41:
fatal error: gst/mpegts/gstmpegts-enumtypes.h: No such file or directory
Could only pass the needed deps to the libscpp test, but gets
messier to maintain, so let's at it for consistency.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6644 >
2024-04-15 13:45:58 +01:00
Sebastian Dröge
4171fe3a70
ptp: Silence warning about some unused trait methods
...
These are not used yet but will likely be useful in the future.
Rust 1.79 (nightly) is warning about them being unused.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6606 >
2024-04-10 18:32:56 +00:00
Matthew Waters
ac2d95eb49
glcolorconvert: don't overread the end of an array
...
Reverse index iteration needs a - 1 for the initial value.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6605 >
2024-04-10 18:39:37 +01:00
Matthew Waters
1c37913e32
glcolorconvert: remove unused swizzling using "rgba" chars
...
We use indices now instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6605 >
2024-04-10 18:39:37 +01:00
Jimmy Ohn
61d7336bf3
pulsedeviceprovider: Add is_default_device_name function and missing lock
...
Add is_default_device_name function to simplify compare device type
name and fix the missing lock when accessing default_sink_name and
default_source_name.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6599 >
2024-04-10 13:27:11 +01:00
Edward Hervey
6302931e70
parsebin: Ensure non-time subtitle streams get "parsed"
...
Since https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6153 ,
subtitle "decoders" (i.e. which decode to raw text) are no longer auto-plugged
by parsebin.
But if a given format does not have a parser at all, we would end up outputting
non-time/non-parsed outputs.
In order to mitigate the issue, until such parsers are available, we check if
the subtitle stream is in TIME format or not (i.e. whether it comes from a
parser or demuxer). If not, we attempt to plug in a subtitle "decoder".
Fixes #3463
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6597 >
2024-04-10 09:59:58 +01:00
Tim-Philipp Müller
934af761fd
Back to development after 1.24.2
2024-04-10 00:15:42 +01:00
Tim-Philipp Müller
2d82731515
Release 1.24.2
2024-04-09 21:48:55 +01:00
Seungha Yang
380511f14d
ccconverter: Fix caps leak and remove unnecessary code
...
The removed code does the exactly same thing as the below code
except for leaking caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6587 >
2024-04-09 20:24:42 +01:00
Seungha Yang
10ffbdbb1f
qsvdecoder: Release too old frames
...
Release too old frames manually.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3163
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6586 >
2024-04-09 18:56:08 +01:00
Philippe Normand
7ce569359f
vpxenc: Include vpx error details in errors and warnings
...
The vpx_codec_t err_detail string usually provides additional context about the
error, so include it in GStreamer warnings and errors, when it's not NULL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6584 >
2024-04-09 17:34:44 +01:00
Jochen Henneberg
2aff9380c7
qt6: Fixes for dummy texture
...
* RED_OR_ALPHA8 will map value to alpha for OpenGL, use R8 to avoid
2nd shader
* Determine texel size for proper texture memory preparation
* QByteArray::fromRawData() does shallow copy and thus leads to use of
corrupted memory
* Make sure RGBA dummy texture is fully opaque
* QRhiTexture::create() must be called to allocate texture resources
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6581 >
2024-04-09 13:51:27 +01:00
Jochen Henneberg
a0e870263e
qt: Fixup for dummy textures
...
* Initialize dummy texture Ids
* Ensure YUV->RGB matrix set for dummy textures
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6581 >
2024-04-09 13:51:27 +01:00
Sebastian Dröge
17db91c7c1
rtpbin: Don't re-use a variable for a completely different purpose temporarily
...
During RTP-Info synchronization, clock_base was temporarily switched
from the actual clock-base to the base RTP time and then back some lines
later.
Instead directly work with the base RTP time. The comment about using a
signed variable for convenience doesn't make any sense because all
calculations done with the value are unsigned.
Similarly, rtp_clock_base was overridden with the rtp_delta when
calculating it, which was fine because it is not used anymore
afterwards. Instead, introduce a new variable `rtp_delta` to make this
calculation clearer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
72c6cac8db
rtpbin: Convert clock-base to extended RTP timestamp correctly
...
It's not in the same period as the current RTP base time but always in
the very first period. This avoids using it again at a much later time.
The code in question is only triggered with rtcp-sync=rtp-info.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
bba6f097b1
rtpjitterbuffer: Use an extended RTP timestamp for the clock-base
...
It is compared to other extended RTP timestamps all over rtpjitterbuffer
and since 4df3da3bab
the initial extended RTP timestamp is not equal
anymore to the plain RTP time.
Continue passing a non-extended RTP timestamp via the `sync` signal for
backwards compatibility. It will always be a timestamp inside the first
extended timestamp period anyway.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
38ec8f1299
rtphdrext-ntp: Fix typo of the RFC number in the element metadata
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3417
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6537 >
2024-04-08 12:21:35 +00:00
Seungha Yang
f5500906ce
dwrite: Fix crash on device update
...
Selected blend mode should not be cleared on device update
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6521 >
2024-04-08 11:38:43 +00:00
Robert Guziolowski
50bd2f2109
qml6glsink: fix destruction of underlying texture
...
One should not directly delete the QRhiTexture instance.
Instead it should be marked as to be deleted once QRhi::endFrame()
is called (see: https://doc.qt.io/qt-6/qrhiresource.html#deleteLater )
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3443
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6506 >
2024-04-08 10:45:26 +00:00
Daniel Morin
b96072b810
ci/fluster: Revert results for visl
...
- Make test pass without h264parse AU boundary detection changes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
9289fb5ce4
h264parser: maintain API changes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
59230efdd9
Revert "h264parse: test - AU align with SEI between frame slices"
...
This reverts commit 533f814fd9
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
83038c3daf
Revert "h264parse: Improved AU boundary detection"
...
This reverts commit 49f200cb54
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
115b4792b5
Revert "h264parse: Remove dead code"
...
This reverts commit 141cd38715
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
9bbf246cc4
Revert "h264parse: Fix AU collection"
...
This reverts commit 495390f63a
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
5453976f03
Revert "h264parse: Remove un-needed check on SPS state"
...
This reverts commit 73dedf9a51
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
ee7026925f
Revert "h264parse: use AUD to detect first VCL NAL"
...
This reverts commit 90a3b63eed
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
c259674ed5
Revert "h264parse: correct NAL mode backlog processing"
...
This reverts commit b2098849dc
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Jan Schmidt
b3d6a14737
rtpjitterbuffer: Don't use estimated_dts to do default skew adjustment
...
When the buffer DTS is estimated based on arrival time at the
jitterbuffer (rather than provided on the incoming buffer itself),
it shouldn't be used for skew adjustment. The typical case is
packets being deinterleaved from a tunnelled TCP/HTTP RTSP stream,
and the arrival times at the jitter buffer are not well enough
correlated to usefully do skew adjustments.
This restores the original intended behaviour for the 'estimated dts'
path, that was broken years ago during other jitterbuffer refactoring.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6561 >
2024-04-07 16:24:22 +01:00
Sebastian Dröge
4b6cbca300
flac: Add wrap file and add fallback for it to the flac plugin
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6560 >
2024-04-07 13:57:40 +00:00
Tim Blechmann
88dd91cb30
v4l2: enforce a pixel aspect ratio of 1/1 if no data are available
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6559 >
2024-04-07 14:17:19 +01:00
Philipp Zabel
993d8b89bc
v4l2: allocator: Fix unref log/trace on memory release
...
Use gst_object_unref() instead of g_object_unref() in
gst_v4l2_allocator_release(), so refcounting log and
tracer get to know about this unref.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6556 >
2024-04-06 23:41:52 +00:00
Edward Hervey
4ea7d5ae64
videoparsers: Demote CC warning message
...
Another warning message which isn't fatal and therefore should just be a DEBUG
line.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6555 >
2024-04-06 19:08:33 +00:00
Elliot Chen
7aa75e590a
v4l2: fix error in calculating padding bottom for tile format
...
This is a regression while porting to arbitrary tile dimensions
introduced in !3424 .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6554 >
2024-04-06 19:10:25 +01:00
Elizabeth Figura
e1b82701df
atdec: Handle channel counts greater than 2
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6546 >
2024-04-05 10:14:59 +00:00
Elizabeth Figura
b7a4b9e1ab
atdec: Use gst_audio_decoder_set_output_caps() directly
...
The code currently sets the same caps in two different ways, and neither of them correctly handle the channel mask.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6546 >
2024-04-05 10:14:59 +00:00
Seungha Yang
ce4f0d5746
avviddec: Fix AVPacket leak
...
av_packet_unref() does not release allocated memory.
av_packet_free() is the correct free function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6545 >
2024-04-05 10:28:22 +01:00
Sebastian Dröge
984b1f413a
wavpackparse: Use an unsigned integer for the block size calculations
...
It's never negative.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00
Sebastian Dröge
078ef786d2
wavpackparse: Fix potential integer overflow on ID_ODD_SIZE blocks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00