mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-04 23:46:43 +00:00
Code Issues 1 Projects Releases Wiki Activity
968 commits 44 branches 1510 tags 537 MiB
Commit graph

258 commits

Author SHA1 Message Date
Guillaume Desmottes
136714c6ed omxvideodec: add dmabuf support for output 
The zynqultrascaleplus OMX implementation has a custom extension
allowing decoders to output dmabuf and so avoid buffers copy between OMX
and GStreamer.

Make use of this extension when built on the zynqultrascaleplus. The
buffer pool code should be re-usable for other platforms as well.

https://bugzilla.gnome.org/show_bug.cgi?id=784847
 2017-07-18 23:46:46 +01:00
Julien Isorce
1b7d0b8599 omxvideodec: handle IL 1.2 behavior for OMX_SetParameter 
It triggers SettingsChanged on the other port and it is up to
the client to decide if it should lead to a port reconfiguration.

Settings are propagated to the other port for fields they have
in common. But this event is only triggered on the other port
if it actually change a setting.

https://bugzilla.gnome.org/show_bug.cgi?id=783976
 2017-07-18 23:45:11 +01:00
Julien Isorce
af18e81fef omxvideodec: fix file permissions 
Introduced by ebc9b4903c
 2017-07-18 23:45:11 +01:00
Julien Isorce
7b114b131f omxvideodec: fix buffer leak when eglimage setup fails 
Can happen if gst_buffer_pool_acquire_buffer succeeds but
gst_buffer_n_memory (buffer) is not exactly 1.

In theory this should not happen because the decoder requests
EGLImage(RGBA) but better to fix any leak on corner cases.

https://bugzilla.gnome.org/show_bug.cgi?id=784365
 2017-07-17 17:11:34 +01:00
Julien Isorce
80c6dd46a1 omxvideodec: use OMX_UseBuffer 
For example this allows the omx decoder to directly fill the
pixmaps coming from the video sink.

It only avoids a buffer copy when the decoder uses a pool provided
by a downstream element. So let's restrict this usage to situations
where the decoder decides to use a downstream buffer pool.

Tested with Tizonia/OMX.Aratelia.video_decoder.vp8
and with Bellagio/OMX.mesa.video_decoder.avc.

If it fails to setup buffers with OMX_UseBuffer the decoders
fallbacks to usual OMX_AllocateBuffer.

Also it allows to test on desktop the GstOMXBufferPool->other_pool
management which was previously only used in the OMX_UseEGLImage
case, i.e. on Rpi.

https://bugzilla.gnome.org/show_bug.cgi?id=784069
 2017-07-12 16:36:03 +01:00
Sejun Park
ebc9b4903c omxvideodec: update local port_def after reopening the component 
gst_omx_video_dec_open will only update GstOMXVideoDec->port->port_def.

Note that the component is reopen only if the flag
GST_OMX_HACK_NO_COMPONENT_RECONFIGURE is set.

https://bugzilla.gnome.org/show_bug.cgi?id=782418
 2017-07-05 10:23:01 +01:00
Guillaume Desmottes
a3805116df omxvideodec: increase the minimum number of allocated buffers 
Ensure that enough buffers are allocated by adding up component's own
minimal plus the number of buffers requested by downstream.
This should prevent buffers starvation problem if downstream elements
are holding some of the buffers they required.

Also simplify the check on the maximum on buffers. What we actually care
about is to make sure the pool can hold the minimum of required buffers.

https://bugzilla.gnome.org/show_bug.cgi?id=784479
 2017-07-03 11:05:24 -04:00
Sejun Park
d980af213b omxvideodec: Removed unreachable code 
https://bugzilla.gnome.org/show_bug.cgi?id=782416
 2017-05-10 11:54:44 +01:00
Jan Schmidt
7c829886ca omxvideodec: demote ERROR message 
There's no need to warn about failing to negotiate EGL output
 - that can be perfectly normal.
 2017-03-14 02:34:36 +11:00
Graham Leggett
a1e613dd89 omx*dec: Flush before we stop the srcpad loop 
Flushing could otherwise hang if output port queue of pending buffers was empty

https://bugzilla.gnome.org/show_bug.cgi?id=774654
 2016-12-19 10:52:16 +02:00
Matthew Waters
baaf404f2b videodecoder: remove use of EGLImage orientation 
New code should use GstVideoTransformationMeta

(The defaults do the right thing here though).
 2016-11-17 19:56:35 +11:00
Kazunori Kobayashi
766cd65fa4 omxvideodec: Use GST_VIDEO_FRAME_PLANE_STRIDE() to get output buffer's stride 
GST_VIDEO_FRAME_PLANE_STRIDE() should be used to get the actual buffer stride,
as reported in the buffers's GstVideoMeta, when copying data to that buffer.

https://bugzilla.gnome.org/show_bug.cgi?id=768173
 2016-06-29 18:44:20 +10:00
Sebastian Dröge
a78756c63f omx: #define OMX_SKIP64BIT on the RPi as required by their API 
Also add generic support for OMX_SKIP64BIT to gst-omx, in case other
implementations also #define that for whatever reason.

https://bugzilla.gnome.org/show_bug.cgi?id=766475
 2016-06-17 12:06:48 +03:00
Sebastian Dröge
198e31355f omxvideodec: Implement ::drain() virtual method 
https://bugzilla.gnome.org/show_bug.cgi?id=767641
 2016-06-17 10:59:45 +03:00
Gwang Yoon Hwang
27d2cdd45d omxvideodec : Use gstglmemoryegl for the RPi 
Modified to use gstglmemoryegl to avoid texture creation/copy operations
at the glupload.

[Matthew Waters]: gst-indent the sources and port testegl to GstGLMemoryEGL

https://bugzilla.gnome.org/show_bug.cgi?id=760918
 2016-05-04 13:42:23 +10:00
Enrique Ocaña González
d1a79d7c59 Properly handle drain requests while flushing 
Without this commit the decoder streaming thread stops without ever attending
the drain request, leaving the decoder input thread waiting forever.

https://bugzilla.gnome.org/show_bug.cgi?id=758274
 2015-11-18 15:18:02 +02:00
Thiago Santos
c038df6671 omxvideodec: use default pad accept-caps handling 
Instead of the videodecoder one. The OMX video decoders have their
valid input in the template pad, so just check against that to
avoid doing a query downstream.
 2015-08-28 12:57:33 -03:00
Aurélien Zanelli
d2df0fb032 omxvideodec: unref allocator after getting it from allocation query 
Otherwise a reference will be leaked for each allocator. It only happens
when target platform is Raspberry Pi and when we have GL support.

https://bugzilla.gnome.org/show_bug.cgi?id=751867
 2015-07-06 11:54:28 +03:00
Sebastian Dröge
d75334456d omx: Let base classes handle EOS 
https://bugzilla.gnome.org//show_bug.cgi?id=734774
 2014-08-14 17:36:11 +03:00
Sebastian Dröge
4593f434a0 omxbufferpool: Copy buffers if the stride does not match and we can't use video meta 
https://bugzilla.gnome.org/show_bug.cgi?id=731672
 2014-06-24 15:11:53 +02:00
Aurélien Zanelli
58aa603b36 omxvideodec: fix a query leak 
Also add a debug message if query fails.

https://bugzilla.gnome.org/show_bug.cgi?id=731898
 2014-06-20 11:54:25 +02:00
Aurélien Zanelli
ad969ffda3 omxvideodec: release frames with old PTS to avoid memory issue 
Interlaced stream could make the decoder use two input frames to produce
one output frame causing the gstvideodecoder frame list to grow.
Assuming the video decoder output frame in display order rather than in
decoding order, this commit add a way to release frames with PTS less
than current output frame.

https://bugzilla.gnome.org/show_bug.cgi?id=730995
 2014-06-04 16:36:02 +02:00
Aurélien Zanelli
3ed713db0d omxvideodec: add missing stream unlock in error path 2014-06-02 19:28:51 +02:00
Sebastian Dröge
bf7e6109d9 omxvideodec: Don't leak buffer pool config in error cases 
CID 1216158
 2014-05-26 11:03:03 +02:00
Sebastian Dröge
e542177c65 omxvideodec: Make output buffer pointer always initialized 
CID 1214605
 2014-05-19 09:08:33 +02:00
Sebastian Dröge
c2e5dca5f0 omxvideodec: Check return value of gst_buffer_map() 
CID 1214599
 2014-05-19 09:06:42 +02:00
Sebastian Dröge
429b0e1e27 omxvideodec: Check return value of gst_omx_port_set_enabled() for errors 
CID 1214589
 2014-05-19 09:04:09 +02:00
Sebastian Dröge
e08c0dc88a omxvideodec: Check return values of buffer pool config parsing functions 
CID 1214588
 2014-05-19 09:01:46 +02:00
Sebastian Dröge
4e20116bc6 omx: Add a hack for not disabling the output port after set_format until the output format is known 
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
 2014-05-15 10:59:35 +02:00
Sebastian Dröge
cfbf5bf16d omxvideodec: Set nTickCount based on the buffer's duration instead of something wrong 2014-05-10 22:47:56 +02:00
Julien Isorce
bdec8c0595 omxvideodec: can negotiate caps with memory:EGLImage feature when using EGLImage allocator 
Previously when using gst EGLImage allocator the caps was
video/x-raw, format=RGBA instead of
video/x-raw(memory:EGLImage), format=RGBA

Kepp previous behavior in case negotiation fails with caps feature.
It means it will still have a chance to use EGLImage even if the
feature is not in the caps.

https://bugzilla.gnome.org/show_bug.cgi?id=729196
 2014-05-02 18:00:48 +01:00
Aurélien Zanelli
da4cf3da1f omxvideodec: don't unref caps before logging field from it 
https://bugzilla.gnome.org/show_bug.cgi?id=728322
 2014-04-17 09:33:47 +02:00
Julien Isorce
499fb23e9c omxvideodec: use new libgstgl API since libgstegl has been removed 
There is no point to retrieve a ref/unref type
instead of an EGLDisplay directly. It's like for EGLImage.

https://bugzilla.gnome.org/show_bug.cgi?id=703343
 2014-04-15 18:32:12 +01:00
Julien Isorce
d4bb7cb4c7 configure.ac: check for libgstgl since libgstegl has been removed 
https://bugzilla.gnome.org/show_bug.cgi?id=703343
 2014-04-15 18:32:12 +01:00
Aurélien Zanelli
1b6879921c omxvideodec: add support of more color format 
Add support for ABGR, ARGB, RGB16, BGR16, YUY2, UYVY, YVYU, GRAY8 and
NV16 color format.
 2014-04-15 15:09:24 +01:00
Aurélien Zanelli
f5f876f681 omxvideodec: simplify color format conversion in fill_buffer function 2014-04-15 15:09:24 +01:00
Aurélien Zanelli
c115da9fd5 omx: add an helper to convert OMX color format to GStreamer color format 2014-04-15 15:09:23 +01:00
Josep Torra
718fd1bb93 omxvideodec: Implement pipeline draining to support adaptive scenarios 
When draining due a format change also drain
the pipeline to reclaim back all buffers.

https://bugzilla.gnome.org/show_bug.cgi?id=726107
 2014-03-28 11:40:20 +00:00
Josep Torra
73d83f311c omxvideodec: fixes race condition during seeks 
Acording 6.1.3 Seek Event Sequence in the OpenMAX IL 1.1.2 spec
document in order to flush the component it needs to be in
paused state.

https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:07:25 +00:00
Julien Isorce
39ca9f980e omxvideodec: use flush because reset is deprecated 
https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:07:15 +00:00
Julien Isorce
777411c286 omxvideodec: populate the most downstream output port on reset 
Make seeking work when using egl_render component

https://bugzilla.gnome.org/show_bug.cgi?id=726038
 2014-03-25 16:06:51 +00:00
Christian König
651e67e32d omxvideodec: add missing unlock in the error path 
Signed-off-by: Christian König <christian.koenig@amd.com>

https://bugzilla.gnome.org/show_bug.cgi?id=726958
 2014-03-24 11:11:39 +00:00
Sebastian Dröge
a04ef276e5 omx: Rename function from _4_ to _for_ for clarity 2014-03-12 12:47:34 +01:00
Christian König
6bf4d9a498 omxvideo: start sharing more code between video decoder and encoder 
Identical functionality spread of two different components.
We can't use a common base class because of different inheritance,
but let's try to share the code anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=726024
 2014-03-12 12:47:09 +01:00
Christian König
325c90f99d omxvideodec: separate the buffer pool from the decoder 
https://bugzilla.gnome.org/show_bug.cgi?id=726025
 2014-03-12 12:42:03 +01:00
Christian König
de5f940186 omx: simplify tunnel functions 
Specifying the component is error prone and unnecessary.

https://bugzilla.gnome.org/show_bug.cgi?id=726021
 2014-03-12 08:48:46 +01:00
Christian König
14a0da437f omxvideodec: fix memory leak in gst_omx_video_dec_allocate_output_buffers 
https://bugzilla.gnome.org/show_bug.cgi?id=725907
 2014-03-08 15:23:59 +01:00
Christian König
5ac0fe2108 omxvideodec: fix memory leak gst_omx_video_dec_negotiate 
https://bugzilla.gnome.org/show_bug.cgi?id=725907
 2014-03-08 15:22:15 +01:00
Christian König
2cfe70ed5d omxvideodec: simplify _find_nearest_frame 
No need to make it more complicated and error prone than
necessary. Also give the function a gst_omx_video_dec prefix
to distinct it from the encoder function.

https://bugzilla.gnome.org/show_bug.cgi?id=724236
 2014-03-03 20:12:51 +01:00
Christian König
bf0d2614c3 omxvideodec: remove dead code 
This code doesn't seems to be used for quite a while,
remove it before it starts to rot.

https://bugzilla.gnome.org/show_bug.cgi?id=724236
 2014-03-03 20:12:35 +01:00
Christian König
0a8cfcde87 omxvideodec: fix startup race condition 
The reset function shouldn't start the src pad
loop if it wasn't started before.

Signed-off-by: Christian König <christian.koenig@amd.com>
 2014-03-02 12:08:09 +01:00
Sebastian Dröge
1bf4edf721 omx: Don't handle FLUSHING and NOT_LINKED as errors 
Also don't stop the task on NOT_LINKED. We're not a demuxer.
 2014-01-25 17:44:57 +01:00
Tim-Philipp Müller
498b74ab6a omx: don't use the 'z' modifier to print size_t 
gcc will warn in some cases even if the size of the type
is exactly that of size_t on the platform.

https://bugzilla.gnome.org/show_bug.cgi?id=699008
 2013-08-20 16:00:07 +01:00
Josep Torra
f3f9330332 omx: Take lock on EOS to update the flow return value 
Fixes "GThread-ERROR **: file gthread-posix.c: line 171
(g_mutex_free_posix_impl): error 'Device or resource busy' during
'pthread_mutex_destroy ((pthread_mutex_t *) mutex)'" in _finalize.
 2013-05-20 12:06:34 +02:00
Josep Torra
64ef1f0e11 omxvideodec: Redesign video size change reconfiguration code 
Ensure stop the decoder before clossing the tunnel.
 2013-05-10 12:25:07 +02:00
jitendra
715b44ea66 omx: Add pads based on element type 
This allows to later add sources and sink that only have a srcpad
or sinkpad.

https://bugzilla.gnome.org/show_bug.cgi?id=699754
 2013-05-06 16:20:20 +02:00
Tim-Philipp Müller
a2db76b048 Check for gstreamer-egl 
And don't use if not available.

https://bugzilla.gnome.org/show_bug.cgi?id=697574
 2013-04-23 11:05:19 +01:00
Tim-Philipp Müller
2cbbab3128 omx: more printf format fixes 
Fix printf formats again, so that gst-omx compiles warning-
free on the Raspberry Pi as well. Unfortunately OMX_UINT32
maybe be typedefed to uint32_t or unsigned long, which
doesn't work well with our debugging printf format strings,
so just use %u for those and cast to guint.
 2013-04-18 23:10:13 +01:00
Josep Torra
9d0763a91d omxvideodec: don't use 'self->dec_out_port' anymore and use just 'port' 
Fixes some criticals.
 2013-04-18 16:03:56 +02:00
Josep Torra
9de6308382 omxvideodec: fixes 'port' may be used uninitialized in this function 2013-04-18 15:21:32 +02:00
Josep Torra
4974f75d91 omxvideodec: silence warnings building for RPI related to 'vcos_*' 2013-04-18 12:03:31 +02:00
Josep Torra
ae3454683e omxvideodec: Use new type from libgstvideo 2013-04-18 11:45:50 +02:00
jitendra
960590f92f omx: Disable output port before transition to idle state 
https://bugzilla.gnome.org/show_bug.cgi?id=698109
 2013-04-16 12:46:48 +02:00
Tim-Philipp Müller
0c08d375f4 omx: fix printf formats in debug messages 
OMX_U32 is typedefed to an unsigned long,
OMX_TICKS to a 64-bit integer.
 2013-04-08 17:02:32 +01:00
Josep Torra
16cf5d77db omxvideodec: use the correct printf format in a debug message 2013-04-08 16:52:19 +02:00
Josep Torra
c46a6a757e omxvideodec: use the correct OMX_IndexParam value 
Fixes playback is not smooth in the EGL path.
 2013-04-08 16:31:33 +02:00
Sebastian Dröge
31159a9b36 omxvideodec: Don't use API that is not in master yet 
It's not really needed here yet, will be needed in future versions
 2013-04-05 13:45:24 +02:00
Sebastian Dröge
8a1bb1b4a3 omxvideodec: Add support for egl_render on RPi 2013-03-26 14:00:03 +01:00
Sebastian Dröge
4483581e2a omx: Add more constraints to the default sink template caps 2013-03-19 13:28:30 +01:00
Sebastian Dröge
e533da2b22 omxvideodec: Set ENDOFFRAME flag for the end of frames 2013-03-19 12:55:09 +01:00
Josep Torra
a5778efe16 omx: Clarify that loop task is also paused in EOS 2013-03-16 10:00:24 +01:00
Sebastian Dröge
2b580837f5 omxvideodec: Make sure that the first frame we pass to OpenMAX is a sync frame 2013-03-15 14:09:45 +01:00
Sebastian Dröge
e1f94660f7 omx: Stop output port task after draining 2013-03-15 11:46:34 +01:00
Sebastian Dröge
84c6fd44d2 omxvideodec: Deallocate output buffers with the right function 2013-03-15 10:38:58 +01:00
Sebastian Dröge
047b3735cf omxvideodec: Don't interpolate timestamps 
We will get exactly one frame per input buffer and assigning
timestamps between frames if more than one OMX buffer is required
per frame easily confuses timestamp tracking in OMX.
 2013-03-15 09:51:42 +01:00
Sebastian Dröge
c59d8930ac omxvideodec: Give the codec_data the timestamp of the first frame and no duration 2013-03-15 09:51:34 +01:00
Sebastian Dröge
bda1e97abd omxvideodec: Simplify bufferpool implementation 2013-03-14 14:51:32 +01:00
Sebastian Dröge
9128ba5018 omxvideodec: Improve min/max buffer counts handling 2013-03-14 12:52:46 +01:00
Sebastian Dröge
22dce51dd4 omx: Handle the OMX_EventBufferFlag to detect EOS too 2013-03-14 12:51:54 +01:00
Sebastian Dröge
1ebd34e637 omxvideodec: Make sure to always get the right buffer 2013-03-13 09:38:03 +01:00
Sebastian Dröge
f4ad6e0858 omxvideodec: Make sure the buffer is released to the pool if it's not the one we wanted 2013-03-13 09:37:58 +01:00
Sebastian Dröge
ef357cce80 omxvideodec: Drop too late frames instead of finishing them 2013-03-13 09:37:43 +01:00
Sebastian Dröge
fa7be0b618 omx: Release buffers to the correct port 2013-03-13 09:37:36 +01:00
Sebastian Dröge
448ea34b75 omxvideodec: Don't provide buffers to downstream 
This only works reliable if we have a way to tell downstream to
release all our buffers for reconfiguration.
 2013-03-11 10:39:25 +01:00
Sebastian Dröge
00be69f4a0 omxvideodec: Disable output port when setting a new format 
Based on a patch by Josep Torra <n770galaxy@gmail.com>
 2013-03-11 10:22:07 +01:00
Sebastian Dröge
65174bbd7f omx: Catch errors when releasing buffers to a port and handle them 2013-03-11 10:04:10 +01:00
Josep Torra
bd071327da omx: Fix deadlock in encoders and add explainatory comments. 2013-03-09 14:14:40 +01:00
Josep Torra
7423e3e023 omxvideodec: fix printf format identifier 2013-03-09 13:27:08 +01:00
Josep Torra
cde5df17fa omx: Minor changes on debuging info 2013-03-09 13:24:30 +01:00
Josep Torra
6d8bf76391 omxvideodec: avoid a deadlock 2013-03-09 13:24:16 +01:00
Sebastian Dröge
aa6be53375 omxvideodec: Don't forget to populate output port 2013-03-08 15:58:01 +01:00
Sebastian Dröge
c014b1c9a3 omx: Flush and stop srcpad when configuring new caps 2013-03-08 15:50:20 +01:00
Sebastian Dröge
ed0de9d699 omxvideodec: Only negotiate a color format with downstream on the initial caps 2013-03-07 17:38:40 +01:00
Sebastian Dröge
bbd30a96bd omxvideodec: Make sure the output port is disabled while we allocate buffers 2013-03-07 17:29:43 +01:00
Sebastian Dröge
0cd96e8c6b omxvideodec: Add buffer pool for sharing OpenMAX memory with downstream 2013-03-07 14:10:12 +01:00
Sebastian Dröge
7a1eaec3b9 omx: Add timeout to the flush operation and move buffer populating to a separate function 2013-03-07 13:57:00 +01:00
Sebastian Dröge
60861f3990 omx: Do number of buffers configuration explicitely 2013-03-07 13:56:44 +01:00
Josep Torra
cc495aeb16 omxvideodec: fixes reconfiguration 
Avoid having fixed fields from previous caps on reconfiguration.
 2013-03-07 11:24:54 +01:00
Sebastian Dröge
687a188dad omxvideo{dec,enc}: Don't use the input state if it wasn't set yet 2013-03-01 11:44:17 +01:00
Sebastian Dröge
63e0d61971 omxvideodec: Only enable the output port after we know the output format 2013-03-01 11:21:25 +01:00