Tim-Philipp Müller
9ec99ac6f2
analyticsmeta: fix g-ir-scanner warnings
...
Fix
gstanalyticsmeta.c:134: Warning: GstAnalytics: "@instance"
parameter unexpected at this location
warning (caused by the extraneous empty line in the doc chunk)
and align function arguments with documentation and header file
(handle -> instance).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6585 >
2024-04-10 00:46:42 +00:00
Seungha Yang
ff754dca79
ccconverter: Fix caps leak and remove unnecessary code
...
The removed code does the exactly same thing as the below code
except for leaking caps
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6548 >
2024-04-09 18:26:18 +00:00
Seungha Yang
0cc206e939
qsvdecoder: Release too old frames
...
Release too old frames manually.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3163
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6583 >
2024-04-09 16:49:47 +00:00
Arun Raghavan
82b10e57b0
pulsesink: Re-enable emission of stream status messages
...
This was disabled almost 10 years ago because we were missing libpulse API to
avoid a deadlock. That was fixed quite a long time ago, so let's enable this
again. The defer counter becomes an atomic, as we no longer have a threaded
mainloop lock protecting it.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3444
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6500 >
2024-04-09 15:50:04 +00:00
Philippe Normand
8d3e7689e1
vpxenc: Include vpx error details in errors and warnings
...
The vpx_codec_t err_detail string usually provides additional context about the
error, so include it in GStreamer warnings and errors, when it's not NULL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6573 >
2024-04-09 14:40:21 +00:00
Jochen Henneberg
6e33a5da14
qt6: Fixes for dummy texture
...
* RED_OR_ALPHA8 will map value to alpha for OpenGL, use R8 to avoid
2nd shader
* Determine texel size for proper texture memory preparation
* QByteArray::fromRawData() does shallow copy and thus leads to use of
corrupted memory
* Make sure RGBA dummy texture is fully opaque
* QRhiTexture::create() must be called to allocate texture resources
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6578 >
2024-04-08 20:05:10 +02:00
Jochen Henneberg
87dc22b053
qt: Fixup for dummy textures
...
* Initialize dummy texture Ids
* Ensure YUV->RGB matrix set for dummy textures
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6578 >
2024-04-08 20:05:09 +02:00
Seungha Yang
448a461a40
d3d12converter: Simplify root signature build
...
D3DX12SerializeVersionedRootSignature() helper method will translate
RS 1.1 into 1.0 version if needed
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6557 >
2024-04-08 13:24:20 +00:00
Sebastian Dröge
0596871b98
rtpbin: Don't re-use a variable for a completely different purpose temporarily
...
During RTP-Info synchronization, clock_base was temporarily switched
from the actual clock-base to the base RTP time and then back some lines
later.
Instead directly work with the base RTP time. The comment about using a
signed variable for convenience doesn't make any sense because all
calculations done with the value are unsigned.
Similarly, rtp_clock_base was overridden with the rtp_delta when
calculating it, which was fine because it is not used anymore
afterwards. Instead, introduce a new variable `rtp_delta` to make this
calculation clearer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6536 >
2024-04-08 10:29:54 +00:00
Sebastian Dröge
11ce209ea0
rtpbin: Convert clock-base to extended RTP timestamp correctly
...
It's not in the same period as the current RTP base time but always in
the very first period. This avoids using it again at a much later time.
The code in question is only triggered with rtcp-sync=rtp-info.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6536 >
2024-04-08 10:29:54 +00:00
Sebastian Dröge
0c34c85f7a
rtpjitterbuffer: Use an extended RTP timestamp for the clock-base
...
It is compared to other extended RTP timestamps all over rtpjitterbuffer
and since 4df3da3bab
the initial extended RTP timestamp is not equal
anymore to the plain RTP time.
Continue passing a non-extended RTP timestamp via the `sync` signal for
backwards compatibility. It will always be a timestamp inside the first
extended timestamp period anyway.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6536 >
2024-04-08 10:29:54 +00:00
Sebastian Dröge
4a4eb56fc2
rtspsrc: Optionally timestamp RTP packets with their receive times in TCP/HTTP mode
...
Until https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6509
this was accidentally done inside rtpjitterbuffer for many years, and
doing so potentially solves problems on some streams while introducing
problems on others.
Make this configurable on rtspsrc and default to not set timestamps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6529 >
2024-04-08 08:34:38 +00:00
Jan Schmidt
362a73218b
webrtc.js: Fix a small typo
...
Fix a typo caused by referencing the event struct after
it's already been destructured
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6547 >
2024-04-07 21:50:17 +00:00
Håvard Graff
b57944efda
examples/gl/cocoa: add an example of a failing scenario with glimagesink
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5708 >
2024-04-07 21:03:23 +00:00
Daniel Morin
93b8a1777d
ci/fluster: Revert results for visl
...
- Make test pass without h264parse AU boundary detection changes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:23 +00:00
Daniel Morin
0c8e4d4a2c
h264parser: maintain API changes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:23 +00:00
Daniel Morin
71659f2545
Revert "h264parse: test - AU align with SEI between frame slices"
...
This reverts commit 533f814fd9
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:23 +00:00
Daniel Morin
e57f561a8e
Revert "h264parse: Improved AU boundary detection"
...
This reverts commit 49f200cb54
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:23 +00:00
Daniel Morin
694c6e77b1
Revert "h264parse: Remove dead code"
...
This reverts commit 141cd38715
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:22 +00:00
Daniel Morin
ac3272db40
Revert "h264parse: Fix AU collection"
...
This reverts commit 495390f63a
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:22 +00:00
Daniel Morin
64c2c8d542
Revert "h264parse: Remove un-needed check on SPS state"
...
This reverts commit 73dedf9a51
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:22 +00:00
Daniel Morin
6ff1973b5b
Revert "h264parse: use AUD to detect first VCL NAL"
...
This reverts commit 90a3b63eed
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:22 +00:00
Daniel Morin
0bc5d97321
Revert "h264parse: correct NAL mode backlog processing"
...
This reverts commit b2098849dc
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6540 >
2024-04-07 15:25:22 +00:00
Jan Schmidt
832a517965
rtpjitterbuffer: Don't use estimated_dts to do default skew adjustment
...
When the buffer DTS is estimated based on arrival time at the
jitterbuffer (rather than provided on the incoming buffer itself),
it shouldn't be used for skew adjustment. The typical case is
packets being deinterleaved from a tunnelled TCP/HTTP RTSP stream,
and the arrival times at the jitter buffer are not well enough
correlated to usefully do skew adjustments.
This restores the original intended behaviour for the 'estimated dts'
path, that was broken years ago during other jitterbuffer refactoring.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6509 >
2024-04-07 12:24:58 +00:00
Sebastian Dröge
ee566b8960
flac: Add wrap file and add fallback for it to the flac plugin
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6553 >
2024-04-07 11:12:51 +00:00
Tim Blechmann
1c9fe19b23
v4l2: enforce a pixel aspect ratio of 1/1 if no data are available
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6242 >
2024-04-07 10:14:18 +00:00
Ruben Gonzalez
27fc705bb2
CI: Use G_DEBUG=fatal_criticals and --gst-disable-registry-fork with gst-inspect-1.0 test
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5704 >
2024-04-07 06:36:44 +00:00
Philipp Zabel
6f9872cb56
v4l2: allocator: Fix unref log/trace on memory release
...
Use gst_object_unref() instead of g_object_unref() in
gst_v4l2_allocator_release(), so refcounting log and
tracer get to know about this unref.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6551 >
2024-04-06 11:44:27 +00:00
Edward Hervey
eedfb5e6d7
videoparsers: Demote CC warning message
...
Another warning message which isn't fatal and therefore should just be a DEBUG
line.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6550 >
2024-04-06 06:11:03 +02:00
Seungha Yang
f59c43c50f
d3d12device: Fix typo in object name
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6549 >
2024-04-06 01:14:56 +09:00
Elliot Chen
e4ee4ca716
v4l2: fix error in calculating padding bottom for tile format
...
This is a regression while porting to arbitrary tile dimensions
introduced in !3424 .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6480 >
2024-04-05 13:28:47 +00:00
Elizabeth Figura
c308f013a7
atdec: Handle channel counts greater than 2
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6157 >
2024-04-05 06:54:24 +00:00
Elizabeth Figura
277d6ddf22
atdec: Use gst_audio_decoder_set_output_caps() directly
...
The code currently sets the same caps in two different ways, and neither of them correctly handle the channel mask.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6157 >
2024-04-05 06:54:24 +00:00
Seungha Yang
bc8a3ca526
avviddec: Fix AVPacket leak
...
av_packet_unref() does not release allocated memory.
av_packet_free() is the correct free function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6544 >
2024-04-04 19:39:09 +00:00
Mathieu Duponchelle
4b93581c15
ajasrc: always post details about detected format
...
.. instead of only when there is a mismatch.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6438 >
2024-04-04 18:23:31 +00:00
Mark Nauwelaerts
e019093fbf
adapter: align documentation to actual behavior
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6535 >
2024-04-04 16:55:35 +00:00
Sebastian Dröge
16f69acf30
wavpackparse: Use an unsigned integer for the block size calculations
...
It's never negative.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6498 >
2024-04-04 15:10:02 +00:00
Sebastian Dröge
eefb7c1638
wavpackparse: Fix potential integer overflow on ID_ODD_SIZE blocks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6498 >
2024-04-04 15:10:02 +00:00
Sebastian Dröge
6402978a48
wavpackparse: Explicitly handle ID_WVX_NEW_BITSTREAM
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6498 >
2024-04-04 15:10:02 +00:00
Sebastian Dröge
2dde87710c
typefind: Handle WavPack block sizes > 131072
...
These are valid nowadays.
Also handle ID_ODD_SIZE and ID_WVX_NEW_BITSTREAM. The parser already
handles the former but not the latter.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3440
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6498 >
2024-04-04 15:10:02 +00:00
Robert Mader
0a26a92b2b
jpegparse: turn some bus warnings into object ones
...
For some cameras `gst_jpeg_parse_app0()` fails on a invalid segment.
While this is likely a driver or firmware bug that should be addressed
accordingly, it's not fatal and likely does not deserve a bus message on
every frame, flooding journals.
Turn down the volume of the warnings by turning them into object
warnings. If we conclude that in some cases we'd still want bus
warnings, they can be done more fine-grained in the
`gst_jpeg_parse_appX()` functions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6490 >
2024-04-04 11:35:07 +00:00
Sebastian Dröge
4b5a265571
pbutils: descriptions: Don't warn on MPEG-1 audio caps without layer field
...
While this is not ideal and won't give too accurate codec descriptions,
it is what tsdemux produces.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6511 >
2024-04-04 09:39:49 +00:00
Ruben Gonzalez
a780b9ed13
subprojects: update glib-networking wrap to 2.78.1
...
Using same mayor/minor version than glib wrap
Origin: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5704 >
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6533 >
2024-04-03 18:49:08 +00:00
Víctor Manuel Jáquez Leal
fc0ef6ede6
vkh265dec: add missing VPS parameter
...
and fix coded size
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6400 >
2024-04-03 16:46:14 +00:00
Víctor Manuel Jáquez Leal
a6608d72e6
vkh26xdec: implement close() vmethod
...
Since a validation layer error is signaled at EOS because it's required to wait
for the last frame to be processed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6400 >
2024-04-03 16:46:14 +00:00
Víctor Manuel Jáquez Leal
316ca23cab
vkh26xdec: remove unused variables
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6400 >
2024-04-03 16:46:14 +00:00
Víctor Manuel Jáquez Leal
3dd5e0d46f
vkh265dec: fix resource info structure when layered DPB
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6400 >
2024-04-03 16:46:14 +00:00
Robert Rosengren
8c5203ba0e
audioringbuffer: set waiting to 0 when signaling
...
Reset the waiting thread counter in all places to be consistent
when sending signal for the audio ring buffer. This fix applies it to
pause, stop and release, which are states that will go into a callback
of the subclass. Having the waiting counter reset will avoid having
executing thread of the same subclass trying to take the mutex when
callong gst_audio_ring_buffer_advance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6195 >
2024-04-03 15:09:00 +00:00
Víctor Manuel Jáquez Leal
d18d6a70ac
examples: vaenc-dynamic: support target percentage change in QVBR
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6465 >
2024-04-03 13:51:31 +02:00
Víctor Manuel Jáquez Leal
a9d839b8a3
examples: vaenc-dynamic: ignore bitrate change with ICQ too
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6465 >
2024-04-03 13:51:31 +02:00