mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 03:29:50 +00:00
Code Issues 1 Projects Releases Wiki Activity
121380 commits 44 branches 1513 tags 342 MiB
Commit graph

121380 commits

This branch
This branch
All branches
Author SHA1 Message Date
Edward Hervey
67c4c35fb7 mxfdemux: Remove useless check 
values will always be positive

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
5bc4ebfe61 speed: Refactor event handler 
To avoid fallthrough issues which were tricky to fix

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
21d81d25ec bad: Clearly specify fallthrough in switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
a9984a0003 vorbisdec: Fix check for "-1" bitrate values 
The check is exactly the same, but more explicit.

Original commit that introduced the check is
20fb58be19:
---
vorbisdec: don't put invalid bitrate values into the taglist

Bitrates are stored as 32-bit signed integers in the vorbis
identification headers, but seem to be read incorrectly,
namely as unsigned 32-bit integers, into the vorbis structure
members which are of type long, which makes our check for
values <= 0 fail with files that put -1 in there for unset
values.
---

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
8b9ac40710 good: Enable extra warning flags 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
47b723c6e1 splitmuxsink: Fix GST_(S)TIME_{ARGS|FORMAT} usage 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
8bc17b58a2 good: Clearly specify fallthrough in switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
2a6c1bbb01 matroska: Reorder switch/case for parsing 
Just makes it clearer

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
5d69f2bc36 qtmux: Fix GST_STIME_ARGS usage 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
b0f527a79e adaptivedemux2: Fix CLAMP usage 
It's a positive value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
02df2a5e9a adaptivedemux2: Remove useless ABS 
Just compare the difference (in the right order)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
9f4f500543 filesrc: Properly handle lseek return value 
On windows we use _lseeki64 which returns a guint64.

The only error code lseek and _lseeki64 return is a casted -1, therefore just do
that to handle all platforms

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
77ad891e68 test: Remove always-true assertion 
The offset is not deterministic

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
72df7ab3bd test: Avoid type-limit issue 
```
../subprojects/gstreamer/tests/check/elements/filesink.c: In function ‘test_seeking’:
../subprojects/gstreamer/tests/check/elements/filesink.c:92:23: warning: comparison of unsigned expression in ‘< 0’ is
  always false [-Wtype-limits]

   92 |         for (i = 0; i < num_bytes; ++i)                                 \
      |                       ^
../subprojects/gstreamer/tests/check/elements/filesink.c:266:3: note: in expansion of macro ‘PUSH_BYTES’
  266 |   PUSH_BYTES (0);
      |   ^~~~~~~~~~
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
a81371bf8b base: Enable more warning flags 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
568ae91a2a compositor: Don't use CLAMP for unsigned values 
Just use MIN, we already know it's above 0

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
c0d35e14a5 gst-play: Move esc-handling to the right place 
It's meant to fall through to the default handler of the switch (for
debugging). Some intermediary commits broke that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:45 +00:00
Edward Hervey
989539830d libvisual: Fix for libvisual headers 
They use old style definition

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
9e58164cfb base: Do not use old-style definition 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
319ff17300 base: Fix fallthrough declarations 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
0e8f8dfe15 gstreamer: Add more warning flags 
See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4123

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
316722d7c9 gstptpclock: Fix GST_STIME_ARGS usage 
It requires a signed value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Edward Hervey
39a1b61469 gstreamer: Make switch passthrough as such 
vasnprintf requires special handling since the following 'case' is #ifdef'ed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
 2025-01-13 12:51:44 +00:00
Carlos Bentzen
b83b73841d webrtc: fix duplicate payload types with RTX and multiple video codecs 
Before this patch, there could be duplicate payload types in offers that
have, within a media section, multiple codecs and RTX enabled:

```
m=video 9 UDP/TLS/RTP/SAVPF 96 97 97 <-- HAS DUPLICATES
a=sendrecv
a=rtpmap:96 VP8/90000
a=rtcp-fb:96 nack
a=rtcp-fb:96 nack pli
a=rtcp-fb:96 ccm fir
a=rtcp-fb:96 transport-cc
a=rtpmap:97 H264/90000
a=rtcp-fb:97 nack
a=rtcp-fb:97 nack pli
a=rtcp-fb:97 ccm fir
a=rtcp-fb:97 transport-cc
a=rtpmap:97 rtx/90000  <--------- PT IS DUPLICATE
a=fmtp:97 apt=96
```

Fix this by populating the media_mapping array with all media formats
rather than only the first one. The added test case reproduces the issue,
which fails without this patch.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8259>
 2025-01-13 10:11:59 +00:00
Edward Hervey
0891a0e5eb wasapi: Use signed value for can_frames 
The can retrieval function can return negative values (which will be properly handled)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
aedb587616 amfcodec: Add missing break statement 
Setting frame-sad would also set ltr

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
8b62792e5c d3d12: Add missing breaks to switch/case 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
916774b4f0 h265bitwriter: Don't use type too small 
The computed `coef_val` could exceed the maximum range of a gint8. Use a bigger
one, the checks after will ensure it's properly cropped/padded

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
5bb22c24dc mpegts: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
b78c119a42 msemediabuffer: Fix ASCII character detection 
Use glib function. The previous check was checking whether a signed int was
lower than its limit (which ... is always TRUE).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
efbe1e96ca msesourcebuffer: Fix unsigned value handling 
Use the explicit valid clocktime handler instead

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
2f1f44cdc7 ristsink: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
a0f50df7a0 splitmuxsink: Fix wrong usage of GstClockTime vs GstClockTimeDiff 
This could potentially have caused issues (because of the rest of the code using
checks for signed invalid values on a unsigned value)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:01 +00:00
Edward Hervey
2e6b98ad89 splitmuxsrc: Add missing break 
This would cause the reconfigure path to be called

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
0ee882cfb9 adaptivedemux2: Add missing break 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
32ebee5594 adaptivedemux2: Fix usage of GstClockTime vs GstClockTimeDiff 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
65b4d26db6 audiorate: Fix unsigned integer comparision 
next_offset uses a magic "-1" value for unset values. Use that value and not
checking whether it's positive (it always is, it's unsigned)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
344ef36b5a videorate: Avoid overflow in calculations 
base_ts and next_end_ts are both guint64. Use explicit check to avoid "negative"
timestamps (which would overflow, not be negative).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
84f995dd90 test: Fix unsigned integer usage 
num_queued is unsigned, it'll never be below 0.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Edward Hervey
9656ae6c0b decodebin3: Add missing break in switch 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8286>
 2025-01-13 08:08:00 +00:00
Ruben Gonzalez
da5a4f7820 videoparsers: Fix indentation 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8281>
 2025-01-12 22:51:44 +00:00
Sebastian Dröge
10f870ac5c decklinkaudiosink: Don't crash if started without corresponding video sink 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8253>
 2025-01-12 18:48:36 +00:00
Andrew Yooeun Chun
26e769589a basetransform: fix incorrect logging inside gst_base_transform_query_caps 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7381>
 2025-01-12 03:41:02 +00:00
Sebastian Dröge
c513340c89 ci: Update to Rust 1.84 and cargo-c 0.10.8 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8285>
 2025-01-11 17:38:00 +02:00
Edward Hervey
6d30b82054 splitmuxsrc: Ensure only a single stream-start event is pushed 
Since we are simulating a single output, we want to ensure only a single
stream-start is pushed downstream. We do *not* want to send a (potentially) new
stream start event after flushing (like after seeks).

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4146

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8252>
 2025-01-10 15:01:04 +00:00
Will Miller
05158769c3 rtpvp9pay: fix profile parsing 
Incorrect parsing of these bits meant that we were incorrectly parsing
the VP9 uncompressed bitstream header for some profiles, as the header
is of variable length and format depending on the profile. Amongst
various unintended effects, this caused the width and height from the SS
to be incorrectly parsed and set in the caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8275>
 2025-01-10 11:19:52 +00:00
L. E. Segovia
bc285dbbbe ges: Fix Xcode-provided Python library name fetching 
Both INSTSONAME and LDLIBRARY point to the Python interpreter, not to
libpythonX.Y.dylib, unlike the pythonX.Y-embed module Xcode provides.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8199>
 2025-01-10 00:08:56 +00:00
L. E. Segovia
06192c125b ges: Fix Python library name fetching on Windows 
The fix in 753aeccde7 is also needed here.

See #3368

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8199>
 2025-01-10 00:08:56 +00:00
Olivier Crête
1485a387a4 codec-utils: Add missing nullable annotation to new APIs 
Those APIs are documented to sometimes return NULL.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8271>
 2025-01-09 22:43:54 +00:00
Colin Kinloch
4a56c82f0c wayland: Print table split when DMABuf format changes 
The `zwp_linux_dmabuf_v1` doesn't specify an order for modifier events
to be sent.

In my case the linear format was sent last resulting in the first item
in each row being the previous format.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8272>
 2025-01-09 18:34:51 +00:00