Commit graph

5045 commits

Author SHA1 Message Date
Leo Singer
3f86f8cee1 gstinfo: fix compilation error if HAVE_REGISTER_PRINTF_SPECIFIER is undefined
Use #if HAVE_FOO instead of #ifdef HAVE_FOO.

Fixes #612733.
2010-03-12 19:05:16 +00:00
Benjamin Otte
8fe63000de plugins: Do not ever unload a plugin after calling into it
This is what can happen in a plugin_init function:
- An element based on GstBaseSink is registered
- Other elements fail to register
- The plugin_init function returns FALSE

Now if this the plugin is the first plugin to link against
libgstbase.so, it will have caused libgstbase.so to be loaded and static
strings from that library will have been added to gobject while
registering GstBaseSink.

So unloading the plugin will cause those strings to go stale and the
next plugin using GstBaseSink will crash. So we must not unload modules
after calling into them ever.

https://bugzilla.redhat.com/show_bug.cgi?id=572800
2010-03-12 16:56:56 +01:00
Edward Hervey
bbe26d36ba gst: Use G_VALUE_COLLECT_INIT if available
This brings total call speedups between 5% and 25%.
gst_caps_set_simple_valist: +5%
gst_structure_set_valist: + 10%
gst_structure_id_set_valist: +25%
gst_tag_list_add_valist: +5%

Measured using valgrind when run over the discovery of 200 media files.

Fixes #610256
2010-03-12 10:01:47 +01:00
Thiago Santos
f563ac57f8 tags: Adds new geo location tags
Adds new tags GST_TAG_GEO_LOCATION_COUNTRY,
GST_TAG_GEO_LOCATION_CITY and GST_TAG_GEO_LOCATION_SUBLOCATION.

API: GST_TAG_GEO_LOCATION_COUNTRY
API: GST_TAG_GEO_LOCATION_CITY
API: GST_TAG_GEO_LOCATION_SUBLOCATION

Fixes #612410
2010-03-11 15:31:06 -03:00
Benjamin Otte
8fa19a360c win32: Add prototype for DllMain() 2010-03-11 18:37:24 +01:00
Edward Hervey
d60a3b8a59 gstreamer: remove unneeded casts
G_PARAM_SPEC_VALUE_TYPE does an expensive type check, whereas the
value_type field is a public field, so we can just use it directly.
2010-03-11 11:46:28 +01:00
Benjamin Otte
7e7f51f617 Fixes for -Wmissing-declarations -Wmissing-prototypes
Also adds those flags to the configure warning flags

https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-11 10:59:57 +01:00
Tim-Philipp Müller
8a4aed855a buffer: fix printf format
Use %u to print unsigned integers.
2010-03-11 09:39:23 +00:00
Stefan Kost
4ba031a7e2 i18n: define dummy ngettext if i18n is disabled.
We cannot blindly use gettext function and not define them when not using gettext.
2010-03-11 10:14:05 +02:00
Stefan Kost
59bf16352b i18n: fix the build with i18n disabled.
Don't include gettext.h if !ENABLE_NLS.
2010-03-11 10:04:27 +02:00
Stefan Kost
a184419ec5 buffer: allow configurable memory alignment. Fixes #596832
The alignment guaranteed by malloc is not always sufficient. E.g. vector
instructions or hardware subsystems want specifically aligned buffers. The
attached patch will use posix_memalign if available to allocate buffers.
The desired alignment can be set when running configure using the new
--with-buffer-alignment option.
2010-03-11 10:00:28 +02:00
Benjamin Otte
a9d1a493a7 Fixes for -Wwrite-strings
This changes some APIs in compatible ways:
- Some functions now take "const char *" arguments, not "char *"
- Some structs now have "conts char *" members, not "char *"
The changes may cause warnings when compiling with the right warning
flags. You've been warned.

Also adds -Wwrite-strings as a warning flag in configure.ac.

https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 20:50:10 +01:00
Benjamin Otte
22f87a529f Fixes -Wundef warnings
... and adds that flag to configure.ac

https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 20:46:09 +01:00
Benjamin Otte
3234c0128b Fixes for -Wold-style-definition
https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 20:45:35 +01:00
Benjamin Otte
e8f65e8bff Make code safe for -Wredundant-decls
Adds that warning to configure.ac

Includes a tiny change of the GST_BOILERPLATE_FULL() macro:
The get_type() function is no longer declared before being defined.

https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 20:45:33 +01:00
Benjamin Otte
f067d38d1d Make sure generated code doesn't run with -Werror
https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 19:27:09 +01:00
Benjamin Otte
0d4d5a57da Revert "registry: remove unused function"
Turns out  the function is not unused, but was in an #ifdef WIN32
section.
Whoops.

This reverts commit 57d5db424c.
2010-03-10 19:17:42 +01:00
Benjamin Otte
57d5db424c registry: remove unused function
Actually, there was two functions with the same name, but only one was
used.

https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 15:24:11 +01:00
Benjamin Otte
5c01dcb1f7 remove unused gst_element_default_error()
https://bugzilla.gnome.org/show_bug.cgi?id=611692
2010-03-10 15:24:11 +01:00
Jeremy Huddleston
fa0d218e4c utils: Use mulq instead of mul as some assemblers can't guess the size of the operands
Fixes bug #612370.
2010-03-10 07:17:07 +00:00
Sebastian Dröge
ce74a1ae19 build: Make some more rules silent if requested 2010-03-09 20:57:17 +00:00
Benjamin Otte
5c4044d5f9 Fix typos in documentation 2010-03-09 19:18:21 +01:00
Benjamin Otte
ec10b764b9 caps: Fail when fractions are followed by random text
Previous code treated "1/1yourmom" the same as "1/1" and "1wimsmom" the
same as "1". Now the code is stricter and will fail to convert a
fraction when followed by garbage text.
2010-03-09 19:18:21 +01:00
Benjamin Otte
4743e62be8 caps: Allow 1/max as the minimal fraction value > 0
This is useful for formats that require a valid framerate (like
theoraenc).
2010-03-08 22:26:34 +01:00
Wim Taymans
14113e8661 element: fix typo in comments 2010-03-08 17:36:02 +01:00
Tim-Philipp Müller
4cbf794b0e gstpoll: don't pass non-objects as first argument to GST_DEBUG_OBJECT()
This may cause crashes when logging is enabled, especially on windows.
It's not safe to pass random pointers to g_type_check_instance_is_a().

Fixes #611719.
2010-03-04 18:40:50 +00:00
Tim-Philipp Müller
0b954928c8 tags: try to make comment for translators more helpful 2010-03-01 12:02:44 +00:00
Johan Bilien
1d7afbd0f2 introspection: add annotation for gst_element_get_state
state and pending are "out" arguments.

Fixes #605189.
2010-02-18 01:28:57 +00:00
Stefan Kost
b45abd2710 taglist: remove blank lines in variable declarations 2010-02-17 09:50:35 +02:00
Tim-Philipp Müller
b6e061b4ea build: make sure gst-plugin-scanner gets installed where we expect it
Add check to make sure gst-plugin-scanner really gets installed where
we will look for it later, ie. paths and prefixes are set at configure
time and not specified via make.

Fixes #609941.
2010-02-16 11:33:19 +00:00
Tim-Philipp Müller
d82700f0c9 tags: wrap long string constants
And fix indenting issue
2010-02-15 00:29:37 +00:00
Tim-Philipp Müller
88f80996b8 tags: add some comments for translators so tag mnemonics get translated correctly
We want 'preview image' translated as a noun, not as 'preview [the] image'.
2010-02-15 00:21:43 +00:00
Tim-Philipp Müller
c802301b69 pad: don't print WARN debug statements for normal things like EOS 2010-02-15 00:08:16 +00:00
Tim-Philipp Müller
092cde0ff3 gst_private: MSVC doesn't seem to like #warning
Visual Studio complains about "invalid preprocessor command 'warning'"
even if the ifdef doesn't trigger, so just remove this again.
2010-02-10 14:28:05 +00:00
Tim-Philipp Müller
05e9dd968c Revert "docs: fix ASCII art so that iterators are aligned property to the diagram"
This reverts commit ae60d06e9e (fixes: #609166)
2010-02-07 10:04:09 +01:00
Tim-Philipp Müller
ae60d06e9e docs: fix ASCII art so that iterators are aligned property to the diagram 2010-02-01 23:47:18 +00:00
Tim-Philipp Müller
4878e95ff4 docs: add some more Since: markers to buffer list docs 2010-01-31 17:30:54 +00:00
Tim-Philipp Müller
6c6f20e0b6 init: don't spew warning about late g_thread_init()s if GLib >= 2.23.2
Late g_thread_init() is fine with newer GLib versions and done automatically
from g_type_init() there, so don't warn if the application hasn't called
g_thread_init() yet when gst_init() is called with new GLib versions.

Fixes #608398.
2010-01-30 13:45:58 +00:00
Wim Taymans
69c531784e pipeline: Take start_time after chaining up too
Refactor the code to take the current start_time when going to PAUSED.
Make sure we also call the start_time update code after we chained up to the
parent bin.

Fixes #607842
2010-01-28 15:55:27 +01:00
Stefan Kost
bd182e3ea0 bin: make a interface vmethod implementation static
This should not cause any troubles - the methods wasn't in any header.
2010-01-24 23:04:27 +02:00
Stefan Kost
9f26847fb1 childproxy: remove ; after } 2010-01-24 22:23:05 +02:00
Wim Taymans
f10c36de20 gstindex: retab .h file 2010-01-21 16:19:44 +01:00
Tim-Philipp Müller
f3d579362c pluginloader: fix compiler warning on win32
Move variable that's only used on unix into the unix block so that
the compiler doesn't complain about the unused variable on win32
(see #597662).
2010-01-20 10:58:29 +00:00
Tim-Philipp Müller
8967604053 pluginloader: try scanner set via env var before using the installed one
If the GST_PLUGIN_SCANNER environment variable is set, we should try
the scanner specified there first, to make sure the right scanner binary
is used for uninstalled setups and builds from source when there's
already an installed version.
2010-01-20 09:48:27 +00:00
Sebastian Dröge
f137d188cb build: Define G_THREADS_MANDATORY everywhere
We require threads to be supported in any case and defining this
will simplify the mutex, condition variable, etc. macros from gthread
to not always check if threads are really supported.

Fixes bug #607481.
2010-01-20 09:51:16 +01:00
Andoni Morales Alastruey
9909d3312f pluginloader: disable external plugin loader on Windows until it is ported properly
See #597662.
2010-01-20 01:48:56 +00:00
Tim-Philipp Müller
087aa6ced4 gst_private.h: make sure gst_private.h is included before glib.h
For the reason outlined at the beginning of gst_private.h (inline
functions in glib may need the g_log_domain variable). Also include
gst_private.h before using any G_OS_* defines, esp. in plugin loader.
2010-01-20 01:48:56 +00:00
Thijs Vermeir
053ada3308 gstpad: directly set the caps when pushing buffer with different caps.
This check is not necesarry as we are not negotiating anymore. And it can
be wrong if upstream can't produce this caps anymore, but downstream can
process them fine.
2010-01-19 14:13:25 +01:00
Sebastian Dröge
ed1247b561 miniobject: The GValue collection function can not assume that the destination is initialized
...and it will usually be either filled by zeroes or random values.

Fixes bug #607283.
2010-01-18 13:57:29 +01:00
Tim-Philipp Müller
51a462853a structure: remove superfluous guard against NULL
All callers of this static function already check for NULL-ness
themselves, so no need to do it again (and if we do it, we should
probably do so before dereferencing the pointer for the first time).
2010-01-16 19:44:35 +00:00
Tim-Philipp Müller
4cdf375b1a structure: micro-optimise some getters
Avoid checking the GType of the value twice (once on our side and
once in g_value_get_*()) by by-passing g_value_get() and accessing
the GValue structure directly.
2010-01-16 19:37:46 +00:00
Wim Taymans
17c98e3510 message: update docs a little 2010-01-15 18:36:43 +01:00
Sebastian Dröge
b3d30dd459 docs: Move field specific Since markers at the same line
Fixes gobject-introspection warnings about Since being defined multiple times.
2010-01-14 10:44:16 +01:00
Tim-Philipp Müller
4da2c6b380 registry: avoid some more unnecessary malloc/frees 2010-01-12 21:35:18 +00:00
Tim-Philipp Müller
5e47d24e1b registry: avoid some unnecessary strdup/free when reading the binary registry
Strings in the binary registry are NUL-terminated, so we can just use them
directly if we only need them temporarily, and avoid unnecessary mallocs
and frees.
2010-01-12 21:35:17 +00:00
Wim Taymans
2da06fb8d3 bus: whitespace fixes 2010-01-11 11:55:51 +01:00
Stefan Kost
3c09381cef utils: defer getting the classes until we actualy need them
This function has a lot of early returns. Give them soem more benefit.
2010-01-10 21:49:25 +02:00
Stefan Kost
5fa9d942e3 utils: avoid extra hop in gst_element_link
No need to call gst_element_link_pads_filtered with filter=NULL, which would
call gst_element_link_pads() in that way. Call it directly to save a call and
expensive gobject type checks.
2010-01-10 21:44:34 +02:00
Tim-Philipp Müller
1474e7a9fa docs: minor documentation fixes for recently-added tags
Mention the type of the tag in the gtk-doc blurb, so people know
which accessor API to use, and fix up the doc blurbs to match the
actual tag define.
2010-01-06 20:06:47 +00:00
Tim-Philipp Müller
27fd0b8d9c tags: fix up translated strings for some new tags
Fix up translated strings for some recently-added tags to match the
existing strings: we want short mnemonic-like strings here that start
with a lower case letter.
2010-01-06 20:04:15 +00:00
Tim-Philipp Müller
c6554049de registry: deprecate useless gst_registry_xml_{read|write}_cache()
The only reason these two functions are still around is that at some
point in the past they were in a public header, so we can't really
remove them now even though they should have been private all along
(and aren't really particularly useful). Since these are just empty
stubs now that do nothing but return FALSE and will be removed in
0.11 anyway, we may just as well deprecate them formally.
2010-01-06 19:19:40 +00:00
Tim-Philipp Müller
57abeb56a8 docs: add Since markers to task pool docs and document task function 2010-01-06 19:18:53 +00:00
Stefan Kost
1526e34687 docs: add missing returns: tag 2010-01-05 00:09:10 +02:00
Wim Taymans
1c5a6768cc buffer: remove unneeded casts 2009-12-27 19:33:25 +01:00
Wim Taymans
67bd9529d0 buffer: remove subbuffer subclass
Move the parent buffer pointer into the GstBuffer struct so that we can
remove the subbuffer class and type. This is interesting because it allows us to
more naturally implement methods to get the real type and parent
of a subbuffer (See #545501).
It should also be slightly faster because there is no extra object hierarchy to
initialize and free.
2009-12-26 00:02:17 +01:00
Wim Taymans
bb780fdf73 miniobject: avoid unneeded casts 2009-12-24 17:22:46 +01:00
Wim Taymans
fc7dd46b20 avoid some more type checks 2009-12-24 14:40:54 +01:00
Wim Taymans
c059cb43de pipeline: avoid some type checks
Avoid type checks when we can
Don't need to peek the parent_class, the boilerplate does that for us.
2009-12-24 14:22:52 +01:00
Wim Taymans
7522e2ccf8 trace: include type name in leaked objects
When we are dealing with a GObject, print the type name along with
the pointer for easier debugging.
2009-12-23 21:37:51 +01:00
Wim Taymans
381d35fd1e pad: Fix problem with destroy callback not being called
When we unblock a pad with the same user_data, the destroy callback is not
called. This leads to refcounting leaks that cannot be avoided. Instead always
call the destroy notify whenever we install a new pad block.
In particular, this fixes a nasty pad leak in decodebin2.

Also update the unit test to have more accurate comments and test the required
behaviour.
2009-12-23 21:20:14 +01:00
Thiago Santos
a3078cf0cd gsttaglist: Adds new tags
Adds the following new tags:
GST_TAG_SHOW_NAME
GST_TAG_SHOW_SORTNAME
GST_TAG_SHOW_EPISODE_NUMBER
GST_TAG_SHOW_SEASON_NUMBER
GST_TAG_LYRICS
GST_TAG_COMPOSER_SORTNAME
GST_TAG_GROUPING

Fixes #599759
2009-12-21 11:58:12 -03:00
Stefan Kost
0b7f75c205 docs: link bus and tasks
Add a link from bus section docs to the task docs. Add a paragraph to task docs
to tell about messages and the bus.
2009-12-14 16:22:16 +02:00
Stefan Kost
790e5d10c8 docs: add more docs around GstState and GstStateChange
Take reviewed docs from docs/design/part-state to have that more prominent
inside the api docs. Add a few sentences to link things better together.
2009-12-14 15:11:42 +02:00
Stefan Kost
e243a41165 gstelementfactory: set object name earlier if applicable
Setting an object name is nice for proper debug logging. Ideally this would
still happens earlier (.e.g when pads are added to an element, its not yet set).
2009-12-14 11:08:48 +02:00
Stefan Kost
076aeeb74b gstobject: add fixme-0.11 comment 2009-12-14 11:08:48 +02:00
Stefan Kost
cb294cb5ea comment: small comment correction 2009-12-14 11:08:47 +02:00
Wim Taymans
f44d8c31de bin: never skip a state change to PLAYING
Never skip the state change to playing, even if the element is already in the
right state. We need this because we also distribute the base_time while doing
the state change and skipping this step would leave some elements without a new
base_time.

Fixes #600313
2009-12-11 16:26:00 +01:00
Wim Taymans
8bc67e5434 element: use NULL instead of 0 for pointers 2009-12-09 13:27:22 +01:00
Sebastian Dröge
1c66f306d6 utils: Fix proxy_setcaps to only iterate pads of other direction 2009-12-08 16:40:57 +01:00
Wim Taymans
c6f2a94777 utils: fix proxy_getcaps
Make it return the padtemplate caps on errors and no parent.
Only intersect pads of the oposite direction of the source pad.
2009-12-08 16:30:51 +01:00
Sebastian Dröge
6bff920ba0 utils: Rename proxy iterator fold functions to have a more meaningful name 2009-12-08 16:24:20 +01:00
Sebastian Dröge
d6492c2958 utils: If one intersection gave empty caps don't continue iterating over the other pads 2009-12-08 16:09:02 +01:00
Wim Taymans
c2b0e9de25 Use plain casting instead of typechecking 2009-12-07 20:52:22 +01:00
Edward Hervey
a5626f239a gstvalue: Use fast gst_value_list_{size|get_value} macro accessors
gst_value_list_size and gst_value_list_get_value will do a series of
extra checks due to being public methods.
When we use them from within gstvalue.c we can directly use them without
the extra checks.
2009-12-07 09:51:04 +01:00
Edward Hervey
1d91fd9fb9 gsturi: Don't use g_signal_emit_by_name, use the signal ID directly 2009-12-07 09:51:03 +01:00
Edward Hervey
4140350594 gstobject: Avoid double strdup when setting NULL names.
Instead of chaining up to gst_object_set_name (which does typechecking
and strdup's the name again), just use the already allocated new
name.
2009-12-07 09:49:06 +01:00
Sebastian Dröge
df741e7e2f bin: Ignore state change failures from children that were removed from the bin already
Fixes bug #584441.
2009-12-04 16:28:27 +01:00
Sebastian Dröge
08ae8a1afb registry: Use GMappedFile for reading the registry
Fixes bug #603787.
2009-12-04 15:19:11 +01:00
Javier Jardón
ca974b1a8f registry: Substitute deprecated GLib symbol: g_mapped_file_free
Use g_mapped_file_unref if Glib >= 2.22 is available

Fixes bug #560442.
2009-12-04 14:50:46 +01:00
Wim Taymans
d5e42a92c8 event: fix docs for _copy() 2009-12-02 13:29:28 +01:00
David Schleef
b0889cf2a1 Make gcc inline assembly conditional on gcc 2009-12-01 18:09:35 -08:00
Edward Hervey
24b357a444 gstghostpad: Register debug funcptr only once.
This makes ghostpad/proxypad creation 5 times faster and avoids contention
over the global funcptr lock.

I also moved the two class init down in the code to avoid having to forward
declare all the various functions.
2009-12-01 17:56:19 +01:00
Edward Hervey
4da0da822a gstpad: Only register debug funcptr once.
This makes pad initialization 2 times faster and without any contention
over the debug funcptr global lock.
2009-12-01 17:56:19 +01:00
Edward Hervey
8f40effea6 gstinfo: API: Add GST_DEBUG_REGISTER_FUNCPTR method.
This is a variant of GST_DEBUG_FUNCPTR which does not return anything.
2009-12-01 17:56:19 +01:00
Thiago Santos
0491df555d gstevent: fix docs
Fix flush stops docs, those are serialized, not out of bounds.
Probably a copy and paste mistake.
2009-11-27 13:44:11 -03:00
Stefan Kost
8d63e8e0c3 docs: make links work (needs recent gtk-doc) 2009-11-27 14:18:39 +02:00
Stefan Kost
85d85f9d36 docs: add missing parameter docs 2009-11-27 14:18:39 +02:00
Stefan Kost
309187c2ce docs: enable docs for GstObjectClass to fix links 2009-11-27 14:18:38 +02:00
Stefan Kost
f1d39627f6 gstobject: add FIXME-0.11 comments 2009-11-27 14:18:38 +02:00
Stefan Kost
9d640c7c61 docs: better way to link class methods 2009-11-27 14:18:38 +02:00