Branko Subasic
52c0763042
gst-rtsp-server: Plug a few memory leaks in tests
...
Found and fixed a few memory leaks in the gst_rtspserver, gst_onvif and
gst_stream tests by running the tests in valgrind.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1742 >
2022-03-07 13:57:27 +00:00
Hou Qi
b11084f729
flvmux: Add protection when unref GstFlvMuxPad
...
This is to avoid gst_object_unref: assertion 'object != NULL' failed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1843 >
2022-03-07 13:03:16 +00:00
Philippe Normand
21f7889187
gstplay: tests: Keep track of errors/warnings
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1869 >
2022-03-07 11:03:41 +00:00
Philippe Normand
84717c6d2a
gstplay: Do not error out on message parsing failures
...
Specially when parsing errors and warnings, the details field can be NULL and
the gst_structure_get() call would return FALSE in such cases, triggering false
positive errors.
Follow-up for #1063
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1869 >
2022-03-07 11:03:41 +00:00
Philippe Normand
027f4a56c0
gstplay: Fix warning parsing API
...
The GError is an out parameter, so should be a ** parameter, like the details
parameter.
See also #1063
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1869 >
2022-03-07 11:03:41 +00:00
Seungha Yang
a63d1cf4c4
cudamemorycopy: Fix build when gl is disabled
...
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1707
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1868 >
2022-03-07 10:22:21 +00:00
Branko Subasic
41d436e56e
gst-rtsp-server: fix race in rtsp-client
...
When tunneling over HTTP, if connection on the second channel happens
before the control timer is created we may trigger an assert in
rtsp_ctrl_timeout_remove(). Avoid that by taking the priv->lock before
attaching the client thread to the context.
Fixes #1025
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1867 >
2022-03-07 09:15:11 +00:00
Mengkejiergeli Ba
c9aa529484
msdkdec: Fix to not trigger SFC scaling when vpp at downstream
...
When there is vpp scaling downstream, we need to make sure SFC is not
triggered because vpp may fall into passthrough mode which causes
the decoder negotiation to create src caps with vpp scaled width/height.
This patch includes bitstream's original size in first query with
downstream in gst_msdkdec_src_caps, which is the same for what we do for
color format in this query. This is to ensure SFC scaling starts to
work only when downstream directly asks for a different size instead of
through vpp.
Note that here SFC scaling follows the same behavior as msdkvpp:
if user only changes width or height, e.g. dec ! video/x-raw,width=xx !,
the height will be modified to the value which fits the original DAR.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1838 >
2022-03-07 07:26:40 +00:00
Hou Qi
89a5cae89b
encodebasebin: Use GST_DEBUG instead of GST_ERROR when skipping muxer
...
_get_muxer() skips the muxers that do not satisfy the requirement and select
the desired one. It should not print error log, so use debug log instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1830 >
2022-03-06 18:15:04 +00:00
Seungha Yang
30ddb0cd97
nvcodec: Add missing null check in context sharing code
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
c31bf2db4d
nvcodec: Refactor cudaupload/download and add support for GL memory
...
* Implement new baseclass GstCudaMemoryCopy to remove duplicated
cudaupload/download code
* Add support for CUDA <-> GL memory conversion via cudaupload/download
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
111b2c3f53
nvcodec: Refactor GstCudaMemory abstraction
...
* Hide GstCudaMemory member variables
* Make GstCudaAllocator object GstCudaContext independent
* Set offset/stride of memory correctly via video meta
* Drop GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT support.
This implementation actually does not support custom alignment
because we allocate device memory via cuMemAllocPitch
of which alignment is almost uncontrollable
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
ad0e7fca14
nvcodec: Refactor basetransform subclasses
...
* cudaupload/download
- Specify only formats actually we can deal with
nvcodec elements, not all video formats
- Supports CUDA output for download and input for upload in order
to make passthrough possible, like other upload/download elements.
* cudabasetransform
- Reset conversion element if upstream CUDA memory
holds different CUDA context and the element can accept it.
This is the same behavior as corresponding d3d11 filter elements.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
89bbcf0061
cudabufferpool: Move GstCudaContext object to public member
...
... so that plugins can understand assosicated cuda context with the
pool.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
c8a1c953d8
cudacontext: Require explicit gpu id instead of auto (-1)
...
Sync up with GstD3D11Device implementation. The auto stuff should
be handled in context sharing step, not device creation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
1b9274307a
nvcodec: Indent update
...
... to prevent gnu indent version dependent diffs.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
Seungha Yang
cec7ac2a1b
cudacontext: Remove unnecessary cuInit() call
...
It's already called at plugin init time
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1834 >
2022-03-06 15:39:04 +00:00
He Junyan
2d624a1d6b
av1parse: Add a comment when the detection of TU fails.
...
Also update the print message.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1863 >
2022-03-05 11:45:15 +08:00
Nicolas Dufresne
576b074dde
camerabin: Remove drain query
...
This was to support very old V4L2 kernel. As we moved to DMABuf and can now
detach buffers on renegotiation, the buffer it tries to fix no longer exist.
The risk to blocking indefinitly the application does still exist though.
Fixes #1070
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1861 >
2022-03-04 22:45:58 +00:00
Nicolas Dufresne
0b7e8efe61
doc: AV1 demuxers now expose their alignment
...
Update the chache accordingly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
He Junyan
9c4adf5a64
av1parse: check the error return when parse_alignment_from_caps()
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
He Junyan
81bae87079
av1parse: Use the intersected caps to decide the alignment.
...
When we negotiate with downstream, We should use the intersected
caps of input and output to decide the alignment and stream format.
The current code just uses the input caps which may lack the stream
format.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
He Junyan
ccd1ed9cbc
ivfparse: Set the alignment to tu for AV1 stream.
...
Just do the same as other demux.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
He Junyan
4c8777667a
av1parse: Only detect the stream format when input alignment is tu.
...
The demux now outputs the AV1 stream in "tu" alignment, so we do not need
to detect the input alignment. But the annex b stream format is not recognized
by the demux, we still need to detect that stream format for the first input.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
Nicolas Dufresne
0f15580853
matroska: Fix AV1 alignment to TU
...
Matroska stores AV1 in temporal unit, so that all OBU sharing the same
timestamp are put together. This was previously just assumed, which isn't
safe now that we have more alignments.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
Nicolas Dufresne
f6c070fbff
isomp4: Fix AV1 default alignment
...
ISOMP4 store TU (temporal units) worth of AV1. Expose this in the
caps to reduce overhead in the parser, and in the muxer to avoid
storing frames split in the wrong way.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
Nicolas Dufresne
29826aa80e
av1parse: Save the default alignment
...
Otherwise the transformation is not applied and decoders may not
get the appropriate format despite the caps being negotiated
correctly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
Nicolas Dufresne
f627d6aafc
av1parse: Remove duplicated check
...
The case of both strings being empty is already checked in the
helper function. No functional changes.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1837 >
2022-03-04 21:58:15 +00:00
Nicolas Dufresne
57c2adeeb2
vp9parse: Fix auto-plugging of HW frame decoder
...
Decoders that required frame aligmment and didn't have an associated
alpha decoder were skipped. This is because the parser was constructing
caps based on the software alpha decoder, which specify super-frame
alignment.
Iterate over the caps to filter the one that have a matching codec-alpha, with
the semantic the no codec-alpha field means codec-alpha=false. Then if
everything was removed, callback to the original, so that the first non-alpha
decoder will be picked.
Fixes #820
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1855 >
2022-03-04 21:24:17 +00:00
Tristan Matthews
9d0d001d19
matroskamux: allow width+height caps changes for VP8/9
...
For VP8 and VP9, width+height changes are signalled inband.
Refs https://github.com/Kurento/bugtracker/issues/535 and
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1047/diffs?commit
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1657 >
2022-03-04 14:17:20 -05:00
Tristan Matthews
c6ba57eb8e
matroskamux: allow width + height changes for avc3|hev1
...
For avc3 and hev1, the intent was to allow more flexibility for caps changes
(see https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1047/diffs?commit_id=9bd8d608d5bae27ec5ff09e733f76ca32b17420c )
however width and resolution were previously omitted.
avc3 and hev1 specifically support changing stream-parameters on the fly, whereas avc1/hvc1 disallow in-band SPS.
This commit allows for changes to width and height for these which is in line with matroskamux's behaviour prior to 1.14.0.
Practically speaking, one use case where this is commonly seen is when capturing a WebRTC stream, as the browser will adapt the resolution live.
Suggested-by: Mathieu Duponchelle "<mathieu@centricular.com>"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1657 >
2022-03-04 14:17:20 -05:00
Jan Alexander Steffens (heftig)
ce503d0645
deinterlace: Prevent race between _set_method and latency query
...
It's possible that the method is being manipulated while downstream
queries our latency, leading to crashes.
Prevent that from happening.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1854 >
2022-03-04 16:14:46 +00:00
Edward Hervey
03b1790e0d
tsdemux: Handle PES headers bigger than a mpeg-ts packet
...
While the actual PES header parser could notify us that it needed more data, we
would never actually act on it.
This commit will accumulate incoming packets in such situation and re-attempt
the header parsing.
Fixes #1027
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1852 >
2022-03-04 15:14:31 +00:00
Víctor Manuel Jáquez Leal
e42d10431d
va: basetransform: Add device-path read-only property.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1844 >
2022-03-04 14:34:32 +00:00
Víctor Manuel Jáquez Leal
47a95dfd65
va: basedec: Add device-path read-only property.
...
And elements will notify the used device-path if display is DRM.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1844 >
2022-03-04 14:34:32 +00:00
Seungha Yang
16f37f8b9c
gldisplay: Reorder GST_GL_WINDOW check for egl-device
...
"egl-device" should be checked before the "egl", otherwise unexpected egl will be picked
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1853 >
2022-03-04 13:34:34 +00:00
Víctor Manuel Jáquez Leal
72c6a3b95a
vah264enc: Remove GST_PARAM_CONDITIONALLY_AVAILABLE.
...
Since it's used only when the property is conditionally installed, and
these parameters are always installed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
He Junyan
be24cdb150
va: encoder: Clean dead code.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Víctor Manuel Jáquez Leal
7aa597d6df
va: encoder: Fix error code path when open.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Víctor Manuel Jáquez Leal
81c00664a2
vah264enc: Remove preferred_output_delay.
...
In the current state of the encoder it's just dead code.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Víctor Manuel Jáquez Leal
1a19a835a9
vah264enc: Avoid mapping coded buffer twice.
...
Currently for copying the coded buffer onto a GStreamer buffer, the
coded buffer is mapped two times: one for getting the size, and later
for do the actual copy. We can avoid this by doing directly in the
element rather than in the general encoder object.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Víctor Manuel Jáquez Leal
81b99c37d8
vah264enc: Single parameter array per picture.
...
There's no need, at least in H.264, to hold a global parameter array,
since there's no need to submit SPS, trellis, hdr or quality in every
buffer, but only on IDR ones.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Víctor Manuel Jáquez Leal
72b0f8ab17
va: Fix log message
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1845 >
2022-03-04 12:41:37 +00:00
Philippe Normand
7a7daf0f37
play: Fix error parsing API
...
The GError is an out parameter, so should be a ** parameter, like the details
parameter.
Fixes #1063
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1849 >
2022-03-04 10:00:30 +00:00
Matthew Waters
b7d0ddd1a4
webrtc: support renegotiating adding/removing RTX
...
We need to always add the RTX/RED/ULPFEC elements as rtpbin will only
call us once to request aux/fec senders/receivers.
We also need to regenerate the media section of the SDP instead of
blindly copying from the previous offer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1762 >
2022-03-04 19:21:59 +11:00
Mengkejiergeli Ba
8a598deef2
msdkenc: Change default ref frames number as 0
...
When user does not set ref-frames in pipeline, we should let MediaSDK
decide the reference frame number via setting default value as 0 at
gstreamer side.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1839 >
2022-03-04 01:05:30 +00:00
Seungha Yang
8e0ce6b125
meson: wic: Fix typo
...
Should check WIC build option, not MediaFoundation
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1847 >
2022-03-04 04:18:06 +09:00
Nirbheek Chauhan
f42f65a993
soup: Fix static build with MSVC
...
../ext/soup/gstsouploader.c(818): error C4098: '_soup_session_send_async': 'void' function returning a value
It's technically a false warning, but that's how MSVC works, so fix
it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1805 >
2022-03-03 23:07:35 +05:30
Nirbheek Chauhan
7f04ee970b
soup: Fix pkgconfig generation and documentation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1805 >
2022-03-03 16:59:16 +00:00
Nirbheek Chauhan
2e3a575533
soup: Fix static build when default_library=both
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1007
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1805 >
2022-03-03 16:59:16 +00:00