Olivier Crête
4e32d6bf3e
webrtcstats: Use our own caps instead of the sticky event
...
The sticky event seems to get cleared sometimes.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
29befed685
webrtcbin: Store the ssrc of the last received packet
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
fc7e7f5ccc
webrtc stats: Remove duplicate structure get
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Olivier Crête
f35435f1f7
webrtc stats: Add more details about codecs into the stats
...
This makes the output a little closer to what the upstream stats are.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1448 >
2021-12-23 23:48:17 -05:00
Brad Hards
d4379c8df7
doc: typo fix for streaming
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1463 >
2021-12-23 07:50:22 +00:00
He Junyan
85d2118a53
va: av1dec: Use named profiles to replace the numeric ones.
...
Use named AV1 profiles (i.e., main, high, and professional) to replace
the old 0, 1, 2 profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:34 +09:00
Seungha Yang
796007f75d
av1enc: Update for newly designed AV1 profile signalling
...
Accept named AV1 profiles (i.e., main, high, and professional)
as well
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:34 +09:00
Seungha Yang
91484ce2ac
d3d11av1dec: Update sinkpad template for profile
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:34 +09:00
Seungha Yang
40213b5c75
av1parse: Use descriptive profile name instead of numeric
...
As per AV1 specification Annex A, AV1 profiles have explicit and
descriptive names for each seq_profile.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 22:20:30 +09:00
Seungha Yang
ac978099c6
av1parse: Remove trailing white space
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1456 >
2021-12-21 01:00:12 +09:00
Seungha Yang
1564567c3e
d3d11av1dec: Fix for Cdef param
...
av1parser will increase the sec_strength values by 1 if parsed
values were equal to 3 as defined in spec. But DXVA wants unmodified
ones.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1455 >
2021-12-17 23:28:29 +09:00
Seungha Yang
146815bbb6
d3d11av1dec: Sync DXVA AV1 data structure with released header
...
Update AV1 data structure based on Windows 11 SDK header
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1455 >
2021-12-17 23:27:24 +09:00
Víctor Manuel Jáquez Leal
69c4e317d8
tests: h265parser: Add test for multiple compatibility profiles.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1440 >
2021-12-16 17:08:30 +01:00
Víctor Manuel Jáquez Leal
b80cd503b6
h265parser: Compare upstream profile with in SPS.
...
Compare if upstream profile in caps is the same as the one parsed in
the SPS. If they are different use the bigger for simplicity and
more chances to decode it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1440 >
2021-12-16 17:08:30 +01:00
Víctor Manuel Jáquez Leal
3040a26073
codecparsers: h265parser: Use a table map to get profile.
...
Instead of a sequence of if statements, declare a table to map profile
idc with profiles and traverse it.
Also, first add the profile from the parsed profile idc and later add,
into the profile array, the profile from the compatibility flags.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1440 >
2021-12-16 17:08:30 +01:00
Víctor Manuel Jáquez Leal
168ad9f58f
codecparsers: h265parser: Verify all possible profiles.
...
It's possible a HEVC stream to have multiple profiles given the
compatibility bits. Instead of returning a single profile, internal
gst_h265_profile_tier_level_get_profiles() returns an array with all
it possible profiles.
Profiles are appended into the array only if the generated profile
is not invalid.
gst_h265_profile_tier_level_get_profile() is rewritten in terms of
gst_h265_profile_tier_level_get_profiles(), returning the first
profile found the array.
And gst_h265_get_profile_from_sps() is also rewritten in terms of
gst_h265_profile_tier_level_get_profiles(), but traversing the array
verifying if the proposed profile is actually valid by Annex A.3.x of
the specification.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1440 >
2021-12-16 17:08:30 +01:00
Mathieu Duponchelle
abd61732bf
webrtcbin: bind transceiver's fec-percentage to encoder percentage
...
Allows for dynamic control of the applied FEC overhead
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1429 >
2021-12-14 17:34:53 +00:00
Mathieu Duponchelle
06893b8b5e
webrtcbin: fix ulpfec / red for the BUNDLE case
...
* Add fec / red encoders as direct children of webrtcbin, instead
of providing them to rtpbin through the request-fec-encoder signal.
That is because they need to be placed before the rtpfunnel, which
is placed upstream of rtpbin.
* Update configuration of red decoders to set a list of RED payloads
on them, instead of setting the pt property.
That is because there may be one RED pt per media in the same session.
* Connect to request-fec-decoder-full instead of request-fec-decoder,
in order to instantiate FEC decoders according to the payload type
of the stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1429 >
2021-12-14 17:34:53 +00:00
Seungha Yang
f10867dfb5
d3d11videosink: Use only tested color space for swapchain
...
We are querying supported swapchain colorspace via
CheckColorSpaceSupport() but it doesn't seem to be reliable.
Use only tested full-range RGB formats which are:
- sRGB
- BT709 primaries with linear RGB
- BT2020 primaries with PQ gamma
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1433 >
2021-12-12 11:00:24 +00:00
Thibault Saunier
d82efb47aa
pitch: Specify layout as required for negotiation
...
There are cases where it might negotiate 'non-interleaved' while it
is wrong.
```
gst-launch-1.0 audiotestsrc ! "audio/x-raw, format=(string)F32LE, layout=(string)non-interleaved" ! audioconvert ! audioresample ! pitch tempo=1.2 ! audioconvert ! "audio/x-raw,format=S16LE" ! fakesink
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
(gst-launch-1.0:3029628): GStreamer-Audio-CRITICAL **: 11:42:22.477: gst_audio_buffer_map: assertion '(!meta && info->layout == GST_AUDIO_LAYOUT_INTERLEAVED) || (meta && info->layout == meta->info.layout)' failed
ERROR: from element /GstPipeline:pipeline0/GstAudioConvert:audioconvert1: The stream is in the wrong format.
Additional debug info:
../subprojects/gst-plugins-base/gst/audioconvert/gstaudioconvert.c(876): gst_audio_convert_transform (): /GstPipeline:pipeline0/GstAudioConvert:audioconvert1:
failed to map input buffer
ERROR: pipeline doesn't want to preroll.
ERROR: from element /GstPipeline:pipeline0/GstAudioTestSrc:audiotestsrc0: Internal data stream error.
Setting pipeline to NULL ...
Additional debug info:
../subprojects/gstreamer/libs/gst/base/gstbasesrc.c(3127): gst_base_src_loop (): /GstPipeline:pipeline0/GstAudioTestSrc:audiotestsrc0:
streaming stopped, reason error (-5)
ERROR: pipeline doesn't want to preroll.
Freeing pipeline ...
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1441 >
2021-12-11 19:09:09 -03:00
Nicolas Dufresne
f9668b0697
doc: Update vp9alphadecodebin doc cache
...
A new field was added to the template cpas.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
2886eab3c4
alphacombine: Fix for early allocation queries
...
When using playbin3, it seems that the alpha decode is always first to
push caps and run an allocation query. As the format change from sink
and alpha were not synchronized, the allocation query could endup
being run before the caps are pushed. That may lead to failing query,
which makes the decoder thinks there is no GstVideoMeta downstream and
most likely CPU copy the frame.
This patch implements a format cookie to track and synchronize the
format changes on both pads fixing the racy performance issue.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
e0f8ce501b
v4l2codecs: vp9: Add alpha decodebin wrapper
...
This will allow HW accelerated decoding of WebM alpha videos.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
31d49da237
v4l2codecs: plugin: Minor style fix
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
3f02515380
v4l2codecs: decoder: Improve logging of timed out request
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
c4216a693c
v4l2codecs: mpeg2: Check that the decoder output formats
...
This is to avoid exposing a decoder for which we don't support any
output format. This happens on platform using vendor formats or
not yet supported tiles formats.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Nicolas Dufresne
91b7a9497b
vp9alphadecodebin: Fix auto-pluging v4l2slvp9dec
...
This adds the alignment field to the template caps. Without this field
set, the auto-plugger will see fixed caps and will use
gst_caps_is_subset() against the caps produced by the parser. This is a
challenge for all cases where a parser can do conversion. This is fixed
by adding alignment field, which makes the auto-pluggers do an
intersection of the caps as it gets unfixed caps after intersection now.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1439 >
2021-12-10 21:37:14 +00:00
Seungha Yang
e8c923ebde
d3d11window: Remove hack related to color space selection
...
Use input GstVideoColorPrimaries without any special case handling
otherwise rendered image color would be very wrong.
The hack was added to work around an issue that some Intel driver
couldn't handle wide color gamut image without HDR10 metadata, specifically PQ image.
But device capability can be checked via a method added in
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1723
so there's no issue now.
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1175
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1430 >
2021-12-09 20:12:12 +09:00
Seungha Yang
1a12883993
d3d11window: Fix typo in debug message
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1430 >
2021-12-09 19:51:20 +09:00
Benjamin Gaignard
9e0c2c4a09
codecs: h264decoder: Fix return value type
...
Return value should be GstFlowReturn not gboolean
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1426 >
2021-12-08 11:08:30 +01:00
Benjamin Gaignard
4ff27314f6
codecs: h265decoder: Fix return value if klass->new_picture isn't set
...
If klass->new_picture isn't set we need to initialize
ret with GST_FLOW_OK to avoid unwanted error case
Fixes: 5b405d1585
("codecs: h265decoder: Use GstFlowReturn everywhere")
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1426 >
2021-12-08 11:02:32 +01:00
Philippe Normand
86719e25a4
wpevideosrc: Use basesrc event vfunc
...
Allows for basic default handling from the base class.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1422 >
2021-12-07 11:43:26 +00:00
Tim-Philipp Müller
26169cee0e
teletextdec: fix minor string leak
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1416 >
2021-12-06 13:07:37 +00:00
Marc Leeman
49736fb3fd
ristsink: set properties on children early
...
The properties on the udpsink/udpsrc elements need to be set before
there is any state change. If not, in a network without default gateway,
udpsink tries to bind an a NULL interface and fails.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1411 >
2021-12-03 23:46:08 +00:00
Nicolas Dufresne
7e875ddb2c
v4l2codecs: mpeg2: Fix selected sizeimage
...
Due to a copy paste bug, the bitdepth was never set and that was leading
to requesting sizeimage of 0. Previously that worked since the driver
would in that case pick a size for us. But now the we bumped the minimum
to 4KB, the driver happily allocate 4KB of bitstream which lead to
decoding error.
As MPEG2 have a fixed bitdeph of 8, use a define instead of the run-time
variable.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1415 >
2021-12-03 07:55:30 -05:00
Nicolas Dufresne
05458f05e0
v4l2codecs: vp9: Drop frames on non-keyframe format change
...
V4L2 does not yet support this feature, this will skip over the
transition portion up to the next keyframe.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1404 >
2021-12-02 15:52:03 -05:00
Nicolas Dufresne
a6eb1e7782
v4l2codecs: Fix renegotiation
...
If we hold the last reference to the allocator, leaving the device
streaming will cause an EBUSY error when trying to free the allocate
buffers.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1404 >
2021-12-02 15:45:26 -05:00
Seungha Yang
e87791592e
d3d11vp9dec: Drop frames on non-keyframe format change
...
... in case of NVIDIA GPU
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Seungha Yang
2c834b5fc7
nvvp9sldec: Drop frames on non-keyframe format change
...
NVDEC doesn't seem to be able to handle the case
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Seungha Yang
e2e45e51b0
codecs: vp9: Drop frames on non-keyframe format change
...
... if subclass does not support the case
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Nicolas Dufresne
43759ffeaa
codecs: vp9: Also consider render_width/height
...
Also emits new_sequence if on keyframe and the render_width/height have
change. The subclass can always optimize this if the frame resolution
didn't change, the output caps needs to reflect this though.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1407 >
2021-12-02 19:19:59 +00:00
Marc Leeman
f699c08af9
rtpsink: set properties on children early
...
The properties on the udpsink/udpsrc elements need to be set before
there is any state change. If not, in a network without default gateway,
udpsink tries to bind an a NULL interface and fails.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1398 >
2021-12-02 14:23:05 +01:00
Nicolas Dufresne
d04fba93f8
v4l2codecs: vp9: Remove uneeded picture data
...
The GstV4l2Request now holds a reference on the picture buffer and is
recounted already. This effectively removes usage of GRefCount which is only
available in GLib 2.58, while we support 2.56.
Fixes #910
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:59 -05:00
Nicolas Dufresne
19d99dbcae
v4l2codecs: decoder: Add method to get the pic_buf
...
This helper will be needed for VP9 frame duplication.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:59 -05:00
Nicolas Dufresne
8a1440b3f1
v4l2codecs: vp9: Add missing error checks in decide_allocation
...
This could otherwise lead to crash.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1402 >
2021-11-30 17:11:56 -05:00
Nicolas Dufresne
4ca7f1e014
v4l2codecs: h264: Fix typo in comment
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1387 >
2021-11-30 00:28:34 +00:00
Nicolas Dufresne
83933b7772
v4l2codecs: h264: Properly set pic_num/frame_num
...
The V4L2 uAPI uses pic_num for both PicNum and ShortTermPicNum. It also
doe the same for both FrameNum and LongTermFrameIdx. This change does
not change the fluster score, but fixed a visual corruption noticed
with some third party streams.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1387 >
2021-11-30 00:28:34 +00:00
He Junyan
b5c07e11ca
va: Use a lock to protect the surface copy by using vpp.
...
If we use vpp to do the surface copy, its operation is not atomic.
We need to maintain the filter's context unchanged during the whole
copy progress.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00
He Junyan
954f7cf88c
va: Use the GstVaSurfaceCopy of the allocator atomically.
...
The mem_copy() of the allocator can be called simultaneously from
different threads. We should use atomic pointer operations to create
and use the GstVaSurfaceCopy of the allocator.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00
He Junyan
7f31dcf084
va: DMA allocator: Set the copied memory properly when popped from pool.
...
The current code does not set the copied memory correctly when it is popped
from the surface cache pool.
1. We forget to ref the allocator, which causes the allocator to be freed
unexpected, and we get a crash later because of the memory violation.
2. We forget to add ref_mems_count, which causes the surface leak because
the surface can not be pushed back to the cache pool again.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1373 >
2021-11-29 19:25:31 +00:00