Vincent Penquerc'h
436c8c11a0
qtdemux: trivial typo fix
2014-05-02 09:49:17 +01:00
Vincent Penquerc'h
74c93b8fc7
speexdec: remove dead code
...
fpp can never equal 0 here, or the loop would not execute at all.
Zero fpp was possible before as the loop condition was allowing
it specifically, but no more.
Coverity 1139681
2014-05-02 09:45:07 +01:00
Vincent Penquerc'h
81d2e9333d
oss4: remove dead mixer code
...
This was partly removed in the port to 0.11. If still needed,
it's still there in the history.
Coverity 1139687
2014-05-02 09:41:19 +01:00
Vincent Penquerc'h
1062992b4a
oss4: fix a missing unlock and a return-only-when-assertions-enabled
...
Spotted on the side while looking at another issue.
2014-05-02 09:33:51 +01:00
Nicolas Dufresne
7ff514fec6
v4l2: Correctly map RGB32 format
...
In v4l2 specification, RGB32 has the alpha, or pading, first, not last.
See http://linuxtv.org/downloads/v4l-dvb-apis/packed-rgb.html .
https://bugzilla.gnome.org/show_bug.cgi?id=540941
2014-04-30 15:36:07 -04:00
Vincent Penquerc'h
14ceb5727c
flacdec: remove dead code
...
For 8 bit width, we always have depth==gdepth==width==8.
Coverity 1139678
2014-04-30 18:06:40 +01:00
Vincent Penquerc'h
0253db6d36
mpegaudioparse: remove dead code
...
A stricer check is already done earlier, and integer overflows
do not seem possible here.
Coverity 1139675
2014-04-30 17:48:53 +01:00
Vincent Penquerc'h
a55b8e9c00
rtpvrawpay: guard against pathological "no space" condition
...
Even if one woul hope one pixel can fit in a MTU, ensure we do not
overwrite a buffer if this is not the case.
Spotted while looking at Coverity 1208786
2014-04-30 14:50:44 +01:00
Vincent Penquerc'h
dfa2df1c88
rtpjpegdepay: sanity check for NULL qtable
...
Can happen (at least in crafted stream)
Coverity 1208778
2014-04-30 11:52:10 +01:00
Tim-Philipp Müller
b1473491cf
wavparse: pass on tags from upstream if there are any
...
Don't just ignore upstream tags from e.g. an ID3 tag before
the .wav data, pass them on downstream.
https://bugzilla.gnome.org/show_bug.cgi?id=729223
2014-04-30 01:08:41 +01:00
Wim Taymans
eba3bba524
rtpjitterbuffer: optimize timer update
...
When we are not doing retransmission, we just need to find the current
seqnum so we can stop when we found it.
2014-04-29 16:26:53 +02:00
Wim Taymans
b2c9646acb
rtpjitterbuffer: small optimizations
...
Small optimizations where we can.
Add some more debug.
2014-04-29 16:21:44 +02:00
Wim Taymans
df04fcbb5d
rtpjitterbuffer: signal when next_seqnum changed
...
Signal the pushing thread when the next_seqnum changed and we might be
able to push a buffer now.
2014-04-29 16:16:17 +02:00
Wim Taymans
3cd0e8ae88
rtpjitterbuffer: only signal event when head changed
...
After adding a buffer, only signal the pushing thread when the head
buffer changed or else we cause a useless wakeup.
2014-04-29 16:12:29 +02:00
Wim Taymans
18b69419fd
rtpjitterbuffer: rework packet insert
...
Rework the packet queue so that the most common action (insert a packet
at the tail of the queue) goes very fast.
Report if a packet was inserted at the head instead of the tail so that
we can know when to retry _pop or _peek.
2014-04-29 16:02:37 +02:00
Wim Taymans
9994ff2c6c
rtpvraw: use plane pointers when needed
...
Pack/unpack planar formats to/from the first plane.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=729058
2014-04-28 14:45:57 +02:00
Sebastian Dröge
3b6c17c2b6
souphttpsrc: Remember if a redirect is permanent or not and store it in the query
2014-04-28 10:04:03 +02:00
Nicolas Dufresne
d87cc7bacf
goom: Remove french comment saying to prefix functions
...
All non-static function in this file are already prefixed with goom_.
2014-04-27 21:57:38 -04:00
Tim-Philipp Müller
02436f52c6
goom: fix compilation on ios-arm7-10.9 and osx-x86_64
...
uint is not a standard type, and the rest of the code uses
Uint which is locally typedefed to unsigned int.
https://bugzilla.gnome.org/show_bug.cgi?id=729067
2014-04-28 00:24:16 +01:00
Luis de Bethencourt
3943c3ec08
goom: fix undefined behaviour of left-shift
...
Don't left-shift into the sign bit, the result is undefined and potentially
an overflow could flip the sign.
2014-04-27 18:31:48 -04:00
Luis de Bethencourt
5dc2e6bef1
qtdemux: check return from qt_demux_video_caps
...
Now qtdemux_video_caps() can return NULL. We need to check this return before
using it's value.
https://bugzilla.gnome.org/show_bug.cgi?id=728987
2014-04-26 20:51:36 -04:00
Tim-Philipp Müller
c9597298f9
docs: remove outdated and pointless 'Last reviewed' lines from docs
...
They are very confusing for people, and more often than not
also just not very accurate. Seeing 'last reviewed: 2005' in
your docs is not very confidence-inspiring. Let's just remove
those comments.
2014-04-26 23:35:17 +01:00
Luis de Bethencourt
c073a6c779
qtdemux: initialize caps pointer to null
...
Make sure the caps pointer returns initialized when using it in
qtdemux_parse_tree ().
https://bugzilla.gnome.org/show_bug.cgi?id=728987
2014-04-25 18:23:23 -04:00
Jan Schmidt
f2d0ddf113
rtpjitterbuffer: Clear last_pt on flush-stop.
...
Otherwise, we don't recheck the buffer caps for clock-rate
properly on the next chain.
2014-04-23 18:54:16 +10:00
Sebastian Dröge
25ed0a30a4
deinterlace: Fix compiler warning
...
gstdeinterlace.c: In function 'gst_deinterlace_output_frame':
gstdeinterlace.c:1537:57: error: 'pattern.length' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This actually is always initialized before it is used there, but
let's just silence gcc here.
2014-04-22 17:29:02 +02:00
Vincent Penquerc'h
f10c3f1a76
rtpmux: fix buffer list drop check
...
While porting to 0.11, the check was mistakenly made constant,
instead of testing for the return value of process_buffer_locked.
Coverity 1139663
2014-04-21 17:21:20 +01:00
Vincent Penquerc'h
d9eb5f7fde
matroska: fix content encoding scope validity check
...
It's 3 bits, and http://matroska.org/technical/specs/index.html
says it can't be 0.
Coverity 1139660
2014-04-21 17:21:20 +01:00
Vincent Penquerc'h
54c5710adb
matroskamux: fix PAR fraction sanity check
...
It was checking par_num twice, and never par_denum.
Coverity 1139634
2014-04-21 17:21:20 +01:00
Vincent Penquerc'h
25fa88f8aa
multiidpsink: warn when setsockopt fails
...
This doesn't seem to be fatal, but it's good to let the user know
in the logs.
Coverity 1139630
2014-04-21 17:21:20 +01:00
Vincent Penquerc'h
e526412afa
interlace: catch failure to create audio info from caps
...
Coverity 1139627, 1139628
2014-04-21 17:21:20 +01:00
Göran Jönsson
80967c7638
gstrtph264pay: Reset sps pps variable when state change.
...
Reset last_spspps and sps/pps arrays when state transition
GST_STATE_CHANGE_PAUSED_TO_READY.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726015
2014-04-21 12:07:20 +02:00
Wim Taymans
3e11ce43b9
jitterbuffer: improve EOS handling
...
Make a new method to disable the jitterbuffer buffering.
Rework the update_estimated_eos() method. Calculate how much time
there is left to play. If we have less than the delay of the
jitterbuffer, we disabled buffering because we might never be able to
fill the complete jitterbuffer again.
If we receive an EOS event, disable buffering. We will drain the
buffer and eventually push the EOS event out.
When we reach the estimated NPT timeout and we didn't receive an EOS
event, make one and queue it so that it can be pushed.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=728017
2014-04-18 14:07:31 +02:00
Wim Taymans
38a486b374
rtpsession: send reconfigure when internal-ssrc changes
...
When the internal-ssrc property changes, we want to send a reconfigure
upstream to make payloaders use the new suggested ssrc.
Using the internal-ssrc property to change the SSRC of a stream is not a
good idea and doesn't work when there are multiple senders, we want to
set the SSRC directly on the payloaders. Therefore, deprecate this
property.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725361
2014-04-18 10:21:27 +02:00
Wim Taymans
42cfedde7f
jitterbuffer: assume a full buffer when eos
...
Rework the logic to make buffering messages a little, make sure we
don't make the same message multiple times.
Consider the buffer full when EOS was received.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=728017
2014-04-18 04:27:39 +02:00
Sebastian Dröge
2149d5a9bd
rtprtx: Don't forget to unmap rtp buffer in the test
2014-04-17 18:07:09 +02:00
Sebastian Dröge
27cf71e209
rtprtxsend: Require clock-rate in the caps and handle no ssrc in the caps properly
2014-04-17 17:58:58 +02:00
Sebastian Dröge
5dba8dfe59
rtprtx: Provide an ssrc in the test
...
And increase timeout to allow all tests to run in valgrind.
2014-04-17 17:43:12 +02:00
Sebastian Dröge
02d9b5e6f8
rtpsession: Fix memory leaks in test
2014-04-17 17:33:46 +02:00
Sebastian Dröge
02e62c139d
rtpjitterbuffer: Fix hundreds of memory leaks in the test
2014-04-17 17:26:36 +02:00
Sebastian Dröge
897c02cace
rtpjitterbuffer: Unref clock id when waiting for the clock is interrupted
2014-04-17 17:00:37 +02:00
Sebastian Dröge
0c073b2d1d
rtpcollision: Fix memory leaks in unit test
2014-04-17 16:39:59 +02:00
Tim-Philipp Müller
77badda6b9
videomixer: name collectpads object based on videomixer name
...
Makes it easier to track things in debug logs when there
are multiple mixers and muxers.
2014-04-16 21:40:45 +01:00
Tim-Philipp Müller
f8d15b1e56
videomixer: better logging of incoming events
...
The pad and parent names are already logged as part of logging
the object. Instead log the full event details.
2014-04-16 21:38:35 +01:00
Sebastian Dröge
cd4c17031b
videomixer: Fix memory leak in unit test
2014-04-16 19:03:47 +02:00
Sebastian Dröge
b21b46a07a
level: Use the correct number of samples to iterate over the input array
...
Fixes invalid memory accesses and accesses to uninitialised data.
2014-04-16 18:50:50 +02:00
Sebastian Dröge
bd65c36cbb
icydemux: Unref dropped events
2014-04-16 18:50:50 +02:00
Vincent Penquerc'h
457712b933
matroska: fix check for amount of data to read
...
History shows length==0 should set data to NULL and return,
so we do that too instead of trying to read nothing.
Coverity 206205
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
46a39bdd4f
deinterlace: fix sign comparison
...
history_count is unsigned, so the whole comparison will be made
as unsigned, and fail to reject what it was meant to.
Coverity 206204
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
c6acd6368b
avidemux: remove dead code
...
sub may not be NULL in this switch, there is a bail out just
before it if so.
Coverity 206098
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
937269d02e
flacparse: remove dead code
...
The block_size == 0 was shortcut earlier, and the variable is not
modified in the meantime.
Coverity 206097
2014-04-16 17:44:50 +01:00