mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-08-03 20:25:07 +00:00
Code Issues 1 Projects Releases Wiki Activity

goom: fix undefined behaviour of left-shift

Browse source 
Don't left-shift into the sign bit, the result is undefined and potentially
an overflow could flip the sign.
This commit is contained in:
Luis de Bethencourt 2014-04-27 18:29:11 -04:00
parent 5dc2e6bef1
commit 3943c3ec08
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/goom/filters.c
View file

@ -731,7 +731,7 @@ generatePrecalCoef (int precalCoef[16][16])
if (!(coefh || coefv)) {
i = 255;
} else {
int i1, i2, i3, i4;
uint i1, i2, i3, i4;
i1 = diffcoeffh * diffcoeffv;
i2 = coefh * diffcoeffv;