Thiago Santos
ac7f4cba67
qtmux: Write uint tags that don't have a complement
...
Write uint tags that have complements (e.g. track-number/
track-count) even when we only have one of them available
and set the other one to 0.
Fixes #622484
2011-04-12 20:32:17 +01:00
Edward Hervey
0fa380b199
qtmux: Remove the pad from our internal list before calling collectpads
...
Previously we would end up with the collectpaddata structure already freed.
This would result in a bogus iteration of mux->sinkpads (all the
GstQTPad being freed) and it wouldn't be removed from that list.
Finally, due to it not being removed from that list, we would end up
calling a bogus gst_qt_mux_pad_reset on those structures => SEGFAULT
2011-04-12 20:32:17 +01:00
David Schleef
4bb9ffa8fb
qtmux: Add VP8
2011-04-12 20:32:17 +01:00
Tim-Philipp Müller
48880abb5b
qtmux: use GStreamer package name and origin in the plugin info
2011-04-12 20:32:17 +01:00
Tim-Philipp Müller
1663c51243
qtmux: init debug category before using it
2011-04-12 20:32:17 +01:00
Benjamin Otte
6f27e4e488
Add -Wold-style-definition
...
and fix the warnings
2011-04-12 20:32:17 +01:00
Benjamin Otte
c4161b3c33
Add -Wwrite-strings
...
and fix its warnings
2011-04-12 20:32:17 +01:00
Benjamin Otte
62be91708f
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
...
And fix all warnings
2011-04-12 20:32:17 +01:00
Benjamin Otte
af347a9545
gst_element_class_set_details => gst_element_class_set_details_simple
2011-04-12 20:32:17 +01:00
Thiago Santos
281ef57d2b
qtmux: Use xmp on mp4mux and gppmux too
...
Do not restrict xmp to qtmux, but use it too
on mp4mux and gppmux
2011-04-12 20:32:17 +01:00
Thiago Santos
a740adc137
qtmux: add xmp support
...
Adds xmp metatags adding to qtmux.
Fixes #609539
2011-04-12 20:32:16 +01:00
Tim-Philipp Müller
f9bba010fa
qtmux: fix GST_ELEMENT_ERROR usage
...
We need to pass (NULL) rather than NULL for empty arguments.
2011-04-12 20:32:16 +01:00
Rob Clark
ae0d32843e
qtmux: fix compile error
...
gst/quicktime/gstqtmoovrecover.c:268: warning: format not a string literal and no format arguments
https://bugzilla.gnome.org/show_bug.cgi?id=612454
2011-04-12 20:32:16 +01:00
Thiago Santos
8d86f34871
qtmux: Rename 'avc-sample' to 'avc' in caps
...
Fixes #606662
2011-04-12 20:32:16 +01:00
Michael Smith
8b3aca9070
qtmux: Take lock around use of (non-threadsafe) tagsetter interface.
2011-04-12 20:32:16 +01:00
Thiago Santos
953aa983bb
qtmux: write all udta children atoms
...
UDTA might have META and other children atoms
together, write them all.
2011-04-12 20:32:16 +01:00
Thiago Santos
c92785e1c2
qtmux: Use internal sink pads list
...
Due to GstCollectPads sink pads list being not reliably
iteratable (when not inside the collected function) this
patch adds a sink pads list to qtmux to be used when iterating
sink pads on reset function.
Fixes #609055
2011-04-12 20:32:16 +01:00
Mark Nauwelaerts
589f70955c
qtmux: prevent leaking hdlr name
2011-04-12 20:32:16 +01:00
Mark Nauwelaerts
bcc9fe0463
qtmux: support for ALAC
...
Fixes #580731 .
2011-04-12 20:32:16 +01:00
Mark Nauwelaerts
76b6997b55
qtmux: refactor building stsd entry 'wave' extension
2011-04-12 20:32:16 +01:00
Thiago Santos
528846c5a1
qtmux: atomsrecovery: Fix compilation problem
...
Fixes a compilation error due to unused function result.
2011-04-12 20:32:16 +01:00
Thiago Santos
b692f9ffb0
qtmux: Adds moov recovery feature
...
Adds a new property to qtmux that sets a path to a file to write
and update data about the moov atom (that is not writen till the
end of the file). If the pipeline/app crashes during execution it
might be possible to recover the movie using the qtmoovrecover element.
qtmoovrecover is an element that is also a pipeline. It is not
meant to be used with other elements (it has no pads). It is merely
a tool/utilitary to recover unfinished qtmux files.
Fixes #601576
2011-04-12 20:32:16 +01:00
Michael Smith
3c0e4d8267
qtmux: for fixed-sample size streams (PCM audio, etc) don't allocate an enormous
...
buffer that we then won't use at all.
2011-04-12 20:32:15 +01:00
Michael Smith
d784a8da6a
qtmux: handle muxing adpcm correctly.
2011-04-12 20:32:15 +01:00
Michael Smith
5f1941a000
qtmux: Set the mdia hdlr name field to what quicktime uses. Fix writing it
...
since it's not null-terminated. Improves compatibility with some hardware
players.
2011-04-12 20:32:15 +01:00
Michael Smith
2d3dc1653b
qtmux: endianness in gstreamer is an int, not boolean.
2011-04-12 20:32:15 +01:00
Mark Nauwelaerts
150f9ad64d
qtmux: streamline moov data memory storage
...
In particular, use arrays rather than (double) linked lists.
2011-04-12 20:32:15 +01:00
Thiago Santos
6dc515bfa7
qtmux: g_free is NULL safe
2011-04-12 20:32:15 +01:00
Benjamin Otte
6569e9587c
[cleanup] Various style and cleanups
...
Various fixes for gtk-doc warnings and making functions without
arguments take void as parameter.
2011-04-12 20:32:15 +01:00
Thiago Santos
33bf180eaa
qtmux: Actually use new caps info on renegotiation
...
Following the previous qtmux commit, this patch tries
to use the new info added to the caps to fill the 'trak'
atom's fields and children atoms. This way qtmux will
use the late added 'codec_data' when h264parse adds
it in the following pipeline:
videotestsrc num-buffers=200 ! x264enc byte-stream=true ! \
h264parse output-format=0 ! qtmux ! \
filesink location=test.mov
2011-04-12 20:32:15 +01:00
Thiago Santos
a5f22f03aa
qtmux: Do caps renegotiation when it only adds fields
...
Qtmux can accept caps renegotiation if the new caps is a
superset of the old one, meaning upstream added new info to
the caps. This patch still doesn't make qtmux update any
atoms info from the new info, but at least it doesn't
reject the new caps anymore.
A pipeline that reproduces this use case is:
videotestsrc num-buffers=200 ! x264enc byte-stream=true ! \
h264parse output-format=0 ! qtmux ! \
filesink location=test.mov
2011-04-12 20:32:15 +01:00
Mark Nauwelaerts
6beda8aae0
qtmux: provide request pads under wider conditions
...
Fixes #606859 .
2011-04-12 20:32:15 +01:00
Thiago Santos
45458c44a4
qtmux: Only accept avc-sample h264
...
qtmux and mp4mux should only accept h264 in avc-sample
format
2011-04-12 20:32:15 +01:00
Thiago Santos
87450c1b6e
Rename aac's stream-format 'none' to 'raw'
...
Renames aac's stream-format from previous commits from none to
raw
2011-04-12 20:32:15 +01:00
Thiago Santos
cbc0b053ee
qtmux: Only accept stream-format='none' aac
...
Only accept raw aac streams (stream-format=none) to avoid
generating invalid files.
Fixes #604925
2011-04-12 20:32:15 +01:00
Stefan Kost
02d1035571
qtmux: also add .h file changes to unbreak the build
2011-04-12 20:32:14 +01:00
Stefan Kost
05257feb87
qtmux: use correct names from template for request pads
...
The pads where names pad0, pad1, ...
2011-04-12 20:32:14 +01:00
Stefan Kost
7d9ed16bbe
qtmux: move errors _new_pad to the end
2011-04-12 20:32:14 +01:00
Thiago Santos
592171b9b5
qtmux: Accept non-paired uint tags
...
Adds support for unpaired unsigned interger tags
2011-04-12 20:32:14 +01:00
Thiago Santos
9a6514e4a7
qtmux: Adds new tags
...
Maps more tags that are already posted by qtdemux
Fixes #599759
2011-04-12 20:32:14 +01:00
Thiago Santos
c5f6e74db9
qtmux: support more of j2k
...
Reads the new caps added to qtdemux by commit
c917d65e6d
and adds its corresponding atoms.
Also adds support for image/x-jpc as it is the same
as image/x-jp2, except that the buffers need to be
boxed inside a jp2c isom box before muxing. To solve
this the QTPads now have a function that (if
not NULL) is called when a buffer is collected. This
function returns a replacement to the current collected
buffer.
Fixes #598916
2011-04-12 20:32:14 +01:00
Thiago Santos
083f825c43
qtmux: Maps 'classification' tag for 3gpp files
...
Adds the mapping of 'classification' tags to writing of
'clsf' atoms for gppmux.
Based on a patch by: Lasse Laukkanen <ext-lasse.2.laukkanen@nokia.com>
2011-04-12 20:32:14 +01:00
Michael Smith
a597bd7273
qtmux: remove c++ comments and add some more comments.
2011-04-12 20:32:14 +01:00
Michael Smith
d74567ca94
qtmux: add ima adpcm support
2011-04-12 20:32:14 +01:00
Thiago Santos
79a9031c16
qtmux: replace _scale with _scale_round
...
Use the rounding version for improved sync between streams.
Small variations in the duration when muxing might lead to
cumullative wrong timestamping when demuxing.
Fixes #602936
2011-04-12 20:32:14 +01:00
Thiago Santos
259c204f42
qtmux: use timestamps for muxing
...
Try to use timestamps even when the stream has out of order
timestamps, only fall back to durations when we detect an
out of order buffer. Improves sync between streams.
2011-04-12 20:32:14 +01:00
Thiago Santos
e62be695a1
qtmux: fix missing debug argument
...
Adds a missing debug argument
2011-04-12 20:32:14 +01:00
Mark Nauwelaerts
7bf67a6e3d
qtmux: fix misinforming debug statement
2011-04-12 20:32:13 +01:00
Mark Nauwelaerts
a64873e15a
qtmux: ensure writable buffer metadata before setting caps
2011-04-12 20:32:13 +01:00
Thiago Santos
496bd01a0f
qtmux: support for SVQ3
...
Adds support for muxing SVQ3 content. Usually this format
has decoder info that must be passed in the 'seqh' field
in the caps. It is also good to add the gama atom to make
quicktime not crash.
Fixes #587922
2011-04-12 20:32:13 +01:00
Thiago Sousa Santos
d24d1e40ea
qtmux: do not leak a string
...
Frees a string after use. Also does some code organization
2011-04-12 20:32:13 +01:00
Thiago Sousa Santos
2f90d33509
qtmux: do not add size to the pointer variable
...
Do not wrongly add the result of the function to the
pointer to the buffer size. Instead, check the result
to see if the serialization was ok.
Based on a patch by: "Carsten Kroll <car@ximidi.com>"
Fixes #602106
2011-04-12 20:32:13 +01:00
Thiago Santos
8d80e93512
qtmux: handle 'late' streams
...
When muxing streams, some can start later than others. qtmux
now handle this by adding an empty edts entry with the
duration of the 'lateness' to the stream's trak.
It tolerates a stream to be up to 0.1s late.
Fixes #586848
2011-04-12 20:32:13 +01:00
Thiago Santos
22e4fb92a9
qtmux: adds the EDTS and ELTS atoms to atoms.c
...
These atoms will be useful for signaling streams
that start later in the file. As well for adding
edit lists if needed sometime later.
2011-04-12 20:32:13 +01:00
Thiago Santos
009d104a34
qtmux: Adding some ifs for protection
...
Adding somes ifs to protect against warning conditions
that might happen when upstream element is not sane
Fixes #600895
2011-04-12 20:32:13 +01:00
Thiago Santos
4ff2fad6a0
gppmux: Add support for 3gr6
...
Keep track of the chunk durations to be able to add 3gr6
brand if it is a faststart file and the longest chunk is
smaller than a sec. Implemented according to 3gpp
TS 26.244 v6.4.0 (2005-09)
Fixes #584361
2011-04-12 20:32:13 +01:00
Thiago Santos
e8c21f14cc
qtmux: Only push ftyp later (in faststart mode)
...
In faststart mode, there is no need to send the ftyp
right at the beginning of the stream. Waiting and sending it
only later (when the moov atom is ready to be sent) provides
us with more information about the stream and we can better
select the compatible brands.
2011-04-12 20:32:13 +01:00
Thiago Santos
99f47c4b17
qtmux: Improve error message
...
Improve error message when we can't get or estimate the
timestamp/duration of a buffer
2011-04-12 20:32:13 +01:00
Marc-André Lureau
0dec6cbbba
qtmux: fix flags_as_uint to flags[]
2011-04-12 20:32:13 +01:00
Jan Urbanski
d43db1bc8d
qtmux: Don't require endianness field for 8 bit raw audio
...
Fixes bug #590360 .
2011-04-12 20:32:12 +01:00
Edward Hervey
ac88adca6e
qtmux: Remove unused variable.
2011-04-12 20:32:12 +01:00
Edward Hervey
430953e8d2
qtmux: Fix debug statement.
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
c3f462d9b2
qtmux: only use (64-bit) extended (mdat) atom size if needed. Fixes #585319 .
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
55afb65f8c
qtmux: set default movie timescale to microsecond units
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
579a7edb3a
qtmux: compress/optimize stsc writing
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
7c9a6093d8
qtmux: add 3GP style tagging (and refactor appropriately)
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
65b69ddc99
qtmux (and variants): handle pixel-aspect-ratio. Fixes #584358 .
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
7ab5ff91ad
gppmux: enhance ftyp brand heuristic. Fixes #584360 .
2011-04-12 20:32:12 +01:00
Mark Nauwelaerts
4dbeaeefe3
qtmux: use different stsd atom type for H263 for ISO and QT variants
...
Fixes #584114 .
2011-04-12 20:32:12 +01:00
Thiago Santos
8e95c502f7
[qtmux] Fixes segfault when adding a blob as first tag.
...
Moves tags data initialization to the function that actually appends
the tags to the list. Fixes #582702
Also fixes some style caught by the pre-commit hook.
2011-04-12 20:32:11 +01:00
Mark Nauwelaerts
0643bf85bc
gppmux: Add MPEG-4 part 2 to supported formats. Fixes #581593 .
2011-04-12 20:32:11 +01:00
Christian Schaller
f77f7c3979
Add ranks to various muxers and encoders in -bad
2011-04-12 20:32:11 +01:00
Thiago Santos
cea5e53465
qtmux: changes caps of src pads to video/quicktime, variant=something
...
Take a look at bug #580005 for further info.
2011-04-12 20:32:11 +01:00
Thiago Santos
6f763db3b8
mp4mux: Changes src caps to application/x-iso-mp4
...
Fixes #580005
2011-04-12 20:32:11 +01:00
Mark Nauwelaerts
4da6cd7c36
qtmux: fix reusing element
...
State change to READY and then back to PAUSED should still provide
the proper structures as are otherwise freshly available following
a request_new_pad.
Pointed out by Thiago Santos.
2011-04-12 20:32:11 +01:00
Wim Taymans
1fbca3b89d
qtmux: fix includes for lseek
...
--
2011-04-12 20:32:11 +01:00
LRN
61d88bd7da
win32: fix seeking in large files
...
Use _lseeki64() on Windows to seek in large files.
Fixes #576021 .
2011-04-12 20:32:11 +01:00
Edward Hervey
f383b6a5b4
qtmux: Be a bit more verbose in our debug message when failing to renegotiate
2011-04-12 20:32:11 +01:00
Mark Nauwelaerts
ffd2ff3ee6
Additional media type support in qtmux (and friends).
...
Support AMR and H263 for both qtmux and gppmux,
and add extensions in sample table description.
2011-04-12 20:32:11 +01:00
David Schleef
975c375b09
gst/quicktime/gstqtmuxmap.c: Add video/x-qt-part and video/x-m4-part to caps so schroenc/schroparse can use it. Fixes #5...
...
Original commit message from CVS:
* gst/quicktime/gstqtmuxmap.c: Add video/x-qt-part and video/x-m4-part
to caps so schroenc/schroparse can use it. Fixes #566958
2011-04-12 20:32:11 +01:00
Mark Nauwelaerts
c201ab463b
gst/quicktime/gstqtmux.c: Do not tempt or suggest to violate gst_collect_pads API specification.
...
Original commit message from CVS:
* gst/quicktime/gstqtmux.c: (gst_qt_mux_change_state):
Do not tempt or suggest to violate gst_collect_pads API specification.
2011-04-12 20:32:11 +01:00
Mark Nauwelaerts
9b0cbfebd6
gst/quicktime/: Dual license qtmux LGPL/MIT. Fixes #564232 .
...
Original commit message from CVS:
* gst/quicktime/atoms.c:
* gst/quicktime/atoms.h:
* gst/quicktime/descriptors.c:
* gst/quicktime/descriptors.h:
* gst/quicktime/fourcc.h:
* gst/quicktime/ftypcc.h:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
* gst/quicktime/gstqtmuxmap.c:
* gst/quicktime/gstqtmuxmap.h:
* gst/quicktime/properties.c:
* gst/quicktime/properties.h:
Dual license qtmux LGPL/MIT. Fixes #564232 .
2011-04-12 20:32:10 +01:00
Stefan Kost
6a47f1f4b5
Totally remove the internal taglists and fully use tagsetter. Fixes various tag muxing issues.
...
Original commit message from CVS:
* ext/celt/gstceltenc.c:
* ext/celt/gstceltenc.h:
* ext/metadata/gstmetadatamux.c:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
Totally remove the internal taglists and fully use tagsetter. Fixes
various tag muxing issues.
2011-04-12 20:32:10 +01:00
Mark Nauwelaerts
877f7fb3ab
gst/quicktime/atoms.c: Fix mj2 sample description metadata construction.
...
Original commit message from CVS:
* gst/quicktime/atoms.c: (build_jp2h_extension):
Fix mj2 sample description metadata construction.
2011-04-12 20:32:10 +01:00
David Schleef
71eacf835e
gst/quicktime/gstqtmux.c: Quiet a debugging message that I recently added.
...
Original commit message from CVS:
* gst/quicktime/gstqtmux.c: Quiet a debugging message that I recently
added.
2011-04-12 20:32:10 +01:00
David Schleef
b11186eba4
gst/quicktime/gstqtmux.*: Use dts from GST_BUFFER_OFFSET_END() for video/x-qt-part.
...
Original commit message from CVS:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
Use dts from GST_BUFFER_OFFSET_END() for video/x-qt-part.
2011-04-12 20:32:10 +01:00
Mark Nauwelaerts
4f64f6c0e1
gst/quicktime/: Revert previous commit.
...
Original commit message from CVS:
* gst/quicktime/atoms.c:
* gst/quicktime/atoms.h:
* gst/quicktime/descriptors.c:
* gst/quicktime/descriptors.h:
* gst/quicktime/fourcc.h:
* gst/quicktime/ftypcc.h:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
* gst/quicktime/gstqtmuxmap.c:
* gst/quicktime/gstqtmuxmap.h:
* gst/quicktime/properties.c:
* gst/quicktime/properties.h:
Revert previous commit.
2011-04-12 20:32:10 +01:00
Mark Nauwelaerts
af97040b98
gst/quicktime/: Dual license LGPL/MIT, as apparently supposed to.
...
Original commit message from CVS:
* gst/quicktime/atoms.c:
* gst/quicktime/atoms.h:
* gst/quicktime/descriptors.c:
* gst/quicktime/descriptors.h:
* gst/quicktime/fourcc.h:
* gst/quicktime/ftypcc.h:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
* gst/quicktime/gstqtmuxmap.c:
* gst/quicktime/gstqtmuxmap.h:
* gst/quicktime/properties.c:
* gst/quicktime/properties.h:
Dual license LGPL/MIT, as apparently supposed to.
2011-04-12 20:32:10 +01:00
Mark Nauwelaerts
3f72fadc76
gst/quicktime/: Cut detour in sample description extension construction.
...
Original commit message from CVS:
* gst/quicktime/atoms.c: (build_esds_extension),
(build_mov_aac_extension), (build_jp2h_extension),
(build_codec_data_extension):
* gst/quicktime/atoms.h:
* gst/quicktime/fourcc.h:
* gst/quicktime/gstqtmux.c: (gst_qt_mux_audio_sink_set_caps),
(gst_qt_mux_video_sink_set_caps):
* gst/quicktime/gstqtmuxmap.c: (gst_qt_mux_map_format_to_header):
Cut detour in sample description extension construction.
Also actually implement ISO JPEG2000 mj2 format.
2011-04-12 20:32:10 +01:00
Mark Nauwelaerts
6b15001dc5
gst/quicktime/gstqtmux.c: Add some more safety/sanity checks in tag manipulation.
...
Original commit message from CVS:
* gst/quicktime/gstqtmux.c: (gst_qt_mux_add_metadata_tags):
Add some more safety/sanity checks in tag manipulation.
2011-04-12 20:32:09 +01:00
Thiago Sousa Santos
c991a04a93
Copy qtmux from revision 148 of the gst-qtmux repository.
...
Original commit message from CVS:
patch by: Thiago Sousa Santos <thiagossantos@gmail.com>
* configure.ac:
* gst/quicktime/Makefile.am:
* gst/quicktime/atoms.c:
* gst/quicktime/atoms.h:
* gst/quicktime/descriptors.c:
* gst/quicktime/descriptors.h:
* gst/quicktime/fourcc.h:
* gst/quicktime/ftypcc.h:
* gst/quicktime/gstqtmux.c:
* gst/quicktime/gstqtmux.h:
* gst/quicktime/gstqtmuxmap.c:
* gst/quicktime/gstqtmuxmap.h:
* gst/quicktime/properties.c:
* gst/quicktime/properties.h:
Copy qtmux from revision 148 of the gst-qtmux repository.
Fixes #550280 .
2011-04-12 20:32:09 +01:00
Tim-Philipp Müller
ed96310d57
qtdemux: rename directory to quicktime to match plugin name
...
In preparation for qtmux moving to -good.
2011-04-12 19:29:56 +01:00
Mark Nauwelaerts
c539fc40dd
flvdemux: simplify framerate fraction calculation
2011-04-12 11:50:08 +02:00
Leonardo Sandoval
071b90059f
flvdemux: add width, height and framerate to caps when present on onMetaData
...
Fixes #640483 .
2011-04-12 10:48:21 +02:00
Pascal Buhler
0d2d52856f
rtpssrcdemux: Unknown SSRC is not fatal
...
https://bugzilla.gnome.org/show_bug.cgi?id=646966
2011-04-11 17:37:58 -04:00
Pascal Buhler
58ef84846e
rtpsession: Number of active sources should be updated whenever the status of the source changes to active
...
Forward-ported by Olivier Crête
https://bugzilla.gnome.org/show_bug.cgi?id=646965
2011-04-11 17:37:36 -04:00
Havard Graff
53c88ae33e
rtpmanager: ignore a BYE if it is sent with our internal SSRC
...
https://bugzilla.gnome.org/show_bug.cgi?id=646964
2011-04-11 17:34:12 -04:00
Thiago Santos
3d96f40f6a
qtdemux: Adds more h264 fields to its caps
...
Adds alignment=au and stream-format=avc to h264 caps
Fixes #606662
2011-04-11 22:41:23 +02:00
Thibault Saunier
b541208b77
android: Make it ready for androgenizer
...
Remove the android/ top dir
Fixe the Makefile.am to be androgenized
To build gstreamer for android we are now using androgenizer which generates the needed Android.mk files.
Androgenizer can be found here: http://git.collabora.co.uk/?p=user/derek/androgenizer.git
2011-04-11 01:20:11 +02:00
Haakon Sporsheim
fd545e260d
rtpgstpay: declare frag_offset to hold 32bits.
...
As specified in documenation above and below.
https://bugzilla.gnome.org/show_bug.cgi?id=646954
2011-04-09 23:14:18 +01:00
Havard Graff
93f022d6ab
rtpsession: fix wrongly applied patch
...
Obviously recv_rtp_sink does not have much to do with send_rtcp_src...
See commit 046ff170.
https://bugzilla.gnome.org/show_bug.cgi?id=647263
2011-04-09 12:32:37 +01:00
Tim-Philipp Müller
ad0e4442e9
audioparsers: update for set_frame_props -> set_frame_rate API change
2011-04-08 18:07:18 +01:00
Mark Nauwelaerts
dbbf54720c
mpegaudioparse: relax sync match a bit when draining
...
... to at least allow initial caps change (but no further caps jitter).
Fixes unit test again after previous change.
2011-04-08 18:07:18 +01:00
Tim-Philipp Müller
e067c554c2
aacparse, amrparse: gst_fooparse_xyz -> gst_foo_parse_xyz to match GstFooParse
...
See moving-plugins checklist.
2011-04-08 18:07:17 +01:00
Tim-Philipp Müller
e44456b481
audioparsers: hook up to build
2011-04-08 18:07:17 +01:00
Tim-Philipp Müller
7a2a088c53
audioparsers: port to new GstBaseParse in core
2011-04-08 18:07:17 +01:00
Mark Nauwelaerts
de54fa0699
mpegaudioparse: require tighter sync match when draining
2011-04-08 18:07:17 +01:00
Sebastian Dröge
f3a1dc9796
mpegaudioparse: Parse encoder delay and encoder padding from the LAME header if present
2011-04-08 18:07:17 +01:00
Arun Raghavan
a1ec326204
dcaparse: Bump rank to primary+1
...
Seems to work fine with a reasonably wide range of media, so bumping
rank.
2011-04-08 18:07:17 +01:00
Arun Raghavan
3050dbb8fe
dcaparse: Expose frame size in caps
...
This exports the size of the frame (number of bytes from one sync point
to the next) as the "frame_size" field in caps.
2011-04-08 18:07:17 +01:00
Arun Raghavan
c0bc522f24
dcaparse: Expose block size in caps
...
This sets the "block_size" field on caps as the number of samples
encoded in one frame.
2011-04-08 18:07:17 +01:00
Tim-Philipp Müller
d92eba5563
mpegaudioparse: add FIXME for making the base class use xing seek tables better
2011-04-08 18:07:17 +01:00
Sebastian Dröge
bf9859ad61
dcaparse: Add depth and endianness to the caps
...
Some decoders can only handle specific endianness or a fixed
depth and this allows better negotiation.
Fixes bug #644208 .
2011-04-08 18:07:17 +01:00
David Schleef
7d876727b3
Revert "aacparse: allow parsed frames on sink pad"
...
This reverts commit e49b89d5c5
.
2011-04-08 18:07:17 +01:00
David Schleef
ef8edf91d9
aacparse: allow parsed frames on sink pad
2011-04-08 18:07:16 +01:00
David Schleef
9469aa92f3
baseparse: Create baseparse library
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
f3f44f81c3
baseparse: tune QUERY_SEEKING response
...
Even if we currently do not have a duration yet, assume seekable if
it looks like we'll likely be able to determine it later on
(which coincides with needed information to perform seeking).
Fixes #641047 .
2011-04-08 18:07:16 +01:00
Arun Raghavan
f0435d6fd6
baseparse: Update min/max bitrate before first posting them
...
This avoids posting an initial min-bitrate of G_UINTMAX and max-bitrate
of 0.
https://bugzilla.gnome.org/show_bug.cgi?id=641857
2011-04-08 18:07:16 +01:00
Arun Raghavan
7f4a61b56c
mpegaudioparse: Post CBR bitrate as nominal bitrate
...
Even if VBR headers are missing, we can't guarantee that a stream is in
fact a CBR stream, so it's safer to let baseparse calculate the average
bitrate rather than assume a CBR stream. However, in order to make
/some/ metadata available before the requisite number of frames have
been parsed, this posts the bitrate from the non-VBR headers as the
nominal bitrate.
https://bugzilla.gnome.org/show_bug.cgi?id=641858
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
cc1b5ded6d
amrparse: a valid amr-wb frame should not have reserved frame type index
...
See #639715 .
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
d1bea6361b
ac3parse: improve handling of dependent substream frames
...
In particular, timestamps of these should track main-stream timestamps.
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
3f2ffc9e53
baseparse: tune default duration estimate update interval
...
Rather than a fixed default frame count, estimate frame count to aim for
an interval duration depending on fps if available, otherwise use old
fixed default.
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
fa16a9a0ef
baseparse: reverse playback; mind keyframes for fragment boundary
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
39da316386
amrparse: properly check for sufficient available data prior to access
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
fd064765a7
baseparse: ensure non-empty candidate frames
2011-04-08 18:07:16 +01:00
Mark Nauwelaerts
2e76193c56
baseparse: clarify some debug statements
2011-04-08 18:07:15 +01:00
Mark Nauwelaerts
054621a58c
baseparse: properly track upstream timestamps
...
... rather than with a delay.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
6df2a01762
baseparse: need proper frame duration to obtain sensible frame bitrate
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
1749b527c1
baseparse: proper initial values for index tracking variables
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
6616883390
baseparse: arrange for consistent event handling
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
de1d89dba6
baseparse: header style cleaning
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
9f5840572e
baseparse: provide some more initial frame metadata in parse_frame
...
... and document accordingly.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
551eefb757
baseparse: refactor passthrough into format flags
...
Also add a format flag to signal baseparse that subclass/format can provide
(parsed) timestamp rather than an estimated one. In particular, such "strong"
timestamp then allows to e.g. determine duration.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
4163969a24
baseparse: introduce a baseparse frame to serve as context
...
... and adjust subclass parsers accordingly
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
b45821c83f
baseparse: restrict duration scanning to pull mode and avoid extra set_caps call
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
9a76c1d8cd
baseparse: update some documentation
...
Also add some more debug.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
32f57133ac
baseparse: allow increasing min_size for current frame parsing only
...
Also check that subclass actually either directs to skip bytes or
increases expected frame size to avoid going nowhere in bogus
indefinite looping.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
d9def3d05d
baesparse: fix refactor regression in loop based parsing
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
9d9d9beb04
baseparse: pass all available data to subclass rather than minimum
...
Also reduce some adapter calls and add a few debug statements.
2011-04-08 18:07:14 +01:00
Mark Nauwelaerts
feaf23f8bd
baseparse: fix reverse playback handling
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
95c2251390
baseparse: minor typo and debug statement cleanup
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
d1bb142b68
baseparse: reduce locking
...
... which is either already mute and/or implicitly handled by STREAM_LOCK.
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
ce23c62f58
baseparse: avoid loop in frame locating interpolation
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
eafcdf67b9
flacparse: mind gst_buffer_unref not liking NULL
...
Fixes #639950 .
2011-04-08 18:07:13 +01:00
Thiago Santos
244f747df2
audioparsers: baseparse: Be careful to not lose the event ref
...
Don't unref the event if it hasn't been handled, because the caller
assumes it is still valid and might reuse it.
I ran into this problem when transcoding an AVI (with mp3 inside)
to gpp.
https://bugzilla.gnome.org/show_bug.cgi?id=639555
2011-04-08 18:07:13 +01:00
Tim-Philipp Müller
bb8f0d3b4c
dcaparse: fix sync word for 14-bit little endian coding
...
Fix copy'n'paste bug that made us look for the raw little endian
sync word twice instead of looking for the 14-bit LE sync word
as well. Fixes parsing of such streams (see #636234 for sample file).
2011-04-08 18:07:13 +01:00
Tim-Philipp Müller
a8c854374b
docs: minor baseparse docs/comment fixes
...
Remove copy'n'paste leftovers.
2011-04-08 18:07:13 +01:00
Edward Hervey
6fbdfa07a8
flacparse: Fix unitialized variable on macosx
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
cf5b01a55f
ac3parse: relax bsid checking
...
... to the widest possible spec interpretation.
Fixes #637062 .
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
d2a9daec36
audioparsers: update some documentation
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
cfbc40aca7
mpegaudioparse: add to documentation
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
d1d1239fe4
dcaparse: add to documentation
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
0bb654ed66
baseparse: increase keyframe awareness
...
... which is not particular relevant for audio parsing, but more so
in video cases. In particular, auto-determine if dealing with video (caps).
2011-04-08 18:07:13 +01:00
Mark Nauwelaerts
f7de334d61
ac3parse: use proper EAC-3 caps
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
b8af812987
baseparse: avoid unexpected stray metadata
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
24cf864c91
baseparse: use proper _NONE output value when applicable
2011-04-08 18:07:12 +01:00
Edward Hervey
1e71d31e67
audioparsers: Remove dead assignments
2011-04-08 18:07:12 +01:00
Andoni Morales Alastruey
5bfc92714e
audioparse: fix possible division-by-zero
...
https://bugzilla.gnome.org/show_bug.cgi?id=635786
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
a45019fdd6
baseparse: use correct offset when adding index entry
...
... bearing in mind that BUFFER_OFFSET is media specific and may not
reflect the basic offset after having been parsed.
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
76b322a429
baseparse: enhancements for timestamp marked framed formats
...
That is, as such formats allow subclass to extract position from frame,
it is possible to extract duration (if not otherwise provided)
from (near) last frame, and a seek can fairly accurately target the required
position.
Fixes #631389 .
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
634d4de627
baseparse: refactor frame scanning peformed by _loop
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
563f1a136b
baseparse: slightly optimize sending of pending newsegment events
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
5eeb1f2e1f
baseparse: minor fixes and enhancements
...
Arrange for upstream as well as downstream flushing when seeking.
Also determine upstream size as well as seekability. Adjust some comments
to reality and employ debug statement in proper order.
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
3e50f0a3c9
aacparse: minor cleanups
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
31d387f7b5
aacparse: fix regression in ADIF src caps setting
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
55da8e46eb
flacparse: parse seektable
...
Fixes #631389 (partially).
2011-04-08 18:07:12 +01:00
Mark Nauwelaerts
b1f8380e4c
flacparse: minor refactor and enable default baseparse segment clipping
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
b25d139538
mpegaudioparse: fix silly leak in _reset
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
ba56999212
baseparse: use only upstream duration if it provides one
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
3d72afd924
baseparse: reflow update_bitrate code
...
... which makes local variables represent real state better, and avoids
triggering unneeded updates/actions.
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
5aafc17dec
baseparse: add some debug statements
2011-04-08 18:07:11 +01:00
Tim-Philipp Müller
3018bdf8de
dcaparse: init variable to make osx build bot happy
...
gstdcaparse.c: In function 'gst_dca_parse_check_valid_frame':
gstdcaparse.c:246: warning: 'best_sync' may be used uninitialized in this function
2011-04-08 18:07:11 +01:00
Tim-Philipp Müller
75735c4573
audioparsers: add very basic dts/dca parser
...
Still some issues, e.g. with seekable queries in totem, but also
processing already-chunked input (created with matroskademux ! gdppay).
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
5d52d3f6c2
ac3parse: properly parse e-ac3 frame header
...
Also add a few debug statements.
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
98c7f4b2f6
flacparse: tweak setting buffer metadata; avoid timestamp jitter
...
Fixes #631993 .
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
5369b97246
aacparse: streamline src caps setting
...
In particular, also set src caps whenever changes in stream warrant doing so.
2011-04-08 18:07:11 +01:00
Sebastian Dröge
274414e3d6
flacparse: Don't drop the last frame if it is followed by garbage
...
See bug #631814 .
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
2c7c4fa9e4
baseparse: perform bitrate handling and posting after newsegment sending
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
0edaf8470e
baseparse: immediately post subclass provided bitrate
2011-04-08 18:07:10 +01:00
Mark Nauwelaerts
4a7f899f6e
flacparse: fix parsing with unknown framesizes
...
Fixes #631814 (mostly).
2011-04-08 18:07:10 +01:00
Sebastian Dröge
c3678a5384
flacparse: Simplify frame header parsing by using lookup tables
...
Based on a patch by Felipe Contreras.
See bug #631200 .
2011-04-08 18:07:10 +01:00
Sebastian Dröge
572366e179
flacparse: Don't parse the complete FLAC frames but only look for valid frame headers
...
Thanks to Felipe Contreras for the suggestion. This is partially
based on his patches and makes flacparse more than 3.5 times faster.
Looking for valid frame headers is unlikely to give false positives
because every frame header is at least 9 bytes long, contains a
14 bit sync code and a 8 bit checksum over the first 8 bytes.
Fixes bug #631200 .
2011-04-08 18:07:10 +01:00
Sebastian Dröge
bfdc132ad0
flacparse: Really post tags only after the initial newsegment event
...
The first newsegment event will be send by the first call to
gst_base_parse_push_buffer() if necessary, posting the tags
before that is not a good idea. Instead do it from the
GstBaseParse::pre_push_buffer vfunc.
2011-04-08 18:07:09 +01:00
Tim-Philipp Müller
6b71b65289
Revert "baseparse: add skip property"
...
This reverts commit b5a3d60363
.
Reverting this for now, since no one really seems to remember why this
property exists or what it could possibly be good for. It seems to have
been in the original mp3parse since the beginning of time and was back-
ported from there.
2011-04-08 18:07:09 +01:00
Sebastian Dröge
872b49efa7
flacparse: Fix uninitialized variable compiler warnings
...
These warnings are wrong, the variables are only used if they were
initialized by the bit reader.
2011-04-08 18:07:09 +01:00
Felipe Contreras
70d5346ee8
flacparse: fix picture parsing
...
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
2011-04-08 18:07:09 +01:00
Sebastian Dröge
36f48450b1
flacparse: Push tags before the header buffers are pushed
2011-04-08 18:07:09 +01:00
Felipe Contreras
eaa6f789b2
flacparse: trivial caps fix
...
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
2011-04-08 18:07:09 +01:00
Sebastian Dröge
4cc901ed96
audioparser: Let the format string agree with the parameters to fix compiler warning
2011-04-08 18:07:09 +01:00
Sebastian Dröge
6f04047f0c
ac3parse: Use unchecked versions of the bitreader get functions
...
We didn't check the return values anyway...
2011-04-08 18:07:09 +01:00
Arun Raghavan
8ef15e6247
baseparse: Fix debug output
...
We lose the reference to the buffer after gst_pad_push(), so the debug
print should happen before.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
2011-04-08 18:07:09 +01:00
Mark Nauwelaerts
0f5f06d5fa
baseparse: support reverse playback
...
... in pull mode or upstream driven.
2011-04-08 18:07:09 +01:00
Mark Nauwelaerts
304b3c78dd
baseparse: remove done TODOs and update documentation
2011-04-08 18:07:09 +01:00
Mark Nauwelaerts
1a54736255
baseparse: use determined seekability in answering SEEKING query
2011-04-08 18:07:09 +01:00
Mark Nauwelaerts
3f02dbd3ab
baseparse: add skip property
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
dd140c7b4d
mpegaudioparse: initial version
...
... adequately equivalent to mp3parse, so lets boldly set it
to higher rank.
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
2d482deabe
aacparse: set minimum frame size at _start
...
... rather than one time at _init.
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
589c455ccb
baseparse: use _set_frame_props to configure frame lead_in and lead_out
...
... provided a corresponding decoder with sufficient leading and following
frames to carry out full decoding for a particular segment.
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
f218b984cc
baseparse: use _set_duration to configure duration update interval
...
... as it logically belongs there as one or the other; either subclass
can provide a duration, or an estimate must be made (reguarly updated).
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
1f7359d388
baseparse: localize use of provided fps information
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
5dd8a489d5
baseparse: seek table and accurate seek support
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
5a69aa4903
baseparse: proper and more extended segment and seek handling
...
That is, loop pause handling, segment seek support, newsegment for gaps, etc
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
f16146df62
baseparse: add index support
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
261b7ec15f
baseparse: refactor state reset
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
2c81b3bf77
baseparse: prevent indefinite resyncing
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
de189e327f
baseparse: specific EOS handling if no output so far
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
0707c189db
baseparse: adjust _set_frame_prop documentation and set default as claimed
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
723059c688
baseparse: fix bitrate copy-and-paste and update heuristic
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
fea135b3de
baseparse: post duration message if average bitrates is updated
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
0198d6320b
baseparse: remove is_seekable vmethod and use a set_seek instead
...
Seekability, like duration, etc is unlikely to change (frequently), and
the default assumption covers most cases, so let subclass set when needed.
At the same time, allow subclass to indicate if it has seek-metadata (table)
available, and possibly have it provide an average bitrate.
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
10611c2826
ac3parse: remove redundant default is_seekable
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
30be03004e
baseparse: add another hook for subclass prior to pushing buffer
...
... and allow subclass to perform custom segment clipping, or to
emit tags or messages at this time.
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
dc6bd085ed
baseparse: 0 converts to 0 by default
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
0e60101a28
basepase: refactor conversion using helper function and export default convert
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
a84eee533f
baseparse: streamline query handling
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
1c65b8287d
baseparse: cleanup struct and remove unused member
2011-04-08 18:07:07 +01:00
Mark Nauwelaerts
952b27a140
audioparsers: increase ranks to enable auto-plugging
...
Because we can, and should, have some shakedown testing before having
these make it into -good later on ...
2011-04-08 18:07:07 +01:00
Arun Raghavan
3448e83c73
baseparse: Allow chaining of subclass event handlers
...
This allows the child class to chain its event handler with
GstBaseParse, so that subclasses don't have to duplicate all the default
event handling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
2011-04-08 18:07:07 +01:00
Sebastian Dröge
8df3c8477a
baseparse: Don't use GST_FLOW_IS_FATAL()
...
Also don't post an error message for UNEXPECTED and do it
for NOT_LINKED.
2011-04-08 18:07:06 +01:00
Mark Nauwelaerts
7831661c40
baseparse: non-TIME seek event is simply not handled
2011-04-08 18:07:06 +01:00
Mark Nauwelaerts
835473b792
baseparse: fix seek event ref handling
2011-04-08 18:07:06 +01:00
Mark Nauwelaerts
baefba9748
baseparse: prevent arithmetic overflows in pull mode buffer cache handling
2011-04-08 18:07:06 +01:00
Mark Nauwelaerts
a459494097
baseparse: fix seek handling
...
Allow a few more seek event type combinations, and really use the result
of gst_segment_set_seek to perform the seek. Also add some debug.
2011-04-08 18:07:06 +01:00
Arun Raghavan
f7e228edb0
baseparse: Don't emit bitrate tags too early
...
We wait to parse a minimum number of frames (10, arbitrarily) before
emiting bitrate tags so that our early estimates are not wildly
inaccurate for streams that start with a silence. If the stream ends
before that, we just emit the tags anyway.
While it _would_ be nicer to be specify the threshold to start pushing
the tags in terms of duration, this would introduce more complexity than
this merits.
https://bugzilla.gnome.org/show_bug.cgi?id=614991
2011-04-08 18:07:06 +01:00
Sebastian Dröge
00b0444618
flacparse: Optionally check the overall frame checksums too before accepting a frame as valid
...
This is optional because it's a quite expensive operation and it's very
unlikely that a non-frame is detected as frame after the header CRC check
and checking all bits for valid values. The overall frame checksums are
mainly useful to detect inconsistencies in the encoded payload.
2011-04-08 18:07:06 +01:00
Sebastian Dröge
7b10c2afce
flacparse: Check the CRC-8 of the headers before accepting a frame as valid
...
This makes false-positives during seeking much less likely and detection of
them much faster.
2011-04-08 18:07:06 +01:00
Sebastian Dröge
0cf1285980
baseparse: Set the last stop to the buffer starttime if the duration is invalid
...
...instead of not setting it at all.
2011-04-08 18:07:06 +01:00
Joshua M. Doe
017bb65d06
baseparse: Send NEWSEGMENT event with correct start and position
...
Instead of taking the last stop (which could be buffer endtime instead
of starttime) always take the buffer starttime.
Fixes bug #614016 .
2011-04-08 18:07:06 +01:00
Arun Raghavan
7184fe911d
flacparse: Fix buffer refcount issue
...
When called from the GST_FLAC_PARSE_STATE_HEADERS case,
gst_flac_parse_hand_headers() does a gst_buffer_set_caps() on a buffer
with refcount > 1. This change handles this case by making the buffer
metadata_Writable.
https://bugzilla.gnome.org/show_bug.cgi?id=614037
2011-04-08 18:07:06 +01:00
Tim-Philipp Müller
bb7f3ffe41
audioparsers: remove unused GstBaseParseClassPrivate structure
2011-04-08 18:07:05 +01:00
Arun Raghavan
fb4673cde9
flacparse: Make bitrate estimation more accurate
...
This implements the get_frame_overhead() vfunc so that baseparse can
make more accurate bitrate estimates.
2011-04-08 18:07:05 +01:00
Arun Raghavan
44878511b2
aacparse: Fix bitrate calculation
...
This patch adds the get_frame_overhead() vfunc so that baseparse can
accurately calculate the min/avg/max bitrates for aacparse.
Note: The bitrate was being incorrectly calculated for ADTS streams
(it's not in the header as the code suggests).
2011-04-08 18:07:05 +01:00
Arun Raghavan
733669e076
audioparsers: Add bitrate calculation to baseparse
...
This makes baseparse keep a running average of the stream bitrate, as
well as the minimum and maximum bitrates. Subclasses can override a
vfunc to make sure that per-frame overhead from the container is not
accounted for in the bitrate calculation.
We take care not to override the bitrate, minimum-bitrate, and
maximum-bitrate tags if they have been posted upstream. We also
rate-limit the emission of bitrate so that it is only triggered by a
change of >10 kbps.
2011-04-08 18:07:04 +01:00
Benjamin Otte
1b5d7be2c9
gst_element_class_set_details => gst_element_class_set_details_simple
2011-04-08 18:07:04 +01:00
Mark Nauwelaerts
e75e19e7f0
audioparsers: rename baseparse GType name to avoid possible conflicts
2011-04-08 18:07:04 +01:00
Edward Hervey
85ceeaefe5
flacparse: Initialize variables.
...
Fixes build on $#@*( macosx
2011-04-08 18:07:04 +01:00
fc94c56c55
win32: Include config.h before anything else. Fix mpegdemux LIBADD
...
Because config.h defines __MSVCRT_VERSION__, which should be defined
before inclusion of any system header.
Also fixes mpegdemux Makefile.am LIBADD typo.
Fixes #606665
2011-04-08 18:07:04 +01:00
Thiago Santos
d02ef41d32
aacparse: Also add stream-format to template caps
...
Do not forget to add stream-format to template caps
off aacparse
2011-04-08 18:07:04 +01:00
Thiago Santos
13c76e3bc3
Rename aac's stream-format 'none' to 'raw'
...
Renames aac's stream-format from previous commits from none to
raw
2011-04-08 18:07:04 +01:00
Thiago Santos
000754cf63
aacparse: Add stream-format to output caps
...
Adds stream-format field to output caps
2011-04-08 18:07:04 +01:00
Mark Nauwelaerts
b314dabb98
audioparsers: documentation fixes
2011-04-08 18:07:04 +01:00
Mark Nauwelaerts
d3660bbee7
ac3parse: add documentation
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
4ee63d49dd
flacparse: add documentation
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
9bcd66cb98
flacparse: perform additional frame checks when resyncing
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
84e0aae90c
flacparse: fix (multiple channel) frame parsing
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
a18863c8ec
flacparse: declare unparsed input and parsed output
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
d283a44302
ac3parse: fix scanning for next syncword
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
fd848904f9
baseparse: adjust seek handling and newsegment sending
...
Perform sanity check on type of seek, and only perform one that is
appropriately supported. Adjust downstream newsegment event
to first buffer timestamp that is sent downstream.
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
748b96ddef
baseparse: minor refactor cleanup
...
Also add some debug logging.
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
83f02e8bc8
flacparse: locate next sync code more efficiently
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
534e2d7f49
flacparse: baseparse takes care of handling leftover pieces
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
6f3106b603
baseparse: implement leftover draining in pull mode
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
0d53b6ad62
flacparse: set _OFFSET and _OFFSET_END on outgoing buffers
2011-04-08 18:07:03 +01:00
Mark Nauwelaerts
4db789a18c
audioparsers: move 'flacparse' into it
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
14763a68be
baseparse: provide default conversion using bps if no fps available
...
Also store estimated duration as such, rather than pretending otherwise
(e.g. set by subclass).
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
a7f46ed82a
baseparse: check for remaining data when draining in push mode
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
23e55f4d6b
baseparse: fix pull mode cache size comparison
2011-04-08 18:07:02 +01:00
Edward Hervey
be9c6045d0
ac3parse: Fix unitialized variable.
2011-04-08 18:07:02 +01:00
Christian Schaller
d461f7529b
Update spec file and fix ac3parser header listing in Makefile.am
2011-04-08 18:07:02 +01:00
Michael Smith
3be2f72344
audioparse: fix a format string as reported on irc.
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
432abf42c3
ac3parse: ensure sufficient data available for parsing
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
d90c80e017
ac3parse: extract and use some more details for Enhanced Ac-3 streams
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
0777806170
baseparse: custom bufferflag indicates not to count frame in stats
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
b320b08149
ac3parse: perform additional frame checks when resyncing
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
41e3099d66
ac3parse: inform base parser of frame duration
2011-04-08 18:07:02 +01:00
Mark Nauwelaerts
138c4d7f9c
ac3parse: improve src caps settings
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
37a58ebe3a
ac3parse: initial version
...
MARGINAL rank for now; might take some time for some (useful)
framed=true/false to appear here and there.
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
781b61b166
amrparse: use (default) time handling of baseparser class
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
3279f55a77
audioparsers: move 'amrparse' into it
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
db4181119d
audioparsers: reference GstBaseParse now lives here
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
bd56e3ad79
audioparsers: rename 'aacparse' plugin to generic 'audioparsers' plugin
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
d41ed9693d
aacparse: separate plugin registration and rename plugin
2011-04-08 18:07:01 +01:00
Mark Nauwelaerts
7cd3f0a2db
aacparse: ensure sufficient data available before accessing
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
f3d2429f92
aacparse: use (default) time handling of baseparser class
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
4ed9e61615
aacparse: fixup comments to C-style
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
4a2a3a60f4
baseparse: reset passthrough mode to default (disabled) on activation
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
4d637e7549
baseparse: ensure buffer metadata is writable
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
3b88bb6cd6
baseparse: fix/enhance DISCONT marking
...
In particular, consider DISCONT == !sync, and allow subclass to query
sync state, as it may want to perform additional checks depending
on whether sync was achieved earlier on.
Also arrange for subclass to query whether leftover data is being drained.
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
b766e405b3
baseparse: add timestamp handling, and default conversion
...
In particular, (optionally) provide baseparse with a notion of frames per second
(and therefore also frame duration) and have it track frame and byte counts.
This way, subclass can provide baseparse with fps and have it provide default
buffer time metadata and conversions, though subclass can still install
callbacks to handle such itself.
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
cc203d7219
baseparse: documentation fixes
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
4f2790c9a1
baseparse: use_fixed_caps for src pad
...
After all, stream is as-is, and there is little molding to downstream's
taste that can be done. If subclass can and wants to do so, it can
still override as such.
2011-04-08 18:06:59 +01:00
Julien Moutte
bd45e64d31
aacparse: Fix compilation warnings
2011-04-08 18:06:59 +01:00
Josep Torra
906c4faa24
aacparse: fix warnings in macosx snow leopard
2011-04-08 18:06:59 +01:00
Mark Nauwelaerts
fb84ca3d93
aacparse: forego (bogus) parsing of already parsed (raw) input
2011-04-08 18:06:58 +01:00
Mark Nauwelaerts
19c47f9673
baseparse: prevent infinite loop when draining
2011-04-08 18:06:58 +01:00
Mark Nauwelaerts
d610cfbbc0
baseparse: fix minor memory leak
2011-04-08 18:06:58 +01:00
Sebastian Dröge
bfe54aff4b
aacparse: Add function for the baseparse subclass to push buffers downstream
...
Also handle the case gracefully where the subclass decides to drop
the first buffers and has no caps set yet. It's still required to
have valid caps set when the first buffer should be passed downstream.
2011-04-08 18:06:58 +01:00
Sebastian Dröge
c83364ee81
baseparse: Fix seek event leaking
2011-04-08 18:06:58 +01:00
Mark Nauwelaerts
442ab41a05
aacparse: ADIF: do not send bogus timestamps, leave to downstream (decoder)
2011-04-08 18:06:58 +01:00
Tim-Philipp Müller
92c80bc879
aacparse: fix sample rate extraction from codec data
...
In one case we extracted the sample rate index from the codec data
and saved it as sample rate rather than getting the real sample
rate from the table. Fix that, and also make sure we don't access
non-existant table entries by adding a small helper function that
guards against out-of-bounds access in case of invalid input data.
2011-04-08 18:06:58 +01:00
Tim-Philipp Müller
c252137b82
aacparse, amrparse: remove bogus gst_pad_fixate_caps() calls
2011-04-08 18:06:58 +01:00
Tim-Philipp Müller
e74776b3cb
baseparse: propagate return value of GstBaseParse::set_sink_caps()
...
gst_base_parse_sink_setcaps() presumably should fail if the subclass
returns FALSE from its ::set_sink_caps() function.
2011-04-08 18:06:58 +01:00
Tim-Philipp Müller
c59ee281ba
baseparse: don't try to GST_LOG an already-freed caps string
...
The proper way to log caps is via GST_PTR_FORMAT anyway.
2011-04-08 18:06:58 +01:00
Tim-Philipp Müller
fc09fe78af
aacparse: set channels and rate on output caps, and keep codec_data
...
Create output caps from input caps, so we maintain any fields we
might get on the input caps, such as codec_data or rate and channels.
Set channels and rate on the output caps if we don't have input caps
or they don't contain such fields. We do this partly because we can,
but also because some muxers need this information. Tagreadbin will
also be happy about this.
2011-04-08 18:06:57 +01:00
Mark Nauwelaerts
debb9362ef
baseparse: fix debug category
2011-04-08 18:06:57 +01:00
Mark Nauwelaerts
f5379229a0
baseparse: fix (regression in) newsegment handling
...
(aacparse, amrparse, flacparse). Fixes #580133 .
2011-04-08 18:06:57 +01:00
René Stadler
4b80afc22c
baseparse: Fix slightly broken buffer-in-segment check (aacparse, amrparse, flacparse)
2011-04-08 18:06:57 +01:00
René Stadler
471bc5730a
baseparse: Fix push mode seeking (aacparse, amrparse)
...
Sending the flush-start event forward before taking the stream lock actually
works, in contrast to deadlocking in downstream preroll_wait (hunk 1).
After that we get the chain function being stuck in a busy loop. This is fixed
by updating the minimum frame size inside the synchronization loop because the
subclass asks for more data in this way (hunk 2).
Finally, this leads to a very probable crash because the subclass can find a
valid frame with a size greater than the currently available data in the
adapter. This makes the subsequent gst_adapter_take_buffer call return NULL,
which is not expected (hunk 3).
2011-04-08 18:06:57 +01:00
Mark Nauwelaerts
4deaa95eda
baseparse: Delay newsegment as long as possible.
...
If newsegment is sent (too) early, caps may not yet be fixed/set,
and downstream may not have been linked.
2011-04-08 18:06:57 +01:00
René Stadler
179632dc02
aacparse: Fix busyloop when seeking. Fixes #575388
...
The problem is that after a discont, set_min_frame_size(1024) is called when
detect_stream returns FALSE. However, detect_stream calls check_adts_frame
which sets the frame size on its own to something larger than 1024. This is the
same situation as in the beginning, so the base class ends up calling
check_valid_frame in an endless loop.
2011-04-08 18:06:57 +01:00
René Stadler
2856da8601
aacparse: Refactor check_valid_frame to expose broken code
...
Just moving code around and removing an unhelpful/misleading comment.
2011-04-08 18:06:57 +01:00
Stefan Kost
4ffb2499d3
baseparse: revert last change and properly fix
...
Baseparse internaly breaks the semantics of a _chain function by calling it with
buffer==NULL. The reson I belived it was okay to remove it was that there is
also an unchecked access to buffer later in _chain. Actually that code is wrong,
as it most probably wants to set discont on the outgoing buffer.
2011-04-08 18:06:57 +01:00
Stefan Kost
675dc650ca
baseparse: remove checks for buffer==NULL
...
Accordifn to docs for GstPadChainFunction buffer cannot be NULL. If we would
leave the check, we would also need more such check below.
2011-04-08 18:06:57 +01:00
René Stadler
2bfa7bc456
aacparse: Fix license specified in plugin details.
2011-04-08 18:06:56 +01:00
Jan Schmidt
06f4cbd7f3
Fix the return value of the default parse_frame function.
...
Fix the return value of the default parse_frame function in both
copies of GstBaseParse
2011-04-08 18:06:56 +01:00
Stefan Kost
8b20a1d46f
Log aac details found in codec_data.
2011-04-08 18:06:56 +01:00
Wim Taymans
76d9b6deaa
gst/aacparse/gstaacparse.c: Don't autoplug aacparse until it works.
...
Original commit message from CVS:
* gst/aacparse/gstaacparse.c: (plugin_init):
Don't autoplug aacparse until it works.
2011-04-08 18:06:56 +01:00
Stefan Kost
16e3a36dc6
gst/: Fix baseparse type name.
...
Original commit message from CVS:
* gst/aacparse/gstbaseparse.c:
* gst/amrparse/gstbaseparse.c:
Fix baseparse type name.
2011-04-08 18:06:56 +01:00
Stefan Kost
fe9e6d3469
Add two new baseparse based parsers (aac and amr) from Bug #518857 .
...
Original commit message from CVS:
* configure.ac:
* gst/aacparse/Makefile.am:
* gst/aacparse/gstaacparse.c:
* gst/aacparse/gstaacparse.h:
* gst/aacparse/gstbaseparse.c:
* gst/aacparse/gstbaseparse.h:
* gst/amrparse/Makefile.am:
* gst/amrparse/gstamrparse.c:
* gst/amrparse/gstamrparse.h:
* gst/amrparse/gstbaseparse.c:
* gst/amrparse/gstbaseparse.h:
Add two new baseparse based parsers (aac and amr) from Bug #518857 .
2011-04-08 18:06:56 +01:00
Havard Graff
e71a908d96
jitterbuffer: Make src_query MT-safe
...
It is possible that the element might be going down while the event arrives
2011-04-08 15:23:05 +02:00
Sebastian Dröge
4c36ca30b2
jitterbuffer: Unref event if the parent element disappeared
2011-04-08 15:22:19 +02:00
Havard Graff
342686bb02
jitterbuffer: Make upstream events MT-safe
2011-04-08 15:21:46 +02:00
Sebastian Dröge
31af4fe33e
rtp: Unref events if the parent element disappeared
2011-04-08 15:20:51 +02:00
Ole André Vadla Ravnås
046f170d6a
rtpmanager: fix pad callbacks so they handle when parent goes away
...
1) We need to lock and get a strong ref to the parent, if still there.
2) If it has gone away, we need to handle that gracefully.
This is necessary in order to safely modify a running pipeline. Has been
observed when a streaming thread is doing a buffer_alloc() while an
application thread sends an event on a pad further downstream, and from
within a pad probe (holding STREAM_LOCK) carries out the pipeline plumbing
while the streaming thread has its buffer_alloc() in progress.
2011-04-08 15:16:56 +02:00
Havard Graff
f8370bb2a8
rtpsession: make iterate_internal_links MT-safe
2011-04-08 14:41:34 +02:00
Alexey Fisher
9b15f9c6a1
rtpspeexpay: Do not transmitt samples with GAP flag
...
If we get GAP samples, there is no need to transmitt it.
In some situations, microphone is muted, we can drop net traffick
usage to ~1 kbit/s. Without patch it will stay ~20 kbit/s
2011-04-08 13:56:13 +02:00
Wim Taymans
547c97f590
rtspsrc: handle * control correctly
...
Parse session control attributes when no media control attribute is
present. Threat * control attributes as an empty string, just like the
spec says.
Fixes #646800
2011-04-05 17:12:28 +02:00
Sebastian Dröge
cea556b75c
matroskamux: Add support for A-Law and µ-Law
...
Fixes bug #646567 .
2011-04-05 14:29:59 +02:00
Alessandro Decina
30ce2680dc
videomixer: update orc dist files
2011-04-04 17:39:04 +02:00
Mark Nauwelaerts
234609844e
rtspsrc: perform post-flush state tricks downstream to upstream
...
... so downstream is set when upstream resumes data flow.
2011-04-04 11:49:00 +02:00
Mark Nauwelaerts
226a7cb32e
rtspsrc: distribute new base_time to manager children following flush seek
...
... by forcing a state changed to PLAYING, which should otherwise be a
no-op as elements should already be in that state.
In particular, jitterbuffer needs new base_time as soon as possible to perform
proper timing (e.g. eos timeout handling) and can't wait for the new base_time
that will be distributed when the whole pipeline returns to PLAYING.
See bug #646397 .
2011-04-04 11:49:00 +02:00
Mark Nauwelaerts
e5bcaa45e6
Revert "jitterbuffer: reset element base_time upon flush"
...
This reverts commit f84b8a69cb
.
Fixes bug #646397 .
2011-04-04 11:49:00 +02:00
Zaheer Abbas Merali
d44d498aa4
flv: Specify the only possible stream-format for h264 in the pad templates.
2011-04-04 10:35:03 +01:00
Sebastian Dröge
fb12172810
qtdemux: Check for invalid (empty) classification info entity strings
...
Otherwise the classification string can be empty and gst_tag_list_add() will
complain or have a \0 in the first four bytes, which is wrong too.
2011-04-04 10:07:42 +02:00
Sebastian Dröge
17d9447ea5
qtdemux: Year 0 is not a valid year for GDate and the proleptic gregorian calendar
2011-04-04 10:01:26 +02:00
Sebastian Dröge
ce66aea7b0
videomixer[2]: Use orc_memset() instead of memset()
2011-04-01 11:35:26 +02:00
Lane Brooks
ef5ac986f1
videomixer: Add transparent background option for alpha channel formats
2011-04-01 11:35:26 +02:00
Lane Brooks
69b5aedc58
videomixer2: Add transparent background option for alpha channel formats
...
This option allows the videomixer2 element to output a valid alpha
channel when the inputs contain a valid alpha channel. This allows
mixing to occur in multiple stages serially.
The following pipeline shows an example of such a pipeline:
gst-launch videotestsrc background-color=0x000000 pattern=ball ! video/x-raw-yuv,format=\(fourcc\)AYUV ! videomixer2 background=transparent name=mix1 ! videomixer2 name=mix2 ! ffmpegcolorspace ! autovideosink videotestsrc ! video/x-raw-yuv,format=\(fourcc\)AYUV ! mix2.
The first videotestsrc in this pipeline creates a moving ball on a
transparent background. It is then passed to the first videomixer2.
Previously, this videomixer2 would have forced the alpha channel to
1.0 and given a background of checker, black, or white to the
stream. With this patch, however, you can now specify the background
as transparent, and the alpha channel of the input will be
preserved. This allows for further mixing downstream, as is shown in
the above pipeline where the a second videomixer2 is used to mix in a
background of an smpte videotestsrc. So the result is a ball hovering
over the smpte test source. This could, of course, have been
accomplished with a single mixer element, but staged mixing is useful
when it is not convenient to mix all video at once (e.g. a pipeline
where a foreground and background bin exist and are mixed at the final
output, but the foreground bin needs an internal mixer to create
transitions between clips).
Fixes bug #639994 .
2011-04-01 11:35:26 +02:00
Jan Urbański
9c5a12c11f
flvdemux: Do not build an index if upstream is not seekable
...
An index is not useful if upstream cannot handle seeks and building it
for infinite files, for instance FLV streams, results in a memory leak.
2011-03-28 19:53:59 +02:00
Stefan Kost
fb071dd89e
spectrum: refactor processing loop for block based operation
...
Previously the chain function was working sample frame based. In each cycle it
was checking if it is time to run a fft or if it is time to send a message.
Now we changed the data transform functions to work on a block of data and
calculate the max length until either {end-of-data, do-fft, do-msg}. This allows
us also to avoid the duplicated code for the single and multi-channel case (as
the transformers have the same signature now).
2011-03-25 00:15:48 +02:00
Stefan Kost
f00af192c9
spectrum: fix the error accumulation and frames_todo handling
...
Even though we wrap around the accumulated second, we still need to add the
error in the same cycle. Increase the todo in the same conditional as afterwards
the accumulated error will be below one second.
2011-03-24 14:14:09 +02:00
Stefan Kost
315347a8dc
spectrum: fix broken code resulting for a wrong splitup of changes
2011-03-24 13:53:12 +02:00
Stefan Kost
3b552ae6f8
spectrum: simplify the have_interval calculation
...
Move some of the conditions to the places where the dependent variables change.
2011-03-24 11:27:34 +02:00
Stefan Kost
1979b04f46
spectrum: use local var for input_data function
...
Avoid dereferencing the input_data from the instance from within an inner loop.
2011-03-24 11:27:34 +02:00
Mark Nauwelaerts
87e1b06cac
flvmux: use running time for synchronization
...
Fixes #432612 .
2011-03-22 20:55:41 +01:00
Mark Nauwelaerts
dd19a7edad
matroskamux: use running time for synchronization
...
Fixes #432612 .
2011-03-22 20:55:37 +01:00
Mark Nauwelaerts
b02edfbfff
avimux: use running time for synchronization
...
See bug #432612 .
2011-03-22 20:55:27 +01:00
Sebastian Dröge
5b977c4fec
matroska: Mark tag mapping tables as static const
2011-03-16 09:39:20 +01:00
Sebastian Dröge
7db758164d
matroskamux: Use ARTIST instead of AUTHOR for GST_TAG_ARTIST
2011-03-16 09:39:20 +01:00
Sebastian Dröge
52aa27f997
matroskademux: Use ARTIST Matroska tag instead of AUTHOR for GST_TAG_ARTIST
...
AUTHOR only existed in an old version of the spec and ARTIST is
the new replacement for this. We are still reading both to still
be compatible with old files.
Fixes bug #644875 .
2011-03-16 09:39:20 +01:00
Youness Alaoui
a1a0186a62
videoflip: Fix buffer overflow bug for odd resolutions and Y422 colorspaces
...
https://bugzilla.gnome.org/show_bug.cgi?id=644773
2011-03-15 20:23:17 +00:00
Youness Alaoui
a3ed3d9374
videoflip: Add support for YUY2, UVYV and YVYU colorspaces
...
https://bugzilla.gnome.org/show_bug.cgi?id=644773
2011-03-15 09:51:26 +00:00
Andoni Morales Alastruey
0ed0174ea9
matroskamux: return TRUE from sink pad event function for tag events, which are handled
...
https://bugzilla.gnome.org/show_bug.cgi?id=644730
2011-03-14 17:08:46 +00:00
Stefan Kost
32afdea96d
spectrum: more comments and tune and logging
2011-03-10 14:29:25 +02:00
Stefan Kost
1a32265b51
spectrum: avoid unneccesary extra fft runs
...
Before it was possible that we run an extra fft when the time for sending a new
message is due. Only do this if we have not run the fft for the interval at all.
2011-03-10 14:15:42 +02:00
Stefan Kost
f1785b0e4a
spectrum: only scale the vectors that we are processing
...
Phase is not produced by default, so lets not scale it unconditionally to save a
few cycles.
2011-03-10 14:12:01 +02:00
Stefan Kost
5bf267c485
spectrum: put number of channels to instance variable
...
When freeing data the format might have changed. Thus we need to remember for
which format we allocated memory.
2011-03-10 14:10:25 +02:00
Stefan Kost
dc1fe1d77f
spectrum: update doc review stamp
2011-03-10 10:27:41 +02:00
Stefan Kost
b792b100e2
spectrum: use function pointers for data readers
...
Don't check the format for each sample frame to read. We can make that decission
in _setup already. This is still not ideal as we call the function per frame.
Ideally we determine how many samples we can copy and have a loop in the input
reader. As an alternative we might also consider to use the fft variants for the
various formats and not convert to float for all cases - we would still need to
mix or deinterleave though.
2011-03-10 10:27:41 +02:00
Mark Nauwelaerts
2738917852
rtspsrc: improve recovery from failed seek
...
In case server-side fails to perform seek, i.e. PLAY at non-zero requested
position, recovery so far would arrange for streaming to continue, albeit
having lost position tracking in the process. So, query position prior
to seek and use upon failed seek.
2011-03-09 17:18:09 +01:00
Mark Nauwelaerts
6bc1aa0e59
jitterbuffer: handle position query
2011-03-09 17:18:08 +01:00
Stefan Kost
c622477a92
spectrum: multi-channel support
...
Add a boolean multi-channel property with a default of FALSE. When set to TRUE
the element won't mix all input channels to mono, but instead run a FFT on each
channel. In that case the result message would contain a 2 dimensional array
of channel x data for magnitude and phase.
API: GstSpectrum:multi-channel
https://bugzilla.gnome.org/show_bug.cgi?id=593482
2011-03-09 17:01:47 +02:00
Stefan Kost
832aac534a
spectrum: more xrefs in the docs
2011-03-09 17:00:58 +02:00
Stefan Kost
65f4c4b3e6
spectrum: factor out the code that accumulated samples into the ring-buffer
...
Use a separate function to read a sample frame into a ringbuffer slot. In the
future we can use format-specific function pointer to avoid the reoccuring
format checks.
2011-03-09 17:00:58 +02:00
Stefan Kost
5b9028c52c
spectrum: pull format to temp var to improve readability of lines using it
2011-03-09 17:00:58 +02:00
Stefan Kost
b60675acaf
spectrum: code cleanup for copying data to ring-buffer
...
Rename fp to is_float and restructure if-else part for handling the different formats.
2011-03-09 17:00:58 +02:00
Stefan Kost
787aca6898
spectrum: add a GstSpecrtumChannel context structure
...
We now keep the fft data that is related to one channel in a separate structure
to prepare for multichannel support. We also refactor the code to operate more
often on the channel context.
2011-03-09 17:00:57 +02:00
Stefan Kost
2fd09ebd89
spectrum: call the instance var spectrum instead of filter
2011-03-09 17:00:57 +02:00
Stefan Kost
d8d6a3b79e
spectrum: don't value we already took from the gvalue
2011-03-09 17:00:57 +02:00
Mark Nauwelaerts
1f7f434df6
jitterbuffer: also estimate eos if very near eos
2011-03-07 16:56:43 +01:00
Mark Nauwelaerts
3c9a4239bf
jitterbuffer: avoid trying to buffer more than is available.
...
That is, in case of short (or near eos of) stream, deadlock (until timeout)
would occur trying to buffer more than is yet forthcoming.
2011-03-07 16:56:18 +01:00
Mark Nauwelaerts
f84b8a69cb
jitterbuffer: reset element base_time upon flush
...
... to arrange for properly scheduled timeout (following seek).
2011-03-07 11:07:12 +01:00
Mark Nauwelaerts
b69c605c2c
wavparse: tune output max buffer size to material
...
... to avoid ending up with tons of short time buffers for e.g. high sample
rate audio.
2011-03-04 18:43:29 +01:00
Stefan Kost
3ec3bed497
monoscope: don't leak the monoscope_state data
...
The monoscope_close() implementation was empty.
2011-03-02 13:01:45 +02:00
Stefan Kost
7bc3344131
monoscope: we have 64 colors, don't access colors[64]
...
Fixes remaining invalid read.
2011-03-02 13:01:45 +02:00
Mark Nauwelaerts
0ffd4ff8c0
qtdemux: arrange for non-fatal error when parsing non-vital parts
2011-03-02 10:26:46 +01:00
Stefan Kost
d2ee8b979d
monoscope: stack needs to be size+1 as we put a end-marker into it
...
Valgrind is still complaining about one bad read, but this takes care of the
crash mentioned in the comment and in bug #564122 .
2011-03-02 10:56:33 +02:00
David Schleef
caa971e605
qtdemux: remove accidental debug message
...
in previous commit
2011-02-25 20:12:35 -08:00
David Schleef
6565dd5fbc
qtdemux: Add support for 2Vuy and r210
2011-02-25 19:36:26 -08:00
Sebastian Dröge
88cbcf5aa4
deinterlace: Add support for NV21 colorspace
2011-02-24 14:08:25 +01:00
Carsten Kroll
ce0e34a0d5
deinterlace: Add support for NV12 colorspace
...
Fixes bug #642961 .
2011-02-24 14:00:37 +01:00
Robert Swain
6607cdcc08
deinterlace: Simplify setcaps
...
The current code never uses upstream negotiation so the code can be
significantly simplified.
2011-02-23 13:09:19 +01:00
Robert Swain
6402556157
deinterlace: Port greedyl to GstDeinterlaceSimpleMethod
...
The main goal of this change is to reuse the complex but now neatly
written scanline pointer calculation code from the simple methods.
2011-02-23 13:09:19 +01:00
Stefan Kost
98501f6f45
Revert "id3demux: ensure a taglist before adding the container tag"
...
This reverts commit a86bab6689
. The issue is
fixed with commit ff5e5a8f0d
instead.
2011-02-22 15:21:42 +02:00
Stefan Kost
ff5e5a8f0d
id3demux: return ID3TAGS_BROKEN_TAG for unsupported versions
...
This prevents us for trying to work with a NULL taglist.
2011-02-22 15:21:28 +02:00
Edward Hervey
e08bdf691d
qtdemux: Fix unitialized variable.
2011-02-22 14:16:05 +01:00
Mark Nauwelaerts
940417edc3
avidemux: ensure sane parameters when parsing superindex
2011-02-22 14:03:25 +01:00
Mark Nauwelaerts
d680842a7f
avidemux: check for NULL audio stream format header when parsing stream
2011-02-22 14:03:23 +01:00
Blaise Gassend
0f88181f43
rtpbin: handle NULL demux elements
...
When using gstrtpbin with ignore-pt=true, the free_stream function tries to
call gst_element_set_locked_state and gst_element_set_state on a stream->demux
which is NULL.
fixes #642412
2011-02-22 13:31:35 +01:00
Robert Swain
6b26017ae7
deinterlace: small clean-ups
...
Improve debug output by printing the buffer pointer when
popping a buffer and simplify code to use scanlines.bottom_field
as appropriate.
https://bugzilla.gnome.org/show_bug.cgi?id=642691
2011-02-21 20:14:19 +00:00
Robert Swain
32f757786b
deinterlace: fix assigned method_id when using fallback
...
https://bugzilla.gnome.org/show_bug.cgi?id=642691
2011-02-21 20:14:09 +00:00
Wim Taymans
45ea930a99
rtpbin: fix setting the SDES property
...
Only the sdes veriable is protected with the object lock.
Use the right object when setting the sdes property.
2011-02-21 17:19:05 +01:00
Edward Hervey
6e1c701502
Revert "Check that collectpads exists before removing pad"
...
This reverts commit 8e6b876e76
.
Depends on a core commit that was reverted
2011-02-21 12:25:19 +01:00
Tim-Philipp Müller
06972db7b6
icydemux: fix tag list handling issues that might have caused crashes
...
Fix slightly confused tag handling in some places: make it clear when
we're taking ownership of a tag list and when not. For example,
gst_icydemux_tag_found() was taking ownership when the source pad
existed, but otherwise not (leak). Also, gst_event_parse_tag() does
not return a newly-allocated taglist, but a tag list that belongs to
the tag event, so don't give ownership of it away.
While we're at it, some minor clean-ups: don't re-invent g_strndup()
and simplify gst_icydemux_parse_and_send_tags() a bit, and don't
leak the tag list in case no valid tags where found.
https://bugzilla.gnome.org/show_bug.cgi?id=641330
2011-02-21 11:03:03 +00:00
David Schleef
8e6b876e76
Check that collectpads exists before removing pad
...
The core now calls release pad from finalize, at which point
the collectpads might have already been freed.
2011-02-20 23:46:01 -08:00
Stefan Kost
367adf2b69
avidemux: stream->current_total is accumulated byte size and not time
...
Use timestamp for the stream index as well.
2011-02-18 10:14:32 +02:00
David Schleef
053f03c032
udpsink: warn when packet is too large
2011-02-17 18:05:43 -08:00
David Schleef
e017e14847
matroskaparse: New element
...
Copied from demux. Duplicates much code, also some dead code
remaining.
2011-02-17 18:05:43 -08:00
David Schleef
eab982ce60
matroskademux: Earlier debug category initialization
2011-02-17 18:05:43 -08:00
David Schleef
63bb9807a3
flvmux: don't set duration for live stream
2011-02-17 18:05:43 -08:00
David Schleef
1732baf7af
debugutils: remove bitrotten negotiation element
...
Wasn't enabled, didn't work, and planned features have been
superceded by capsfilter and capsdebug.
2011-02-17 18:05:43 -08:00
David Schleef
e54ba41ff7
rtpvrawpay: Implement interlacing
2011-02-17 18:05:43 -08:00
Stefan Kost
d8f29266e9
avidemux: also add the frame-type for the stream index
2011-02-17 17:57:42 +02:00
Stefan Kost
80d820ff29
avidemux: get the index writer id when the pad has a parent
...
Otherwise the index writer has a weired name, as the pad has no parent yet.
2011-02-17 17:56:29 +02:00
Stefan Kost
99e4bdd8f2
avidemux, flvdemux: formatting cleanup
...
Trim trailing whitespaces and fix the formatting of double negation.
2011-02-17 14:13:36 +02:00
Stefan Kost
ade128a002
avidemux, flvdemux: mark delta-units in the index
...
We need to use the 'delta' flag for delta units and not the 'none' flag.
2011-02-17 14:13:36 +02:00
Stefan Kost
b38cf735a5
qtdemux: mark delta-unit in the index
...
We need to use the delta flag fro delta units and not none. Print more details
to the debug log.
2011-02-17 12:50:03 +02:00
Stefan Kost
9852f1cee6
qtdemux: formatting cleanup
...
Trim trailing whitespaces and fix the formatting of double negation.
2011-02-17 12:48:49 +02:00
Stefan Kost
8d5be2e8a4
matroskamux: rework _request_new_pad to handle explict req-pad-names
...
Don't ignore explicit pad-names.
2011-02-16 17:15:28 +02:00
Stefan Kost
1e034cb01f
avimux: rework _request_new_pad to handle explict req-pad-names
...
Don't ignore explicit pad-names. Rearrange the code and the error handling a
bit. Add a FIXME-0.11 for the bad pad-names.
2011-02-16 17:15:27 +02:00
Andy Wingo
cfeb84b821
plug qtdemux refcount leaks
...
* gst/qtdemux/qtdemux.c (gst_qtdemux_src_convert): Unref the qtdemux; we
weren't doing so before.
(gst_qtdemux_handle_src_event, gst_qtdemux_chain): Fix some error
cases which would leak a ref to the qtdemux.
2011-02-15 16:30:29 +01:00
Mark Nauwelaerts
d466f07def
matroskademux: avoid sorting NULL array of cluster positions
2011-02-14 17:57:33 +01:00
Wim Taymans
4279aa6a68
theorapay: handle 0 sized packets
...
Handle 0 sized packets (repeat frame) in the payloader and depayloader.
Fixes #641827
2011-02-14 16:48:06 +01:00
Tuukka Pasanen
d203b1ef50
taginject: resend tags when they are changed
...
Allow setting new tags on the property while running and send them.
Fixes #640249
2011-02-14 15:23:56 +02:00
Miguel Angel Cabrera Moya
3cca27ced1
rtspsrc: fix minor leaks when handling server requests.
...
https://bugzilla.gnome.org/show_bug.cgi?id=640163
2011-02-14 11:33:18 +01:00
Heath Nielson
aa7e638d8e
qtdemux: extract MusicBrainz tags
...
Extract MusicBrainz tags added by MusicBrainz's Picard
tagger application. These tags (esp. the album id) are
helpful for rhythmbox et.al. to automatically downloads
cover art.
https://bugzilla.gnome.org/show_bug.cgi?id=642205
2011-02-14 00:49:00 +00:00
Tim-Philipp Müller
6f0a4fa85b
qtdemux: refactor iTunes tag parsing a bit
2011-02-14 00:38:45 +00:00
Mark Nauwelaerts
686189f3f0
qtdemux: propagate error during expose_streams
...
... as it may occur during initial parsing of fragmented file.
2011-02-10 18:17:56 +01:00
Mark Nauwelaerts
3dc42d3704
qtdemux: avoid skipping exposing a stream following a removed stream
2011-02-10 18:17:40 +01:00
Mark Nauwelaerts
b70f4b6ffa
matroskademux: store cluster positions provided by SeekHead
...
... and use those, if available, to locate a cluster rather than scanning.
2011-02-10 18:17:31 +01:00
Mark Nauwelaerts
9de84b45bc
matroskademux: properly resume cluster scanning
...
... rather than getting offset tracking messed up, and then likely
failing a subsequent assert.
2011-02-09 16:27:00 +01:00
Stefan Kost
a86bab6689
id3demux: ensure a taglist before adding the container tag
...
In the case of id3v1 also don't return NULL on empty tags, but also create a new
taglist and add the container tag for consistency.
2011-02-08 10:07:43 +02:00
Stefan Kost
6f6b2a7efc
rtspsrc: strip trailing spaces
2011-02-07 17:08:47 +02:00
Stefan Kost
5e071d51f2
rtpsrc: set multiple properties in one go
...
There is no need for separate g_object_set() calls here.
2011-02-07 17:07:42 +02:00
Thiago Santos
cb527623a3
deinterlace: Handle image caps without asserting
...
Images might have framerate=0/1 in the caps, which caused an
assertion on deinterlace. I don't know of interlaced image formats
but deinterlace might be hardcoded on some generic pipelines and
it shouldn't assert.
The fix was to set field_duration to 0 if the input has a framerate
with a 0 numerator.
This patch also adds checks for this situation on the unit tests.
https://bugzilla.gnome.org/show_bug.cgi?id=641400
2011-02-04 09:38:35 -03:00
Stefan Kost
18213aa214
docs: fix parameter name in udpsrc docs
...
It is "buffer-size" and not "buffer". Also trim trailing whitespace.
2011-02-04 12:34:08 +02:00
Wim Taymans
61382aad28
source: fix type of ntpnstime
2011-02-02 18:30:47 +01:00
Wim Taymans
8598aaf81b
rtpbin: Get and use the NTP time when receiving RTCP
...
When we receive an RTCP packet, get the current NTP time in nanseconds so that
we can correctly calculate the round-trip time.
2011-02-02 18:30:46 +01:00
Olivier Crête
8a7a327db7
rtptheoradepay: Request new keyframe on lost packets
...
Theora can only use the last frame (or the keyframe) as a reference, so in
practice. If we receive a buffer that references an unknown codebook, request
new headers. It probably means that headers were lost.
2011-02-01 18:28:51 +01:00
Olivier Crête
cd923223dd
rtpsession: Add action signal to request early RTCP
2011-02-01 18:28:51 +01:00
Olivier Crête
c0996e6b90
rtpsession: Add callback to get the current time
2011-02-01 18:28:51 +01:00
Olivier Crête
a630c68fc3
rtpsession: Don't relay more than one PLI request per RTT
...
Drop PLI requests if one was relay in the last RTT, the other side may
just not have received the keyframe yet.
2011-02-01 18:28:51 +01:00
Olivier Crête
a61bb9e94b
rtpsession: Send GstForceKeyUnit event in response to received RTCP PLI
2011-02-01 18:28:51 +01:00
Sjoerd Simons
7350d2adfa
gstrtpsession: Fallback for FIR to PLI if PLI isn't available
2011-02-01 18:28:51 +01:00
Olivier Crête
52f95fa7ee
rtpsession: Implement sending PLI packets in response to GstForceKeyUnit
2011-02-01 18:28:51 +01:00
Olivier Crête
db5150a23a
rtpsource: Retain RTCP Feedback packets for a specified amount of time
2011-02-01 18:28:51 +01:00
Olivier Crête
90354ecb49
rtpsession: Make rtcp buffer metadata writable after processing it
...
Functions that process the rtcp buffer could decide to keep a ref
on the buffer for further processing. So make the metadata writable
only after they are done.
2011-02-01 18:28:50 +01:00
Olivier Crête
1643f427db
rtpsession: Emit signal on incoming RTCP FB packet
2011-02-01 18:28:50 +01:00
Wim Taymans
f399b6a641
rtpsession: fix compilation
2011-02-01 18:28:50 +01:00
Olivier Crête
1bde427250
rtpsession: Add method to request early RTCP packet
...
Implement the early mode defined in RFC 4585. In this mode, RTCP feedback
packets are sent early to notifier.
2011-02-01 17:03:39 +01:00
Olivier Crête
975e1fecb3
rtpsession: Add property for minimum interval between Regular RTCP messages
...
This can be changed according to RFC 4585
2011-02-01 16:56:15 +01:00
Olivier Crête
cdb5465741
rtpsession: Emit signal when sending a compound RTCP packet
...
This allows users to add extra RTCP packets to the compound
RTCP packet.
2011-02-01 16:50:58 +01:00
Olivier Crête
589b254ce5
rtpptdemux: Tag upstream custom events with payload type
2011-02-01 16:50:25 +01:00
Olivier Crete
c7b1ce7310
rtpssrcdemux: Tag upstream custom events with SSRC
2011-02-01 16:49:10 +01:00
Olivier Crête
9f073459e0
rtpsession: Emit "on-ssrc-validated" when validating by RTCP
...
Emit "on-ssrc-validated" if the SSRC is validated by receiving
a RTCP SDES packet.
2011-02-01 16:45:58 +01:00
Wim Taymans
f95c30a413
j2kpay: skip EPH packets
...
Include EPH markers into the previous chunk of packets.
2011-02-01 16:39:10 +01:00
Olivier Crête
07ebec51f5
rtppcmapay: Rename the class to have the right name
...
It was name pmca instead of pcma and made debug logs hard to search.
2011-01-31 17:56:43 -05:00
Tim-Philipp Müller
ede0635d45
deinterlace: simplify template caps
...
We can merge all the YUV variants into one single structure.
2011-01-31 13:44:45 +00:00
Mark Nauwelaerts
8d90dba55e
avidemux: initialize local variable to please mingw32 compiler
2011-01-27 16:02:46 +01:00
Mark Nauwelaerts
7def8c9b98
udp: use socklen_t where appropriate rather than custom type
...
In particular, fixes Cygwin build where socklen_t is defined as int
in line with native win32 api definition.
2011-01-27 16:01:09 +01:00
Mark Nauwelaerts
cb76a13cc9
qtdemux: mind rounding issues when converting from global time to mov time
...
In particular, this avoids missing the intended keyframe when first converting
from the frame's mov time to global segment time, and then back from global
time to mov time when activating the segment.
2011-01-27 12:27:38 +01:00
Ognyan Tonchev
0add79cbf1
matroskamux: don't leak ebml writer caps when re-using matroskamux
...
https://bugzilla.gnome.org/show_bug.cgi?id=640542
2011-01-26 08:51:04 +00:00
Stefan Kost
9f34b89245
rtpjitterbuffer: don't divide by 0
2011-01-25 21:57:57 +02:00
Mark Nauwelaerts
68fc03fd76
matroskademux: pull mode should always report seekable
...
... as it no longer requires an index, but can seek by scanning as well.
2011-01-24 22:24:28 +01:00
Mark Nauwelaerts
9f7570f132
qtdemux: support some more mpeg-4 fourcc variants
2011-01-24 22:23:56 +01:00
Mark Nauwelaerts
662ec520ae
qtdemux: simplify retrieving stsd child entry atom
2011-01-24 22:23:53 +01:00
Edward Hervey
c6b9f5b25a
avidemux: Don't consider 0 fcc_handler as uncompressed.
...
Just avoids a warning
2011-01-24 18:30:57 +01:00
Wim Taymans
899dad8949
qtdemux: take configured start time into account
...
when creating the newsegment event, take the configured start time
into account.
2011-01-24 16:48:17 +01:00
Tim-Philipp Müller
06364a54ce
qtdemux: fix printf format warning on mingw32
...
Make win32 build bot happy again, and nicefy output while we're at it.
qtdemux.c: In function 'qtdemux_parse_trun':
qtdemux.c:2162:3: error: format '%lu' expects type 'long unsigned int', but argument 9 has type 'guint32'
2011-01-24 15:11:02 +00:00
Tim-Philipp Müller
693b3b7e0b
h264depay: don't leak codec data buffer in byte-stream=true mode
...
https://bugzilla.gnome.org/show_bug.cgi?id=640063
2011-01-20 14:10:55 +00:00