Benjamin Otte
33c2f5fb01
Add -Wwrite-strings
...
and fix its warnings
2010-03-22 13:16:33 +01:00
Michael Smith
29fe6205ca
id3mux: glib doesn't reliably null-terminate wide-character encodings in
...
g_convert, so write the null-terminator separately and explicitly.
2009-10-27 14:32:30 -07:00
Michael Smith
2caac8d175
id3tag: actually write image to APIC tag.
2009-10-16 14:37:02 -07:00
Michael Smith
196acecc04
id3mux: Write UTF-16 byte order marker correctly.
2009-10-05 11:15:41 -07:00
Michael Smith
af6ea56cce
id3tag: When writing id3v2.3, do not use UTF-8.
...
UTF-8 is only permitted in v2.4. So instead use ISO-8859-1 for ascii-only
strings, and UTF16 otherwise. Also, do not null terminate strings in text
frames, except where required. These two allow windows media player to play
(and correctly read tags) files created by id3mux.
2009-09-10 12:14:28 -07:00
Sebastian Dröge
b7534074e2
id3tag: Unconditionally use GLib 2.16 API
2009-08-31 08:14:10 +02:00
Tim-Philipp Müller
e2ef7a2a8a
id3mux: init genre field in ID3v1 tag to an invalid number
...
So that it is not interpreted as 'Blues' if no genre is to be written.
2009-06-06 02:35:35 +01:00
Tim-Philipp Müller
75cc0245fa
id3mux: don't write ID3v1 tag until specifically instructed to do so
...
ID3v1 tags are one of the most broken and ill-designed things that
exist on this planet. Let's not write them by default.
2009-06-06 02:13:13 +01:00
Tim-Philipp Müller
73f231fac9
id3mux: don't write empty ID3v1 tag
2009-06-06 02:13:13 +01:00
Tim-Philipp Müller
09a304b39a
id3tag: rename new id3tag element to id3mux replacing the one removed from -ugly
2009-06-06 02:13:07 +01:00
Tim-Philipp Müller
e5b1c976c4
id3tag: canonicalise function names
2009-05-22 09:54:57 +01:00
Tim-Philipp Müller
fdaeae57c9
id3tag: change GType to GstId3Tag so it doesn't conflict with the id3tag plugin in -ugly
2009-05-22 09:51:29 +01:00
Tim-Philipp Müller
02bff8754b
id3tag: register GType of the base class with a less generic name
...
.. so we can easily move the base class into -base later without
causing GType name conflicts.
2009-05-22 01:30:48 +01:00
Michael Smith
fe38f53572
id3tag: Add new id3 tagging plugin, supports v1, v2.3, and v2.4.
...
By default, does v1 and v2.3, but there are properties to select.
Will hopefully replace id3mux, id3v2mux, in the not-too-distant future.
2009-05-21 13:15:46 -07:00
