mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-17 05:46:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

id3mux: glib doesn't reliably null-terminate wide-character encodings in

Browse source 
g_convert, so write the null-terminator separately and explicitly.
This commit is contained in:
Michael Smith 2009-10-27 14:31:39 -07:00
parent 63734cbb3c
commit 29fe6205ca
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/id3tag/id3tag.c
View file

@ -374,10 +374,11 @@ id3v2_frame_write_string (GstId3v2Frame * frame, int encoding,
/* Write the BOM */
id3v2_frame_write_bytes (frame, (const guint8 *) bom, 2);
/* NUL terminator is 2 bytes, if present */
terminator_length = null_terminate ? 2 : 0;
id3v2_frame_write_bytes (frame, (const guint8 *) utf16,
utf16len + terminator_length);
id3v2_frame_write_bytes (frame, (const guint8 *) utf16, utf16len);
if (null_terminate) {
/* NUL terminator is 2 bytes, if present. */
id3v2_frame_write_uint16 (frame, 0);
}
g_free (utf16);
} else {