Mark Nauwelaerts
8bf4c1e1a8
queue2: don't read beyond the end of file upstream in pull mode
...
... which could lead to a premature eos being reported downstream,
rather than a successful partial read which would result when
performed directly on e.g. basesrc.
2011-02-15 14:51:20 +01:00
Mark Nauwelaerts
e14c133587
queue2: properly identity dequeued event as such
...
... which avoids terminating with ERROR rather than UNEXPECTED.
2011-02-02 15:37:38 +01:00
Mart Raudsepp
b387daa6ff
docs: Fix GstQueue2:ring-buffer-max-size property Since tag (0.10.31, not 0.10.30)
2011-01-24 14:38:36 +00:00
Tim-Philipp Müller
d692735f49
coreelements: GST_BOILERPLATE already sets parent_class
2010-12-31 00:56:11 +00:00
Edward Hervey
8f12a5e7cd
queue2: Only call update_buffering if needed.
...
update_buffering is so big it will never be inlined (and shouldn't),
we therefore move the check outside of it.
2010-12-02 19:04:57 +01:00
Edward Hervey
66bba2a49e
queue2: Avoid re-checking many times whether an item is a buffer
...
Avoids calling 6 times gst_buffer_get_type() for every item coming
through queue2
2010-12-02 19:04:56 +01:00
Edward Hervey
080c965f4f
queue2: Reduce amount of time locks are taken
2010-12-02 19:04:56 +01:00
Edward Hervey
ccb9ed2e80
queue2: Fixup documentation of some properties
2010-12-02 19:04:56 +01:00
Edward Hervey
8a79c1aa98
queue2: Avoid useless segment_to_running_time() calculations.
...
* Cache src and sink time
* Use a boolean to known whether src/sink time needs to be recalculated
Avoids 50% of calls to gst_segment_to_running_time()
2010-12-02 19:04:56 +01:00
Sebastian Dröge
6720373610
queue2: Remove dead assignment and unused variable
2010-12-02 19:02:08 +01:00
Sebastian Dröge
3b9d85d1a7
queue2: Remove dead assignment and move variable declaration into inner block
2010-12-02 19:02:08 +01:00
Sebastian Dröge
e554c7a1f6
queue2: Remove redundant variable
...
Other than saving an immense amount of 4 bytes of memory this
prevents clang from complaining and keeps the ring buffer state
in a single variable instead of two.
2010-12-02 19:02:08 +01:00
Tim-Philipp Müller
2ee5e4d8ac
queue2: don't leak pad ref in pull mode when flushing
...
Fix pad leak when queue2 is flushing or being shut down.
2010-11-01 12:34:15 +00:00
Tim-Philipp Müller
ce35fb79da
queue2: don't send seeks beyond the end of the file upstream in pull mode
...
If downstream is operating in pull mode, short-circuit any pulls beyond
the end of the file and return FLOW_UNEXPECTED immediately instead of
sending a seek beyond the end of the file upstream, since this might
confuse upstream elements (and/or http servers, for example). Fixes
playback of apple trailers in totem and youtube/html5 clips in
WebkitGTK+.
https://bugzilla.gnome.org/show_bug.cgi?id=632977
2010-11-01 12:34:15 +00:00
Edward Hervey
cb2c028b39
queue2: Remove unused argument from find_range()
2010-10-13 12:05:44 +02:00
Wim Taymans
62ffd66f10
queue2: release queue2 lock before notify
...
Make sure that we don't hold the lock when we notify the temp-location
property,
Fixes #631853
2010-10-11 18:10:07 +02:00
Stefan Kost
41e00e58e7
queue2: remove var only used for debug statement
2010-09-23 15:12:32 +03:00
Wim Taymans
2d1450d777
queue2: only post buffering message when percent changed
2010-09-15 13:29:52 +02:00
Wim Taymans
e3176a31e9
queue2: always update buffering status
...
Update the buffering status even when we are not using a queue so that EOS can
properly finish the buffering.
2010-09-15 13:15:19 +02:00
Philippe Normand
410ca5c164
queue2: buffering_ranges query support
...
Fixes bug 623121
2010-09-03 19:59:28 +02:00
Sebastian Dröge
2e6f80bf81
elements: Stop using GST_FLOW_IS_FATAL()
2010-08-27 16:59:09 +02:00
Wim Taymans
77f806bf9f
queue2: fix on-disk buffering again
2010-08-26 17:04:20 +02:00
Edward Hervey
cc4b33ffdf
queue2: Use G_GUINT64_FORMAT where needed
...
Fixes build on macosx
2010-08-19 09:58:55 +02:00
Wim Taymans
bb45ff49a9
queue2: fix compilation
2010-08-13 16:38:59 +02:00
Robert Swain
dec12cb2b8
queue2: Fix a special case during range management
...
When a range contained no data, if it was new or newly empty, it would
be mishandled if it were the current range.
2010-08-13 16:38:58 +02:00
Robert Swain
414911b90a
queue2: fix locking around init_ranges
...
This fixes a segfault where the ready to paused state change causes
freeing and allocation of new ranges while another thread is trying to
use them.
2010-08-13 16:38:58 +02:00
Robert Swain
0182c0d88b
queue2: More ring buffer fixes
...
- Set reading_pos correctly in _create_read ()
- Seek to data if it is further than QUEUE_MAX_BYTES (queue) -
cur_level.bytes away. This should avoid a situation where the ring
buffer is full but the data offset from which we shall read is not in
the ring buffer.
- Only update the max_reading_pos to a lower value to protect data when
necessary
- Always signal an ADD in _locked_enqueue () so that an EOS unlocks the
reader
- More useful debug output
2010-08-13 16:38:58 +02:00
Robert Swain
c78996a313
queue2: ring buffer fixes
...
One must not affect the values of the current range based on a read
request before the correct range is activated.
2010-08-13 16:38:58 +02:00
Robert Swain
602f4774c7
queue2: Fix bugs
...
update_buffering () needs to be called every time we write to the ring
buffer so that applications don't get stuck waiting for a 100% buffered
message while queue2 is waiting for space
_create_write () must only be called for temp file/ring buffer cases
2010-08-13 16:38:57 +02:00
Robert Swain
9df54eb4ff
queue2: extend ring buffer to support ram mode
2010-08-13 16:38:57 +02:00
Robert Swain
e29cca10a4
queue2: merge write buffer functions and fix bugs
...
Cached data could have been overwritten so it is now protected until
it is read. Similarly data was overread as _have_data () was always
looking for the originally requested data even if part of it had been
read already.
2010-08-13 16:38:57 +02:00
Wim Taymans
04f1572ea2
queue2: small cleanup
2010-08-13 16:38:56 +02:00
Wim Taymans
695da33ef5
queue2: cleanup write_to_ring_buffer
...
Use cur_level.bytes to see how much space is free in the ringbuffer.
Simplyfy the write function, avoid taking subbuffers, move waiting for free
space in one spot, use simply counter to write data of a buffer.
2010-08-13 16:38:56 +02:00
Wim Taymans
abc9ab1747
queue2: cleanups
...
Add a macro to get the max size of the queue in bytes, which depends on the
max_level.bytes and the ring_buffer_max_size.
Some cleanups.
2010-08-13 16:38:56 +02:00
Wim Taymans
ecd8d3be3a
queue2: remove unused variable
2010-08-13 16:38:56 +02:00
Wim Taymans
4478c90642
queue2: cleanups
...
Make sure the cur_level.bytes is updated after we change the writing_pos or the
max_reading_pos.
Refactor get_free_space()
Add some comments
2010-08-13 16:38:55 +02:00
Wim Taymans
aec4ea0bfe
queue2: remove unneeded signal
2010-08-13 16:38:55 +02:00
Wim Taymans
7de963c0e0
queue2: set buffering mode correctly
2010-08-13 16:38:55 +02:00
Wim Taymans
cb6d9b071e
queue2: fix calculation of available ringbuffer data
2010-08-13 16:38:55 +02:00
Wim Taymans
8de7cc2222
queue2: reading_pos is updated in create_read only
2010-08-13 16:38:54 +02:00
Wim Taymans
cda4967839
queue2: refactor and add debug
2010-08-13 16:38:54 +02:00
Wim Taymans
117d12f325
queue2: fix flushing
2010-08-13 16:38:54 +02:00
Wim Taymans
e037dd37ae
queue2: add debug
2010-08-13 16:38:53 +02:00
Wim Taymans
e882e1b533
queue2: don't try to write 0 bytes
2010-08-13 16:38:53 +02:00
Wim Taymans
73e27fb017
queue2; cleanups and fixes
...
Make a macro for some frequent checks
Emit the removed signal in all cases when we remove something
2010-08-13 16:38:53 +02:00
Wim Taymans
6339bd0bec
queue2: refactorings
...
Check and handle seek errors
Refactor the wait_free_space function.
2010-08-13 16:38:53 +02:00
Robert Swain
c847b981f4
queue2: Use ring-buffer-max-size prop to control ring buffer
2010-08-13 16:38:52 +02:00
Robert Swain
500d6a9986
queue2: Clean up and improve code
2010-08-13 16:38:52 +02:00
Robert Swain
bde816451e
queue2: Fix conditions where behaviour should differ between ring
...
buffer and temp file
2010-08-13 16:38:52 +02:00
Robert Swain
68e2275bb9
queue2: add useful debug messages and fix an assumption in _have_data ()
2010-08-13 16:38:51 +02:00