Christian König
0ea0eb1579
omxbufferpool: add proper type definitions
...
https://bugzilla.gnome.org/show_bug.cgi?id=726325
2014-03-15 11:26:36 +01:00
Christian König
0700d6875f
omx: consolidate message waiting code
...
Add a wait_message helper function and remove all those duplicated code.
https://bugzilla.gnome.org/show_bug.cgi?id=725493
2014-03-12 14:04:57 +01:00
Sebastian Dröge
6b28cf0378
omx: Copy old copyright notice into the new file
2014-03-12 12:48:12 +01:00
Sebastian Dröge
a04ef276e5
omx: Rename function from _4_ to _for_ for clarity
2014-03-12 12:47:34 +01:00
Christian König
6bf4d9a498
omxvideo: start sharing more code between video decoder and encoder
...
Identical functionality spread of two different components.
We can't use a common base class because of different inheritance,
but let's try to share the code anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=726024
2014-03-12 12:47:09 +01:00
Sebastian Dröge
e9b7dc230b
omxbufferpool: Fix header include guard
2014-03-12 12:42:23 +01:00
Christian König
325c90f99d
omxvideodec: separate the buffer pool from the decoder
...
https://bugzilla.gnome.org/show_bug.cgi?id=726025
2014-03-12 12:42:03 +01:00
Christian König
de5f940186
omx: simplify tunnel functions
...
Specifying the component is error prone and unnecessary.
https://bugzilla.gnome.org/show_bug.cgi?id=726021
2014-03-12 08:48:46 +01:00
Christian König
14a0da437f
omxvideodec: fix memory leak in gst_omx_video_dec_allocate_output_buffers
...
https://bugzilla.gnome.org/show_bug.cgi?id=725907
2014-03-08 15:23:59 +01:00
Christian König
5ac0fe2108
omxvideodec: fix memory leak gst_omx_video_dec_negotiate
...
https://bugzilla.gnome.org/show_bug.cgi?id=725907
2014-03-08 15:22:15 +01:00
Christian König
20cfcda4db
omxvideoenc: fix a memory leak in gst_omx_video_enc_getcaps
...
https://bugzilla.gnome.org/show_bug.cgi?id=725826
2014-03-06 20:37:02 +01:00
Christian König
85db124673
omxvideoenc: simplify _find_nearest_frame
...
Just the same as we did with the decoder. Also give the
function a gst_omx_video_enc prefix to distinct it from
the decoder function.
https://bugzilla.gnome.org/show_bug.cgi?id=724236
2014-03-03 20:12:58 +01:00
Christian König
2cfe70ed5d
omxvideodec: simplify _find_nearest_frame
...
No need to make it more complicated and error prone than
necessary. Also give the function a gst_omx_video_dec prefix
to distinct it from the encoder function.
https://bugzilla.gnome.org/show_bug.cgi?id=724236
2014-03-03 20:12:51 +01:00
Christian König
bf0d2614c3
omxvideodec: remove dead code
...
This code doesn't seems to be used for quite a while,
remove it before it starts to rot.
https://bugzilla.gnome.org/show_bug.cgi?id=724236
2014-03-03 20:12:35 +01:00
Christian König
8b06b07f6f
omx: fix two serious message handling bugs
...
Waiting for the next message if we already got one
is nonsense and can lead to lockups.
https://bugzilla.gnome.org/show_bug.cgi?id=725468
2014-03-02 12:09:59 +01:00
Christian König
4e4f093319
omxvideoenc: fix startup race condition
...
The reset function shouldn't start the src pad
loop if it wasn't started before.
Signed-off-by: Christian König <christian.koenig@amd.com>
2014-03-02 12:08:09 +01:00
Christian König
0a8cfcde87
omxvideodec: fix startup race condition
...
The reset function shouldn't start the src pad
loop if it wasn't started before.
Signed-off-by: Christian König <christian.koenig@amd.com>
2014-03-02 12:08:09 +01:00
Sebastian Dröge
1bf4edf721
omx: Don't handle FLUSHING and NOT_LINKED as errors
...
Also don't stop the task on NOT_LINKED. We're not a demuxer.
2014-01-25 17:44:57 +01:00
Tim-Philipp Müller
498b74ab6a
omx: don't use the 'z' modifier to print size_t
...
gcc will warn in some cases even if the size of the type
is exactly that of size_t on the platform.
https://bugzilla.gnome.org/show_bug.cgi?id=699008
2013-08-20 16:00:07 +01:00
Roman Arutyunyan
5ba55b6c9a
gstomxvideoenc: Set bitrate in setcaps
...
Otherwise it gets lost whenever we configure new caps
https://bugzilla.gnome.org/show_bug.cgi?id=698049
2013-07-01 15:48:47 +02:00
Josep Torra
f3f9330332
omx: Take lock on EOS to update the flow return value
...
Fixes "GThread-ERROR **: file gthread-posix.c: line 171
(g_mutex_free_posix_impl): error 'Device or resource busy' during
'pthread_mutex_destroy ((pthread_mutex_t *) mutex)'" in _finalize.
2013-05-20 12:06:34 +02:00
Josep Torra
64ef1f0e11
omxvideodec: Redesign video size change reconfiguration code
...
Ensure stop the decoder before clossing the tunnel.
2013-05-10 12:25:07 +02:00
jitendra
715b44ea66
omx: Add pads based on element type
...
This allows to later add sources and sink that only have a srcpad
or sinkpad.
https://bugzilla.gnome.org/show_bug.cgi?id=699754
2013-05-06 16:20:20 +02:00
Carlos Rafael Giani
2d1138f45c
omx: fixed type error in printf call
...
%zu expects size_t
https://bugzilla.gnome.org/show_bug.cgi?id=699008
2013-04-27 09:17:28 +01:00
Tim-Philipp Müller
a2db76b048
Check for gstreamer-egl
...
And don't use if not available.
https://bugzilla.gnome.org/show_bug.cgi?id=697574
2013-04-23 11:05:19 +01:00
Tim-Philipp Müller
2cbbab3128
omx: more printf format fixes
...
Fix printf formats again, so that gst-omx compiles warning-
free on the Raspberry Pi as well. Unfortunately OMX_UINT32
maybe be typedefed to uint32_t or unsigned long, which
doesn't work well with our debugging printf format strings,
so just use %u for those and cast to guint.
2013-04-18 23:10:13 +01:00
Josep Torra
82807bd9dd
omx: fixes unused variable 'comp' when GStreamer is built without debug
2013-04-18 16:40:06 +02:00
Josep Torra
9d0763a91d
omxvideodec: don't use 'self->dec_out_port' anymore and use just 'port'
...
Fixes some criticals.
2013-04-18 16:03:56 +02:00
Josep Torra
9de6308382
omxvideodec: fixes 'port' may be used uninitialized in this function
2013-04-18 15:21:32 +02:00
Josep Torra
4974f75d91
omxvideodec: silence warnings building for RPI related to 'vcos_*'
2013-04-18 12:03:31 +02:00
Josep Torra
ae3454683e
omxvideodec: Use new type from libgstvideo
2013-04-18 11:45:50 +02:00
jitendra
960590f92f
omx: Disable output port before transition to idle state
...
https://bugzilla.gnome.org/show_bug.cgi?id=698109
2013-04-16 12:46:48 +02:00
Tim-Philipp Müller
0c08d375f4
omx: fix printf formats in debug messages
...
OMX_U32 is typedefed to an unsigned long,
OMX_TICKS to a 64-bit integer.
2013-04-08 17:02:32 +01:00
Josep Torra
16cf5d77db
omxvideodec: use the correct printf format in a debug message
2013-04-08 16:52:19 +02:00
Josep Torra
c46a6a757e
omxvideodec: use the correct OMX_IndexParam value
...
Fixes playback is not smooth in the EGL path.
2013-04-08 16:31:33 +02:00
Sebastian Dröge
31159a9b36
omxvideodec: Don't use API that is not in master yet
...
It's not really needed here yet, will be needed in future versions
2013-04-05 13:45:24 +02:00
Sebastian Dröge
8a1bb1b4a3
omxvideodec: Add support for egl_render on RPi
2013-03-26 14:00:03 +01:00
Tim-Philipp Müller
f17c8ac55b
omx: fix compiler warnings when compiling with -DG_DISABLE_ASSERT
...
As we do for releases. Fixes 'variable may be used uninitialized'
warnings.
2013-03-22 19:23:46 +00:00
Tim-Philipp Müller
75dca2b081
omx: fix typo in copyright headers
2013-03-19 16:40:09 +00:00
Sebastian Dröge
4483581e2a
omx: Add more constraints to the default sink template caps
2013-03-19 13:28:30 +01:00
Sebastian Dröge
e533da2b22
omxvideodec: Set ENDOFFRAME flag for the end of frames
2013-03-19 12:55:09 +01:00
Sebastian Dröge
8460cabd13
omx: Add Theora decoder
2013-03-19 12:25:27 +01:00
Sebastian Dröge
29a348efac
omx: Remove additional comma
2013-03-18 16:43:24 +01:00
Sebastian Dröge
36e76faa05
omx: Rename MPEG2 decoder for consistency everywhere
2013-03-18 16:34:51 +01:00
Sebastian Dröge
d9d46263c6
omx: Add MJPEG decoder support
2013-03-18 16:34:51 +01:00
Sebastian Dröge
0f5e6e967b
omx: Add VP8 decoder support
2013-03-18 16:34:51 +01:00
Tim-Philipp Müller
9da6ee8727
omxmpeg2dec: mpeg-2 decoder should be able to handle mpeg-1 too
...
https://bugzilla.gnome.org/show_bug.cgi?id=695879
2013-03-16 13:21:51 +00:00
Josep Torra
8231c9068e
omx: minor stylistic change for consistency with other similar code
2013-03-16 10:13:06 +01:00
Josep Torra
a5778efe16
omx: Clarify that loop task is also paused in EOS
2013-03-16 10:00:24 +01:00
Josep Torra
e16207f3dd
omxvideoenec: Don't forget propagate flow return value upstream
2013-03-16 09:59:01 +01:00
Tim-Philipp Müller
c51afe9093
omx: improve debug logging some more
2013-03-15 13:17:18 +00:00
Sebastian Dröge
2b580837f5
omxvideodec: Make sure that the first frame we pass to OpenMAX is a sync frame
2013-03-15 14:09:45 +01:00
Sebastian Dröge
e1f94660f7
omx: Stop output port task after draining
2013-03-15 11:46:34 +01:00
Sebastian Dröge
35a13a2cea
omx: Reset EOS flag in more places
2013-03-15 11:01:12 +01:00
Sebastian Dröge
84c6fd44d2
omxvideodec: Deallocate output buffers with the right function
2013-03-15 10:38:58 +01:00
Tim-Philipp Müller
d7862b927c
omx: log commands as strings
...
Makes logs easier to read.
2013-03-15 09:29:56 +00:00
Tim-Philipp Müller
07e6ae99f1
omx: log states as strings
2013-03-15 09:29:55 +00:00
Tim-Philipp Müller
118345eef5
omx: log component name in debug messages
...
Useful when we have more different components
active at the same time.
2013-03-15 09:29:55 +00:00
Sebastian Dröge
047b3735cf
omxvideodec: Don't interpolate timestamps
...
We will get exactly one frame per input buffer and assigning
timestamps between frames if more than one OMX buffer is required
per frame easily confuses timestamp tracking in OMX.
2013-03-15 09:51:42 +01:00
Sebastian Dröge
c59d8930ac
omxvideodec: Give the codec_data the timestamp of the first frame and no duration
2013-03-15 09:51:34 +01:00
Sebastian Dröge
67dc871116
omx: Reset some more buffer fields as required
2013-03-14 17:26:51 +01:00
Sebastian Dröge
5bab4a05f0
omx: The hack to disable usage of EOS buffers is not necessary anymore on RPi
2013-03-14 17:01:08 +01:00
Sebastian Dröge
ec687f1414
omx: Reset the flags for output ports when releasing a buffer, not for input ports
2013-03-14 17:00:42 +01:00
Sebastian Dröge
02335ef953
omx: Only unref caps after usage of its fields
2013-03-14 15:03:02 +01:00
Sebastian Dröge
bda1e97abd
omxvideodec: Simplify bufferpool implementation
2013-03-14 14:51:32 +01:00
Sebastian Dröge
9128ba5018
omxvideodec: Improve min/max buffer counts handling
2013-03-14 12:52:46 +01:00
Sebastian Dröge
22dce51dd4
omx: Handle the OMX_EventBufferFlag to detect EOS too
2013-03-14 12:51:54 +01:00
Sebastian Dröge
acf15e84a9
omx: Mark OpenMAX buffers as EGLImage if they contain one
...
Needs special handling in some places, e.g. because nFilledLen
will always be 0.
2013-03-13 13:10:28 +01:00
Sebastian Dröge
b9af5f4f31
omxvideoenc: Properly check the nVersion field
2013-03-13 10:21:49 +01:00
Sebastian Dröge
68c8196912
omxvideoenc: RPi returns garbage for OMX_IndexParamVideoBitrate, work around that
2013-03-13 09:38:07 +01:00
Sebastian Dröge
1ebd34e637
omxvideodec: Make sure to always get the right buffer
2013-03-13 09:38:03 +01:00
Sebastian Dröge
f4ad6e0858
omxvideodec: Make sure the buffer is released to the pool if it's not the one we wanted
2013-03-13 09:37:58 +01:00
Sebastian Dröge
ef357cce80
omxvideodec: Drop too late frames instead of finishing them
2013-03-13 09:37:43 +01:00
Sebastian Dröge
fa7be0b618
omx: Release buffers to the correct port
2013-03-13 09:37:36 +01:00
Sebastian Dröge
303b6c4dc5
omx: Always load the OpenMAX IL cores with G_MODULE_BIND_LOCAL
2013-03-13 09:37:02 +01:00
Sebastian Dröge
f505dad87a
omx: Lazy-load symbols of libbcm_host.so
...
It exports eglIntOpenMAXILDoneMarker(), which is also
exported by libopenmaxil.so... but we need the version
from libopenmaxil.so as the other one is just a stub.
2013-03-13 09:35:20 +01:00
Sebastian Dröge
3544fa5ae3
omx: Don't set profile/level in other encoders if downstream caps don't specify any
2013-03-11 13:59:15 +01:00
Sebastian Dröge
77f95de529
omxh264enc: If caps specify no profile/level use the component's defaults
2013-03-11 13:49:38 +01:00
Sebastian Dröge
3c13502b75
omxvideoenc: Always allocate output buffers from the loop function
2013-03-11 13:45:04 +01:00
Sebastian Dröge
bd53faacc9
omxh264enc: The h264 encoders are supposed to output byte-stream/au
2013-03-11 13:13:22 +01:00
Sebastian Dröge
79a1fed0e0
omxvideoenc: Wait until the Executing state is reached before passing buffers to the component
2013-03-11 11:52:57 +01:00
Sebastian Dröge
448ea34b75
omxvideodec: Don't provide buffers to downstream
...
This only works reliable if we have a way to tell downstream to
release all our buffers for reconfiguration.
2013-03-11 10:39:25 +01:00
Sebastian Dröge
8bf902b69d
omxaudioenc: Disable output port when setting a new format
2013-03-11 10:29:44 +01:00
Sebastian Dröge
f518ce5ed9
omxvideoenc: Disable output port when setting a new format
2013-03-11 10:29:30 +01:00
Sebastian Dröge
00be69f4a0
omxvideodec: Disable output port when setting a new format
...
Based on a patch by Josep Torra <n770galaxy@gmail.com>
2013-03-11 10:22:07 +01:00
Sebastian Dröge
65174bbd7f
omx: Catch errors when releasing buffers to a port and handle them
2013-03-11 10:04:10 +01:00
Sebastian Dröge
eac2078056
omxvideoenc: Use the correct video codec state when filling an input buffer
2013-03-10 12:09:23 +01:00
Sebastian Dröge
98cf9f6fe2
omxvideoenc: Store correct input state
2013-03-10 12:05:50 +01:00
Sebastian Dröge
fb3b213b3e
omxvideoenc: Allocate output buffers as early as possible
2013-03-10 11:31:55 +01:00
Sebastian Dröge
b9bf849a39
omx: Log unknown events
2013-03-10 11:03:18 +01:00
Josep Torra
bd071327da
omx: Fix deadlock in encoders and add explainatory comments.
2013-03-09 14:14:40 +01:00
Josep Torra
7423e3e023
omxvideodec: fix printf format identifier
2013-03-09 13:27:08 +01:00
Josep Torra
cde5df17fa
omx: Minor changes on debuging info
2013-03-09 13:24:30 +01:00
Josep Torra
6d8bf76391
omxvideodec: avoid a deadlock
2013-03-09 13:24:16 +01:00
Sebastian Dröge
aa6be53375
omxvideodec: Don't forget to populate output port
2013-03-08 15:58:01 +01:00
Sebastian Dröge
c014b1c9a3
omx: Flush and stop srcpad when configuring new caps
2013-03-08 15:50:20 +01:00
Sebastian Dröge
716adfa5be
Revert "omx: use no-component-reconfigure hack on the Raspberry PI"
...
This reverts commit e123b2089f
.
It's not required anymore after the fix from the last commit.
2013-03-07 17:40:21 +01:00
Sebastian Dröge
ed0de9d699
omxvideodec: Only negotiate a color format with downstream on the initial caps
2013-03-07 17:38:40 +01:00
Sebastian Dröge
bbd30a96bd
omxvideodec: Make sure the output port is disabled while we allocate buffers
2013-03-07 17:29:43 +01:00
Sebastian Dröge
20c9ae0823
omx: Also wait for disabled output ports to be reconfigured
2013-03-07 17:27:05 +01:00
Sebastian Dröge
0cd96e8c6b
omxvideodec: Add buffer pool for sharing OpenMAX memory with downstream
2013-03-07 14:10:12 +01:00
Sebastian Dröge
7a1eaec3b9
omx: Add timeout to the flush operation and move buffer populating to a separate function
2013-03-07 13:57:00 +01:00
Sebastian Dröge
001b7f0ed9
omx: Remove min buffer count hack for RPi again
...
It's not necessary anymore
2013-03-07 13:56:50 +01:00
Sebastian Dröge
60861f3990
omx: Do number of buffers configuration explicitely
2013-03-07 13:56:44 +01:00
Josep Torra
cc495aeb16
omxvideodec: fixes reconfiguration
...
Avoid having fixed fields from previous caps on reconfiguration.
2013-03-07 11:24:54 +01:00
Josep Torra
e123b2089f
omx: use no-component-reconfigure hack on the Raspberry PI
2013-03-07 11:02:39 +01:00
Josep Torra
118c023f55
omxvideoenc: drop unused data member
2013-03-01 15:32:47 +01:00
Sebastian Dröge
0b348473fa
omxvideoenc: And set it actually on the right port
2013-03-01 12:24:09 +01:00
Sebastian Dröge
eef92abf28
omxvideoenc: Set the coding type in the subclasses to the specific codec
2013-03-01 12:18:08 +01:00
Sebastian Dröge
42937eaea0
omxvideoenc: gst_omx_port_update_port_definition() returns a OMX_ERRORTYPE, not a gboolean
2013-03-01 11:49:53 +01:00
Sebastian Dröge
687a188dad
omxvideo{dec,enc}: Don't use the input state if it wasn't set yet
2013-03-01 11:44:17 +01:00
Sebastian Dröge
d92fb127ae
omxaudioenc: Only enable the output port after we know the output format
2013-03-01 11:25:04 +01:00
Sebastian Dröge
a53c5638e2
omxvideoenc: Only enable the output port after we know the output format
2013-03-01 11:24:56 +01:00
Sebastian Dröge
63e0d61971
omxvideodec: Only enable the output port after we know the output format
2013-03-01 11:21:25 +01:00
Sebastian Dröge
0bb816e32c
omx: Handle errors more gracefully
2013-03-01 11:18:38 +01:00
Sebastian Dröge
aeec430261
omx: Return the OMX_ERRORTYPE from gst_omx_port_update_port_definition
2013-02-28 15:49:14 +01:00
Sebastian Dröge
dc0385d762
omx: Return port definition update errors
2013-02-28 15:38:28 +01:00
Sebastian Dröge
1dd6214f44
omx: Add hack for RPi for the minimum number of buffers required for a port
...
The value in the port definition is invalid and the initial actual
buffer count should be used.
2013-02-28 13:57:43 +01:00
Sebastian Dröge
5132a89331
omx: Always tell the component about the right number of buffers that we're going to allocate
2013-02-28 13:26:56 +01:00
Sebastian Dröge
59e92f955d
omx: Invert assertion to let it express what was intended
2013-02-28 13:07:58 +01:00
Sebastian Dröge
1a906da409
omx: Add API for allocating a specific number of buffers and using EGLImages or buffers allocated elsewhere
2013-02-28 11:20:52 +01:00
Sebastian Dröge
e42faae652
omx: Refactor code flow a bit if output port settings have changed
2013-02-27 16:56:02 +01:00
Sebastian Dröge
b12610efd7
omx: Clean up port settings change handling
2013-02-27 15:50:20 +01:00
Josep Torra
26b69d99a2
omxvideodec: initialize param structure before using it
2013-02-27 11:30:14 +01:00
Josep Torra
b85358aff7
omxvideoenc: prevent a NULL pointer access
2013-02-27 10:21:39 +01:00
Josep Torra
3973425689
omxvideodec: prevent a NULL pointer access
2013-02-26 17:25:49 +01:00
Sebastian Dröge
8872afff1d
omx: Fix deadlock during reconfiguration
2013-02-25 13:11:16 +01:00
Sebastian Dröge
5b45cb0810
omx: Auto-detect the port indizes if possible
2013-02-25 12:42:05 +01:00
Sebastian Dröge
3e090dd83b
omx: Refactor querying of component supported caps into its own function
2013-02-25 11:42:38 +01:00
Sebastian Dröge
70368c31cd
omx: Refactor waiting for buffers to be released by the component to a separate function
2013-02-25 10:41:12 +01:00
Sebastian Dröge
f79bbc302b
omx: Add methods to set up and close a tunnel between components
2013-02-25 09:47:37 +01:00
Sebastian Dröge
fa9bf95c40
omxaudioenc: Rename component variable
2013-02-25 09:19:08 +01:00
Sebastian Dröge
92c7944499
omxvideoenc: Rename component variable
2013-02-25 09:19:08 +01:00
Sebastian Dröge
e08b801fea
omxvideodec: Rename component variable
2013-02-25 09:19:08 +01:00
Josep Torra
71b4573a34
omxvideoenc: remove duplicated line
2013-02-22 16:27:33 +01:00
Sebastian Dröge
cba466b61c
Retry loading libbcm_host.so without an absolute path if that failed
2013-02-22 10:42:08 +01:00
Sebastian Dröge
9ed06008cd
Add OpenMAX IL target for Bellagio
...
Not tested since a very long time though.
2013-02-21 11:03:23 +01:00
Sebastian Dröge
cfafeabfa2
Allow using external OpenMAX IL headers
2013-02-21 10:59:29 +01:00
Sebastian Dröge
05819da94d
Set default hacks for the RPI target and always initialize bcm_host
2013-02-21 10:08:07 +01:00
Sebastian Dröge
5d6d6ec2df
omx: Add FIXME for the future
2013-02-12 11:55:39 +01:00
Sebastian Dröge
219a93bbaf
omx: Some minor refactoring and cleanup
2013-02-12 11:49:21 +01:00
Sebastian Dröge
4399c0b96b
omx: Don't access the port's buffers array if it wasn't allocated yet
2013-02-12 11:49:07 +01:00
Sebastian Dröge
dd3ad9e6d5
omx: Mark an array as const
2013-02-12 11:44:40 +01:00
Sebastian Dröge
c3bcc43db7
omx: Split enabling/disabling of port into sending the command and waiting for it
...
This allows to do anything necessary after sending the command to actually let it finish
2013-02-12 11:41:43 +01:00
Sebastian Dröge
58a093bc0c
omx: Flushing is also allowed in Paused state
2013-02-12 11:37:38 +01:00
Sebastian Dröge
39672e70c4
omxvideoenc: Set stride, slice height and buffer size
2013-02-12 11:28:36 +01:00
Sebastian Dröge
044a88f838
omxvideoenc: Properly negotiate OMX color format with the component
2013-02-12 11:03:32 +01:00
Sebastian Dröge
023b542ad5
omxvideoenc: Implement getcaps() vfunc
2013-02-12 11:03:30 +01:00
Julian Scheel
3d7a50944d
omx: add mpeg2 video decoder
...
This adds a decoder class for mpeg2, as well as an extended
configuration for raspberry pi.
https://bugzilla.gnome.org/show_bug.cgi?id=692446
Signed-off-by: Julian Scheel <julian@jusst.de>
2013-01-24 22:46:52 +00:00
Sebastian Dröge
5c4799ccf1
omx: Minimize the time when the messages lock is held
...
Fixes a deadlock if any OMX functions are called when the
messages are handled.
Thanks to Nicolas Dufresne for noticing.
2013-01-18 16:47:52 +01:00
Tim-Philipp Müller
453d81886d
omx: improve debug message when we can't find the config file
...
Mention where we looked for the config file.
2013-01-18 15:28:20 +00:00
Sebastian Dröge
4044aaecbe
omx: Fix includes to properly work with the 1.0 releases
2013-01-17 18:08:15 +01:00
Sebastian Dröge
e5bf204a1d
omx: Update port definition when changing some port setting
2013-01-15 14:37:37 +01:00
Sebastian Dröge
449017b50b
omx: Rename from libgstopenmax.so to ligstomx.so for consistency
2013-01-15 14:37:37 +01:00
Nicolas Dufresne
8c3bd103ff
omx: Add a method to send message
2013-01-14 10:37:13 +01:00
Sebastian Dröge
2d913c6773
omx: Atomic ops are not required anymore for the reconfiguration
2013-01-14 10:37:06 +01:00
Sebastian Dröge
be31e7273b
omx: Fix some memory leaks and suboptimal locking
2013-01-14 10:36:57 +01:00
Sebastian Dröge
bcb181bd2d
omxvideoenc: Don't forget to unmap frame in error cases
2013-01-14 10:36:50 +01:00
Sebastian Dröge
25d5c55764
omxvideoenc: Fix copying of the video frames to the OMX buffers
2013-01-14 10:36:44 +01:00
Sebastian Dröge
2fd8d72c50
omxvideodec: Fix copying of the video frames from the OMX buffers
2013-01-14 10:36:38 +01:00
Sebastian Dröge
a42f27547d
omx: Implement new approach for locking that should solve all deadlocks on RPi
...
No mutex is locked while calling any OpenMAX functions anymore
and everything from the OpenMAX callbacks is inserted into a message
queue and handled from outside the callbacks.
Also there's only a single mutex and condition variable per component
now for handling anything from OpenMAX callbacks and a single mutex
for keeping our component/port state sane.
2013-01-14 10:36:32 +01:00
Sebastian Dröge
1bf69c8f69
omxvideodec: Set the OMX buffer nFilledLength field properly
2012-12-20 19:30:38 +01:00
Sebastian Dröge
29aabc223e
omxrecmutex: Fix another race condition when two threads are trying to lock for recursion at the same time
2012-12-20 18:48:21 +01:00
Sebastian Dröge
500410226f
omxrecmutex: Fix yet another race condition that resulted in deadlocks
2012-12-20 18:16:43 +01:00
Sebastian Dröge
e026926951
omx: Fix another race condition in the recursive mutex
...
Between lock() and begin_recursion() it was possible for another thread to
try to do a recursive_lock(). This would block because the mutex was already
locked(), but not ready for recursive locking yet. unlock() would never
happen in the original thread because it was waiting for the other thread
to finish first.
Happened on the Raspberry Pi.
2012-12-20 17:46:36 +01:00
Sebastian Dröge
1c7fcf832e
omxrecmutex: Fix a small race condition when unlocking a non-recursive lock
2012-12-20 14:45:18 +01:00
Sebastian Dröge
1d01c0ebf0
omx: Fix ununsed variable compiler warning
2012-12-20 12:30:05 +01:00
Sebastian Dröge
83b4c1d892
omx: No need to start the srcpad task in ::start() already
...
It will be started properly after the caps are set.
2012-12-20 12:27:47 +01:00
Sebastian Dröge
4ef40839a2
omxvideodec: OMX_ErrorNoMore is no error and just means we ended iteration
2012-12-20 12:23:49 +01:00
Sebastian Dröge
f90a6ed9e9
omx: Improve debug output
2012-12-20 12:20:31 +01:00
Sebastian Dröge
f6f078e847
omxvideodec: Don't forget to free a GList
2012-12-20 12:02:30 +01:00
Sebastian Dröge
20280afa1f
omxvideodec: Map OMX_COLOR_FormatYUV420PackedPlanar to I420 too
...
This is used on the Raspberry Pi.
2012-12-20 11:56:29 +01:00
Sebastian Dröge
a80e2b9053
omxvideodec: During negotiation of the output format make sure we use the correct OpenMAX format
2012-12-20 11:55:36 +01:00
Sebastian Dröge
07e0d674a0
omxvideodec: If negotiation fails this could also mean that the component can't do it at this point yet
2012-12-20 11:42:17 +01:00
Sebastian Dröge
7354baec66
omxvideodec: Improve format negotiation a bit
...
Don't leak caps and make sure to fixate caps.
2012-12-20 11:40:28 +01:00
Sebastian Dröge
a70a71b9a5
omx: Also initialize nStep field of the OMX structures
2012-12-19 13:05:28 +01:00
Sebastian Dröge
73dc5bb199
omx: Initialize struct version with the OMX version we compiled with
2012-12-19 13:03:37 +01:00
Sebastian Dröge
9c464924a5
omxvideodec: Extract data from the input buffer, not the codec data
2012-12-19 12:44:31 +01:00
Sebastian Dröge
b93d86abbe
omx: Use has_suffix() instead of has_prefix() for the Broadcom hack
2012-12-19 12:19:12 +01:00
Sebastian Dröge
5105daba1a
omx: Add hack to load and initialize libbcm_host.so
...
Needed on the Raspberry Pi. Patch based on a patch by
George Kiagiadakis <george.kiagiadakis@collabora.com>
2012-12-19 11:31:51 +01:00
Sebastian Dröge
7c53535026
configure: Add configure option to pack OpenMAX structures
...
This is required to set to 4 for the Raspberry Pi for example.
2012-12-19 11:26:36 +01:00
George Kiagiadakis
147dd89e21
omx: Initialize structures to version 1.1.2
2012-12-19 11:26:36 +01:00
Sebastian Dröge
31bf1c8bd6
config: Add raspberry-pi configuration in a different directory
2012-12-19 11:26:36 +01:00
George Kiagiadakis
78035a4848
raspberry: Add a gstomx.conf for the Raspberry Pi
2012-12-19 11:07:25 +01:00
Sebastian Dröge
3244201b49
omx: Fix some compilation errors caused by circular includes
2012-12-12 17:45:39 +00:00
Sebastian Dröge
7fa4616598
omx: Fix refcount problem with frames being dropped because of decoder bugs
2012-11-12 15:14:09 +01:00
Sebastian Dröge
2481ceb8c4
omx: Update to new GLib thread API
2012-11-12 11:29:48 +01:00
Sebastian Dröge
bced70525a
omx: Use open/close vfuncs
2012-10-22 14:34:53 +02:00
Sebastian Dröge
9d0e582484
omx: Handle video meta correctly
2012-10-22 14:28:04 +02:00
Sebastian Dröge
5fdb490f1a
omx: Port to video base classes from -base
2012-10-22 14:20:41 +02:00
Tim-Philipp Müller
49ba281e8b
omx: gst_element_class_set_details_simple() -> set_static_metadata()
2012-10-17 17:57:43 +01:00
George Kiagiadakis
f93feb2644
omx: fix debug statement
2012-09-03 12:37:02 +03:00
George Kiagiadakis
8a669ee308
omx: use recursive_lock inside set_last_error(), since this function may be called from an event handler
2012-09-03 12:36:53 +03:00
Tim-Philipp Müller
3f963f87fb
omx: fix plugin name for new GST_PLUGIN_DEFINE API
2012-08-03 19:32:13 +01:00
Sebastian Dröge
48163f60f0
omx: Update for allocation query API changes
2012-07-10 09:57:09 +02:00
Sebastian Dröge
e84fee6488
omx: Fix compilation after gst_pad_start_task() API changes
2012-06-20 11:09:13 +01:00
George Kiagiadakis
7b3dac67af
omx: Fix spelling mistake found by lintian: s/Seperate/Separate/
2012-05-08 16:16:00 +03:00
George Kiagiadakis
158775f497
Implement a new custom recursive mutex type and fix locking in callbacks so that in-context calls are allowed.
...
According to the OMX specification, implementations are allowed to call
callbacks in the context of their function calls. However, our callbacks
take locks and this causes deadlocks if the unerlying OMX implementation
uses this kind of in-context calls.
A solution to the problem would be a recursive mutex. However, a normal
recursive mutex does not fix the problem because it is not guaranteed
that the callbacks are called from the same thread. What we see in Broadcom's
implementation for example is:
- OMX_Foo is called
- OMX_Foo waits on a condition
- A callback is executed in a different thread
- When the callback returns, its calling function
signals the condition that OMX_Foo waits on
- OMX_Foo wakes up and returns
The solution I came up with here is to take a second lock inside the callback,
but only if recursion is expected to happen. Therefore, all calls to OMX
functions are guarded by calls to gst_omx_rec_mutex_begin_recursion() / _end_recursion(),
which effectively tells the mutex that at this point we want to allow calls
to _recursive_lock() to succeed, although we are still holding the master lock.
2012-05-07 17:01:16 +03:00
George Kiagiadakis
5c15caef8e
omx: Add hack to disable setting roles to components.
...
Conflicts:
omx/gstomx.c
2012-05-03 13:21:18 +02:00
George Kiagiadakis
7ca067be28
omxvideodec: Implement no-empty-eos-buffer hack, as in omxvideoenc.
...
Conflicts:
omx/gstomxvideodec.c
2012-05-03 12:24:43 +02:00