Jan Alexander Steffens (heftig)
16a07d303a
rtmp2: Replace stats queue with stats lock
...
Making the thread receiving the stats wait on the loop to respond was
not a good idea, as the latter can get blocked on the streaming thread.
Have get_stats read the values directly, adding a lock to ensure we
don't read garbage.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1550 >
2020-09-09 06:34:51 +00:00
Nazar Mokrynskyi
ebc057bb7a
rtmp2sink: add docs section with since marker on new stop-commands property
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256 >
2020-09-09 05:53:08 +00:00
Nazar Mokrynskyi
8c37eea410
rtmp2: fix code style, update documentation cache
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256 >
2020-09-09 05:53:08 +00:00
Jan Alexander Steffens (heftig)
30274dee52
rtmp2: Clean up (improve) GstRtmpStopCommands type
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256 >
2020-09-09 05:53:08 +00:00
Nazar Mokrynskyi
9a2828c216
rtmp2sink: handle EOS event and close stream
...
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1285
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256 >
2020-09-09 05:53:08 +00:00
Jan Alexander Steffens (heftig)
66f9d37c37
mpegtsmux: Make handling of sinkpads thread-safe
...
Ensure we take the object lock while accessing `GstElement.sinkpads`.
Use an iterator when the code isn't simple to avoid deadlock.
When we find the best pad, take a reference so a concurrent pad
release doesn't destroy the pad before we're done with it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1553 >
2020-09-09 02:25:40 +00:00
Edward Hervey
1068083135
mpegtsmux: Don't create streams with reserved PID
...
There are quite a few reserved PID in the various MPEG-TS (and derivate)
specifications which we should definitely not use. Those PID have a certain
meaning and purpose.
Furthermore, a lot of the code in the muxer implementation also makes assumption
on the purpose of streams based on their PID.
Therefore, when requesting a pad with a specific PID, make sure it is not a
restricted PID.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1561 >
2020-09-08 21:09:36 +00:00
Sebastian Dröge
64039cdf84
gst: Update for gst_video_transfer_function_*() function renaming
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1557 >
2020-09-07 12:14:47 +03:00
Jan Alexander Steffens (heftig)
ef8142ef90
mpegtsmux: Keep mux usable after stop
...
Otherwise you cannot request new pads until after it is started again.
gst_base_ts_mux_reset with FALSE is still called in the dispose
implementation, so the muxer still gets deallocated when we actually
clean up.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1552 >
2020-09-01 14:01:56 +00:00
Nirbheek Chauhan
ce18a344f4
rtmp2: Need to unescape the userinfo before setting
...
This regressed in 827afa206d
. The same
fix was also committed to the webrtc element, but rtmp2 was missed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1547 >
2020-08-30 09:53:42 +00:00
Jose Quaresma
fe3a0c2c90
proxysink: event_function needs to handle the event when it is disconnecetd from proxysrc
...
without this a disconneted proxysink fail when goes to play with error:
Internal data stream error.
streaming stopped, reason error (-5)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1508 >
2020-08-13 14:21:05 +00:00
Felix Yan
5886138c13
Correct typos in gsth264parse.c
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1511 >
2020-08-12 17:03:00 +00:00
Nicolas Dufresne
76b4de79ca
h264parse: Add new H.264 levels
...
The spec now list 6, 6.1 and 6.2.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1509 >
2020-08-12 08:30:14 -04:00
Jordan Petridis
26bbcae973
gstautoconvert.c: fix clang warnings
...
clang 10 is complaining about incompatible types due to the
glib typesystem.
```
gst-plugins-bad/gst/autoconvert/b5c3019@@gstautoconvert@sha/gstautoconvert.c.o' -c ../subprojects/gst-plugins-bad/gst/autoconvert/gstautoconvert.c
../subprojects/gst-plugins-bad/gst/autoconvert/gstautoconvert.c:898:8: error: incompatible pointer types passing 'typeof ((((void *)0))) *' (aka 'void **') to parameter of type 'GList **' (aka 'struct _GList **') [-Werror,-Wincompatible-pointer-types]
if (!g_atomic_pointer_compare_and_exchange (&autoconvert->factories, NULL,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gatomic.h:192:44: note: expanded from macro 'g_atomic_pointer_compare_and_exchange'
__atomic_compare_exchange_n ((atomic), &gapcae_oldval, (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
^~~~~~~~~~~~~~
1 error generated.
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1487 >
2020-08-04 11:37:52 +00:00
Nirbheek Chauhan
d4ca8820e7
webrtc, rtmp2: Warn if the user or password aren't escaped
...
If the user/pass aren't escaped, the userinfo will be ambiguous and we
won't know where to split. We will accidentally get it right if the :
belongs in the password.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481 >
2020-08-03 18:12:50 +00:00
Nirbheek Chauhan
827afa206d
webrtc, rtmp2: Fix parsing of userinfo in URI strings
...
While parsing the string, `gst_uri_from_string()` also unescapes the
userinfo. This is bad if your username contains a `:` character, since
we will then split the userinfo at the wrong location when parsing it.
To fix this, we can use the new `gst_uri_from_string_escaped()` API
that was added in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/583
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/831
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481 >
2020-08-03 18:12:50 +00:00
George Kiagiadakis
fc9a612e2c
ristsrc: drop stream-start & eos messages posted from the internal udp sink(s)
...
See #1368
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1472 >
2020-07-29 13:20:28 +00:00
George Kiagiadakis
914161f902
rtpsrc: drop stream-start & eos messages posted from the internal udp sink(s)
...
See #1368
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1472 >
2020-07-29 13:20:28 +00:00
Vivia Nikolaidou
d8b37973d2
tsmux: Fix PCR calculation for CBR live streams
...
Take the first ever timestamp as an offset
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1431 >
2020-07-28 16:18:45 +00:00
Jan Alexander Steffens (heftig)
5a358b7687
tsmux: Refactor get_current_pcr
...
No functional change.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1431 >
2020-07-28 16:18:45 +00:00
Nicolas Dufresne
782dc857e0
rtpsrc: Add domain name support
...
This add domain name resolution (similar to udpsrc does) to the rtpsrc
element.
Fixes 1352
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433 >
2020-07-14 20:48:04 +00:00
Nicolas Dufresne
19c632f4e8
ristsrc: Add support for domain name
...
This add domain name resolution (similar to udpsrc does) to the ristsrc
element.
Fixes 1352
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433 >
2020-07-14 20:48:04 +00:00
Nicolas Dufresne
f6ac2e44bb
rtpsrc: Always set rtcp socket address
...
Regardless if it's multicast or not, set the address property to match
the element address. This is the address of the interface to listen to,
which is expected to be ANY in most cases, but should be honnored even
for RTCP non-multicast case.
This also fixes an assertion if the address is not a parsable IPv4 or
IPv6 string.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433 >
2020-07-14 20:48:04 +00:00
Nicolas Dufresne
82fe23f212
rtpsink: Fix error handling on bad DNS
...
This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433 >
2020-07-14 20:48:04 +00:00
Nicolas Dufresne
89fbcc71d9
ristsink: Fix error handling on bad DNS
...
This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433 >
2020-07-14 20:48:04 +00:00
Mathieu Duponchelle
13376f88fe
basetsmux: make use of gst_aggregator_finish_buffer_list
...
Fixes #1276
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1429 >
2020-07-10 20:12:11 +00:00
Tim-Philipp Müller
510e8ef8cb
docs: fix element names in section headers
...
Hopefully that'll make hotdoc pick up the docs for these elements.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1428 >
2020-07-10 19:22:29 +00:00
Andreas Frisch
0e075b4dbf
mpegtsmux: Don't assume English for ISO-639 language descriptor
...
Previously, "en" (should have actually been "eng") was assumed
for the ISO-639 language descriptor if no language was explicitely given.
Neither ETSI EN 300 468 nor ATSC A/52 mandate for a language descriptor,
so we should simply not set it, if it's unknown.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1386 >
2020-07-08 13:37:12 +00:00
Jan Schmidt
46cc64e09f
mpegtsmux: Fix handling of MPEG-2 AAC
...
The audio/mpeg,mpegversion=2 caps in GStreamer refer to
MPEG-2 AAC (ISO 13818-7), not to the extended MP3 (ISO 13818-3),
which is audio/mpeg,mpegversion=1,mpegaudioversion=2/3
Fix the caps, and add handling for MPEG-2 AAC in both ADTS and raw
form, adding ADTS headers for the latter.
2020-07-08 12:24:13 +00:00
Tim-Philipp Müller
f3fdd76683
rtmp, transcodebin: fix i18n header includes
...
Fixes #1351
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1416 >
2020-07-07 19:55:00 +01:00
Nicolas Dufresne
af741f0723
rist: Use g_signal_connect_object()
...
rtpbin can still emit signals when it is being disposed, and while
rtpbin is inside ristsrc/ristsink it can still live longer.
So we either have disconnect all signals at some point, or let GObject
take care of that automatically.
Related to !1412
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1413 >
2020-07-07 15:37:57 +00:00
Josep Torra
7346e7c1e2
scenechange: use orc to compute score
...
Add an orc implementation for SAD operation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1024 >
2020-07-07 15:06:55 +01:00
Sebastian Dröge
b812d1c743
rtpsrc/sink: Use g_signal_connect_object()
...
rtpbin can still emit signals when it is being disposed, and while
rtpbin is inside rtpsrc/rtpsink it can still live longer.
So we either have disconnect all signals at some point, or let GObject
take care of that automatically.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1412 >
2020-07-07 12:42:36 +00:00
Jan Alexander Steffens (heftig)
cba9ba9b38
mpegtsmux: Avoid crash releasing pad with NULL prog
...
If we release a pad while the muxer is running which has never been used
for aggregation (thus it does not have an assigned program), `prog` is
NULL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1411 >
2020-07-07 14:05:04 +02:00
Tim-Philipp Müller
7b2c3a984c
meson: add update-orc-dist target
...
Add target to update backup orc -dist.[ch] files.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1408 >
2020-07-04 15:05:23 +01:00
Vivia Nikolaidou
31d5d04bb1
videoparseutils: Only add a single closed caption meta
...
Otherwise, having a stream go through a parser multiple times would
result in duplicate closed caption meta.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1396 >
2020-07-03 08:25:54 +00:00
Jan Alexander Steffens (heftig)
afdde9fa40
videoparsers: Fix parsing ATSC bar data
...
It rejected the case of all bars being disabled.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394 >
2020-07-01 20:02:35 +00:00
Jan Alexander Steffens (heftig)
01896c11d2
videoparsers: Fix parsing of ATSC AFD data
...
The test for 0x40 being set is repeated by
gst_video_parse_utils_parse_afd, which also extracts the low nibble
again, so we must not clear it here.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394 >
2020-07-01 20:02:35 +00:00
Jan Alexander Steffens (heftig)
cedb07fe46
videoparsers: Give gstvideoparseutils.c a debug category
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394 >
2020-07-01 20:02:35 +00:00
Jan Alexander Steffens (heftig)
1e29c5d52a
rtmp2: Set connect args like libavformat does
...
To improve our compatibility. Critically, a server might elide data for
codecs we don't advertise.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384 >
2020-07-01 18:33:42 +00:00
Jan Alexander Steffens (heftig)
2ad3aab1d4
rtmp2: Add support for AGGREGATE messages
...
They're multiple frames (tags) of FLV data wrapped into a message.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384 >
2020-07-01 18:33:42 +00:00
Jan Alexander Steffens (heftig)
30b1187108
rtmp2: Move FLV tag header parsing into rtmputils.c
...
To be shared with the AGGREGATE handling.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384 >
2020-07-01 18:33:42 +00:00
Jan Alexander Steffens (heftig)
368c038ef0
rtmp2: Mark our memory singleton as leakable
...
So it doesn't appear in the leaks tracer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384 >
2020-07-01 18:33:42 +00:00
Jan Alexander Steffens (heftig)
edd3c4fadf
rtmp2: Remove GST_ERROR from rtmputils.c
...
This file does not have debug logging set up.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384 >
2020-07-01 18:33:42 +00:00
Andreas Frisch
297e5022ca
mpegtsmux: Correctly set ISO-639 language descriptor
...
fixes #1340
Only 2 of the necessary 3 letters were copied because the teminating '\0'
needs to be counted, too - cf.
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strlcat
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1375 >
2020-06-30 11:41:27 +00:00
Vivia Nikolaidou
290d0432c3
interlace: Make caps writable before modifying them
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1373 >
2020-06-25 16:05:39 +03:00
Mathieu Duponchelle
e2f28c3d08
mxfvanc: document new sink pad template
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1368 >
2020-06-25 06:59:18 +00:00
Sebastian Dröge
e54107db02
mxfdemux/mux: Add support for CEA-708 CDP from S436 essence tracks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1368 >
2020-06-25 06:59:18 +00:00
Vivia Nikolaidou
482d2c9459
interlace: Switch field-pattern on the fly
...
The frame rate interlace uses changes when we change field-pattern, so
we need to issue a reconfigure event.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1364 >
2020-06-24 17:44:46 +00:00
Vivia Nikolaidou
1eeaee24d4
interlace: Re-indentation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349 >
2020-06-24 11:31:15 +03:00