mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 00:32:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtc, rtmp2: Warn if the user or password aren't escaped

Browse source 
If the user/pass aren't escaped, the userinfo will be ambiguous and we
won't know where to split. We will accidentally get it right if the :
belongs in the password.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481>
This commit is contained in:
Nirbheek Chauhan 2020-08-01 02:18:39 +05:30
parent 827afa206d
commit d4ca8820e7
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ext/webrtc/gstwebrtcice.c
View file

@ -291,6 +291,12 @@ _parse_userinfo (const gchar * userinfo, gchar ** user, gchar ** pass)
return;
}
/* Check that the first occurence is also the last occurence */
if (colon != g_strrstr (userinfo, ":"))
GST_WARNING ("userinfo %s contains more than one ':', will assume that the "
"first ':' delineates user:pass. You should escape the user and pass "
"before adding to the URI.", userinfo);
*user = g_strndup (userinfo, colon - userinfo);
*pass = g_strdup (&colon[1]);
}

5
gst/rtmp2/gstrtmp2locationhandler.c
View file

@ -221,6 +221,11 @@ uri_handler_set_uri (GstURIHandler * handler, const gchar * string,
goto out;
}
if (g_strrstr (split[1], ":") != NULL)
GST_WARNING_OBJECT (self, "userinfo %s contains more than one ':', will "
"assume that the first ':' delineates user:pass. You should escape "
"the user and pass before adding to the URI.", userinfo);
g_object_set (self, "username", split[0], "password", split[1], NULL);
g_strfreev (split);
}