mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 15:27:07 +00:00
Code Issues 1 Projects Releases Wiki Activity
13444 commits 44 branches 1510 tags 480 MiB
Commit graph

805 commits

Author SHA1 Message Date
Thiago Santos
fb3a9d1bc5 video: avoid overflows when doing int operations for size 
size is a gsize, so cast the operands to it to avoid overflows
and setting wrong value to the video size.

Includes tests.

https://bugzilla.gnome.org/show_bug.cgi?id=731195
 2014-06-09 23:38:39 -03:00
Thibault Saunier
d2ea3260e9 videodecoder: Keep still meaningfull pending events on FLUSH_STOP 
Only EOS and segment should be deleted in that case.

+ Add a testcase

https://bugzilla.gnome.org/show_bug.cgi?id=709868
 2014-06-03 13:03:49 +02:00
Thibault Saunier
2843f358d9 videoencoder: Keep still meaningfull pending events on FLUSH_STOP 
Only EOS and segment should be deleted in that case.

https://bugzilla.gnome.org/show_bug.cgi?id=709868
 2014-06-03 13:03:19 +02:00
Thiago Santos
0cb5ea4396 videodecoder: actually return the push result in backwards playback 
It was always returning _OK regardless of what downstream returned
 2014-05-26 23:24:56 -03:00
Thiago Santos
ff9e37ea66 videodecoder: return EOS when segment is over 
if a buffer is clipped by being completely out of segment, check if this
buffer is after the end of the segment and return EOS upstream

https://bugzilla.gnome.org/show_bug.cgi?id=709224
 2014-05-26 19:26:45 -03:00
Nicolas Dufresne
e0cfd6e26b video-info: Also check the stride and offset are equal 
gst_video_info_is_equal() was not checking if stride and offset
had changed.

https://bugzilla.gnome.org/show_bug.cgi?id=729896
 2014-05-12 18:22:32 -04:00
Edward Hervey
ec95963b1f videodecoder: Free data after removing it from the list 
While it wouldn't have caused any failures (g_list_remove doesn't dereference
the provided pointer), it does make the code cleaner.

CID #1212174
 2014-05-12 17:17:07 +02:00
Nicolas Dufresne
64d58b80c0 videodecoder: Retry setting configuration with modified config 
Buffer pool set_config() may return FALSE if requested configuration needed small
changes. Reget the config and try setting it again. This ensure we have a configured
pool if possible.
 2014-05-08 15:09:47 -04:00
Sebastian Dröge
68f5350c66 Release 1.3.1 2014-05-03 17:50:10 +02:00
Thiago Santos
5ac9476b40 videodecoder: do not parse caps for not using it 
Saving some cpu
 2014-05-01 19:31:25 -03:00
Sebastian Dröge
9398207101 videoframe: Initialise GstVideoFrame to zeroes if mapping fails 
This should allow for more meaningful errors. Dereferencing NULL
is more useful information than dereferencing a random address
happened to be on the stack.
 2014-04-16 19:53:46 +02:00
Vincent Penquerc'h
3d1fdf8dd8 video-overlay-composition: guard against NULL pointer dereference on error 
If gst_video_overlay_rectangle_apply_global_alpha is called with
a rectangle with unsuitable alpha, expanding the alpha plane will
fail, and thus lead to dereferencing a NULL src pointer. It's not
certain this will happen in practice, as the function is static
and callers might ensure suitable alpha before calling, but there
is no apparent explicit such check.
Add prologue asserts for proper alpha to explicitely prevent this.

Coverity 1139707
 2014-04-10 12:35:03 +01:00
Vincent Penquerc'h
4a401adf38 videometa: fix texture_type memcpy size 
Coverity 1139589, 1139588
 2014-04-10 12:35:03 +01:00
Sebastian Dröge
8c7cbeed5b video-event: Update the running times in the force-keyunit events from the pad offsets 2014-04-10 09:18:05 +02:00
Thiago Santos
05e957106f videodecoder: do not deactivate the bufferpool, just unref 
Videodecoder does late renegotiation, it will wait for the next
buffer before renegotiating its caps and bufferpool. It might happen
that downstream element switched from passthrough to non-passthrough
and sent a reconfigure upstream (that caused this renegotiation).
This downstream element will ask the video sink below for the bufferpool
with an allocation query and will get the same bufferpool that
videodecoder is holding, too.

When renegotiating, if videodecoder deactivates its bufferpool it
might be deactivating the bufferpool that some element downstream
is using and cause the pipeline to fail.

https://bugzilla.gnome.org/show_bug.cgi?id=727498
 2014-04-04 13:50:03 -03:00
Sebastian Dröge
6189847ed0 videodecoder: Always drain the decoder after a discont group in reverse playback mode 2014-03-30 18:26:59 +02:00
Sebastian Dröge
5a4fbb1638 videodecoder: Flush the decoder once per discont group, not once per keyframe 2014-03-30 18:00:53 +02:00
Sebastian Dröge
f1f8731ff5 videodecoder: Handle reverse playback with multiple GOPs per discont group properly 
baseparse will reverse each GOP for us already, so the segment events can
be after our keyframe. Make sure to get it and all other relevant sticky
events before starting to decode.
 2014-03-30 17:59:55 +02:00
Sebastian Dröge
50c2218d4d videodecoder: Log event types of events that are pushed downstream 2014-03-29 10:33:01 +01:00
Sebastian Dröge
1c26e5734c videodecoder: In reverse playback mode we need to finish the subclass after passing all frames to it 2014-03-29 10:33:01 +01:00
Matthieu Bouron
a8951c16da video-overlay-composition: add GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION 2014-03-05 20:38:45 +01:00
Sebastian Rasmussen
900c204eb9 videoformat: Remove duplicate/incorrect section 
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725521
 2014-03-02 23:41:51 +00:00
Sebastian Rasmussen
35bb1b3328 docs: Add annotations for return values 
Rephrase and clarify some return value descriptions

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725521
 2014-03-02 23:41:18 +00:00
Sebastian Rasmussen
5b4f2ba20b docs: Fix argument and annotation typos 
* colorbalance: Fix misspelled annotation
 * rtsp: Replace incorrectly documented function argument
 * sdp: Escape @ character to avoid gtk-doc warning
 * video-*: Add missing annotation colon
 * videodecoder/video-color: Fix function argument typos
 * videoutils: Remove unknown annotation field

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725521
 2014-03-02 23:22:51 +00:00
Tim-Philipp Müller
6442e76e9f docs: add GstVideoPool to docs 2014-02-23 14:42:12 +00:00
Nicolas Dufresne
6b77971097 video: Fix NV12_64Z32 default offset and size 
This was a regression introduced by f52fd7a68, where we started using
the stride to encode the dimensions in tiles. This patch simply updates
offset and size calculation as described in the documentation,
part-mediatype-video-raw.txt.
 2014-02-18 13:09:21 -05:00
Thiago Santos
da54836a33 videoencoder: push tags and events before eos 
if any tags or events are pending, push them before pushing eos
 2014-01-29 12:33:59 -03:00
Wim Taymans
8ac3dbc4f3 video-chroma: don't crash on NULL resamplers 
Make dummy resamplers for all cases and only execute the horizontal
resampler instead of crashing.

See https://bugzilla.gnome.org/show_bug.cgi?id=722742
 2014-01-23 10:45:00 +01:00
Sebastian Dröge
87829debe4 videodecoder: Add API to get the currently pending frame size for parsing 
https://bugzilla.gnome.org/show_bug.cgi?id=719890
 2014-01-18 13:54:22 +01:00
Thiago Santos
47f720a8f0 videodecoder: plug leak when frames are released on subclass stop 
They end up stored in the 'pending_events' list and should be
freed after calling stop
 2014-01-17 11:21:33 -03:00
Sebastian Dröge
335e6e888d videoverlay: Don't mention gconf elements and add a sentence about playbin/playsink 
playbin/playsink now implement the video overlay interface
 2014-01-14 13:20:48 +01:00
Wim Taymans
ecac298e4e videodecoder: only copy chroma_site when known 
Only overwrite the chroma-site if we have a valid value in the reference
format.
 2014-01-13 17:24:01 +01:00
Wim Taymans
fba783a5fe videoutils: add some debug 2014-01-13 17:24:01 +01:00
Nicolas Dufresne
595bcfb4d7 video: Generate types for tile enumeration 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:47:23 -05:00
Nicolas Dufresne
f52fd7a68b video: Don't use extra plane and componenent for tile format 
Instead of using extra plane, we encode the number of tiles in x and y in the stride of
each planes (i.e. y_tiles << 16 | x_tiles) and introduce tile_mode, tile_width and
tile_height into GstVideoFormatInfo structure.

https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:47:03 -05:00
Wim Taymans
d899e6df5a video: rename NV12T -> NV12_64Z32 
Is a bit more descriptive and allows us to add more tiled types
later.

https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:52 -05:00
Nicolas Dufresne
c8597330a9 video-frame: scale vertical tiles based on subsampling 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:45 -05:00
Nicolas Dufresne
53605e35f4 video-frame: fix tiled pixel stride 
Pixel stride is per component, not per plane. We get the tile mode from
the pixelstride of the TILE component.

https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:37 -05:00
Wim Taymans
61cbdf379b format: improve docs 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:31 -05:00
Wim Taymans
f3e989179b video-format: fix off-by-one for tiled coordinates 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:17 -05:00
Wim Taymans
fb0fecbf48 video-tile: improve docs 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:07 -05:00
Wim Taymans
33c486e5c1 video-format: use shifts when possible 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:46:01 -05:00
Wim Taymans
980811c120 video-frame: fix copy of tiled formats 
Add code to copy tiled planes.

https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:45:50 -05:00
Wim Taymans
3ceb7dfe22 video-tile: add tile mode and helper functions 
Move the tile helper functions to their own file. Make it possible to
make other tiling modes later.

https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:45:37 -05:00
Wim Taymans
f8d3b9b4fc video: add NV12T support 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:45:26 -05:00
Wim Taymans
67a2717235 Add tiled color format support 
https://bugzilla.gnome.org/show_bug.cgi?id=707361
 2014-01-13 10:45:02 -05:00
Thiago Santos
672cda66db videodecoder: do not lose events when dropping frames 
Events must be persisted after a frame is dropped to avoid
losing obligatory information for the stream.

https://bugzilla.gnome.org/show_bug.cgi?id=721835
 2014-01-13 06:11:09 -03:00
Thiago Santos
5b8e1925b5 videodecoder: use new segment earlier for reverse playback 
For reverse playback, the segment event will only be pushed when
the first buffer is actually pushed. But for decoding frames and storing
those into the list to be pushed the output_segment.rate value is used
to determine if it is forward or reverse playback.

In case a previous segment event (or none) is in use it will mistakenly
think it is doing forward playback and push the buffers immediatelly and
try to clip buffers based on an old segment (or an uninitialized one, leading
to an assertion)

This patch fixes this by copying the segment earlier if on reverse playback

https://bugzilla.gnome.org/show_bug.cgi?id=721666
 2014-01-13 06:11:09 -03:00
Sebastian Dröge
58592a2af3 audio/video-info: Properly initialize the info structures in set_format() 
And don't assume in other code that set_format() preserves any fields at
all. These assumptions were already made here for fields that were changed
by set_format().
 2013-12-30 10:53:24 +01:00
Sebastian Dröge
65732d9c97 audio/video-info: Initialize the complete struct to 0 in the beginning 
Instead of only initializing some parts in some code paths. Also
makes it easier to use the reserved bits of the structs later.

https://bugzilla.gnome.org/show_bug.cgi?id=720810
 2013-12-30 10:15:20 +01:00